From: Vadym Kochan
For some reason there might be a crash during ports creation if port
events are handling at the same time because fw may send initial
port event with down state.
The crash points to cancel_delayed_work() which is called when port went
is down. Currently I did not find out
From: Vadym Kochan
Add PCI match for AC3X 98DX3265 device which is supported by the current
driver and firmware.
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera
On Sat, Apr 17, 2021 at 02:02:02AM +0300, Vadym Kochan wrote:
> From: Vadym Kochan
>
> Add PCI match for AC3X 98DX3265 device which is supported by the current
> driver and firmware.
>
> Signed-off-by: Vadym Kochan
> ---
> drivers/net/ethernet/marvell/prestera/preste
From: Vadym Kochan
Add PCI match for AC3X 98DX3265 device which is supported by the current
driver and firmware.
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera
Hi Sridhar,
On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote:
> On 4/9/2021 9:22 AM, Oleksandr Mazur wrote:
> > I'd like to discuss a possibility of handling devlink port parameters
> > with devlink port pointer supplied.
> >
> > Current design makes it impossible to distinguish
Hi Jakub,
On Thu, Feb 04, 2021 at 09:19:34PM -0800, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 18:54:58 +0200 Vadym Kochan wrote:
> > For some reason there might be a crash during ports creation if port
> > events are handling at the same time because fw may send initial
>
Hi,
On Wed, Feb 03, 2021 at 04:17:48PM +0200, Vadym Kochan wrote:
> The following changes since commit 05789708b79b38eb0f1a20d8449b4eb56d39b39f:
>
> brcm: Link RPi4's WiFi firmware with DMI machine name. (2021-01-19 07:42:43
> -0500)
>
> are available in the Git repo
Hi Jakub,
On Thu, Feb 04, 2021 at 09:10:12PM -0800, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 18:54:53 +0200 Vadym Kochan wrote:
> > There are change in firmware which requires that receiver will
> > disable event interrupts before handling them and enable them
> > after
Add PCI match for AC3X 98DX3265 device which is supported by the current
driver and firmware.
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
b/drivers
Latest FW IPC floow message format was changed to configure uc/mc
flooding separately, so change code according to this.
Signed-off-by: Vadym Kochan
---
.../ethernet/marvell/prestera/prestera_hw.c | 37 +--
.../ethernet/marvell/prestera/prestera_hw.h | 3 +-
.../marvell
end trace 5eced933df3a080b ]---
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c
b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 394
: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
.../net/ethernet/marvell/prestera/prestera.h | 30 ++-
.../ethernet/marvell/prestera/prestera_hw.c | 180 -
.../ethernet/marvell/prestera/prestera_hw.h | 14 +
.../ethernet/marvell/prestera/prestera_main.c | 247
Move handling of PRECHANGEUPPER event from prestera_switchdev to
prestera_main which is responsible for basic netdev events handling
and routing them to related module.
Signed-off-by: Vadym Kochan
---
.../ethernet/marvell/prestera/prestera_main.c | 29 +--
.../marvell/prestera
New firmware version has some ABI and feature changes like:
- LAG support
- initial L3 support
- changed events handling logic
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
There are change in firmware which requires that receiver will
disable event interrupts before handling them and enable them
after finish with handling. Events still may come into the queue
but without receiver interruption.
Signed-off-by: Vadym Kochan
---
.../ethernet/marvell/prestera
LAG support
Vadym Kochan (6):
net: marvell: prestera: bump supported firmware version to 2.5
net: marvell: prestera: disable events interrupt while handling
net: marvell: prestera: add support for AC3X 98DX3265 device
net: marvell: prestera: move netdev topology validation to
es up to 1722d0deb575e4bd5433914bb2eeabfd0703ed2f:
mrvl: prestera: Add Marvell Prestera Switchdev firmware 2.5 version
(2021-02-03 16:04:13 +0200)
Vadym Kochan (1):
mrvl: prestera: Add Marvell Prestera Switchdev firmwar
simplify
post_doit")
CC: Parav Pandit
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
v2:
1) Use correct "Fixes" commit.
net/core/devlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index ee8
ff-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
net/core/devlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index ee828e4b1007..738d4344d679 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@
ff-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
1) Fixed plvision.com -> plvision.eu
net/core/devlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index ee828e4b1007..738d4344d679 100644
--- a/net/core/devlink.c
++
;wq) {
> + err = -ENOMEM;
> goto err_wq_alloc;
> + }
>
> INIT_WORK(&fw->evt_work, prestera_fw_evt_work_fn);
Thank you!
Just in case it is needed:
Reviewed-by: Vadym Kochan
Acked-by: Vadym Kochan
switchdev/prestera side that you think would be good to
> work on?
>
> Thanks,
> Chris
There is an activity to push the Prestera build SDK in form of 'Buildroot
external tree' to the Github to build the image for some of the the Prestera
Switchdev-designed board (if you refer to this kind of board).
Regards,
Vadym Kochan
Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver
implementation")
Reported-by: Randy Dunlap
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/Kconfig | 1 +
1 file changed, 1 insertion(+)
dif
o: in function
> `prestera_bridge_port_event':
> prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
>
>
> Also please add drivers/net/ethernet/marvell/prestera/ to the
> MAINTAINERS file.
>
> thanks.
Thanks for catching this, will send fix via the "net" tree.
Regards,
Vadym Kochan
Hi Stephen,
On Thu, Oct 01, 2020 at 08:09:16AM +1000, Stephen Rothwell wrote:
> Hi all,
>
[CUT]
>
> I am still getting this build failure ...
>
> --
I just 've checked linux-next/master and it builds fine at least with my custom
config, do/how I need to handle this case ?
I see the changes y
7a0221265cda381b5231355965a403ca264392a5:
linux-firmware: Update Marvell Switchdev firmware with ABI changes
(2020-09-18 16:54:29 +0300)
Vadym Kochan (1):
linux-firmware: Update Marvell Switchdev firmware with ABI changes
mrvl/prestera
timeout parameter is set globally per device
Co-developed-by: Serhiy Boiko
Signed-off-by: Serhiy Boiko
Co-developed-by: Serhiy Pshyk
Signed-off-by: Serhiy Pshyk
Co-developed-by: Taras Chornyi
Signed-off-by: Taras Chornyi
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Add missing comma for last
events from prestera.c
- use struct prestera_bridge for bridge objects, and get rid of
struct prestera_bridge_device which may confuse.
- use refcount_t
9) Get rid of macro usage for sending fw requests in prestera_hw.c
10) Add base_mac setting as module paramete
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
d-off-by: Taras Chornyi
Co-developed-by: Volodymyr Mytnyk
Signed-off-by: Volodymyr Mytnyk
Signed-off-by: Vadym Kochan
---
PATCH v9:
1) Replace read_poll_timeout_atomic() by original 'do {} while()' loop
because it works much better than read_poll_timeout_atomic()
consi
: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Sorted includes.
2) Use traditional error handling pattern:
err = F();
if (err)
return err;
3) Invert '!err ? speed : SPEED_UNKNOWN' into 'err ? SPEED_UNKNOWN : speed'
4) R
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Put license in one line.
2) Use traditional error handling pattern in
prestera_devlink_port_register():
err = F();
if (err
ixes, firmware ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Co-developed-by: Oleksandr Mazur
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Sort includes.
2) Add missing c
7;s
idx:
int sfp_controller_add_socket(struct sfp_controller *ctl, struct sfp *sfp, int
idx);
void sfp_controller_del_socket(struct sfp_controller *ctl, struct sfp *sfp);
so the driver may create mapping between struct sfp* and it's idx and call the:
sfp_state_update(struct sfp *sfp, int state);
Regards,
Vadym Kochan
On Thu, Sep 10, 2020 at 06:30:47PM -0700, Jakub Kicinski wrote:
> On Thu, 10 Sep 2020 18:00:50 +0300 Vadym Kochan wrote:
> > +static int prestera_sdma_tx_wait(struct prestera_sdma *sdma,
> > +struct prestera_tx_ring *tx_ring)
> > +{
&g
d-off-by: Taras Chornyi
Co-developed-by: Volodymyr Mytnyk
Signed-off-by: Volodymyr Mytnyk
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Put license in one line.
2) Sort includes.
3) Add missing comma for last enum member
4) Use PRESTERA_DSA_ as macro prefix in prestera_dsa.c
5
ixes, firmware ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Co-developed-by: Oleksandr Mazur
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Sort includes.
2) Add missing c
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Put license in one line.
2) Use traditional error handling pattern in
prestera_devlink_port_register():
err = F();
if (err
: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Sorted includes.
2) Use traditional error handling pattern:
err = F();
if (err)
return err;
3) Invert '!err ? speed : SPEED_UNKNOWN' into 'err ? SPEED_UNKNOWN : speed'
4) R
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
timeout parameter is set globally per device
Co-developed-by: Serhiy Boiko
Signed-off-by: Serhiy Boiko
Co-developed-by: Serhiy Pshyk
Signed-off-by: Serhiy Pshyk
Co-developed-by: Taras Chornyi
Signed-off-by: Taras Chornyi
Signed-off-by: Vadym Kochan
---
PATCH v8:
1) Add missing comma for last
Looks like u32p_replace_bits() should be used instead of
u32_replace_bits() which does not modifies the value but returns the
modified version.
Fixes: 2b9feef2b6c2 ("soc: qcom: ipa: filter and routing tables")
Signed-off-by: Vadym Kochan
Reviewed-by: Alex Elder
---
Found it while g
e.
- use refcount_t
9) Get rid of macro usage for sending fw requests in prestera_hw.c
10) Add base_mac setting as module parameter. base_mac is required for
generation default port's mac.
Vadym Kochan (6):
net: marvell: prestera: Add driver for Prestera family ASIC de
On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> &
Hi Andy,
On Fri, Sep 04, 2020 at 10:41:17PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote:
> >
> > The following features are supported:
> >
> > - VLAN-aware bridge offloading
> > - VLAN-unaware bridge offloading
&
On Mon, Sep 07, 2020 at 10:55:49AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 7, 2020 at 10:30 AM Vadym Kochan wrote:
> > On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan
> > > wrote:
>
> I
Hi Andy,
On Tue, Sep 08, 2020 at 12:38:04PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 8, 2020 at 11:35 AM Vadym Kochan wrote:
> > On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan
> > > wrote:
>
Hi Alex,
On Wed, Sep 09, 2020 at 06:53:17AM -0500, Alex Elder wrote:
> On 9/8/20 9:32 AM, Vadym Kochan wrote:
> > Looks like u32p_replace_bits() should be used instead of
> > u32_replace_bits() which does not modifies the value but returns the
> > modified version.
> &g
Looks like u32p_replace_bits() should be used instead of
u32_replace_bits() which does not modifies the value but returns the
modified version.
Fixes: 2b9feef2b6c2 ("soc: qcom: ipa: filter and routing tables")
Signed-off-by: Vadym Kochan
---
Found it while grepping of u32_replace_bi
On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> &
Hi Andy,
On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a lar
chdev.c with following changes:
- handle netdev events from prestera.c
- use struct prestera_bridge for bridge objects, and get rid of
struct prestera_bridge_device which may confuse.
- use refcount_t
9) Get rid of macro usage for sending fw requests in prester
ixes, firmware ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Co-developed-by: Oleksandr Mazur
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Remove not-needed packed &
d-off-by: Taras Chornyi
Co-developed-by: Volodymyr Mytnyk
Signed-off-by: Volodymyr Mytnyk
Signed-off-by: Vadym Kochan
---
PATCH v7:
1) Use ether_addr_copy() in prestera_main.c:prestera_port_set_mac_address()
instead of memcpy().
2) Removed not needed device's DMA address r
timeout parameter is set globally per device
Co-developed-by: Serhiy Boiko
Signed-off-by: Serhiy Boiko
Co-developed-by: Serhiy Pshyk
Signed-off-by: Serhiy Pshyk
Co-developed-by: Taras Chornyi
Signed-off-by: Taras Chornyi
Signed-off-by: Vadym Kochan
---
PATCH v7:
1) Add missing
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Convert following error check:
if (func(...))
or
if (!func(...))
to use err variable:
err = func(...)
if (err)
2) Remove "," from terminated enum entry.
PATCH v4:
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Simplified some error path handling by simple return error code in:
- prestera_dl_info_get(...)
2) Remove not-needed err assignment
Hi Andrew,
On Fri, Sep 04, 2020 at 03:32:17PM +0200, Andrew Lunn wrote:
> > > > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8
> > > > *addr)
> > > > +{
> > > > + if (!is_valid_ether_addr(addr))
> > > > + return -EADDRNOTAVAIL;
> > > > +
> > > > +
On Thu, Sep 03, 2020 at 07:18:59PM +0200, Willem de Bruijn wrote:
> On Wed, Sep 2, 2020 at 5:07 PM Vadym Kochan wrote:
> >
> > The following features are supported:
> >
> > - VLAN-aware bridge offloading
> > - VLAN-unaware bridge offloading
> >
On Thu, Sep 03, 2020 at 06:35:34PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 3, 2020 at 6:23 PM Willem de Bruijn
> wrote:
> > On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan
> > wrote:
>
> ...
>
> > > +static int prestera_is_valid_mac_addr(struct
Hi Willem,
On Thu, Sep 03, 2020 at 05:22:24PM +0200, Willem de Bruijn wrote:
> On Wed, Sep 2, 2020 at 5:37 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a lar
Sorry, I mistakenly used "net" instead of "net-next" as label.
On Wed, Sep 02, 2020 at 06:04:36PM +0300, Vadym Kochan wrote:
> Marvell Prestera 98DX3255 integrates up to 24 ports of 1GbE with 8
> ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
loped-by: Volodymyr Mytnyk
Signed-off-by: Volodymyr Mytnyk
Signed-off-by: Vadym Kochan
---
PATCH v6:
1) Use rwlock to protect port list on create/delete stages. The list
is mostly readable by fw event handler or packets receiver.
2) Remove not needed variable initializ
ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Co-developed-by: Oleksandr Mazur
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Remove not-needed packed & aligned at
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Convert following error check:
if (func(...))
or
if (!func(...))
to use err variable:
err = func(...)
if (err)
2) Remove "," from terminated enum entry.
PATCH v4:
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Simplified some error path handling by simple return error code in:
- prestera_dl_info_get(...)
2) Remove not-needed err assignment
truct prestera_bridge_device which may confuse.
- use refcount_t
9) Get rid of macro usage for sending fw requests in prestera_hw.c
10) Add base_mac setting as module parameter. base_mac is required for
generation default port's mac.
Vadym Kochan (6):
net: marvell: prester
timeout parameter is set globally per device
Co-developed-by: Serhiy Boiko
Signed-off-by: Serhiy Boiko
Co-developed-by: Serhiy Pshyk
Signed-off-by: Serhiy Pshyk
Co-developed-by: Taras Chornyi
Signed-off-by: Taras Chornyi
Signed-off-by: Vadym Kochan
---
PATCH v5:
0) Add Co-developed tag
Hi Chris,
On Wed, Aug 26, 2020 at 04:30:35AM +, Chris Packham wrote:
> Hi Vadym,
>
> On 26/08/20 12:20 am, Vadym Kochan wrote:
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a lar
Hi David,
On Wed, Aug 26, 2020 at 07:34:46AM -0700, David Miller wrote:
> From: Vadym Kochan
> Date: Wed, 26 Aug 2020 11:17:44 +0300
>
> > Initially there was (in RFC patch set), not locking, but _rcu list API
> > used, because the port list is modified only by 1 writer
On Tue, Aug 25, 2020 at 05:20:03PM -0700, David Miller wrote:
> From: Vadym Kochan
> Date: Tue, 25 Aug 2020 15:20:08 +0300
>
> > +int prestera_dsa_parse(struct prestera_dsa *dsa, const u8 *dsa_buf)
> > +{
> > + __be32 *dsa_words = (__be32 *)dsa_buf;
> &
timeout parameter is set globally per device
Co-developed-by: Serhiy Boiko
Signed-off-by: Serhiy Boiko
Co-developed-by: Serhiy Pshyk
Signed-off-by: Serhiy Pshyk
Co-developed-by: Taras Chornyi
Signed-off-by: Taras Chornyi
Co-developed-by: Vadym Kochan
Signed-off-by: Vadym Kochan
---
PATCH v5
: Serhiy Boiko
Co-developed-by: Vadym Kochan
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Convert following error check:
if (func(...))
or
if (!func(...))
to use err variable:
err = func(...)
if (err)
2) Remove "," from termi
loped-by: Volodymyr Mytnyk
Signed-off-by: Volodymyr Mytnyk
Co-developed-by: Vadym Kochan
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Make SPDX license as separate comment
2) Change 'u8 *' -> 'void *' in prestera.h: struct
prestera_device->{send_req,recv_msg} callba
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Simplified some error path handling by simple return error code in:
- prestera_dl_info_get(...)
2) Remove not-needed err assignment
ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Co-developed-by: Oleksandr Mazur
Signed-off-by: Oleksandr Mazur
Co-developed-by: Vadym Kochan
Signed-off-by: Vadym Kochan
---
PATCH v5:
1) Remove not-ne
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
of macro usage for sending fw requests in prestera_hw.c
10) Add base_mac setting as module parameter. base_mac is required for
generation default port's mac.
Vadym Kochan (6):
net: marvell: prestera: Add driver for Prestera family ASIC devices
net: marvell: prestera: Add PCI in
o use?
>
> Andrew
This 'compatible' string is just for parsing the DTS node related to
this driver. There is no any relation in this name matching for fw
compatibility but only to describe some properties which might be
applied by the driver.
Regards,
Vadym Kochan
Hi Andrew,
On Fri, Aug 14, 2020 at 03:18:15PM +0200, Andrew Lunn wrote:
> > > > Currently
> > > >
> > > > compatible = "marvell,prestera"
> > > >
> > > > is used as default, so may be
> > > >
> > > > you mean to support few matching including particular silicon too, like
> > > > ?
> > > >
On Fri, Aug 14, 2020 at 01:05:36PM +0100, Jonathan McDowell wrote:
> On Fri, Aug 14, 2020 at 11:20:54AM +0300, Vadym Kochan wrote:
> > On Thu, Aug 13, 2020 at 09:03:22AM +0100, Jonathan McDowell wrote:
> > > On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote:
> &
Hi Jonathan,
On Thu, Aug 13, 2020 at 09:03:22AM +0100, Jonathan McDowell wrote:
> On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote:
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stackin
Hi Andy,
On Fri, Jul 31, 2020 at 07:02:47PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 31, 2020 at 6:22 PM Vadym Kochan wrote:
> > On Mon, Jul 27, 2020 at 03:59:13PM +0300, Andy Shevchenko wrote:
> > > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan
> > > wrote:
>
Hi Andy,
On Mon, Jul 27, 2020 at 03:59:13PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a lar
Hi Andy,
On Mon, Jul 27, 2020 at 04:07:07PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote:
> >
> > Add very basic support for devlink interface:
> >
> > - driver name
> > - fw version
> > - de
> >
> >PATCH - indicates only fixes, firmware ABI is not changed.
> >
> >Firmware image file name contains only MAJOR and MINOR numbers to make
> >driver be compatible with any PATCH version.
> >
> >Signed-off-by: Oleksandr Mazur
> >Signed-off-b
timeout parameter is set globally per device
Signed-off-by: Serhiy Boiko
Signed-off-by: Serhiy Pshyk
Signed-off-by: Taras Chornyi
Signed-off-by: Vadym Kochan
---
PATCH v4:
1) Check for the prestera dev interface in switchdev event handler
to ignore unsupported topology.
.../net
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
autoneg on
- forward error correction feature is supported only on SFP ports, 10G
speed
- auto-negotiation and MDI-x features are not supported on
Copper-to-Fiber SFP module
Signed-off-by: Andrii Savka
Signed-off-by: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
PATCH v4:
1
Add very basic support for devlink interface:
- driver name
- fw version
- devlink ports
Signed-off-by: Vadym Kochan
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/marvell/prestera/Kconfig | 1 +
.../net/ethernet/marvell/prestera/Makefile| 2 +-
.../net/ethernet/marvell
ABI is not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
Acked-by: Jiri Pirko
---
PATCH v4:
1) Get rid of "packed" attribute for the fw image
se_mac setting as module parameter. base_mac is required for
generation default port's mac.
Vadym Kochan (6):
net: marvell: prestera: Add driver for Prestera family ASIC devices
net: marvell: prestera: Add PCI interface support
net: marvell: prestera: Add basic devlink support
net
ii Savka
Signed-off-by: Oleksandr Mazur
Signed-off-by: Serhiy Boiko
Signed-off-by: Serhiy Pshyk
Signed-off-by: Taras Chornyi
Signed-off-by: Volodymyr Mytnyk
Signed-off-by: Vadym Kochan
---
PATCH v4:
1) Use prestera_ prefix for netdev_ops struct var.
PATCH v3:
1) Simplify __be32 type ca
Hi Andy,
On Mon, Jul 27, 2020 at 11:04:56AM +0300, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 1:55 AM Vadym Kochan wrote:
> > On Sun, Jul 26, 2020 at 01:32:19PM +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 25, 2020 at 6:10 PM Vadym Kochan
> > > wrote
Hi Andy,
On Sun, Jul 26, 2020 at 01:32:19PM +0300, Andy Shevchenko wrote:
> On Sat, Jul 25, 2020 at 6:10 PM Vadym Kochan wrote:
> >
> > Add PCI interface driver for Prestera Switch ASICs family devices, which
> > provides:
> >
> > - Firmware loading mech
autoneg on
- forward error correction feature is supported only on SFP ports, 10G
speed
- auto-negotiation and MDI-x features are not supported on
Copper-to-Fiber SFP module
Signed-off-by: Andrii Savka
Signed-off-by: Serhiy Boiko
Signed-off-by: Vadym Kochan
---
.../net
Add brief description how to configure base mac address binding in
device-tree.
Describe requirement for the PCI port which is connected to the ASIC, to
allow access to the firmware related registers.
Signed-off-by: Vadym Kochan
---
.../bindings/net/marvell,prestera.txt | 34
not changed.
Firmware image file name contains only MAJOR and MINOR numbers to make
driver be compatible with any PATCH version.
Signed-off-by: Oleksandr Mazur
Signed-off-by: Vadym Kochan
---
drivers/net/ethernet/marvell/prestera/Kconfig | 11 +
.../net/ethernet/marvell/prestera/Makefile|
1 - 100 of 153 matches
Mail list logo
