Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Tom Tucker
On 11/27/07 7:27 PM, "Rusty Russell" <[EMAIL PROTECTED]> wrote: > On Tuesday 27 November 2007 16:35:42 Tom Tucker wrote: >> On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: >> Explicitly documenting what comprises the kernel API (external, >> sup

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Tom Tucker
On Tue, 2007-11-27 at 18:15 +0100, Adrian Bunk wrote: > On Mon, Nov 26, 2007 at 11:35:42PM -0600, Tom Tucker wrote: > > On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: > >... > > > No. That's the wrong question. What's the real upside? > > >

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-26 Thread Tom Tucker
On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: > On Monday 26 November 2007 17:15:44 Roland Dreier wrote: > > > Except C doesn't have namespaces and this mechanism doesn't create them. > > > So this is just complete and utter makework; as I said before, noone's > > > going to confuse

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-16 Thread Tom Tucker
On Wed, 2007-08-15 at 22:26 -0400, Jeff Garzik wrote: [...snip...] > > I think removing the RDMA stack is the wrong thing to do, and you > > shouldn't just threaten to yank entire subsystems because you don't like > > the technology. Lets keep this constructive, can we? RDMA should get > > t

[PATCH] amso1100: QP init bug in amso driver

2007-07-24 Thread Tom Tucker
Roland: The guys at UNH found this and fixed it. I'm surprised no one has hit this before. I guess it only breaks when the refcount on the QP is non-zero. Initialize the wait_queue_head_t in the c2_qp structure. Signed-off-by: Ethan Burns <[EMAIL PROTECTED]> Acked-by: Tom Tuc

Re: [openib-general] [PATCH 3/9] NetEffect 10Gb RNIC Driver: openfabrics connection manager c file

2006-10-27 Thread Tom Tucker
[...snip...] > +extern void set_interface( > +UINT32ip_addr, These should probably be the standard linux types u32, or uint32 > +UINT32mask, > +UINT32bcastaddr, > +

[PATCH] Add spinlocks to serialize ib_post_send/ib_post_recv

2006-10-03 Thread Tom Tucker
From: Tom Tucker <[EMAIL PROTECTED]> The AMSO driver was not thread-safe in the post WR code and had code that would sleep if the WR post FIFO was full. Since these functions can be called on interrupt level I changed the sleep to a udelay. Signed-off-by: Tom Tucker <[EMAIL

Re: [PATCH v5 1/2] iWARP Connection Manager.

2006-08-30 Thread Tom Tucker
b though to have header files called *private.h in a public directory. Putting them in iwcm.h is fine with me... Here's a patch for the KDB code if anyone is interested... KDB module for dumping OpenFabrics stack data types From: Tom Tucker <[EMAIL PROTECTED]> --- kdb/kdbmain.c

Re: RDMA will be reverted

2006-07-25 Thread Tom Tucker
On Mon, 2006-07-24 at 15:23 -0700, David Miller wrote: > From: Tom Tucker <[EMAIL PROTECTED]> > Date: Wed, 05 Jul 2006 12:09:42 -0500 > > > "A TOE net stack is closed source firmware. Linux engineers have no way > > to fix security issues that arise. As a

Re: RDMA will be reverted

2006-07-07 Thread Tom Tucker
On Thu, 2006-07-06 at 23:53 -0700, David Miller wrote: > From: Tom Tucker <[EMAIL PROTECTED]> > Date: Thu, 06 Jul 2006 00:25:03 -0500 > > > This patch is about dotting I's and crossing T's, it's not about > > foundations. > > You assume that I&

Re: RDMA will be reverted

2006-07-06 Thread Tom Tucker
On Fri, 2006-07-07 at 10:03 +1000, Herbert Xu wrote: > On Thu, Jul 06, 2006 at 12:36:24PM -0500, Tom Tucker wrote: > > > > The RDMA CMA uses IP addresses and port numbers to create a uniform > > addressing scheme across all transport types. For IB, it is necessary to > &

Re: RDMA will be reverted

2006-07-06 Thread Tom Tucker
On Fri, 2006-07-07 at 00:08 +1000, Herbert Xu wrote: > Tom Tucker <[EMAIL PROTECTED]> wrote: > > > > All that said, the proposed patch helps not only iWARP, but other > > transports (iSCSI, IB) as well. It is not large, invasive, > > Care to explain on how it hel

Re: RDMA will be reverted

2006-07-05 Thread Tom Tucker
On Wed, 2006-07-05 at 20:03 -0700, David Miller wrote: > From: Roland Dreier <[EMAIL PROTECTED]> > Date: Wed, 05 Jul 2006 13:29:35 -0700 > > > The way forward seems to be to merge basic iWARP support that lives in > > drivers/infiniband, and then you can accept or reject things for > > better inte

Re: RDMA will be reverted

2006-07-05 Thread Tom Tucker
On Sat, 2006-07-01 at 16:26 +0200, Andi Kleen wrote: > On Saturday 01 July 2006 01:01, Tom Tucker wrote: > > On Fri, 2006-06-30 at 14:16 -0700, David Miller wrote: > > > > > The TOE folks have tried to submit their hooks and drivers > > > on several occaisions,

Re: RDMA will be reverted

2006-06-30 Thread Tom Tucker
On Fri, 2006-06-30 at 14:16 -0700, David Miller wrote: > The TOE folks have tried to submit their hooks and drivers > on several occaisions, and we've rejected it every time. iWARP != TOE > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL

Re: RDMA will be reverted

2006-06-29 Thread Tom Tucker
On Thu, 2006-06-29 at 13:53 -0700, David Miller wrote: > From: Tom Tucker <[EMAIL PROTECTED]> > Date: Thu, 29 Jun 2006 15:47:13 -0500 > > > I concede that features have been lost, but some applications benefit > > greatly from RDMA. For these applications and these cus

Re: RDMA will be reverted

2006-06-29 Thread Tom Tucker
On Thu, 2006-06-29 at 13:19 -0700, David Miller wrote: > From: Tom Tucker <[EMAIL PROTECTED]> > Date: Thu, 29 Jun 2006 15:11:06 -0500 > > > Doesn't this position force vendors to build deeper adapters, not > > shallower adapters? Isn't this exactly the op

Re: RDMA will be reverted

2006-06-29 Thread Tom Tucker
[...snip...] > community at large, Linux and Andrew, you? I'm not trying to be Linus sorry... spell checker... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Re: RDMA will be reverted

2006-06-29 Thread Tom Tucker
On Thu, 2006-06-29 at 12:46 -0700, David Miller wrote: > From: Roland Dreier <[EMAIL PROTECTED]> > Date: Thu, 29 Jun 2006 09:54:37 -0700 > > > In any case I think we need to find a way for Linux to support iWARP > > hardware, since there are users that want this, and (some of) the > > vendors are

Re: RDMA will be reverted

2006-06-28 Thread Tom Tucker
On Wed, 2006-06-28 at 00:07 -0700, David Miller wrote: > Roland, there is no way in the world we would have let support for > RDMA into the kernel tree had we seen and reviewed it on netdev. I've > discussed this with Andrew Morton, and we'd like you to please revert > all of the RDMA code from Li

Re: [PATCH v2 4/7] AMSO1100 Memory Management.

2006-06-12 Thread Tom Tucker
On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote: > On Wed, 07 Jun 2006 15:06:55 -0500 > Steve Wise <[EMAIL PROTECTED]> wrote: > > > > > +void c2_free(struct c2_alloc *alloc, u32 obj) > > +{ > > + spin_lock(&alloc->lock); > > + clear_bit(obj, alloc->table); > > + spin_unlock(&alloc->l

Re: [PATCH v2 1/2] iWARP Connection Manager.

2006-06-12 Thread Tom Tucker
Andrew, thanks for the review, comments inline... On Thu, 2006-06-08 at 00:54 -0700, Andrew Morton wrote: > On Wed, 07 Jun 2006 15:06:05 -0500 > Steve Wise <[EMAIL PROTECTED]> wrote: > > > > > This patch provides the new files implementing the iWARP Connection > > Manager. > > > > Review Change

Re: [PATCH v2 2/2] iWARP Core Changes.

2006-06-07 Thread Tom Tucker
A reference is being taken on an iWARP device that is never getting released. This prevents a participating iWARP netdev device from being unloaded after a connection has been established on the passive side. Search for ip_dev_find below... On Wed, 2006-06-07 at 15:06 -0500, Steve Wise wrote: >

Re: [openib-general] Re: [PATCH 1/2] iWARP Connection Manager.

2006-06-01 Thread Tom Tucker
On Thu, 2006-06-01 at 14:09 -0700, Sean Hefty wrote: > Steve Wise wrote: > >>>+int iw_cm_disconnect(struct iw_cm_id *cm_id, int abrupt) > >>>+{ > >>>+ struct iwcm_id_private *cm_id_priv; > >>>+ unsigned long flags; > >>>+ int ret = 0; > >>>+ > >>>+ cm_id_priv = container_of(cm_id, struct iwcm_i

Re: [openib-general] Re: [PATCH 1/2] iWARP Connection Manager.

2006-06-01 Thread Tom Tucker
On Wed, 2006-05-31 at 15:22 -0700, Sean Hefty wrote: > Steve Wise wrote: > > +/* > > + * Release a reference on cm_id. If the last reference is being removed > > + * and iw_destroy_cm_id is waiting, wake up the waiting thread. > > + */ > > +static int iwcm_deref_id(struct iwcm_id_private *cm_id_pr

[PATCH][RFC] Notifier mechanism to notify RDMA devices of network events

2006-03-08 Thread Tom Tucker
Generic netevent notifiers + * + * Authors: + * Tom Tucker <[EMAIL PROTECTED]> + * + * Changes: + */ + +#ifdef __KERNEL__ + +#include + +struct netevent_redirect { + struct dst_entry *old; + struct dst_entry *new; +}; + +struct netevent_route_change { +