Re: [PATCH] vhost-vdpa: fix memory leak in error path

2020-09-18 Thread Tianjia Zhang
LGTM. Reviewed-by: Tianjia Zhang Thanks. On 9/9/20 11:41 PM, Li Qiang wrote: Free the 'page_list' when the 'npages' is zero. Signed-off-by: Li Qiang --- drivers/vhost/vdpa.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vd

[PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()

2020-08-02 Thread Tianjia Zhang
In the case of invalid rule, a positive value EINVAL is returned here. I think this is a typo error. It is necessary to return an error value. Cc: Po Liu Signed-off-by: Tianjia Zhang --- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH] net: ethernet: aquantia: Fix wrong return value

2020-08-02 Thread Tianjia Zhang
In function hw_atl_a0_hw_multicast_list_set(), when an invalid request is encountered, a negative error code should be returned. Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions") Cc: David VomLehn Signed-off-by: Tianjia Zhang --- drivers/ne

[PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-02 Thread Tianjia Zhang
In case of btf_id does not exist, a negative error code -ENOENT should be returned. Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") Cc: Andrii Nakryiko Signed-off-by: Tianjia Zhang --- tools/bpf/bpftool/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] liquidio: Fix wrong return value in cn23xx_get_pf_num()

2020-08-02 Thread Tianjia Zhang
On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a virtual machine") Cc: Rick Farrington Signed-off-by: Tianjia Zhang --- drivers/net/ethernet/caviu