In the case of invalid rule, a positive value EINVAL is returned here.
I think this is a typo error. It is necessary to return an error value.

Cc: Po Liu <po....@nxp.com>
Signed-off-by: Tianjia Zhang <tianjia.zh...@linux.alibaba.com>
---
 drivers/net/ethernet/freescale/enetc/enetc_qos.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c 
b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index fd3df19eaa32..4b3f1b60a24b 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -1017,7 +1017,7 @@ static int enetc_psfp_parse_clsflower(struct 
enetc_ndev_priv *priv,
                    !is_zero_ether_addr(match.mask->src)) {
                        NL_SET_ERR_MSG_MOD(extack,
                                           "Cannot match on both source and 
destination MAC");
-                       err = EINVAL;
+                       err = -EINVAL;
                        goto free_filter;
                }
 
@@ -1025,7 +1025,7 @@ static int enetc_psfp_parse_clsflower(struct 
enetc_ndev_priv *priv,
                        if (!is_broadcast_ether_addr(match.mask->dst)) {
                                NL_SET_ERR_MSG_MOD(extack,
                                                   "Masked matching on 
destination MAC not supported");
-                               err = EINVAL;
+                               err = -EINVAL;
                                goto free_filter;
                        }
                        ether_addr_copy(filter->sid.dst_mac, match.key->dst);
@@ -1036,7 +1036,7 @@ static int enetc_psfp_parse_clsflower(struct 
enetc_ndev_priv *priv,
                        if (!is_broadcast_ether_addr(match.mask->src)) {
                                NL_SET_ERR_MSG_MOD(extack,
                                                   "Masked matching on source 
MAC not supported");
-                               err = EINVAL;
+                               err = -EINVAL;
                                goto free_filter;
                        }
                        ether_addr_copy(filter->sid.src_mac, match.key->src);
@@ -1044,7 +1044,7 @@ static int enetc_psfp_parse_clsflower(struct 
enetc_ndev_priv *priv,
                }
        } else {
                NL_SET_ERR_MSG_MOD(extack, "Unsupported, must include 
ETH_ADDRS");
-               err = EINVAL;
+               err = -EINVAL;
                goto free_filter;
        }
 
-- 
2.26.2

Reply via email to