[PATCH net-next] mld: remove unnecessary prototypes

2021-04-16 Thread Taehee Yoo
Some prototypes are unnecessary, so delete it. Signed-off-by: Taehee Yoo --- net/ipv6/mcast.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index ff536a158b85..0d59efb6b49e 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -75,9 +75,6 @@ static

[PATCH net-next] mld: fix suspicious RCU usage in __ipv6_dev_mc_dec()

2021-04-16 Thread Taehee Yoo
: add mc_lock for protecting per-interface mld data") Suggested-by: Eric Dumazet Reported-by: Eric Dumazet Signed-off-by: Taehee Yoo --- Target banch is "net-next" although it has a fix tag because the commit 63ed8de4be81 ("mld: add mc_lock for protecting per-interface mld data&q

[PATCH v2 net-next] mld: change lockdep annotation for ip6_sf_socklist and ipv6_mc_socklist

2021-04-04 Thread Taehee Yoo
08094 ("mld: convert ifmcaddr6 to RCU") Reported-by: Eric Dumazet Signed-off-by: Taehee Yoo --- v1 -> v2: - Do not add new rtnl lock(by Eric Dumazet) - Add missing lock_sock(). - Change headline. net/ipv6/mcast.c | 48 +--- net/tipc/udp_

Re: [PATCH net-next] mld: add missing rtnl_lock() in do_ipv6_getsockopt()

2021-03-30 Thread Taehee Yoo
On 3/31/21 1:08 AM, Eric Dumazet wrote: > On Tue, Mar 30, 2021 at 6:02 PM Taehee Yoo wrote: >> >> On 3/31/21 12:40 AM, Eric Dumazet wrote: >> > This seems a serious regression compared to old code (in net tree) >> > >> > Have you added RTNL requi

Re: [PATCH net-next] mld: add missing rtnl_lock() in do_ipv6_getsockopt()

2021-03-30 Thread Taehee Yoo
On 3/31/21 12:40 AM, Eric Dumazet wrote: > This seems a serious regression compared to old code (in net tree) > > Have you added RTNL requirement in all this code ? > > We would like to use RTNL only if strictly needed. Yes, I agree with you. This patchset actually relies on existed RTNL, which i

[PATCH net-next] mld: add missing rtnl_lock() in do_ipv6_getsockopt()

2021-03-30 Thread Taehee Yoo
.13+0x1706/0x29f0 ? do_ipv6_mcast_group_source+0x150/0x150 ? __wake_up_common+0x620/0x620 ? mutex_trylock+0x23f/0x2a0 [ ... ] Fixes: 88e2ca308094 ("mld: convert ifmcaddr6 to RCU") Reported-by: Eric Dumazet Signed-off-by: Taehee Yoo --- commit 88e2ca308094 ("mld: convert ifmcaddr6 t

Re: [PATCH net-next v3 7/7] mld: add mc_lock for protecting per-interface mld data

2021-03-30 Thread Taehee Yoo
On 3/30/21 9:24 PM, Eric Dumazet wrote: > > > On 3/30/21 1:59 PM, Eric Dumazet wrote: >> >> >> On 3/25/21 5:16 PM, Taehee Yoo wrote: >>> The purpose of this lock is to avoid a bottleneck in the query/report >>> event handler logic. >>> >&g

Re: [PATCH net-next v3 5/7] mld: convert ifmcaddr6 to RCU

2021-03-29 Thread Taehee Yoo
On 2021. 3. 30. 오전 4:56, Eric Dumazet wrote: > > Hi Eric, Thank you for the review! > On 3/25/21 5:16 PM, Taehee Yoo wrote: >> The ifmcaddr6 has been protected by inet6_dev->lock(rwlock) so that >> the critical section is atomic context. In order to switch this context

Re: [PATCH net-next v3 0/7] mld: change context from atomic to sleepable

2021-03-25 Thread Taehee Yoo
On 3/26/21 1:16 AM, Taehee Yoo wrote: This patchset changes the context of MLD module. Before this patchset, MLD functions are atomic context so it couldn't use sleepable functions and flags. There are several reasons why MLD functions are under atomic context. 1. It uses timer API.

[PATCH net-next v3 7/7] mld: add mc_lock for protecting per-interface mld data

2021-03-25 Thread Taehee Yoo
needed in the query/report event handler logic. Therefore bottleneck will be disappeared by mc_lock. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v3: - Initial patch include/net/if_inet6.h | 1 + net/ipv6/mcast.c | 309 + 2 files changed

[PATCH net-next v3 6/7] mld: add new workqueues for process mld events

2021-03-25 Thread Taehee Yoo
_lock, and worker functions are protected by RTNL. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v3: - Initial patch include/net/if_inet6.h | 9 +- include/net/mld.h | 3 + net/ipv6/icmp.c| 4 +- net/ipv6/mcast.c | 280 +--

[PATCH net-next v3 5/7] mld: convert ifmcaddr6 to RCU

2021-03-25 Thread Taehee Yoo
tched to sleepable. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v2 -> v3: - Fix sparse warnings because of rcu annotation - Do not use mca_lock v1 -> v2: - Separated from previous big one patch. drivers/s390/net/qeth_l3_main.c | 6 +- include/net/if_inet6.h | 7 +-

[PATCH net-next v3 2/7] mld: get rid of inet6_dev->mc_lock

2021-03-25 Thread Taehee Yoo
it should be removed. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v2 -> v3: - No change v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 1 - net/ipv6/mcast.c | 9 - 2 files changed, 10 deletions(-) diff --git a/include/net/if_inet6.h b/in

[PATCH net-next v3 4/7] mld: convert ip6_sf_list to RCU

2021-03-25 Thread Taehee Yoo
ed to sleepable. But It doesn't remove mca_lock yet because ifmcaddr6 isn't converted to RCU yet. So, It's not fully converted to the sleepable context. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v2 -> v3: - Fix sparse warnings because of rcu annotation v1 -> v2: - S

[PATCH net-next v3 1/7] mld: convert from timer to delayed work

2021-03-25 Thread Taehee Yoo
is used by both process and BH context. So that it still uses spin_lock_bh() and rwlock. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v2 -> v3: - Do not use msecs_to_jiffies() - Do not add unnecessary rtnl_lock and rtnl_unlock v1 -> v2: - Separated from previous big one patc

[PATCH net-next v3 3/7] mld: convert ipv6_mc_socklist->sflist to RCU

2021-03-25 Thread Taehee Yoo
ed-by: Cong Wang Signed-off-by: Taehee Yoo --- v2 -> v3: - Fix sparse warnings because of rcu annotation v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 4 ++-- net/ipv6/mcast.c | 52 ++ 2 files changed, 24 insert

[PATCH net-next v3 0/7] mld: change context from atomic to sleepable

2021-03-25 Thread Taehee Yoo
'ipv6_mc_socklist'->sf_count'. 5. Do not add mld_check_leave_group() function. 6. Do not add ip6_mc_del_src_bulk() function. 7. Do not add ip6_mc_add_src_bulk() function. 8. Do not use rcu_read_lock() in the qeth_l3_add_mcast_rtnl(). (by Julian Wiedmann) Taehee Yoo (7): mld: conv

Re: [PATCH net] vxlan: move debug check after netdev unregister

2021-02-23 Thread Taehee Yoo
On 2021. 2. 24. 오전 6:34, Jakub Kicinski wrote: Hi Jakub, Thank you for the review! > On Sun, 21 Feb 2021 15:45:52 +0000 Taehee Yoo wrote: >> The debug check must be done after unregister_netdevice_many() call -- >> the hlist_del_rcu() for this is done inside .ndo_stop. >>

[PATCH net] vxlan: move debug check after netdev unregister

2021-02-21 Thread Taehee Yoo
es: 0e4ec5acad8b ("vxlan: exit_net cleanup checks added") Signed-off-by: Taehee Yoo --- drivers/net/vxlan.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a8ad710629e6..0842371eca3d 100644 --- a/drivers/net

Re: [PATCH net-next v2 1/7] mld: convert from timer to delayed work

2021-02-16 Thread Taehee Yoo
[...] >> By the way, I think the 'delay' is from the >> unsolicited_report_interval() and it just return value of >> idev->cnf.mldv{1 | 2}_unsolicited_report_interval. >> I think this value is msecs, not jiffies. >> So, It should be converted to use msecs_to_jiffies(), I think. >> How do you thi

Re: [PATCH net-next v2 3/7] mld: add a new delayed_work, mc_delrec_work

2021-02-14 Thread Taehee Yoo
> > By the way, if you do not use a delay, you can just use regular work. > The regular workqueue API couldn't be used in an atomic context, So I used delayed_work. If 0 delay is passed to delayed_work, it internally calls regular workqueue. So, I think there is no actual difference. Thanks!

Re: [PATCH net-next v2 0/7] mld: change context from atomic to sleepable

2021-02-14 Thread Taehee Yoo
On 21. 2. 14. 오전 4:58, David Ahern wrote: your patches still show up as 8 individual emails. Did you use 'git send-email --thread --no-chain-reply-to' as Jakub suggested? Please read the git-send-email man page for what the options do. I sent all patches individually with these options. gi

Re: [PATCH net-next v2 3/7] mld: add a new delayed_work, mc_delrec_work

2021-02-14 Thread Taehee Yoo
On 21. 2. 14. 오전 4:18, Cong Wang wrote: > On Sat, Feb 13, 2021 at 9:52 AM Taehee Yoo wrote: >> >> The goal of mc_delrec_work delayed work is to call mld_clear_delrec(). >> The mld_clear_delrec() is called under both data path and control path. >> So, the context o

Re: [PATCH net-next v2 5/7] mld: convert ipv6_mc_socklist->sflist to RCU

2021-02-14 Thread Taehee Yoo
On 21. 2. 14. 오전 4:41, kernel test robot wrote: Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210214-015930 base

Re: [PATCH net-next v2 1/7] mld: convert from timer to delayed work

2021-02-14 Thread Taehee Yoo
On 21. 2. 14. 오전 4:07, Cong Wang wrote: > On Sat, Feb 13, 2021 at 9:51 AM Taehee Yoo wrote: >> -static void mld_dad_start_timer(struct inet6_dev *idev, unsigned long delay) >> +static void mld_dad_start_work(struct inet6_dev *idev, unsigned long delay) >> { >>

[PATCH net-next v2 7/7] mld: convert ifmcaddr6 to RCU

2021-02-13 Thread Taehee Yoo
atomic context locks, they are ifmcaddr6->mca_lock and inet6_dev->lock. These locks are protecting resources, they are written on the datapath. RTNL can't be used on the datapath, these locks are used. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated f

[PATCH net-next v2 5/7] mld: convert ipv6_mc_socklist->sflist to RCU

2021-02-13 Thread Taehee Yoo
ed-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 4 ++-- net/ipv6/mcast.c | 52 ++ 2 files changed, 24 insertions(+), 32 deletions(-) diff --git a/include/net/if_inet6.h b

[PATCH net-next v2 4/7] mld: get rid of inet6_dev->mc_lock

2021-02-13 Thread Taehee Yoo
it should be removed. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 1 - net/ipv6/mcast.c | 9 - 2 files changed, 10 deletions(-) diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h

[PATCH net-next v2 6/7] mld: convert ip6_sf_list to RCU

2021-02-13 Thread Taehee Yoo
ed to sleepable. But It doesn't remove mca_lock yet because ifmcaddr6 isn't converted to RCU yet. So, It's not fully converted to the sleepable context. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_ine

[PATCH net-next v2 2/7] mld: separate two flags from ifmcaddr6->mca_flags

2021-02-13 Thread Taehee Yoo
So, if they are separated from mca_flags, it could reduce atomic context. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 8 net/ipv6/mcast.c | 26 +++--- 2 files chang

[PATCH net-next v2 3/7] mld: add a new delayed_work, mc_delrec_work

2021-02-13 Thread Taehee Yoo
protected by RTNL. So, this function should be called in a sleepable context. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 1 + net/ipv6/mcast.c | 32 +++- 2 files changed,

[PATCH net-next v2 0/7] mld: change context from atomic to sleepable

2021-02-13 Thread Taehee Yoo
6_mc_del_src_bulk() function. 7. Do not add ip6_mc_add_src_bulk() function. 8. Do not use rcu_read_lock() in the qeth_l3_add_mcast_rtnl(). (by Julian Wiedmann) Taehee Yoo (7): mld: convert from timer to delayed work mld: separate two flags from ifmcaddr6->mca_flags mld: add a new delayed_

[PATCH net-next v2 1/7] mld: convert from timer to delayed work

2021-02-13 Thread Taehee Yoo
is used by both process and BH context. So that it still uses spin_lock_bh() and rwlock. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- v1 -> v2: - Separated from previous big one patch. include/net/if_inet6.h | 8 +-- net/ipv6/mcast.c | 148 -

Re: [PATCH net-next 8/8] mld: change context of mld module

2021-02-09 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 17:26, Julian Wiedmann wrote: > Hi Julian, Thank you for the review! > On 08.02.21 18:59, Taehee Yoo wrote: > > MLD module's context is atomic although most logic is called from > > control-path, not data path. Only a few functions are called from &g

Re: [PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-09 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 14:31, Cong Wang wrote: > > On Mon, Feb 8, 2021 at 6:17 PM Taehee Yoo wrote: > > You're right, this patchset contains many unnecessary changes. > > So I will send a v2 patch, which contains only the necessary changes. > > And target branch

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:56, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:18:40 -0700 David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > > Thanks, I understand why the arrays have been using. > > > I will send a v2 patch, which contains only the nec

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:18, David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > Thanks, I understand why the arrays have been using. > > I will send a v2 patch, which contains only the necessary changes. > > please send v2 as a patch series and not 8 in

Re: [PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 10:50, Cong Wang wrote: > Hi Cong! Thank you for your review. > On Mon, Feb 8, 2021 at 9:50 AM Taehee Yoo wrote: > > > > This patchset changes context of MLD module. > > Before this patch, MLD functions are atomic context so it couldn't us

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 03:31, Eric Dumazet wrote: > Hi Eric, Thank you for the review! > > > On 2/8/21 6:58 PM, Taehee Yoo wrote: > > Currently, struct ip6_sf_socklist doesn't use list API so that code > > shape is a little bit different from others. > > So

[PATCH net-next 8/8] mld: change context of mld module

2021-02-08 Thread Taehee Yoo
ontrol-path and data-path. So, mutex can't be used. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- drivers/s390/net/qeth_l3_main.c | 6 +- include/net/if_inet6.h | 29 +- net/batman-adv/multicast.c | 4 +- net/ipv6/addrconf.c | 4

[PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
Currently, struct ip6_sf_socklist doesn't use list API so that code shape is a little bit different from others. So it converts ip6_sf_socklist to use list API so it would improve readability. Signed-off-by: Taehee Yoo --- include/net/if_inet6.h | 19 +- include/uapi/linux/in.h | 4 +-

[PATCH net-next 6/8] mld: convert ipv6_mc_socklist to list macros

2021-02-08 Thread Taehee Yoo
Currently, struct ipv6_mc_socklist doesn't use list API so that code shape is a little bit different from others. So it converts ipv6_mc_socklist to use list API so it would improve readability. Signed-off-by: Taehee Yoo --- .../chelsio/inline_crypto/chtls/chtls_cm.c| 1 + include/

[PATCH net-next 5/8] mld: rename igmp6 to mld

2021-02-08 Thread Taehee Yoo
ipv6 multicast protocol is MLD, not IGMP6. So it should be renamed. Signed-off-by: Taehee Yoo --- include/net/ndisc.h | 14 ++-- net/ipv6/af_inet6.c | 12 +-- net/ipv6/icmp.c | 4 +- net/ipv6/mcast.c| 198 ++-- 4 files changed, 115 insertions

[PATCH net-next 4/8] mld: convert from timer to delayed work

2021-02-08 Thread Taehee Yoo
ed by both process and BH context. So that it still uses spin_lock_bh() and rwlock. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo --- include/net/if_inet6.h | 8 +-- net/ipv6/mcast.c | 141 - 2 files changed, 86 insertions(+), 63 deletions(-) di

[PATCH net-next 3/8] mld: use mca_{get | put} instead of refcount_{dec | inc}

2021-02-08 Thread Taehee Yoo
mca_{get | put} are wrapper function of refcount_{dec | inc}. And using only wrapper functions is more readable. Signed-off-by: Taehee Yoo --- net/ipv6/mcast.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 9c4dc4c2ff01

[PATCH net-next 2/8] mld: convert ip6_sf_list to list macros

2021-02-08 Thread Taehee Yoo
Currently, struct ip6_sf_list doesn't use list API so that code shape is a little bit different from others. So it converts ip6_sf_list to use list API so it would improve readability. Signed-off-by: Taehee Yoo --- include/net/if_inet6.h | 6 +- net/ipv6/mcast.c

[PATCH net-next 1/8] mld: convert ifmcaddr6 to list macros

2021-02-08 Thread Taehee Yoo
Currently, struct ifmcaddr6 doesn't use list API so that code shape is a little bit different from others. So it converts ifmcaddr6 to use list API so it would improve readability. Signed-off-by: Taehee Yoo --- drivers/s390/net/qeth_l3_main.c | 2 +- include/net/if_inet6.h

[PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-08 Thread Taehee Yoo
is to use the mutex instead of spinlock and rwlock because A critical section of spinlock and rwlock is atomic. Taehee Yoo (8): mld: convert ifmcaddr6 to list macros mld: convert ip6_sf_list to list macros mld: use mca_{get | put} instead of refcount_{dec | inc} mld: convert from tim

[PATCH net v2 1/2] bareudp: set NETIF_F_LLTX flag

2020-12-28 Thread Taehee Yoo
97.056135][ T822] ip_finish_output2+0x6ea/0x2020 [ ... ] Acked-by: Guillaume Nault Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change reproducer script drivers

[PATCH net v2 0/2] bareudp: fix several issues

2020-12-28 Thread Taehee Yoo
ccurs kernel panic. Changelog v1 -> v2: - Change reproducer script in 1/2 patch. - Fix reproducer script in 2/2 patch. Taehee Yoo (2): bareudp: set NETIF_F_LLTX flag bareudp: Fix use of incorrect min_headroom size drivers/net/bareudp.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH net v2 2/2] bareudp: Fix use of incorrect min_headroom size

2020-12-28 Thread Taehee Yoo
d+0x91/0xa0 [ 66.513279][C2] ? ip6_protocol_deliver_rcu+0x1560/0x1560 [ 66.514414][C2] ipv6_rcv+0xe8/0x300 [ ... ] Acked-by: Guillaume Nault Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Sign

Re: [PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size

2020-12-27 Thread Taehee Yoo
On Mon, 28 Dec 2020 at 01:33, Guillaume Nault wrote: > Hi Guillaume, Thank you for the review! > On Sat, Dec 26, 2020 at 05:13:08PM +, Taehee Yoo wrote: > > In the bareudp6_xmit_skb(), it calculates min_headroom. > > At that point, it uses struct iphdr, but it's no

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-27 Thread Taehee Yoo
On Mon, 28 Dec 2020 at 04:24, Cong Wang wrote: > > On Sun, Dec 27, 2020 at 6:40 AM Taehee Yoo wrote: > > But I'm so sorry I didn't understand some points. > > > > 1. you said "both side" and I understand these as follows: > > a) failure of

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-27 Thread Taehee Yoo
On Sun, 27 Dec 2020 at 04:27, Cong Wang wrote: > Hi Cong, Thank you so much for the review! > On Wed, Dec 23, 2020 at 8:55 AM Taehee Yoo wrote: > > > > mld_newpack() doesn't allow to allocate high order page, > > just order-0 allocation is allowed. > > If h

[PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size

2020-12-26 Thread Taehee Yoo
327][C2] ? rcu_read_lock_held+0x91/0xa0 [ 66.513279][C2] ? ip6_protocol_deliver_rcu+0x1560/0x1560 [ 66.514414][C2] ipv6_rcv+0xe8/0x300 [ ... ] Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Taehee

[PATCH net 1/2] bareudp: set NETIF_F_LLTX flag

2020-12-26 Thread Taehee Yoo
63][ T822] ? pneigh_lookup+0x410/0x410 [ 97.056135][ T822] ip_finish_output2+0x6ea/0x2020 [ ... ] Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Taehee Yoo --- drivers/net/bareudp.c | 1

[PATCH net 0/2] bareudp: fix several issues

2020-12-26 Thread Taehee Yoo
ccurs kernel panic. Taehee Yoo (2): bareudp: set NETIF_F_LLTX flag bareudp: Fix use of incorrect min_headroom size drivers/net/bareudp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1

[PATCH net] mld: fix panic in mld_newpack()

2020-12-23 Thread Taehee Yoo
lem. Fixes: 72e09ad107e7 ("ipv6: avoid high order allocations") Signed-off-by: Taehee Yoo --- net/ipv6/mcast.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 6c8604390266..2cab0c563214 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -1601

[PATCH v3 net] netdevsim: set .owner to THIS_MODULE

2020-11-15 Thread Taehee Yoo
Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots") Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata") Signed-off-by: Taehee Yoo --- v3: - Separate from one big series v2: - Change headline - Squash patches

Re: [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

2020-11-07 Thread Taehee Yoo
On Sun, 8 Nov 2020 at 04:05, Jakub Kicinski wrote: > Hi Jakub, Thank you for the review! > On Sat, 7 Nov 2020 17:21:31 + Taehee Yoo wrote: > > When debugfs file is opened, its module should not be removed until > > it's closed. > > Because debugfs internally u

Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel wrote: > Hi Arend, Thank you for the review! > On November 7, 2020 6:25:15 PM Taehee Yoo wrote: > > > If THIS_MODULE is not set, the module would be removed while debugfs is > > being used. > > It eventually makes kernel

[PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f8c8e62cd50 ("brcmfmac: add "reset" debugfs entry for testing reset") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline driver

[PATCH net v2 21/21] Bluetooth: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
nt identity information in debugfs") Fixes: c2aa30db744d ("Bluetooth: debugfs option to unset MITM flag") Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one") Fixes: 6de50f9fdb60 ("Bluetooth: Export ECDH selftest result in

[PATCH net v2 18/21] b43legacy: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers

[PATCH net v2 14/21] wcn36xx: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash pat

[PATCH net v2 20/21] mwifiex: mwifiex: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash pat

[PATCH net v2 19/21] b43: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: e4d6b7951812 ("[B43]: add mac80211-based driver for modern BCM43xx devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wire

[PATCH net v2 15/21] wil6210: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
es: 10d599ad84a1 ("wil6210: add support for device led configuration") Fixes: 12bace75704e ("wil6210: extract firmware capabilities from FW file") Fixes: 13cd9f758a55 ("wil6210: extract firmware version from file header") Fixes: fe9ee51e6a43 ("wil6210: add support for PCI

[PATCH net v2 12/21] ath11k: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-dri

[PATCH net v2 16/21] cw1200: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline driver

[PATCH net v2 10/21] iwlegacy: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
legacy devices 3945/4965"") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/intel/iwlegacy/3945-rs.c | 1 + drivers/net/wireless/intel/iwlegacy/4965-rs.c | 3 +++ drivers/net/wireless/intel/iwlegacy/debu

[PATCH net v2 09/21] iwlwifi: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
lwifi: mvm: Add mem debugfs entry") Fixes: 93b167c13a3a ("iwlwifi: runtime: sync FW and host clocks for logs") Fixes: 38167459da50 ("iwlagn: show current rate scale data in debugfs") Fixes: 87e5666c0722 ("iwlagn: transport handler can register debugfs entries") Fi

[PATCH net v2 13/21] ath10k: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
44fa5722712 ("ath10k: debugfs file to enable Bluetooth coexistence feature") Fixes: 348cd95c8196 ("ath10k: add debugfs entry to enable extended tx stats") Fixes: cc61a1bbbc0e ("ath10k: enable debugfs provision to enable Peer Stats feature") Signed-off-by: Taehee Yoo -

[PATCH net v2 11/21] rtlwifi: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/realtek/rtlwif

[PATCH net v2 08/21] wl1251: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f01a1f58889 ("wl12xx: add driver") Fixes: b7339b1de0f7 ("wl1251: add tx queue status to debugfs") Signed-off-by: Taehee Yoo --- v1 -> v2: - Ch

[PATCH net v2 05/21] ieee802154: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/ieee802154

[PATCH net v2 07/21] wlcore: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: f5fc0f86b02a ("wl1271: add wl1271 driver files") Fixes: bcca1bbdd412 ("wlcore: add debugfs macro to help print fw statistics arrays") Signed-off-by:

[PATCH net v2 06/21] i2400m: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: c71228caf91e ("i2400m: debugfs controls") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem driv

[PATCH net v2 01/21] net: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
on") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem net/6lowpan/debugfs.c | 1 + net/batman-adv/log.c | 1 + 2 files changed, 2 insertions(+) diff --git a/net/6lowpan/debugfs.c b/net/6lowpan/debugfs.c index 1c140af06d52..2f791c

[PATCH net v2 04/21] netdevsim: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots") Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsyste

[PATCH net v2 03/21] cfg80211: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 1ac61302dcd1 ("mac80211/cfg80211: move wiphy specific debugfs entries to cfg80211") Fixes: 80a3511d70e8 ("cfg80211: add debugfs HT40 allow map") Signe

[PATCH net v2 02/21] mac80211: set .owner to THIS_MODULE

2020-11-07 Thread Taehee Yoo
ement Airtime-based Queue Limit (AQL)") Fixes: 276d9e82e06c ("mac80211: debugfs option to force TX status frames") Fixes: 827b1fb44b7e ("mac80211: resume properly, add suspend/resume test") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Sq

[PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

2020-11-07 Thread Taehee Yoo
me+0x44/0xa9 [ 75.385427][ T662] RIP: 0033:0x7f937b3159e4 [ ... ] v1 -> v2: - Rebase - Squash patches into per-driver/subsystem Taehee Yoo (21): net: set .owner to THIS_MODULE mac80211: set .owner to THIS_MODULE cfg80211: set .owner to THIS_MODULE netdevsim: set .owner to THIS_MODU

[PATCH net] net: core: use list_del_init() instead of list_del() in netdev_run_todo()

2020-10-15 Thread Taehee Yoo
_locked+0x13/0x50 [ 255.812910][ T1030] ? rtnl_is_locked+0x11/0x20 [ 255.814061][ T1030] ? netdev_master_upper_dev_get+0xf/0x120 [ 255.815553][ T1030] do_setlink+0x94c/0x3040 [ ... ] Reported-by: syzbot+4a0f7bc34e3997a6c...@syzkaller.appspotmail.com Fixes: 1fc70edb7d7b ("net: core: add nested_level variab

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-09 Thread Taehee Yoo
On Fri, 9 Oct 2020 at 16:45, Johannes Berg wrote: > Hi Johannes, Thank you for the review! > On Fri, 2020-10-09 at 07:09 +0200, Nicolai Stange wrote: > > Johannes Berg writes: > > > > > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: > > > > From

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-09 Thread Taehee Yoo
On Fri, 9 Oct 2020 at 14:39, Nicolai Stange wrote: > Hi Nicolai, Thank you for the review! > Taehee Yoo writes: > > > On Fri, 9 Oct 2020 at 01:14, Johannes Berg > > wrote: > > On Thu, 2020-10-08 at 15:59 +, David Laight wrote: > > > >> From: Tae

Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-08 Thread Taehee Yoo
On Fri, 9 Oct 2020 at 01:14, Johannes Berg wrote: On Thu, 2020-10-08 at 15:59 +, David Laight wrote: Hi Johannes and David, Thank you for the review! > From: Taehee Yoo > > Sent: 08 October 2020 16:49 > > > > When debugfs file is opened, its module should not be r

[PATCH net 027/117] i2400m: set i2400m_rx_stats_fops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: c71228caf91e ("i2400m: debugfs controls") Signed-off-by: Taehee Yoo --- drivers/net/wimax/i2400m/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net 028/117] i2400m: set i2400m_tx_stats_fops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: c71228caf91e ("i2400m: debugfs controls") Signed-off-by: Taehee Yoo --- drivers/net/wimax/i2400m/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net 035/117] wl12xx: set DEBUGFS_FWSTATS_FILE_ARRAY.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f01a1f58889 ("wl12xx: add driver") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ti/wl1251/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net 038/117] wl1251: set tx_queue_status_ops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: b7339b1de0f7 ("wl1251: add tx queue status to debugfs") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ti/wl1251/debugfs.c | 1 + 1 file changed, 1 insertio

[PATCH net 036/117] wl12xx: set DEBUGFS_READONLY_FILE.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f01a1f58889 ("wl12xx: add driver") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ti/wl1251/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net 061/117] iwlagn: set DEBUGFS_WRITE_FILE_OPS.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 16db88ba51d6 ("iwlagn: move dump_csr and dump_fh to transport layer") Signed-off-by: Taehee Yoo --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1 + 1 fi

[PATCH net 029/117] dpaa2-eth: set dpaa2_dbg_cpu_ops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 091a19ea6e34 ("dpaa2-eth: add debugfs statistics") Signed-off-by: Taehee Yoo --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 1 + 1 file

[PATCH net 059/117] iwlagn: set rs_sta_dbgfs_rate_scale_data_ops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 38167459da50 ("iwlagn: show current rate scale data in debugfs") Signed-off-by: Taehee Yoo --- drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 1 + 1 file

[PATCH net 070/117] ath10k: set fops_btcoex.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 844fa5722712 ("ath10k: debugfs file to enable Bluetooth coexistence feature") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ath/ath10k/debug.c | 3 +

[PATCH net 060/117] iwlagn: set DEBUGFS_READ_FILE_OPS.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 87e5666c0722 ("iwlagn: transport handler can register debugfs entries") Signed-off-by: Taehee Yoo --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1

[PATCH net 071/117] ath10k: set fops_enable_extd_tx_stats.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 348cd95c8196 ("ath10k: add debugfs entry to enable extended tx stats") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ath/ath10k/debug.c | 3 ++- 1 file

[PATCH net 072/117] ath10k: set fops_peer_stats.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: cc61a1bbbc0e ("ath10k: enable debugfs provision to enable Peer Stats feature") Signed-off-by: Taehee Yoo --- drivers/net/wireless/ath/ath10k/debug.c | 3 +

[PATCH net 115/117] Bluetooth: set force_no_mitm_fops.owner to THIS_MODULE

2020-10-08 Thread Taehee Yoo
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: c2aa30db744d ("Bluetooth: debugfs option to unset MITM flag") Signed-off-by: Taehee Yoo --- net/bluetooth/hci_debugfs.c | 1 + 1 file changed, 1 insertion(+)

  1   2   3   4   >