If THIS_MODULE is not set, the module would be removed while debugfs is
being used.
It eventually makes kernel panic.

Fixes: 2f01a1f58889 ("wl12xx: add driver")
Fixes: b7339b1de0f7 ("wl1251: add tx queue status to debugfs")
Signed-off-by: Taehee Yoo <ap420...@gmail.com>
---

v1 -> v2:
 - Change headline
 - Squash patches into per-driver/subsystem

 drivers/net/wireless/ti/wl1251/debugfs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/ti/wl1251/debugfs.c 
b/drivers/net/wireless/ti/wl1251/debugfs.c
index d48746e640cc..0a26cee0f287 100644
--- a/drivers/net/wireless/ti/wl1251/debugfs.c
+++ b/drivers/net/wireless/ti/wl1251/debugfs.c
@@ -35,6 +35,7 @@ static const struct file_operations name## _ops = {           
        \
        .read = name## _read,                                           \
        .open = simple_open,                                            \
        .llseek = generic_file_llseek,                                  \
+       .owner = THIS_MODULE,                                           \
 };
 
 #define DEBUGFS_ADD(name, parent)                                      \
@@ -67,6 +68,7 @@ static const struct file_operations sub## _ ##name## _ops = { 
        \
        .read = sub## _ ##name## _read,                                 \
        .open = simple_open,                                            \
        .llseek = generic_file_llseek,                                  \
+       .owner = THIS_MODULE,                                           \
 };
 
 #define DEBUGFS_FWSTATS_ADD(sub, name)                         \
@@ -212,6 +214,7 @@ static const struct file_operations tx_queue_len_ops = {
        .read = tx_queue_len_read,
        .open = simple_open,
        .llseek = generic_file_llseek,
+       .owner = THIS_MODULE,
 };
 
 static ssize_t tx_queue_status_read(struct file *file, char __user *userbuf,
@@ -234,6 +237,7 @@ static const struct file_operations tx_queue_status_ops = {
        .read = tx_queue_status_read,
        .open = simple_open,
        .llseek = generic_file_llseek,
+       .owner = THIS_MODULE,
 };
 
 static void wl1251_debugfs_delete_files(struct wl1251 *wl)
-- 
2.17.1

Reply via email to