96f0eb3cabab986adcd8a58b9bdbe9d
>
> Reported-by: syzbot
> Tested-by: syzbot
> Signed-off-by: Tetsuo Handa
> Fixes: ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 in TT code")
> Fixes: 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN specific&qu
On Monday, 5 April 2021 12:02:02 CEST Tetsuo Handa wrote:
[...]
> > Thanks but this patch is incomplete. Please also fix
> > batadv_tt_prepare_tvlv_global_data (exactly the same way)
>
> Indeed. Hmm, batadv_send_tt_request() is already using kzalloc().
> Which approach ( "->reserved = 0" or "kzal
On Monday, 5 April 2021 07:33:06 CEST Tetsuo Handa wrote:
[...]
> ---
> net/batman-adv/translation-table.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/batman-adv/translation-table.c
> b/net/batman-adv/translation-table.c
> index f8761281aab0..eb82576557e6 100644
> --- a/net/batm
On Thursday, 4 February 2021 20:58:36 CET Jakub Kicinski wrote:
> Back when I was working for a vendor I had a script which used git to
> find files touched in current year and then a bit of sed to update the
> dates. Instead of running your current script every Jan, you can run
> that one every De
On Thursday, 4 February 2021 01:35:06 CET Jakub Kicinski wrote:
[...]
> Is this how copyright works? I'm not a layer, but I thought it was
> supposed to reflect changes done to given file in a given year.
Because we all know that the first thing a person is doing when
submitting a change is to up
On Thursday, 4 February 2021 01:33:02 CET Jakub Kicinski wrote:
[...]
> For just comment adjustments and the sizeof() change?
The process is basically:
1. update the version information for a development period
2. queue up whatever comes in during that time
3. send it to netdev for net-next when
On Tuesday, 8 December 2020 08:48:56 CET Enrico Weigelt, metux IT consult wrote:
> > Is there some explanation besides an opinion? Some kind goal which you want
> > to
> > achieve with it maybe?
>
> Just a cleanup. I've been under the impression that this version is just
> an relic from oot time
On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
Is there some explanation besides an opinion? Some kind goal which you want to
achieve with it maybe?
A
While vxlan doesn't need any extra tailroom, the lowerdev might need it. In
that case, copy it over to reduce the chance for additional (re)allocations
in the transmit path.
Signed-off-by: Sven Eckelmann
---
drivers/net/vxlan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/driver
vice. The first
caller of net_dev_xmit could therefore never make sure that enough headroom
was allocated for the rest of the transmit path.
Cc: Annika Wickert
Signed-off-by: Sven Eckelmann
---
drivers/net/vxlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxlan.c b/dr
Hi,
I find your output slightly confusing. Maybe you can change your printk stuff
to something more like:
printk("%s %s:%u max_headroom %u\n", __FILE__, __func__, __LINE__,
max_headroom);
On Thursday, 26 November 2020 00:14:35 CET Annika Wickert wrote:
> This is what I get from the bridge wh
On Sunday, 20 September 2020 21:59:19 CEST Stephen Rothwell wrote:
> Hi all,
Yes, I've accidentally swapped the IDs while adding them to the various patches.
The correct ones should have been:
* 097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash
indexing")
Fixes: 07568d0369
On Friday, 18 September 2020 05:03:19 CEST Xiyu Yang wrote:
> batadv_neigh_node_create() is used to create a neigh node object, whose
> fields will be initialized with the specific object. When a new
> reference of the specific object is created during the initialization,
> its refcount should be i
On Sunday, 23 August 2020 08:05:10 CEST Randy Dunlap wrote:
[...]
> > Please rebase to only contain the changes not yet in
> > https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next
[...]
> Is this git tree included in linux-next?
No, Stephen Rothwell isn't including the ba
On Sunday, 23 August 2020 01:13:27 CEST Randy Dunlap wrote:
> Drop repeated words in net/batman-adv/.
Please rebase to only contain the changes not yet in
https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next
Kind regards,
Sven
signature.asc
Description: This is
On Monday, 17 August 2020 10:39:00 CEST Bjørn Mork wrote:
> Linus Lüssing writes:
[...]
> This is not a bug. They are deliberately breaking IPv6 because they
> consider this a feature. You should not try to work around such issues.
> It is a fight you cannot win. Any workaround will only encour
On Tuesday, 7 July 2020 17:30:14 CEST syzbot wrote:
> general protection fault, probably for non-canonical address
> 0xdc0e: [#1] PREEMPT SMP KASAN
> KASAN: null-ptr-deref in range [0x0070-0x0077]
> CPU: 1 PID: 9126 Comm: kworker/u4:9 Not tainted 5.8.0-rc3-
On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote:
[...]
> > No new sysfs config files.
>
> Why? The bridge for instance does the same.
https://patchwork.open-mesh.org/patch/16763/ - here the quote
On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote:
> I strongly believe it
On Wednesday, 6 February 2019 20:08:14 CET Linus Lüssing wrote:
> Ok, will rewrite the batctl part later then. And probably keep "batctl
> mm" as a (hidden?) option for compatibility reasons?
Yes, sounds good.
Kind regards,
Sven
signature.asc
Description: This is a digitally signed messa
On Tuesday, 5 February 2019 20.24.10 CET Linus Lüssing wrote:
[...]
> Another thought, if all this is too vague for now...
Yes, it is to vague for the integration in netlink :D
> what about
> ommiting the BATADV_ATTR_MULTICAST_(MODE)_ENABLED for now and use
> a reverse logic instead? Like
> BATA
On Saturday, 19 January 2019 16.56.07 CET Sven Eckelmann wrote:
[...]
> There were also two topics which were not yet really discussed and thus
> these requests (from Linus) were not yet implemented:
@Jiri, @Linus maybe you can discuss these topics further and select the
correct so
attributes:
* u8 BATADV_ATTR_GW_MODE (0 == off, 1 == client, 2 == server)
* u32 BATADV_ATTR_GW_BANDWIDTH_DOWN (in 100 kbit/s steps)
* u32 BATADV_ATTR_GW_BANDWIDTH_UP (in 100 kbit/s steps)
* u32 BATADV_ATTR_GW_SEL_CLASS
Signed-off-by: Sven Eckelmann
---
Cc: Marek Lindner
Cc: Antonio Quartulli
cast group using the BATADV_CMD_SET_VLAN command
message type that settings might have been changed and what the current
values are.
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 17 +++
net/batman-adv/netlink.c| 191 +++-
2 files changed,
BATADV_ATTR_ELP_INTERVAL
attribute.
Signed-off-by: Sven Eckelmann
---
Cc: Linus Lüssing
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 143 +++
1 file changed, 100 insertions(+), 43 deletions(-)
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 5fe833cc..e56c40d1 100644
--- a/net/batman-adv/netlink.c
+++ b/net/
will disable this feature and setting it
to something else is enabling this feature.
Signed-off-by: Sven Eckelmann
---
Cc: Simon Wunderlich
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 11 +++
2 files changed, 17 insertions(+)
diff --git a/include
to zero will disable this feature and setting it
to something else is enabling this feature.
Signed-off-by: Sven Eckelmann
---
Cc: Linus Lüssing
---
include/uapi/linux/batman_adv.h | 8
net/batman-adv/netlink.c| 15 +++
2 files changed, 23 insertions(+)
diff --git a
ave been changed and what the current
values are.
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 16 +++-
net/batman-adv/netlink.c| 160 +++-
2 files changed, 111 insertions(+), 65 deletions(-)
diff --git a/include/uapi/linux/batman_adv.h
feature using the
BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE_ENABLED attribute. Setting the u8 to zero
will disable this feature and setting it to something else is enabling this
feature.
Signed-off-by: Sven Eckelmann
---
Cc: Simon Wunderlich
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv
e/attribute format.
Kind regards,
Sven
[1] https://www.open-mesh.org/issues/300
[2] https://patchwork.open-mesh.org/cover/17610/
Sven Eckelmann (19):
batman-adv: Move common genl doit code pre/post hooks
batman-adv: Prepare framework for mesh genl config
batman-adv: Prepare fram
will disable this feature and setting it
to something else is enabling this feature.
Signed-off-by: Sven Eckelmann
---
Cc: Andreas Langer
Cc: Martin Hundeboll
Cc: Marek Lindner
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv/netlink.c| 12
2 files changed
changed and what the
current values are.
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 16 ++-
net/batman-adv/netlink.c| 240 +---
2 files changed, 233 insertions(+), 23 deletions(-)
diff --git a/include/uapi/linux/batman_adv.h b/include/uap
attributes BATADV_ATTR_ISOLATION_MARK
and BATADV_ATTR_ISOLATION_MASK.
Signed-off-by: Sven Eckelmann
---
Cc: Antonio Quartulli
---
include/uapi/linux/batman_adv.h | 19 +++
net/batman-adv/netlink.c| 89 +
2 files changed, 108 insertions(+)
diff --git a/include
. Setting the u8 to zero
will disable this feature and setting it to something else is enabling this
feature.
Signed-off-by: Sven Eckelmann
---
Cc: Antonio Quartulli
---
include/uapi/linux/batman_adv.h | 8
net/batman-adv/netlink.c| 17 +
2 files changed, 25
disable this feature and setting it
to something else is enabling this feature.
Signed-off-by: Sven Eckelmann
---
Cc: Marek Lindner
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 12
2 files changed, 18 insertions(+)
diff --git a/include/uapi/linux
: Sven Eckelmann
---
Cc: Marek Lindner
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index 2f0dbcc0..5c18d454 100644
--- a
commands allow to set/get
the configuration of this feature using the u32
BATADV_ATTR_THROUGHPUT_OVERRIDE attribute. The used unit is in 100 Kbit/s.
If the value is set to 0 then batman-adv will try to estimate the
throughput by itself.
Signed-off-by: Sven Eckelmann
---
Cc: Antonio Quartulli
BATADV_ATTR_NETWORK_CODING_ENABLED
attribute. Setting the u8 to zero will disable this feature and setting it
to something else is enabling this feature.
Signed-off-by: Sven Eckelmann
---
Cc: Martin Hundeboll
Cc: Marek Lindner
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv
attribute.
Signed-off-by: Sven Eckelmann
---
Cc: Marek Lindner
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index b37cb923
allow to set/get the
configuration of this feature using the u8 BATADV_ATTR_HOP_PENALTY
attribute.
Signed-off-by: Sven Eckelmann
---
Cc: Linus Lüssing
Cc: Marek Lindner
Cc: Antonio Quartulli
Cc: Simon Wunderlich
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c
multicast
group.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 10 +++
net/batman-adv/netlink.h | 6
net/batman-adv/sysfs.c | 63 +---
3 files changed, 63 insertions(+), 16 deletions(-)
diff --git a/net/batman-adv/netlink.c b/net/
On Sunday, 30 December 2018 11.41.03 CET syzbot wrote:
[...]
> HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=122a373f40
> kernel config: https://syzkaller.appspot.com/x/.config
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 69c0d85bceb3..e0007f242823 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -109,7 +109,10 @@ static int __init batadv_init(void)
> ba
On Friday, 30 November 2018 15:00:02 CET Wen Yang wrote:
> This patch fixes a possible null pointer dereference in
> batadv_gw_election, detected by the semantic patch
> deref_null.cocci, with the following warning:
>
> ./net/batman-adv/gateway_client.c:289:15-24: ERROR: next_gw is NULL but
> der
On Freitag, 23. November 2018 17:13:51 CET Sven Eckelmann wrote:
> + /** @BATADV_GW_MODE_CLIENT: announce itself as gatway server */
> + BATADV_GW_MODE_SERVER,
The kernel-doc should actually be for BATADV_GW_MODE_SERVER.
[...]
> + if (sel_class < 1
On Freitag, 23. November 2018 17:13:56 CET Sven Eckelmann wrote:
> + if (info->attrs[BATADV_ATTR_ORIG_INTERVAL]) {
> + u32 orig_interval;
> +
> + attr = info->attrs[BATADV_ATTR_ISOLATION_MASK];
This should have been BATADV_ATTR_ORIG_INTE
On Samstag, 24. November 2018 10:29:55 CET Jiri Pirko wrote:
[...]
> This looks great. Nice job!
>
> Do you have a userspace app to communicate with this? Would be nice to
> play with it or at least to see examples of usage.
I have only published the the mcast parsing portion [1] because the
app
feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 12
2 files changed, 18 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b
allow to set/get the
configuration of this feature using the u8 BATADV_ATTR_HOP_PENALTY
attribute.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 11 +++
2 files changed, 17 insertions(+)
diff --git a
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 140 +++
1 file changed, 97 insertions(+), 43 deletions(-)
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 2dc3304c..b20801a3 100644
--- a/net/batman-adv/netlink.c
+++ b/net/
disable this feature and setting it to
something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 11 +++
2 files changed, 17 insertions(+)
diff --git a/include/uapi/linux
BATADV_ATTR_NETWORK_CODING
attribute. Setting the u8 to zero will disable this feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv/netlink.c| 17 +
2
will disable this feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 8
net/batman-adv/netlink.c| 15 +++
2 files changed, 23 insertions(+)
diff --git a/include/uapi
multicast
group.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
net/batman-adv/netlink.c | 10 +++
net/batman-adv/netlink.h | 6
net/batman-adv/sysfs.c | 63 +---
3 files changed, 63 insertions(+), 16 deletions(-)
diff --git a/net/batman-adv/n
disable this feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv/netlink.c| 12
2 files changed, 19 insertions(+)
diff --git a/include/uapi/linux
attribute.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index b6d0eaf6..1c7d325f
feature using the BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE
attribute. Setting the u8 to zero will disable this feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 7 +++
net/batman-adv/netlink.c
rrent
implementation might collide with some other features which you might have
in your pipeline.
v2:
* rewrite everything in a more nl80211-like message/attribute format.
Kind regards,
Sven
[1] https://www.open-mesh.org/issues/300
[2] https://patchwork.open-mesh.org/cover/17610/
attributes:
* u8 BATADV_ATTR_GW_MODE (0 == off, 1 == client, 2 == server)
* u32 BATADV_ATTR_GW_BANDWIDTH_DOWN (in 100 kbit/s steps)
* u32 BATADV_ATTR_GW_BANDWIDTH_UP (in 100 kbit/s steps)
* u32 BATADV_ATTR_GW_SEL_CLASS
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h
BATADV_ATTR_ISOLATION_MARK
and BATADV_ATTR_ISOLATION_MASK.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 18 +++
net/batman-adv/netlink.c| 88 +
2 files changed, 106 insertions(+)
diff --git a/include/uapi/linux
ave been changed and what the current
values are.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 16 +++-
net/batman-adv/netlink.c| 159 +++-
2 files changed, 110 insertions(+), 65 deletions(-)
diff --git a/include/uapi/
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index 8a3f8920..f8661657 100644
--- a/include
cast group using the BATADV_CMD_SET_VLAN command
message type that settings might have been changed and what the current
values are.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 17 +++
net/batman-adv/netlink.c| 193 +++-
the u8 to zero will disable this feature and setting it
to something else is enabling this feature.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 8
net/batman-adv/netlink.c| 17 +
2 files changed, 25 insertions(+)
diff --git
commands allow to set/get
the configuration of this feature using the u32
BATADV_ATTR_THROUGHPUT_OVERRIDE attribute. The used unit is in 100 Kbit/s.
If the value is set to 0 then batman-adv will try to estimate the
throughput by itself.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi
changed and what the
current values are.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 16 ++-
net/batman-adv/netlink.c| 237 +---
2 files changed, 230 insertions(+), 23 deletions(-)
diff --git a/include/uapi/linux/batman_
BATADV_ATTR_ELP_INTERVAL
attribute.
Cc: Jiri Pirko
Signed-off-by: Sven Eckelmann
---
include/uapi/linux/batman_adv.h | 6 ++
net/batman-adv/netlink.c| 17 +
2 files changed, 23 insertions(+)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h
index f8661657
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the
BATMAN_ADV is enabled. A feature which is enabled by default for a module
should not be considered experimental.
Reported-by: Joe Perches
Signed-off-by: Sven Eckelmann
---
v2: no change
net/batman-adv/Kconfig | 2 +-
1
The "default n" is the default value for any bool or tristate Kconfig
setting. It is therefore not necessary to add it to a config entry.
Reported-by: Sergei Shtylyov
Signed-off-by: Sven Eckelmann
---
v2: changed "the an config entry" to "a config entry" in c
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the
BATMAN_ADV is enabled. A feature which is enabled by default for a module
should not be considered experimental.
Reported-by: Joe Perches
Signed-off-by: Sven Eckelmann
---
net/batman-adv/Kconfig | 2 +-
1 file changed, 1
The "default n" is the default value for any bool or tristate Kconfig
setting. It is therefore not necessary to add it to the an config entry.
Reported-by: Sergei Shtylyov
Signed-off-by: Sven Eckelmann
---
net/batman-adv/Kconfig | 5 -
1 file changed, 5 deletions(-)
diff -
On Freitag, 25. Mai 2018 14:13:40 CEST Sergei Shtylyov wrote:
> > [...]
> >>> --- a/net/batman-adv/Kconfig
> >>> +++ b/net/batman-adv/Kconfig
> >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
> >>> bool "batman-adv debugfs entries"
> >>> depends on BATMAN_ADV
> >>> depends on DEBUG_FS
> >>> -
On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote:
[...]
> > --- a/net/batman-adv/Kconfig
> > +++ b/net/batman-adv/Kconfig
> > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
> > bool "batman-adv debugfs entries"
> > depends on BATMAN_ADV
> > depends on DEBUG_FS
> > - default y
> > +
Hi Jiri,
seems like you still haven't answered Linus' question.
On Montag, 7. Mai 2018 08:34:16 CEST Sven Eckelmann wrote:
> On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote:
> > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote:
> > > >&g
On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote:
> On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote:
> > >> I strongly believe it is a huge mistake to use sysfs for things like
> > >> this. This should be done via generic netlink api.
> > >
> > >This doesn't change the proble
On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote:
[...]
> -static int batadv_interface_tx(struct sk_buff *skb,
> +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb,
> struct net_device *soft_iface)
> {
> struct ethhdr *ethhdr;
>
CHECK
On Freitag, 23. März 2018 23:53:50 CET Colin King wrote:
> From: Colin Ian King
>
> In the case where hard_iface is NULL, the error path may pass a null
> pointer to batadv_hardif_put causing a null pointer dereference error.
> Avoid this by only calling the function if hard_iface not null.
>
>
On Mittwoch, 24. Januar 2018 14:40:03 CET Sven Eckelmann wrote:
[...]
> I know your intentions and I understand the problem. But there is the chance
> that David Miller will reject this patch - like he did it some years ago
> with a similar (not the same) patch:
>
> "I
On Mittwoch, 24. Januar 2018 12:21:37 CET Matthias Schiffer wrote:
> NIC drivers generally try to ensure that the "network header" is aligned
> to a 4-byte boundary. This is not always possible: When Ethernet frames are
> encapsulated in other packets with 4-byte aligned headers, the inner
> Ethern
The headers used by packet.h should also be included by it directly. main.h
is currently dealing with it in batman-adv, but this will no longer work
when this header is moved to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/main.h | 2 --
net/batman-adv/packet.h | 2
ETH_P_BATMAN ethernet
packets.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS | 1 +
net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8
net/batman-adv/bat_iv_ogm.c | 2 +-
net/batman-adv/bat_
The uapi headers use the __u8/__u16/... version of the fixed width types
instead of u8/u16/... The use of the latter must be avoided before
packet.h is copied to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 214
ast packet header definition from flow_dissector.c
* moved the batman-adv packet.h/uapi headers around to provide the correct
definitions to flow_dissector.c
Kind regards,
Sven
Sven Eckelmann (5):
batman-adv: Let packet.h include its headers directly
batman-adv: Remove usage of
the same neighbor to different cores.
Signed-off-by: Sven Eckelmann
---
net/core/flow_dissector.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 15ce30063765..fa0a4879fb9d 100644
--- a
The BIT(x) macro is no longer available for uapi headers because it is
defined outside of it (linux/bitops.h). The use of it must therefore be
avoided and replaced by an appropriate other representation.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 23 +++
1
On Mittwoch, 20. Dezember 2017 14:39:46 CET David Miller wrote:
[...]
> Pulled, but there was a minor docbook annotation conflict I had to
> address.
>
> This pull added () to the function names in the docbook comments,
> but this overlapped with the fix of a variable name in the docbook
> info fo
On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote:
[]
> Thanks for making these changes. The flow dissection looks good to me.
>
> One possible issue is that this exposes kernel fixed width types u8/u16/..
> to userspace. For posix compatibility reasons, uapi headers use the
>
The headers used by packet.h should also be included by it directly. main.h
is currently dealing with it in batman-adv, but this will no longer work
when this header is moved to include/uapi/linux/.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/main.h | 2 --
net/batman-adv/packet.h | 2
ETH_P_BATMAN ethernet
packets.
Signed-off-by: Sven Eckelmann
---
MAINTAINERS | 1 +
net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8
net/batman-adv/bat_iv_ogm.c | 2 +-
net/batman-adv/bat_
The BIT(x) macro is no longer available for uapi headers because it is
defined outside of it (linux/bitops.h). The use of it must therefore be
avoided and replaced by an appropriate other representation.
Signed-off-by: Sven Eckelmann
---
net/batman-adv/packet.h | 23 +++
1
the same neighbor to different cores.
Signed-off-by: Sven Eckelmann
---
net/core/flow_dissector.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 15ce30063765..fa0a4879fb9d 100644
--- a
.org/patch/17162/
Sven Eckelmann (4):
batman-adv: Let packet.h include its headers directly
batman-adv: Remove usage of BIT(x) in packet.h
batman-adv: Convert packet.h to uapi header
flow_dissector: Parse batman-adv unicast headers
MAINTAINERS
On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote:
> > No, this is also bad because batman_adv.h is MIT license and packet.h is
> > GPL-2. So what other name would you suggest for packet.h?
> > batman_adv_packet.h?
>
> Sure, that sounds great. Thanks.
Really? Isn't include/uapi/l
On Freitag, 15. Dezember 2017 12:43:09 CET Simon Wunderlich wrote:
> compat-include/linux/build_bug.h | 34 ++
This backport change slipped in. Sorry, this was my fault when I initially
integrating it.
Kind regards,
Sven
signature.asc
Description: This is a di
On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote:
> On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote:
> [...]
> > >> > ---
> > >> > MAINTAINERS| 2 +-
> > >> > inc
On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote:
[...]
> >> > ---
> >> > MAINTAINERS| 2 +-
> >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++---
> >>
> >> This and the previous patch changes uapi. That might break userspace
On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote:
> Perhaps it can even be behind a static key depending on whether any
> devices are active, adjusted in batadv_hardif_(en|dis)able_interface.
I don't like that because we don't need batman-adv loaded to simply forward
(bridge) tra
On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote:
> On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann
> wrote:
> > This file contains the relevant information to let userspace communicate
> > with batman-adv over generic netlink. The relevant genl enums for the
1 - 100 of 155 matches
Mail list logo
