Re: [RFC] apparently bogus logics in unix_find_other() since 2002

2019-02-11 Thread Solar Designer
On Sun, Feb 10, 2019 at 04:24:22AM +, Al Viro wrote: > In "net/unix/af_unix.c: Set ATIME on socket inode" (back in > 2002) we'd grown something rather odd in unix_find_other(). In the > original patch it was > u=unix_find_socket_byname(sunname, len, type, hash); > -

Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions

2017-05-23 Thread Solar Designer
> >>> On Mon, May 22, 2017 at 2:08 PM, Solar Designer > >>> wrote: > >>> > On Mon, May 22, 2017 at 01:57:03PM +0200, Djalal Harouni wrote: > >>> >> *) When modules_autoload_mode is set to (2), automatic module loading > >>

Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions

2017-05-22 Thread Solar Designer
On Mon, May 22, 2017 at 03:49:15PM +0200, Djalal Harouni wrote: > On Mon, May 22, 2017 at 2:08 PM, Solar Designer wrote: > > On Mon, May 22, 2017 at 01:57:03PM +0200, Djalal Harouni wrote: > >> *) When modules_autoload_mode is set to (2), automatic module loading is > >

Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions

2017-05-22 Thread Solar Designer
Hi Djalal, Thank you for your work on this! On Mon, May 22, 2017 at 01:57:03PM +0200, Djalal Harouni wrote: > *) When modules_autoload_mode is set to (2), automatic module loading is > disabled for all. Once set, this value can not be changed. What purpose does this securelevel-like property ("O

Re: [PATCH net] ping: implement proper locking

2017-03-24 Thread Solar Designer
acquiring ping rwlock earlier. > > Thanks to Alexander and Andrey for letting us know of this problem. > > Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind") > Reported-by: Solar Designer > Reported-by: Andrey Konovalov We should credit the origi

Re: [oss-security] Linux kernel ping socket / AF_LLC connect() sin_family race

2017-03-24 Thread Solar Designer
On Fri, Mar 24, 2017 at 03:21:06PM -0700, Eric Dumazet wrote: > Looks easy enough to fix ? Oh. Probably. Thanks. Need to test, but I guess you already did? > diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c > index > 2af6244b83e27ae384e96cf071c10c5a89674804..ccfbce13a6333a65dab64e4847dd510dfafb1

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-20 Thread Solar Designer
On Sun, Aug 20, 2006 at 08:38:34PM +0200, Andi Kleen wrote: > On Sunday 20 August 2006 18:16, Solar Designer wrote: > > On Sun, Aug 20, 2006 at 10:34:43AM +0200, Andi Kleen wrote: > > > In general I don't think it makes sense to submit stuff for 2.4 > > > that isn

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-20 Thread Solar Designer
On Sun, Aug 20, 2006 at 10:34:43AM +0200, Andi Kleen wrote: > In general I don't think it makes sense to submit stuff for 2.4 > that isn't in 2.6. In general I agree, however right now I had the choice between submitting these changes for 2.4 first and not submitting them at all (at least for som

[PATCH] getsockopt() early argument sanity checking

2006-08-19 Thread Solar Designer
Willy, I propose the attached patch (extracted from 2.4.33-ow1) for inclusion into 2.4.34-pre. (2.6 kernels could benefit from the same change, too, but at the moment I am dealing with proper submission of generic changes like this that are a part of 2.4.33-ow1.) The patch makes getsockopt(2) sa