Re: [PATCH v3 1/2] net: add support for threaded NAPI polling

2020-08-30 Thread Sebastian Gottschall
Am 22.08.2020 um 03:49 schrieb Jakub Kicinski: On Fri, 21 Aug 2020 21:01:50 +0200 Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform well. Since NAPI poll is bound to the CPU it was scheduled from, we can easily end

Re: [PATCH] net: add support for threaded NAPI polling

2020-08-02 Thread Sebastian Gottschall
Am 31.07.2020 um 18:36 schrieb Eric Dumazet: On 7/30/20 10:21 AM, Sebastian Gottschall wrote: Am 30.07.2020 um 18:08 schrieb Eric Dumazet: On 7/30/20 7:30 AM, Sebastian Gottschall wrote: Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 30.07.2020 um 18:08 schrieb Eric Dumazet: On 7/30/20 7:30 AM, Sebastian Gottschall wrote: Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 30.07.2020 um 17:42 schrieb David Laight: From: Sebastian Gottschall Sent: 30 July 2020 15:30 ... Quite frankly, I do believe this STATE_THREADED status should be a generic NAPI attribute that can be changed dynamically, at admin request, instead of having to change/recompile a driver

Re: [PATCH] net: add support for threaded NAPI polling

2020-07-30 Thread Sebastian Gottschall
Am 29.07.2020 um 19:44 schrieb Eric Dumazet: On 7/29/20 9:50 AM, Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform well. Since NAPI poll is bound to the CPU it was scheduled from, we can easily end up with a few v

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
i agree. i just can say that i tested this patch recently due this discussion here. and it can be changed by sysfs. but it doesnt work for wifi drivers which are mainly using dummy netdev devices. for this i made a small patch to get them working using napi_set_threaded manually hardcoded in th

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
Am 25.07.2020 um 14:25 schrieb Hillf Danton: On Sat, 25 Jul 2020 12:38:00 +0200 Sebastian Gottschall wrote: you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html <https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html>

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html years ago someone already wanted to bring this feature upstream, but it was denied. i already tested this patch the last

Re: [RFC 7/7] ath10k: Handle rx thread suspend and resume

2020-07-23 Thread Sebastian Gottschall
your patch seem to only affect the WCN3990 chipset. all other ath10k supported chipset are not supported here. so you see a chance to implement this more generic? Sebastian Am 21.07.2020 um 19:14 schrieb Rakesh Pillai: During the system suspend or resume, the rx thread also needs to be suspen

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Sebastian Gottschall
** **its clearly visible when i activated the other stream for getting duplex load ... The highest rate also stays alot under the possible 930MBits that i have seen earlier with 4.14. ** ** ** **the parallel stream reached around 450Mbits , which almost sums up to 660Mbits. This is what i me

Re: hung task in mac80211

2017-09-06 Thread Sebastian Gottschall
_agg_stop_reason reason); void ieee80211_process_delba(struct ieee80211_sub_if_data *sdata, johannes I confirm that this patch fixes the hang too. I'm curious to see if there are noticeable performance differences between the two solutions. Cheers, -- Mit freundlichen GrĂ¼ssen /

Re: hung task in mac80211

2017-09-06 Thread Sebastian Gottschall
ly ath10k. johannes that explans the behaviour i have found with latest mac80211 and ath10k. -- Mit freundlichen GrĂ¼ssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Ge

Re: [PATCH 2/3] ath10k: use size_t for len variables

2017-02-02 Thread Sebastian Gottschall
size_t len; u8 spectral_count; mutex_lock(&ar->conf_mutex); @@ -422,7 +422,8 @@ static ssize_t read_file_spectral_bins(struct file *file, { struct ath10k *ar = file->private_data; char buf[32]; - unsigned int len, bins, fft_size, bin_scale; + unsigne