On 2019-08-23 7:08 a.m., Christophe JAILLET wrote:
Hi,
in this patch, there is one piece that looked better before. (see below)
Removing the 'if (skb)' is fine, but concatening everything in one
statement just to save 2 variables and a few LOC is of no use, IMHO,
and the code is less readab
bitfield directly using
ethtool --reset DEVNAME flags %x
Signed-off-by: Scott Branden
---
ethtool.8.in | 67 ++-
ethtool.c| 113 +++
2 files changed, 179 insertions(+), 1 deletion(-)
diff --git a/ethtool.8
This covers kernel changes up to:
commit 40e44a1e669d078946f46853808a60d29e6f0885
Author: Scott Branden
Date: Thu Nov 30 11:35:59 2017 -0800
net: ethtool: add support for reset of AP inside NIC interface.
Add ETH_RESET_AP to reset the application processor(s) inside the NIC
This reverts commit 5dd7bfbc5079cb375876e4e76191263fc28ae1a6.
As Stephen Hemminger mentioned
there is an ABI compatibility issue with this patch:
https://patchwork.ozlabs.org/patch/806049/#1757846
Signed-off-by: Scott Branden
---
ethtool-copy.h | 2 --
ethtool.8.in | 1 -
ethtool.c | 8
:
- update commit message to indicate support for ap
- add symbolic support for parsing of -shared added to each component specified
- cleaned up reset print information to indicate which components have and
have not been reset
Scott Branden (3):
Revert "ethtool: Add DMA Coalescing su
Hi Michal,
Thanks - one question below hopefully someone can help with.
On 17-12-05 02:29 PM, Michal Kubecek wrote:
On Tue, Dec 05, 2017 at 02:06:09PM -0800, Scott Branden wrote:
On 17-12-05 01:30 PM, Michal Kubecek wrote:
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote:
Add
Hi Andrew,
On 17-12-05 02:26 PM, Andrew Lunn wrote:
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote:
Add ETHTOOL_RESET support via --reset command.
ie. ethtool --reset DEVNAME
flagnames currently match the ETH_RESET_xxx names:
mgmt,irq,dma,filter,offload,mac,phy,ram
Hi Michal,
thanks for review - see comments
On 17-12-05 01:30 PM, Michal Kubecek wrote:
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote:
Add ETHTOOL_RESET support via --reset command.
ie. ethtool --reset DEVNAME
flagnames currently match the ETH_RESET_xxx names:
mgmt,irq,dma
Patch series to add ETHTOOL_RESET support to ethtool userspace tool.
Include:
- revert custom change to ethtool-copy.h that is not in linux kernel
- sync ethtool-copy.h with ethtool.h in linux kernel net-next
- add ETHTOOL_RESET support with up to date ethtool.h reset defines
Scott Branden (3
: Scott Branden
---
ethtool.8.in | 58 +-
ethtool.c| 75
2 files changed, 132 insertions(+), 1 deletion(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 90ead41..e77ecd3 100644
--- a
This reverts commit 5dd7bfbc5079cb375876e4e76191263fc28ae1a6.
As Stephen Hemminger mentioned
there is an ABI compatibility issue with this patch:
https://patchwork.ozlabs.org/patch/806049/#1757846
Signed-off-by: Scott Branden
---
ethtool-copy.h | 2 --
ethtool.8.in | 1 -
ethtool.c | 8
This covers kernel changes up to:
commit 40e44a1e669d078946f46853808a60d29e6f0885
Author: Scott Branden
Date: Thu Nov 30 11:35:59 2017 -0800
net: ethtool: add support for reset of AP inside NIC interface.
Add ETH_RESET_AP to reset the application processor(s) inside the NIC
://patchwork.ozlabs.org/patch/806049/#1757846
Thanks,
Paul
-Original Message-
From: Scott Branden [mailto:scott.bran...@broadcom.com]
Sent: Monday, December 4, 2017 12:07 PM
To: linvi...@tuxdriver.com; Greenwalt, Paul
Cc: netdev
Subject: ethtool-copy.h out of sync with linux header file?
Hi
On 17-12-05 12:21 AM, Gal Pressman wrote:
On 04-Dec-17 22:16, Scott Branden wrote:
Hi Gal,
I do not understand you're comment - questions inline
On 17-12-03 12:07 AM, Gal Pressman wrote:
On 30-Nov-17 21:24, Scott Branden wrote:
Add ETHTOOL_RESET support via --reset command.
ie. et
Hi Gal,
I do not understand you're comment - questions inline
On 17-12-03 12:07 AM, Gal Pressman wrote:
On 30-Nov-17 21:24, Scott Branden wrote:
Add ETHTOOL_RESET support via --reset command.
ie. ethtool --reset DEVNAME
flagnames currently match the ETH_RESET_xxx names:
mgmt,ir
Hi Paul/John,
I see a commit "ethtool: Add DMA Coalescing support" was added to
ethtool-copy.h yet I cannot find the change in the ethtool.h in the
linux kernel.
As such, I am unable to commit a change to ethtool-copy.h to sync it
with net-next. If I sync then ethtool will fail to compile.
Add support to reset appplication processors inside SmartNICs by
defining new ETH_RESET_AP bit.
And use new ETH_RESET_AP bit in bnxt ethernet driver.
Scott Branden (2):
net: ethtool: add support for reset of AP inside NIC interface.
bnxt_en: Add ETH_RESET_AP support
drivers/net/ethernet
inside the NIC processor - be it a simple algorithm without
an OS to as complex as hosting multiple VMs.
Signed-off-by: Scott Branden
Reviewed-by: Andrew Lunn
---
include/uapi/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux
Add ETH_RESET_AP support handling to reset the internal
Application Processor(s) of the SmartNIC card.
Signed-off-by: Scott Branden
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 11 +++
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 1 +
2 files changed, 12 insertions
: Scott Branden
---
ethtool.8.in | 55 -
ethtool.c| 73
2 files changed, 127 insertions(+), 1 deletion(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 6ad3065..925cfe3 100644
--- a
+netdev@vger.kernel.org
On 17-10-18 09:01 AM, Scott Branden wrote:
Add ETH_RESET_AP to reset the application processor inside the NIC
interface.
Signed-off-by: Scott Branden
---
include/uapi/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/ethtool.h b
+netdev@vger.kernel.org
On 17-10-18 02:30 PM, Andy Gospodarek wrote:
On Wed, Oct 18, 2017 at 12:31:28PM -0700, Scott Branden wrote:
Hi Andrew,
On 17-10-18 12:16 PM, Andrew Lunn wrote:
Yes, there is also a management processor.
O.K.
Maybe it would be nice to add some more text to the
Hi Rob,
On 17-06-29 03:40 PM, Rob Herring wrote:
On Tue, Jun 27, 2017 at 12:10 AM, Scott Branden
wrote:
Hi Rob/Florian,
Thanks for input but still don't see any need for SoC specific
compatible stings. IP revision specific yes.
On 17-06-22 06:04 PM, Florian Fainelli wrote:
On 06/22
Hi Rob/Florian,
Thanks for input but still don't see any need for SoC specific
compatible stings. IP revision specific yes.
On 17-06-22 06:04 PM, Florian Fainelli wrote:
On 06/22/2017 05:42 PM, Scott Branden wrote:
On 17-06-21 08:19 PM, Rob Herring wrote:
On Tue, Jun 20, 2017 at 3:
On 17-06-21 08:19 PM, Rob Herring wrote:
On Tue, Jun 20, 2017 at 3:48 PM, Scott Branden
wrote:
Hi Rob,
On 17-06-18 07:04 AM, Rob Herring wrote:
On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote:
Add device tree binding documentation for the Broadcom DTE
PTP clock driver
Hi Rob,
On 17-06-18 07:04 AM, Rob Herring wrote:
On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote:
Add device tree binding documentation for the Broadcom DTE
PTP clock driver.
Signed-off-by: Arun Parameswaran
---
Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt | 13
On 17-04-24 04:54 PM, Eric Anholt wrote:
Scott Branden writes:
Minor comment in line
On 17-04-24 02:50 PM, Eric Anholt wrote:
Cygnus is a small family of SoCs, of which we currently have
devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the
same as 58xx, just requir
Minor comment in line
On 17-04-24 02:50 PM, Eric Anholt wrote:
Cygnus is a small family of SoCs, of which we currently have
devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the
same as 58xx, just requiring a tiny bit of setup that was previously
missing.
Signed-off-by: Eric Anho
One change
On 16-11-09 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote:
Add documentation for mdio mux available in Broadcom NSP SoC
Signed-off-by: Yendapally Reddy Dhananjaya Reddy
---
.../devicetree/bindings/net/brcm,mdio-mux-nsp.txt | 57 ++
1 file changed, 57 insert
On 16-11-01 01:59 PM, Jon Mason wrote:
On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote:
+- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the
+ TX/RX lanes to function properly.
Is 'requires' the right word here? The PHY performs the actual swap of
the Tx
One change in this patch
On 16-11-01 01:04 PM, Jon Mason wrote:
Add support for the variant of amac hardware present in the Broadcom
Northstar2 based SoCs. Northstar2 requires an additional register to be
configured with the port speed/duplexity (NICPM). This can be added to
the link callback
Hi Jon,
On 16-11-01 10:51 AM, Jon Mason wrote:
Changes in v3:
* Clean-up the bgmac DT binding doc (per Rob Herring)
* Document the lane swap binding and make it generic (Per Andrew Lunn)
Where is the documentation of the lane swap binding?
Changes in v2:
* Remove the PHY power-on (per Andre
Hi Jon,
In Subject line, you mean add amac entries.
On 16-07-08 08:56 AM, Jon Mason wrote:
Add device tree entries for the ethernet devices present on the
Broadcom Northstar Plus SoCs
Signed-off-by: Jon Mason
---
arch/arm/boot/dts/bcm-nsp.dtsi | 18 ++
arch/arm/boot/dts/
33 matches
Mail list logo
