Hi Gal,

I do not understand you're comment - questions inline


On 17-12-03 12:07 AM, Gal Pressman wrote:
On 30-Nov-17 21:24, Scott Branden wrote:
Add ETHTOOL_RESET support via --reset command.

ie.  ethtool --reset DEVNAME <flagname(s)>

flagnames currently match the ETH_RESET_xxx names:
mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all

Alternatively, you can specific component bitfield directly using
ethtool --reset DEVNAME flags %x

Signed-off-by: Scott Branden <scott.bran...@broadcom.com>
---
  ethtool.8.in | 55 ++++++++++++++++++++++++++++++++++++++++++++-
  ethtool.c    | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 127 insertions(+), 1 deletion(-)

diff --git a/ethtool.8.in b/ethtool.8.in
index 6ad3065..925cfe3 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -355,6 +355,20 @@ ethtool \- query or control network driver and hardware 
settings
  .B ethtool \-\-get\-phy\-tunable
  .I devname
  .RB [ downshift ]
+.HP
+.B ethtool \-\-reset
+.I devname
+.BN flags
+.B [mgmt]
+.B [irq]
+.B [dma]
+.B [filter]
+.B [offload]
+.B [mac]
+.B [phy]
+.B [ram]
+.B [dedicated]
+.B [all]
  .
Nit:
Usually, the brackets formatting is different than the keyword inside them.
Could you please explain what the formatting should be then?  Any of the options listed are possible components that can be selected.  At least one must be chosen.  Should the brackets be removed then?

Gal

Reply via email to