Correct two minor kerneldoc errors:
1) missing reference to @mode in struct phy_ops
2) obsolete reference to @init_data in struct_phy_attrs,
removed in dbc98635e0d42f0e62ea92813df1e0e4c90f8375
Signed-off-by: Robert P. J. Day
---
AFAICT, none of this is actually included in the
1) note that gianfar_phy.c was removed years ago
2) fix obvious copy and paste error in regular doc
3) change regular doc into kerneldoc for phy_modes()
Signed-off-by: Robert P. J. Day
---
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3ea87f774a76..e040f3ab4c7a 100644
--- a
On Wed, 26 Dec 2018, Andrew Lunn wrote:
> On Wed, Dec 26, 2018 at 05:41:29AM -0600, Robert P. J. Day wrote:
> >
> > 1) gianfar_phy.c should clearly refer to gianfar.c
> > 2) fix obvious copy and paste error in regular doc
> > 3) change regular doc into kerneldoc for
1) gianfar_phy.c should clearly refer to gianfar.c
2) fix obvious copy and paste error in regular doc
3) change regular doc into kerneldoc for phy_modes()
Signed-off-by: Robert P. J. Day
---
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3ea87f774a76..1ca94a51a93e 100644
Signed-off-by: Robert P. J. Day
---
diff --git a/include/linux/mod_devicetable.h
b/include/linux/mod_devicetable.h
index 01797cb4587e..a0dcc9b6a723 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -565,7 +565,7 @@ struct platform_device_id
To be consistent with subsequent error message specifically mentioning
zero RX queues, add a reference to TX queues to the error message.
Signed-off-by: Robert P. J. Day
---
diff --git a/net/core/dev.c b/net/core/dev.c
index 325fc5088370..a5d0c2244fb5 100644
--- a/net/core/dev.c
+++ b/net/core
;s doing in those two places.
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
ients
but, as a contractor, i have little influence. but i will continue to
make them.
rday
--
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter:
On Sun, 26 Aug 2018, Stephen Hemminger wrote:
> On Sun, 26 Aug 2018 11:14:33 -0400 (EDT)
> "Robert P. J. Day" wrote:
>
> > apologies for the constant pleas for assistance, but i think i'm
> > zeroing in on the problem that started all this. recap: custom
&g
On Sun, 26 Aug 2018, Stephen Hemminger wrote:
> On Sun, 26 Aug 2018 15:20:24 -0400 (EDT)
> "Robert P. J. Day" wrote:
>
> > On Sun, 26 Aug 2018, Andrew Lunn wrote:
> >
> > > > i ask since, in my testing, when the interface should have been
> >
On Sun, 26 Aug 2018, Andrew Lunn wrote:
> On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote:
> > On Sun, 26 Aug 2018, Andrew Lunn wrote:
> >
> > > > i ask since, in my testing, when the interface should have been
> > > > up, the attrib
On Sun, 26 Aug 2018, Andrew Lunn wrote:
> On Sun, Aug 26, 2018 at 11:14:33AM -0400, Robert P. J. Day wrote:
> >
> > apologies for the constant pleas for assistance, but i think i'm
> > zeroing in on the problem that started all this. recap: custom
> > FPGA-bas
t; virtual device like tun/tap.
i wish, but i'm on contract, and proprietary, and NDA and all that.
so i am reduced to crawling through the code, trying to figure out
what is misconfigured that is causing all this grief.
rday
--
================
o one to learn that this aspect was
misprogrammed.
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
tever
that means)?
i ask since, in my testing, when the interface should have been up,
the attribute file "operstate" for that interface showed "unknown",
and i wondered how worried i should be about that.
rday
--
===============
ven look at
them in that location and instead invokes the respective functions. do
i have that about right, before i crawl further down this rabbit hole?
it's all starting to make sense.
rday
--
============
Robert P. J. Day
Correct the references for both flags and priv flags since they both
refer to the incorrect file which contains their explanations.
Signed-off-by: Robert P. J. Day
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index ca5ab98053c8..f01f3473bb91 100644
--- a/include/linux
On Wed, 22 Aug 2018, Stephen Hemminger wrote:
> On Wed, 22 Aug 2018 18:32:36 -0400 (EDT)
> "Robert P. J. Day" wrote:
>
> > almost certainly another dumb question, but i was poking around the
> > sysfs, particularly /sys/class/net//*, to familiarize myself
> &
with some of those flags being
"volatile" as dewscribed in include/uapi/linux/if.h? or am i just
totally misreading this?
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
On Sat, 18 Aug 2018, Willy Tarreau wrote:
> On Sat, Aug 18, 2018 at 09:10:25PM +0200, Andrew Lunn wrote:
> > On Sat, Aug 18, 2018 at 01:39:50PM -0400, Robert P. J. Day wrote:
> > >
> > > (i'm sure this has been explained many times before, so a link
> > &g
erfaces into two new namespaces, and
setting up forwarding.
anyway, a recipe for this would be just ducky. thank you kindly.
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
well if the C preprocessor ever gets
ahold of it.
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
On Sun, 5 Aug 2018, Andrew Lunn wrote:
> On Sat, Aug 04, 2018 at 07:06:58AM -0400, Robert P. J. Day wrote:
> >
> > i'll try to keep this (relatively) short as there may be a
> > simple answer to this, or it could just be a stupid question --
> > sort of related
r
so i am reduced to concluding that the drivers in question are simply
not calling correctly the very routines you mention.
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
rday
--
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn:
mation.
> >
> > i'm about to ask the original authors why they did the above, but
>
> I guess that the reason is that they had no clue what they are doing
> :)
given that i've been immersed in networking code for only a few
days, i was not about to draw any conclu
ebugging
feature that would normally be removed at production? or what?
rday
--
================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter:
On Wed, 1 Aug 2018, Florian Fainelli wrote:
> On 08/01/2018 05:58 AM, rpj...@crashcourse.ca wrote:
> >
> > (warning that i have a few questions that are probably trivial
> > until i get up to speed with networking code.)
> >
> > a colleague asked for advice about the following -- apparently a
Move the "device present" mask bits up immediately after the MMD
device definitions, since it makes no sense to have them further down
in the file.
This is purely a cosmetic change for readability.
Signed-off-by: Robert P. J. Day
---
since the *only* thing that actually us
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i realized that. but all you can say is that only amb_init() calls
> > setup_dev() *currently*. when you're not looking, someone else might
> > (for whatever reason)
On Mon, 26 Nov 2007, Joonwoo Park wrote:
> 2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> > i'm not sure the above is a safe thing to do, as you're zeroing that
> > area, then making a function call and assuming, upon entry to the
> > function call, tha
oppy about it. unless you're
prepared to guarantee that there will never be another call to
setup_dev() from elsewhere.
rday
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
memset(n, 0, sz);
> + n = kzalloc(sz, GFP_KERNEL);
> + else {
> + if (hashdist)
i believe the more common standard for the above is:
else if (hashdist) {
to reduce the level of overall indentation, no?
rday
=
e.
rday
====
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
-
To unsubscribe from t
Given that it's well established that the "ether=" kernel parameter is
deprecated in favour of the newer "netdev=", might as well make it
official.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Documentation/feature-removal-schedule.txt |
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
i'm just going to assume that loop is rounding up to the next power
of two, right?
diff --git a/drivers/net/pcmcia/pcnet_cs.c b/drivers/net/pcmcia/pcnet_cs.c
index db6a97d..07eae16 100644
--- a/drivers/net/pcmcia/pcnet
in that call to __setup()
really violates the spirit of defining kernel parms. :-)
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
-
To u
n? thanks.
--
========
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
Officially deprecate the boot-time "ether=" option in favour of
"netdev=", update the documentation accordingly in various places, and
schedule removal for September of 2008.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
i realize that some people
ULTPPP ==
net/wanrouter/wanmain.c:568:#ifdef CONFIG_WANPIPE_MULTPPP
net/wanrouter/wanmain.c:589:#ifdef CONFIG_WANPIPE_MULTPPP
net/wanrouter/wanmain.c:662:#ifdef CONFIG_WANPIPE_MULTPPP
rday
--
Robert P. J. Day
Linux Consulti
On Sat, 1 Sep 2007, Sam Ravnborg wrote:
> On Sat, Sep 01, 2007 at 06:44:06AM -0400, Robert P. J. Day wrote:
> >
> > > > while (1) {
> > > > printf("%*s%s ", indent - 1, "", menu->prompt->text);
> > > >
t; + }
> > if (sym->name)
> > printf("(%s) ", sym->name);
> > type = sym_get_type(sym);
for now, simon, why not just reduce this to support
thank you for making my point for me.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
=
a reason for this -- any feature should have exactly *one*
value for any attribute. that is, in terms of maturity, a feature
could be EXPERIMENTAL *or* DEPRECATED *or* OBSOLETE. it ***can't***
be more than one, as in both DEPRECATED *and* OBSOLETE. to allow that
flexibility is to descend in
On Fri, 31 Aug 2007, Jeff Garzik wrote:
> Robert P. J. Day wrote:
> > i'm sure i'm going to get shouted down here, but i really disagree
> > with "BROKEN" being considered a "maturity level". IMHO, things
> > like EXPERIMENTAL, DEPRECATED and
On Fri, 31 Aug 2007, Randy Dunlap wrote:
> On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote:
>
> > On 19/07/07 17:19, Robert P. J. Day wrote:
> > > On Thu, 19 Jul 2007, Randy Dunlap wrote:
> > >> I think that Stefan means a patch to the kconfig source code,
On Tue, 28 Aug 2007, David Miller wrote:
> From: "Robert P. J. Day" <[EMAIL PROTECTED]>
> Date: Tue, 28 Aug 2007 05:54:57 -0400 (EDT)
>
> >
> > given drivers/net/Kconfig:
> >
> > ...
> > config SHAPER
> > tristate "Traffi
given drivers/net/Kconfig:
...
config SHAPER
tristate "Traffic Shaper (OBSOLETE)"
...
is that traffic shaper really obsolete to the point where it can be
tossed. i have a patch ...
rday
--
========
Robert
superfluous casts when
calling one of those memory allocation routines.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
==
On Fri, 20 Jul 2007, Gabriel C wrote:
> Robert P. J. Day wrote:
> > this has *nothing* to do with the aforementioned maturity levels.
> > i understand entirely the inconsistency above. what i'm
> > suggesting is that it might very well be more appropriate to *drop
On Fri, 20 Jul 2007, Gabriel C wrote:
> Robert P. J. Day wrote:
> > On Fri, 20 Jul 2007, Gabriel C wrote:
> >
> >> Hi,
> >>
> >> IP_VS has :
> >>
> >> ..
> >>
> >> tristate "IP virtual server su
...
config TCP_CONG_HYBLA
tristate "TCP-Hybla congestion control algorithm"
depends on EXPERIMENTAL
...
config TCP_CONG_VEGAS
tristate "TCP Vegas"
depends on EXPERIMENTAL
...
... etc etc ...
rday
--
===
depends on INET && EXPERIMENTAL
...
it might be a better investment in time to look through the Kconfig
files, and decide which entries currently marked as "EXPERIMENTAL"
really *shouldn't* be, and remo
On Thu, 19 Jul 2007, Simon Arlott wrote:
> On 19/07/07 17:19, Robert P. J. Day wrote:
> > On Thu, 19 Jul 2007, Randy Dunlap wrote:
> >> I think that Stefan means a patch to the kconfig source code,
> >> not the the Kconfig files. Good luck. I'd still like to s
On Thu, 19 Jul 2007, Randy Dunlap wrote:
> On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Thu, 19 Jul 2007, Stefan Richter wrote:
> >
> > > Robert P. J. Day wrote:
> > > > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> > > >
On Thu, 19 Jul 2007, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> >
> > ...
> >> I would consider it more ugly to special case this and that in the
> >> kconfig code when plain dependencies already of
at this point, i've really given up caring about it. if
someone wants to do this, have at it. i have better things to do than
to keep suggesting it and getting nowhere with it.
rday
--
================
Robert P. J. Day Linux Consulting, Tr
me
to make a choice.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
On Wed, 18 Jul 2007, Adrian Bunk wrote:
> On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote:
> > On Wed, 18 Jul 2007, Jeff Garzik wrote:
> >
> > > Randy Dunlap wrote:
> > > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
> &
On Wed, 18 Jul 2007, Jeff Garzik wrote:
> Randy Dunlap wrote:
> > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
> > > there's no point adding all that redundant content when it can all be
> > > done automatically.
> >
> > I like i
On Wed, 18 Jul 2007, Randy Dunlap wrote:
> On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Wed, 18 Jul 2007, Gabriel C wrote:
> >
> > > Everything 'depends on' EXPERIMENTAL should be marked as such,
> > > visible in the menu
ll be
done automatically.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsub
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/cxgb3/cxgb3_offload.c
b/drivers/net/cxgb3/cxgb3_offload.c
index ebcf35e..999bc41 100644
--- a/drivers/net/cxgb3/cxgb3_offload.c
+++ b/drivers/net/cxgb3/cxgb3_offload.c
@@ -1105,7 +1105,7
/kallsyms:
...
c038845d T inet_bind
c0388615 T inet_stream_connect
c0388814 T inet_accept
c03888b5 T inet_sock_destruct
...
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, C
Since there is no Kconfig variable RXRPC anywhere in the tree, and the
variable AF_RXRPC performs exactly the same function, remove the
reference to CONFIG_RXRPC from net/Makefile.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/net/Makefile b/net/Makefile
index 3
ient) form of a
routine has been defined, it should be used. if you have no plans to
use it, it shouldn't have been defined in the first place.
in short, make a consistent decision and go with it.
rday
--
Remove the useless comment referring to the obsolete MODULE_PARM
macro.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/fealnx.c b/drivers/net/fealnx.c
index abe9b08..2351092 100644
--- a/drivers/net/fealnx.c
+++ b/drivers/net/fealnx.c
@@ -111,7
FIG_USE_W977_PNP */
drivers/net/irda/w83977af_ir.c:323:#ifdef CONFIG_USE_W977_PNP
drivers/net/irda/w83977af_ir.c:349:#endif /* CONFIG_USE_W977_PNP */
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Peda
OCK_PACKET) {
net/socket.c:1098: printk(KERN_INFO "%s uses obsolete
(PF_INET,SOCK_PACKET)\n",
== WANPIPE_MULTPPP ==
net/wanrouter/wanmain.c:569:#ifdef CONFIG_WANPIPE_MULTPPP
net/wanrouter/wanmain.c:590:#ifdef CONFIG_WANPIPE_MULTPPP
net/wanrouter/wa
On Thu, 3 May 2007, Arnd Bergmann wrote:
> On Thursday 03 May 2007, Robert P. J. Day wrote:
> > > Suggest: configfiles=$(find . -name 'Kconfig*' -or -name '*defconfig*')
> > >
> > > Some CONFIG_ options exist that are not declared anywhere in t
o i'm not going to be touching those
files. also, adding that extra check wouldn't add anything useful to
the output.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedan
go wild.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: send the line "un
On Sun, 15 Apr 2007, Ian McDonald wrote:
> On 4/15/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > in fact, according to this:
> >
> > http://lkml.org/lkml/2006/1/13/139
> >
> > that notice was put in the feature removal file well over a year ago,
>
the admins about
this. sorry.)
On Sun, 15 Apr 2007, Ian McDonald wrote:
> On 4/15/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> >
> > Remove the obsolete code for the traffic shaper.
> >
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> >
&g
On Sun, 15 Apr 2007, Rene Herman wrote:
> On 04/15/2007 01:30 AM, Robert P. J. Day wrote:
>
> > Remove the obsolete code for the traffic shaper.
>
> Why are all your messages getting a "{Spam?}" subject prefix?
i have no idea, that's a recent development. i
Remove the obsolete code for the traffic shaper.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
nothing seems to be using this, it's labelled "OBSOLETE" in the
Kconfig file, and there is not a single test for CONFIG_SHAPER
anywhere in the tree. time to
Remove the apparently redundant include of .
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
compile-tested on x86, in preparation for the day when the legacy PM
code goes away.
diff --git a/drivers/net/3c509.c b/drivers/net/3c509.c
index f791bf0..a8ea346 100644
--- a/drive
Remove the worthless net/sched/Makefile entry for the non-existent
source file sch_hpfq.c.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/net/sched/Makefile b/net/sched/Makefile
index ff2d6e5..020767a 100644
--- a/net/sched/Makefile
+++ b/net/sched/Makefile
@@ -17,7
Rename some internal ipw2100 debugging macros to not look like
user-settable kernel config settings.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
make some renames based on short conversation with [EMAIL PROTECTED]:
CONFIG_IPW2100_RX_DEBUG -> IPW2100
On Tue, 10 Oct 2006, Auke Kok wrote:
> Robert P. J. Day wrote:
... snip ...
> > if someone wants to tell me what, in the context of ixgb_main.c,
> > i would use as that "dev" argument [for dev_dbg], i'm all for
> > that.
>
> (CC netdev since it'
80 matches
Mail list logo
