On Tue, 10 Oct 2006, Auke Kok wrote: > Robert P. J. Day wrote:
... snip ... > > if someone wants to tell me what, in the context of ixgb_main.c, > > i would use as that "dev" argument [for dev_dbg], i'm all for > > that. > > (CC netdev since it's a network driver topic). > > all our macro's (e100, e1000, ixgb) use adapter->netdev->name > inserted through the DPRINTK macro. > > if you'd really want to clean it all up, you'd have to replace all > DPRINTK() calls with dev_dbg(adapter->netdev->name, ....) which > would just make it more lengthy and uncomfortable to read. > > which puts this in a bigger perspective. I suppose the nicest way to do > program these is to do something like this: > > #define ixgb_dbg(args...) dev_dbg(adapter->netdev->name, args) > #define ixgb_err(args...) dev_err(adapter->netdev->name, args) > #define ixgb_info(args...) dev_info(adapter->netdev->name, args) > > and use those consistently throughout the driver, ditto for e100/e1000. > > I'll look into it and see what I can do. um, yeah. i'm rapidly getting out of my comfort zone here. this seemed like such a simple submission six hours ago. :-) live and learn. rday - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
