Re: skb_cow() vs skb_cow_head() - what exactly is "header"?

2019-01-06 Thread Radu Rendec
On Tue, 2019-01-01 at 09:53 -0800, David Miller wrote: > From: Radu Rendec Date: Sat, 29 Dec 2018 13:26:34 -0500 > > > I'm working on some application-specific NIC driver. On the TX path, it > > must remove a custom tag that sits between the Ethernet type field and

skb_cow() vs skb_cow_head() - what exactly is "header"?

2018-12-29 Thread Radu Rendec
, additional data is stored in separate pages (in frags[]) or skbs (in frag_list). Last but not least, is there any *recent* documentation that explains the subtleties of skbs? Most of the documentation I could find is very old and/or covers only the basic concepts, such as head/data/tail/end. Thank you in advance, Radu Rendec

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-10-28 Thread Radu Rendec
On Mon, 2018-10-01 at 14:52 +0200, Sabrina Dubroca wrote: > 2018-09-19, 12:44:41 -0400, Radu Rendec wrote: > > Hello, > > Gah, sorry, this fell into the "week-end" crack and I forgot to answer :( No worries. I was on vacation in the meantime, hence my late reply. >

Re: [PATCH 1/1] macsec: reflect the master interface state

2018-09-19 Thread Radu Rendec
Hello, On Wed, Sep 19, 2018 at 11:24 AM Sabrina Dubroca wrote: > 2018-09-18, 20:16:12 -0400, Radu Rendec wrote: > > This patch makes macsec interfaces reflect the state of the underlying > > interface: if the master interface changes state to up/down, the macsec > > interf

[PATCH 0/1] macsec: reflect the master interface state

2018-09-18 Thread Radu Rendec
pretty much architecture independent. Any comments or suggestions are welcome. Thanks! Radu Rendec (1): macsec: reflect the master interface state drivers/net/macsec.c | 57 +++- 1 file changed, 46 insertions(+), 11 deletions(-) -- 2.17.1

[PATCH 1/1] macsec: reflect the master interface state

2018-09-18 Thread Radu Rendec
vlan_device_event() in net/8021q/vlan.c. In fact, the code was copied and adapted from there. Signed-off-by: Radu Rendec --- drivers/net/macsec.c | 57 +++- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net

Re: virtio_net: ethtool supported link modes

2017-09-04 Thread Radu Rendec
On Fri, 2017-09-01 at 20:45 +0300, Michael S. Tsirkin wrote: > On Fri, Sep 01, 2017 at 05:19:53PM +0100, Radu Rendec wrote: > > On Fri, 2017-09-01 at 18:43 +0300, Michael S. Tsirkin wrote: > > > On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > > &g

Re: virtio_net: ethtool supported link modes

2017-09-01 Thread Radu Rendec
On Fri, 2017-09-01 at 18:43 +0300, Michael S. Tsirkin wrote: > On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > > Looking at the code in virtnet_set_link_ksettings, it seems the speed > > and duplex can be set to any valid value. The driver will "remember"

Re: virtio_net: ethtool supported link modes

2017-09-01 Thread Radu Rendec
On Fri, 2017-09-01 at 11:36 +0800, Jason Wang wrote: > > On 2017年09月01日 01:04, Radu Rendec wrote: > > Hello, > > > > Looking at the code in virtnet_set_link_ksettings, it seems the speed > > and duplex can be set to any valid value. The driver will "remembe

virtio_net: ethtool supported link modes

2017-08-31 Thread Radu Rendec
lly be set. Could you please share your opinion on this? Thank you, Radu Rendec

Re: TUN interfaces loopback

2015-11-29 Thread Radu Rendec
On Sun, 2015-11-29 at 17:40 +0900, Lorenzo Colitti wrote: > On Thu, Nov 26, 2015 at 1:58 AM, Radu Rendec wrote: > > I tracked down the problem to ip_route_input_slow() in net/ipv4/route.c > > [...] > > The next problem is that packets are seen as "martians" and dro

TUN interfaces loopback

2015-11-25 Thread Radu Rendec
Disclaimer: I know this is a *development* list, but I feel the answer lies deep down in the ipv4 routing code, so it's more likely that I find help here. That being said, I have two TUN interfaces that are "cross-connected" in user space (i.e. whatever is read on the socket corresponding to eithe

[PATCH] [PKT_SCHED] CLS_U32: Use ffs() instead of C code on hash mask to get first set bit.

2007-11-08 Thread Radu Rendec
applying ntohl() also saves one ntohl() call if mask is 0. Signed-off-by: Radu Rendec <[EMAIL PROTECTED]> --- net/sched/cls_u32.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 5317102..c390082 100644 ---

Re: Endianness problem with u32 classifier hash masks

2007-11-07 Thread Radu Rendec
On Wed, 2007-11-07 at 01:22 -0800, David Miller wrote: > I've grown impatient and done the work for you :-) I've applied > the patch below to my tree, thank you! > > If someone wants to send me the ffs() thing relative to this, > I'd appreciate it. Thanks again! Thanks again for making the patc

Re: Endianness problem with u32 classifier hash masks

2007-11-07 Thread Radu Rendec
On Wed, 2007-11-07 at 08:42 -0500, jamal wrote: > On Wed, 2007-07-11 at 01:22 -0800, David Miller wrote: > > > @@ -615,7 +615,7 @@ static int u32_change(struct tcf_proto *tp, unsigned > > long base, u32 handle, > > n->handle = handle; > > { > > u8 i = 0; > > - u32 mask = s->hmask; > >

Re: Endianness problem with u32 classifier hash masks

2007-11-06 Thread Radu Rendec
On Tue, 2007-11-06 at 09:43 -0500, jamal wrote: > On Tue, 2007-06-11 at 15:25 +0100, Jarek Poplawski wrote: > > > Yes, it saves one htonl() on the slow path! > > Would it feel better to say grew down exponentially from version 1 to > 3? ;-> Not only it saves one htonl(), but also keeps the code

Re: Endianness problem with u32 classifier hash masks

2007-11-06 Thread Radu Rendec
en't so big I think you could > >> try Jamal's at first, and if it doesn't work, and nothing new from Jamal > >> in the meantime, resend your version. Cutdown in u32_change() seems to > >> add more to the fastpath, but maybe Jamal thinks about

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
clone of Dave's net-2.6 tree, so it shouldn't be such a big effort to use git after all. I can also make the patch against 2.6.24-rc1, so please tell me which is more convinient for you. Cheers, Radu Rendec - To unsubscribe from this list: send the line "unsubscribe netdev&

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
guess is that it won't work (most probably it will produce what Jarek suggested earlier). What exactly did you mean by "cutdown on the conversion in u32_change()"? Cheers, Radu Rendec - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
rked with kernel maintainers before, please be patient if it's not perfect at the first attempt :) What tree/branch should I make the patch against? Thanks, Radu Rendec On Mon, 2007-11-05 at 10:12 +0100, Jarek Poplawski wrote: > On Sun, Nov 04, 2007 at 06:58:13PM -0500, jamal wrote: > &

Endianness problem with u32 classifier hash masks

2007-11-01 Thread Radu Rendec
ernel) when a selector is dumped - in u32_dump(). I would like at least to know your opinion about this issue. Thanks, Radu Rendec --- linux-2.6.22.9/net/sched/cls_u32.c.orig 2007-10-30 17:08:03.0 +0200 +++ linux-2.6.22.9/net/sched/cls_u32.c 2007-10-30 17:04:49.0 +0200 @