On 13. 04. 21 14:44, Andrew Lunn wrote:
On Tue, Apr 13, 2021 at 09:09:37AM +0200, Michal Vokáč wrote:
On 12. 04. 21 16:14, Andrew Lunn wrote:
The FEC does not have PHY and is connected to the switch at RGMII level.
Adding the fixed-link { speed = <1000>; full-duplex; }; subnode to FEC
do
On 12. 04. 21 16:14, Andrew Lunn wrote:
[1]
https://elixir.bootlin.com/linux/v5.12-rc7/source/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi#L101
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
phy-mode = "rgmii-id";
phy-reset-gpios = <&gpio1 25 GPIO_
Hi folks,
I am working on kernel upgrade on our imx6dl-yapp4 platform and just realized
that since v5.9 networking is broken. Git bisect brought me to commit
b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
Kernel v5.8 NFS boot without the offending commit:
qca8k 2188000.et
K!
qca8k 2188000.ethernet-1:0a eth2 (uninitialized): PHY [2188000.ethernet-1:01]
driver [Generic PHY]
qca8k 2188000.ethernet-1:0a eth1 (uninitialized): PHY [2188000.ethernet-1:02]
driver [Generic PHY]
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Cc:
Signed-
On 26. 09. 19 10:59, Michal Vokáč wrote:
The QCA8K family supports up to 7 ports. So use the existing
QCA8K_NUM_PORTS define to allocate the switch structure and limit all
operations with the switch ports.
This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and
disable all
On 24. 09. 19 15:10, Michal Vokáč wrote:
On 24. 09. 19 14:31, Andrew Lunn wrote:
On Tue, Sep 24, 2019 at 01:27:24PM +0200, Michal Vokáč wrote:
Hi,
just tried booting latest next-20190920 on our imx6dl-yapp4-hydra platform
with QCA8334 switch and got this:
[7.424620] [<80684
On 25. 09. 19 2:47, Andrew Lunn wrote:
The CPU port does not have a PHY connected to it. So calling
phy_support_asym_pause() results in an Opps. As with other DSA
drivers, add a guard that the port is a user port.
Reported-by: Michal Vokáč
Thank you for the prompt fix Andrew!
Tested-by
On 25. 09. 19 2:44, Andrew Lunn wrote:
On Tue, Sep 24, 2019 at 03:10:44PM +0200, Michal Vokáč wrote:
On 24. 09. 19 14:31, Andrew Lunn wrote:
I added the printk and the above fix and can confirm that it is the CPU
port and the phy is NULL pointer:
[6.976366] qca8k 2188000.ethernet-1:0a
On 24. 09. 19 14:31, Andrew Lunn wrote:
On Tue, Sep 24, 2019 at 01:27:24PM +0200, Michal Vokáč wrote:
Hi,
just tried booting latest next-20190920 on our imx6dl-yapp4-hydra platform
with QCA8334 switch and got this:
[7.424620] [<806840e0>] (phy_support_asym_pause) from [<
Hi,
just tried booting latest next-20190920 on our imx6dl-yapp4-hydra platform
with QCA8334 switch and got this:
[6.957822] 8<--- cut here ---
[6.963550] Unable to handle kernel NULL pointer dereference at virtual
address 0264
[6.974342] pgd = (ptrval)
[6.979751] [0264]
On 01. 03. 19 12:26, liweihang wrote:
Hi all,
We encountered a problem that if there are two devices in kernel v5.0 with
marvell phy 88E1510 connect with each other directly, one with autoneg on and
the other off. The one who has disabled auto-negotiation will failed on setting
speed and duplex
struct bridge_vlan_info info;
int ret;
+ if (vid == 0)
+ return 0;
+
/* Check for a possible bridge VLAN entry now since there is no
* need to emulate the switchdev prepare + commit phase.
*/
Tested-by: Michal Vokáč
I am not sure what was th
Added Christian to the CC list.
I see you also work with the QCA833x switch. Your comments are welcome!
On 20. 02. 19 19:37, Heiner Kallweit wrote:
On 20.02.2019 16:02, Michal Vokáč wrote:
Hi,
Another issue in a row with networking on imx6dl-yapp4 platform [1]
that uses QCA8334 Ethernet
On 26. 02. 19 8:33, Heiner Kallweit wrote:
On 20.02.2019 16:02, Michal Vokáč wrote:
Hi,
Another issue in a row with networking on imx6dl-yapp4 platform [1]
that uses QCA8334 Ethernet switch.
Very recently, with Vinod and Andrew, we solved an issue with
RGMII_ID mode by patch[2][3]. I tested
On 27. 02. 19 18:26, p...@cmp.felk.cvut.cz wrote:
From: Pavel Pisa
Ahoj Pavle,
I can not comment on the content of the binding but it is a good
practice to add at least a short description to each commit even
if it should be the subject said differently.
Anyway, hats off to all of you, great
Hi,
Another issue in a row with networking on imx6dl-yapp4 platform [1]
that uses QCA8334 Ethernet switch.
Very recently, with Vinod and Andrew, we solved an issue with
RGMII_ID mode by patch[2][3]. I tested those with next-20190215
and it worked just fine.
The patch[2] was merged into next-201
my imx6dl platform with QCA8334 switch.
Thank you!
Tested-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index a4b6cda38016..aa1f7f1b20d3 100644
--- a/drivers/net/dsa/qca8k.c
+++
On 18. 02. 19 14:03, Vinod Koul wrote:
On 18-02-19, 12:54, Michal Vokáč wrote:
On 18. 02. 19 11:45, Vinod Koul wrote:
On 15-02-19, 16:23, Andrew Lunn wrote:
On Fri, Feb 15, 2019 at 04:01:08PM +0100, Michal Vokáč wrote:
Hi,
networking on my boards [1], which are currently in linux-next
On 18. 02. 19 11:45, Vinod Koul wrote:
On 15-02-19, 16:23, Andrew Lunn wrote:
On Fri, Feb 15, 2019 at 04:01:08PM +0100, Michal Vokáč wrote:
Hi,
networking on my boards [1], which are currently in linux-next, suddently
stopped working. I tracked it down to this commit 5ecdd77c61c8 ("net
Hi,
networking on my boards [1], which are currently in linux-next, suddently
stopped working. I tracked it down to this commit 5ecdd77c61c8 ("net: dsa:
qca8k: disable delay for RGMII mode") [2].
So I think the rgmii-id mode is obviously needed in my case.
I was able to find a couple drivers tha
On 23.5.2018 17:39, Florian Fainelli wrote:
On 05/22/2018 11:20 PM, Michal Vokáč wrote:
This series basically adds support for a QCA8334 ethernet switch to the
qca8k driver. It is a four-port variant of the already supported seven
port QCA8337. Register map is the same for the whole familly
regarding SPDX and
redundant parentheses.
Changes in v3:
- Rebased on latest net-next/master.
- Corrected fixed-link documentation.
Michal Vokáč (7):
net: dsa: qca8k: Add QCA8334 binding documentation
net: dsa: qca8k: Add support for QCA8334 switch
net: dsa: qca8k: Enable RXMAC when bringing up
Add support for the four-port variant of the Qualcomm QCA833x switch.
The CPU port default link settings can be reconfigured using
a fixed-link sub-node.
Signed-off-by: Michal Vokáč
Reviewed-by: Rob Herring
Reviewed-by: Andrew Lunn
---
Changes in v3:
- Correct fixed-link node documentation
Add support for the four-port variant of the Qualcomm QCA833x switch.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
---
Changes in v3:
- Add "Reviewed-by" tag from Andrew
Changes in v2:
- Add commit message
drivers/net/dsa/qca8k.c | 1 +
1 file changed, 1 insertion(+)
di
Implement adjust_link function that allows to overwrite default CPU port
setting using fixed-link device tree subnode.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v3:
- none
Changes in v2:
- Add "Reviewed-by" tags from Andrew a
When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Floria
Replace the GPLv2 license boilerplate with the SPDX license identifier.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v3:
- none
Changes in v2:
- Add commit message.
- Add "Reviewed-by" tags from Andrew and Florian.
drive
correct size of the bit field used to configure link speed.
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v3:
- none
Changes in v2:
- Add "Fixes" t
Fix warning reported by checkpatch.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v3:
- none
Changes in v2:
- Fix typo in subject.
- Add "Reviewed-by" tags from Andrew and Florian.
drivers/net/dsa/qca8k.c | 2 +-
1 file
Add support for the four-port variant of the Qualcomm QCA833x switch.
The CPU port default link settings can be reconfigured using
a fixed-link sub-node.
Signed-off-by: Michal Vokáč
---
Changes in v2:
- Add commit message and document fixed-link binding.
.../devicetree/bindings/net/dsa
Implement adjust_link function that allows to overwrite default CPU port
setting using fixed-link device tree subnode.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v2:
- Add "Reviewed-by" tags from Andrew and Florian.
drive
Replace the GPLv2 license boilerplate with the SPDX license identifier.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v2:
- Add commit message.
- Add "Reviewed-by" tags from Andrew and Florian.
drivers/net/dsa/qca8k.c | 10 +--
Fix warning reported by checkpatch.
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v2:
- Fix typo in subject.
- Add "Reviewed-by" tags from Andrew and Florian.
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+),
correct size of the bit field used to configure link speed.
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
Changes in v2:
- Add "Fixes" tag as pointed out by Florian.
Add support for the four-port variant of the Qualcomm QCA833x switch.
Signed-off-by: Michal Vokáč
---
Changes in v2:
- Add commit message.
drivers/net/dsa/qca8k.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 3684e56..6a3ffb2
When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Michal Vokáč
Reviewed-by: Andrew Lunn
Reviewed-by: Floria
regarding SPDX and
redundant parentheses.
Michal Vokáč (7):
net: dsa: qca8k: Add QCA8334 binding documentation
net: dsa: qca8k: Add support for QCA8334 switch
net: dsa: qca8k: Enable RXMAC when bringing up a port
net: dsa: qca8k: Force CPU port to its highest bandwidth
net: dsa: qca8k: Allow
On 21.5.2018 17:20, Florian Fainelli wrote:
On 05/21/2018 06:28 AM, Michal Vokáč wrote:
Signed-off-by: Michal Vokáč
Reviewed-by: Florian Fainelli
I don't know if we need all people who contributed to that driver to
agree on that, this is not a license change, so it should be o
On 21.5.2018 17:21, Florian Fainelli wrote:
On 05/21/2018 06:28 AM, Michal Vokáč wrote:
Fix warning reported by checkpatch.
Nit in the subject: should be redundant, with that:
Reviewed-by: Florian Fainelli
Thanks, I will fix it.
Michal
On 21.5.2018 17:19, Florian Fainelli wrote:
On 05/21/2018 06:28 AM, Michal Vokáč wrote:
By default autonegotiation is enabled to configure MAC on all ports.
For the CPU port autonegotiation can not be used so we need to set
some sensible defaults manually.
This patch forces the default
On 21.5.2018 17:17, Florian Fainelli wrote:
On 05/21/2018 06:28 AM, Michal Vokáč wrote:
When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.
Signed-off-by: Michal Vokáč
Reviewed-by: Florian Fainelli
Should
On 21.5.2018 16:47, Andrew Lunn wrote:
On Mon, May 21, 2018 at 03:28:07PM +0200, Michal Vokáč wrote:
Signed-off-by: Michal Vokáč
Hi Michal
It would be good to document that fixed-link can be used.
OK, I will document that and add a commit message as well as you
mentioned before.
Thanks
When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers
correct size of the bit field used to configure link speed.
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 6 +-
drivers/net/dsa/qca8k.h | 6 --
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 0d224f3..14a108b38
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7eba987..c834893 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -1,17 +1,9
Signed-off-by: Michal Vokáč
---
Documentation/devicetree/bindings/net/dsa/qca8k.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
index 9c67ee4..3d73cd0 100644
Fix warning reported by checkpatch.
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index c834893..c0da402 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa
Implement adjust_link function that allows to overwrite default CPU port
setting using fixed-link device tree subnode.
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 43 +++
drivers/net/dsa/qca8k.h | 1 +
2 files changed, 44 insertions
Signed-off-by: Michal Vokáč
---
drivers/net/dsa/qca8k.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 3684e56..6a3ffb2 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -1010,6 +1010,7 @@ static SIMPLE_DEV_PM_OPS
regarding SPDX and
redundant parentheses.
Michal Vokáč (7):
net: dsa: qca8k: Add QCA8334 binding documentation
net: dsa: qca8k: Add support for QCA8334 switch
net: dsa: qca8k: Enable RXMAC when bringing up a port
net: dsa: qca8k: Force CPU port to its highest bandwidth
net: dsa: qca8k: Allow
On 16.5.2018 15:17, Andrew Lunn wrote:
So as the fixed-link subnode is optional we still should force some sensible
defaults if it is not used. Same as Marvell drives does. Can I say that we
agreed that the current CPU port setting is not correct and the fastest link
speed and duplex supported by
On 15.5.2018 18:17, Florian Fainelli wrote:
I would like to have confirmed that I understand it correctly and that
the problem is really in the driver not handling fixed-link.
I would actually skip fixed-link, if you don't need it. Just hardwire
the CPU port, like the Marvell driver does:
http
On 10.5.2018 16:29, Andrew Lunn wrote:
I would probably add code to dump all the qca8k registers. Compare the
values for your working setup and your non-working setup. Hopefully
they are not too different, and you can quickly get to the bits which
matter.
Perfect! Thanks to your suggestion I di
On 4.5.2018 15:30, Andrew Lunn wrote:
I am out of ideas how to further debug this.
Any additional adivce will be much appreciated.
I would suggest looking at the statistics counters. ethtool -S. Try
it for both the slave interfaces, and the master interface. The master
interfaces statistics sh
On 30.4.2018 15:20, Andrew Lunn wrote:
Using rgmii-id for the port is not valid as the qca8k driver does not support
that mode. It only supports rgmii and sgmii. I think this is actually not
correct. When phy-mode is set to rgmii for port the qca8k driver configures
internal delays in the switch.
On 26.4.2018 16:06, Andrew Lunn wrote:
On Thu, Apr 26, 2018 at 03:37:33PM +0200, Michal Vokáč wrote:
- Linux 4.9.84 (Freescale 4.9-1.0.x-imx branch)
Hi Michal
Please use mainline, not the freescale fork. For DSA, there is nothing
you need in the freescale fork. Once it works with mainline
Ahoj,
Sorry for bothering you guys but I could not come up with a more appropriate
place to ask my question.
I would very much appreciate some adivce to the DSA/QCA8K driver usage.
I am not (yet) very educated in networking internals so my wording may not be
right and my expectations may be wron
57 matches
Mail list logo
