Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode

l 10GE MII > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX > * @PHY_INTERFACE_MODE_MAX: Book keeping [...] This is kernel-internal interface, so maybe the new mode can be inserted before 1000baseX for easier lookup? Best Regards Michał Mirosław

Re: [RFC PATCH net-next 00/11] Nested VLANs - decimate flags and add another

this is apropriate when reducing MTU because of eg. PMTU limit for a tunnel. Best Regards, Michał Mirosław

net: netdev_sync_lower_features()

hould do just what netdev_sync_lower_features() is doing now in the context of upper device, and also respect all the other constraints we have on features. Best Regards, Michał Mirosław

Re: [PATCH 03/15] staging: wfx: fix double free

On Tue, May 05, 2020 at 02:37:45PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > In case of error in wfx_probe(), wdev->hw is freed. Since an error > occurred, wfx_free_common() is called, then wdev->hw is freed again. > > Cc: Michał Mirosław > Sig

Re: [PATCH] bonding: Always enable vlan tx offload

vices without HW VLAN tagging. Generally drivers that don't ever > >do VLAN offload also ignore vlan_tci presence. Am I missing something > >here? > validate_xmit_skb->validate_xmit_vlan Yes it is. Thanks! Best Regards, Michał Mirosław

[PATCH v3 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

into i40e_process_skb_fields() to save on duplicated code. i40e_receive_skb() becomes trivial and so is removed. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- v3: * fix whitespace for checkpatch v2: * no changes --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 31

[PATCH v3 2/2] i40e: DRY rx_ptype handling code

Move rx_ptype extracting to i40e_process_skb_fields() to avoid duplicating the code. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- v3: * no changes v2: * fix prototype in i40e_txrx_common.h --- drivers/net/ethernet/intel/i40e/i40e_txrx.c| 12 drivers

[PATCH net v2 2/2] i40e: DRY rx_ptype handling code

Move rx_ptype extracting to i40e_process_skb_fields() to avoid duplicating the code. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- v2: * fix prototype in i40e_txrx_common.h --- drivers/net/ethernet/intel/i40e/i40e_txrx.c| 12 drivers/net/ethernet/intel

[PATCH net v2 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

into i40e_process_skb_fields() to save on duplicated code. i40e_receive_skb() becomes trivial and so is removed. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- v2: * no changes --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 30 +-- .../ethernet/intel/i40e

[PATCH net 2/2] i40e: DRY rx_ptype handling code

Move rx_ptype extracting to i40e_process_skb_fields() to avoid duplicating the code. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 6 +- 2 files changed, 5

[PATCH net 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

into i40e_process_skb_fields() to save on duplicated code. i40e_receive_skb() becomes trivial and so is removed. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 30 +-- .../ethernet/intel/i40e/i40e_txrx_common.h

[PATCH net-next 4/4] mlx5: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c index 6dacaeba2fbf..9afdf955f2bc 100644 --- a

[PATCH net-next 0/4] VLAN tag handling cleanup

This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit handling is made similar to how other tag fields are used. Michał Mirosław (4): net/vlan: introduce skb_vlan_tag_get_cfi() helper net/hyperv: use skb_vlan_tag_*() helpers benet: use skb_vlan_tag_get_prio() mlx5: use

[PATCH net-next 1/4] net/vlan: introduce skb_vlan_tag_get_cfi() helper

Abstract CFI/DEI bit access consistently with other VLAN tag fields. Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 7a541eadf78e..4cca4da7a6de 100644 --- a

[PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

Replace open-coded bitfield manipulation with skb_vlan_tag_*() helpers. This also enables correctly passing of VLAN.CFI bit. Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv

[PATCH net-next 3/4] benet: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 80b2bd3747ce..245abf0d19c0 100644 --- a/drivers/net

[PATCH net-next] OVS: remove VLAN_TAG_PRESENT - fixup

It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing. This fixes it. Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT") Signed-off-by: Michał Mirosław --- net/openvswitch/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswi

Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers

On Thu, Nov 08, 2018 at 08:50:05PM +0200, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote: > > This series removes VLAN_TAG_PRESENT use from network drivers in > > preparation to removing its special meaning. > Can you please give an ext

[PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers

This series removes VLAN_TAG_PRESENT use from network drivers in preparation to removing its special meaning. Michał Mirosław (4): i40iw: remove use of VLAN_TAG_PRESENT cnic: remove use of VLAN_TAG_PRESENT gianfar: remove use of VLAN_TAG_PRESENT OVS: remove use of VLAN_TAG_PRESENT

[PATCH net-next 3/4] gianfar: remove use of VLAN_TAG_PRESENT

Reviewed-by: Claudiu Manoil Signed-off-by: Michał Mirosław --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index

[PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 771eb6bd0785..4b3999d88c9e 100644 --- a/drivers/infiniband

[PATCH net-next 2/4] cnic: remove use of VLAN_TAG_PRESENT

This just removes VLAN_TAG_PRESENT use. VLAN TCI=0 special meaning is deeply embedded in the driver code and so is left as is. Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet

[PATCH net-next 4/4] OVS: remove use of VLAN_TAG_PRESENT

This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- net/openvswitch/actions.c | 13 + net/openvswitch/flow.c

[PATCH net-next 2/4] net/vlan: introduce __vlan_hwaccel_copy_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index c438fa0a1c6a..941da4bf3929 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -472,6 +472,19

[PATCH net-next 4/4] net/vlan: remove unused #define HAVE_VLAN_GET_TAG

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index b14bf87999aa..03b08ffded07 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -555,8 +555,6 @@ static inline

[PATCH net-next 3/4] net/vlan: include the shift in skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 +- net/core/flow_dissector.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 941da4bf3929..b14bf87999aa 100644 --- a/include/linux/if_vlan.h +++ b

[PATCH net-next 1/4] net/vlan: introduce __vlan_hwaccel_clear_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 83ea4df6ab81..c438fa0a1c6a 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h

[PATCH net-next 0/4] net/vlan: prepare for removal of VLAN_TAG_PRESENT

This is a preparatory patchset before removing the use of VLAN_TAG_PRESENT bit in skb->vlan_tci as indication of VLAN offload. This set includes only cleanups that allow abstracting of code testing VLAN tag presence in drivers and networking code. Michał Mirosław (4): net/vlan: introd

[PATCH net] ibmvnic: fix accelerated VLAN handling

Don't request tag insertion when it isn't present in outgoing skb. Signed-off-by: Michał Mirosław --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvn

[PATCH net] qlcnic: remove assumption that vlan_tci != 0

VLAN.TCI == 0 is perfectly valid (802.1p), so allow it to be accelerated. Signed-off-by: Michał Mirosław --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net

Re: [PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table

think that if you just renamed 'n' to 'best_index' and avoided reusing 'max_l3_len' (as you already did) the idea could be made more obvious without expading the code to twice the lines. The max_len[] array in the original code documents how the HW reacts to a spec

Re: [PATCH net-next 2/2 v9] net: ethernet: Add a driver for Gemini gigabit ethernet

ed to work on other platforms, this seemed like the best workaround to make it compile on other arches. Best Regards, Michał Mirosław

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

On Sat, Dec 02, 2017 at 12:06:40PM +0100, Linus Walleij wrote: [...] > The latest v6 incarnation of this driver was written by Michał > Mirosław and submitted for inclusion in 2011. This was the > last post: > https://lwn.net/Articles/437889/ > > DaveM ACKed it at the time: >

Re: [PATCH net] ipv4: fib: Fix NULL pointer deref during fib_sync_down_dev()

: fib: Notify about nexthop status changes") > Signed-off-by: Ido Schimmel > Reported-by: Michał Mirosław Tested-by: Michał Mirosław Thanks!

Re: [v4.12 regression] netns: NULL deref in fib_sync_down_dev()

On Fri, Jul 28, 2017 at 08:36:02PM +0300, Ido Schimmel wrote: > On Fri, Jul 28, 2017 at 10:28:16AM -0700, Cong Wang wrote: > > On Fri, Jul 28, 2017 at 9:43 AM, Ido Schimmel wrote: > > > On Fri, Jul 28, 2017 at 06:00:47PM +0200, Michał Mirosław wrote: > > >> Dear NetD

[v4.12 regression] netns: NULL deref in fib_sync_down_dev()

Dear NetDevs, Before I go to bisecting, have you seen a following NULL dereference, yet? Where should I start looking? It is triggered by deleting netns (cut-down script attached - triggers every time). This was working correctly under v4.11.x. Best Regards, Michał Mirosław [1097925.958758

Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

On Wed, Jan 04, 2017 at 09:11:57PM +0100, Daniel Borkmann wrote: > On 01/04/2017 02:18 AM, Michał Mirosław wrote: > > Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT. > > The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset. > &

[PATCH net-next 3/6] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

Acked-by: Ralf Baechle Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 49a2e2226fee..d06722294ede 100644 --- a/arch/mips/net/bpf_jit.c +++ b

[PATCH net-next 2/6] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- v2: remove one insn for big-endians arch/arm/net/bpf_jit_32.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 93d0b6d0b63e..0700cbbe4f14 100644 --- a/arch/arm/net

[PATCH net-next 1/6] net/skbuff: add macros for VLAN_PRESENT bit

Signed-off-by: Michał Mirosław --- include/linux/skbuff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index b53c0cfd417e..168c3e486bd4 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -768,6 +768,12 @@ struct

[PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

split JIT changes per architecture. Michał Mirosław (6): net/skbuff: add macros for VLAN_PRESENT bit net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI n

[PATCH net-next 4/6] net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/powerpc/net/bpf_jit_comp.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c index 7e706f36e364..22ae63fb9b7d 100644 --- a/arch/powerpc/net/bpf_jit_comp.c

[PATCH net-next 6/6] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- v2: save an insn on big-endiands net/core/filter.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 1969b3f118c1..7caf0bbbd092 100644 --- a/net/core/filter.c +++ b/net/core

[PATCH net-next 5/6] net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/sparc/net/bpf_jit_comp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c index a6d9204a6a0b..61cc15dc86f7 100644 --- a/arch/sparc/net/bpf_jit_comp.c +++ b

[PATCH net-next 0/8] Preparation for VLAN_TAG_PRESENT cleanup, drivers part

Cleanups needed before enabling passing of VLAN.CFI. Those patches depend on '*** SUBJECT HERE ***' patchset, but are otherwise independent of each other. Michał Mirosław (8): benet: use __vlan_hwaccel helpers benet: use skb_vlan_tag_get_prio() sky2: use __vlan_hwaccel helpers

[PATCH net-next 1/8] benet: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- v3: fix adapter->pvid handling drivers/net/ethernet/emulex/benet/be_main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c in

[PATCH net-next 4/8] net/core: use __vlan_hwaccel helpers

This removes assumptions about VLAN_TAG_PRESENT bit. Signed-off-by: Michał Mirosław --- net/core/dev.c | 8 +--- net/core/skbuff.c| 2 +- net/sched/act_vlan.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 56818f7eab2b

[PATCH net-next 2/8] benet: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index cd12c9a7664b..7e50c6c224c4 100644 --- a/drivers/net

[PATCH net-next 3/8] sky2: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/marvell/sky2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index b60ad0e56a9f..bcd20e04caba 100644 --- a/drivers/net/ethernet/marvell

[PATCH net-next 8/8] OVS: remove use of VLAN_TAG_PRESENT

This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- v2: removed userspace-facing changes net/openvswitch/actions.c | 13

[PATCH net-next 6/8] 8021q: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index e2ed69850489..604a67abdeb6 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -50,7 +50,7 @@ bool

[PATCH net-next 7/8] ipv4/tunnel: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/ipv4/ip_tunnel_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index fed3d29f9eb3..0004a54373f0 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -120,7

[PATCH net-next 5/8] bridge: use __vlan_hwaccel helpers

This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 15 +-- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c| 6 +++--- 3 files changed, 13 insertions(+), 10 deletions(-) diff

Re: [PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack

On Tue, Jan 03, 2017 at 04:32:17PM -0500, David Miller wrote: > From: Michał Mirosław > Date: Tue, 3 Jan 2017 21:52:33 +0100 (CET) > > > Dear NetDevs > > > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > > Currently Linux always c

[PATCH net-next] nfnetlink/queue: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/netfilter/nfnetlink_queue.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 3ee0b8a000a4..8c7923aac826 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net

[PATCH net-next] cnic: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index b1d2ac818710..6e3c61081338 100644 --- a/drivers/net/ethernet/broadcom

[PATCH net-next] gianfar: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław Reviewed-by: Claudiu Manoil --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index

[PATCH net-next] cxgb4: use __vlan_hwaccel helpers

This also initializes vlan_proto field. Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f1510cc76d2d..66a3d39b3d54 100644 --- a

[PATCH net-next] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv

[PATCH net-next] ibmvnic: fix accelerated VLAN handling

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c12596676bbb..c7664db9019c 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c

[PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 95a0586a4da8..125c66bf6107 100644 --- a/drivers/infiniband

[PATCH net-next] qlcnic: remove assumption that vlan_tci != 0

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c index fedd7366713c..c3cc707cc265 100644

[PATCH net-next 1/1] net/vlan: remove unused #define HAVE_VLAN_GET_TAG

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index bc4e8c2533da..74675312f8d9 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -476,8 +476,6 @@ static inline

[PATCH net-next 3/3] net/vlan: include the shift in skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 +- net/core/flow_dissector.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 75e839b84a63..bc4e8c2533da 100644 --- a/include/linux/if_vlan.h +++ b

[PATCH net-next 1/3] net/vlan: introduce __vlan_hwaccel_clear_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8d5fcd6284ce..38be9041cde4 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h

[PATCH net-next 2/3] net/vlan: introduce __vlan_hwaccel_copy_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 38be9041cde4..75e839b84a63 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -393,6 +393,19

[PATCH net-next 0/3] Preparation for VLAN_TAG_PRESENT cleanup

This introduces additional and fixes existing helpers for accessing skb->vlan_tag. Michał Mirosław (3): net/vlan: introduce __vlan_hwaccel_clear_tag() helper net/vlan: introduce __vlan_hwaccel_copy_tag() helper net/vlan: include the shift in skb_vlan_tag_get_prio() include/linux/if_vla

Re: [PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack

On Wed, Jan 04, 2017 at 12:21:51AM +0100, Michał Mirosław wrote: > On Tue, Jan 03, 2017 at 04:32:17PM -0500, David Miller wrote: > > From: Michał Mirosław > > Date: Tue, 3 Jan 2017 21:52:33 +0100 (CET) > > > > > Dear NetDevs > > > > > > This

Re: [PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack

On Tue, Jan 03, 2017 at 04:32:17PM -0500, David Miller wrote: > From: Michał Mirosław > Date: Tue, 3 Jan 2017 21:52:33 +0100 (CET) > > > Dear NetDevs > > > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > > Currently Linux always c

[PATCH net-next v3 10/27] benet: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- v3: fix adapter->pvid handling drivers/net/ethernet/emulex/benet/be_main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c in

Re: [PATCH net-next v2 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

On Tue, Jan 03, 2017 at 09:52:40PM +0100, Michał Mirosław wrote: > --- > lib/test_bpf.c | 15 +++ > 1 file changed, 15 insertions(+) Please ignore - squashed with #25. Best Regards, Michał Mirosław

[PATCH net-next v3 25/27] net: remove VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- v3: merged with #24 (test_bpf temporary changes) arch/mips/net/bpf_jit.c | 3 --- arch/powerpc/net/bpf_jit_comp.c | 3 --- arch/sparc/net/bpf_jit_comp.c | 4 include/linux/if_vlan.h | 11 ++- include/linux/skbuff.h

[PATCH net-next v2 09/27] cxgb4: use __vlan_hwaccel helpers

This also initializes vlan_proto field. Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f1510cc76d2d..66a3d39b3d54 100644 --- a

[PATCH net-next v2 07/27] gianfar: remove use of VLAN_TAG_PRESENT

Reviewed-by: Claudiu Manoil Signed-off-by: Michał Mirosław --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index

[PATCH net-next v2 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv

[PATCH net-next v2 18/27] net/skbuff: add macros for VLAN_PRESENT bit

Signed-off-by: Michał Mirosław --- include/linux/skbuff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index b53c0cfd417e..168c3e486bd4 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -768,6 +768,12 @@ struct

[PATCH net-next v2 06/27] cnic: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index b1d2ac818710..6e3c61081338 100644 --- a/drivers/net/ethernet/broadcom

[PATCH net-next v2 10/27] benet: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 7e1633bf5a22..b365a0117349 100644 --- a/drivers

[PATCH net-next v2 05/27] i40iw: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 95a0586a4da8..125c66bf6107 100644 --- a/drivers/infiniband

[PATCH net-next v2 00/27] Allow passing of VLAN CFI bit through network stack

s per architecture. Best Regards, Michał Mirosław v2: rebase onto net-next --- Michał Mirosław (27): net/vlan: introduce __vlan_hwaccel_clear_tag() helper net/vlan: introduce __vlan_hwaccel_copy_tag() helper ibmvnic: fix accelerated VLAN handling qlcnic: remove assumption that vlan_tci != 0

[PATCH net-next v2 26/27] net/hyperv: enable passing of VLAN.CFI bit

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d7901929..4e20f4c247fa 100644 --- a/drivers/net/hyperv

[PATCH net-next v2 17/27] OVS: remove use of VLAN_TAG_PRESENT

This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- v2: removed userspace-facing changes net/openvswitch/actions.c | 13

[PATCH net-next v2 25/27] net: remove VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 3 --- arch/powerpc/net/bpf_jit_comp.c | 3 --- arch/sparc/net/bpf_jit_comp.c | 4 include/linux/if_vlan.h | 11 ++- include/linux/skbuff.h | 16 +--- lib/test_bpf.c

[PATCH net-next v2 11/27] sky2: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/marvell/sky2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index b60ad0e56a9f..bcd20e04caba 100644 --- a/drivers/net/ethernet/marvell

[PATCH net-next v2 27/27] net/vlan: remove unused #define HAVE_VLAN_GET_TAG

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8ff2f0ed4c27..f0b935625bc8 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -477,8 +477,6 @@ static inline

[PATCH net-next v2 19/27] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/arm/net/bpf_jit_32.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 93d0b6d0b63e..6dbc60241f9d 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net

[PATCH net-next v2 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

Acked-by: Ralf Baechle Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 49a2e2226fee..4b12b5df47e8 100644 --- a/arch/mips/net/bpf_jit.c

[PATCH net-next v2 14/27] 8021q: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index e2ed69850489..604a67abdeb6 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -50,7 +50,7 @@ bool

[PATCH net-next v2 12/27] net/core: use __vlan_hwaccel helpers

This removes assumptions about VLAN_TAG_PRESENT bit. Signed-off-by: Michał Mirosław --- net/core/dev.c | 8 +--- net/core/skbuff.c| 2 +- net/sched/act_vlan.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 56818f7eab2b

[PATCH net-next v2 15/27] ipv4/tunnel: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/ipv4/ip_tunnel_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index fed3d29f9eb3..0004a54373f0 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -120,7

[PATCH net-next v2 16/27] nfnetlink/queue: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/netfilter/nfnetlink_queue.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 3ee0b8a000a4..8c7923aac826 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net

[PATCH net-next v2 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

Signed-off-by: Michał Mirosław --- lib/test_bpf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 0362da0b66c3..00d345006671 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -691,8 +691,13 @@ static struct bpf_test tests

[PATCH net-next v2 22/27] net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/sparc/net/bpf_jit_comp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c index a6d9204a6a0b..61cc15dc86f7 100644 --- a/arch/sparc/net/bpf_jit_comp.c +++ b

[PATCH net-next v2 21/27] net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/powerpc/net/bpf_jit_comp.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c index 7e706f36e364..22ae63fb9b7d 100644 --- a/arch/powerpc/net/bpf_jit_comp.c

[PATCH net-next v2 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- net/core/filter.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 1969b3f118c1..5209c5f5ac4a 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -188,22 +188,20

[PATCH net-next v2 13/27] bridge: use __vlan_hwaccel helpers

This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 15 +-- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c| 6 +++--- 3 files changed, 13 insertions(+), 10 deletions(-) diff

[PATCH net-next v2 02/27] net/vlan: introduce __vlan_hwaccel_copy_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 38be9041cde4..75e839b84a63 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -393,6 +393,19

[PATCH net-next v2 01/27] net/vlan: introduce __vlan_hwaccel_clear_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8d5fcd6284ce..38be9041cde4 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h

[PATCH net-next v2 04/27] qlcnic: remove assumption that vlan_tci != 0

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c index fedd7366713c..c3cc707cc265 100644

[PATCH net-next v2 03/27] ibmvnic: fix accelerated VLAN handling

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c12596676bbb..c7664db9019c 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c

  1   2   >