Hi David, Nico,
On 17/04/2021 06:24, David Gow wrote:
Hi Matt,
Like patch 1/6, I can apply it in MPTCP tree and send it later to
net-next with other patches.
Except if you guys prefer to apply it in KUnit tree and send it to
linux-next?
Given 1/6 is going to net-next, it makes sense to send
Hi David,
Thank you for your very clear reply!
On 15/04/2021 08:01, David Gow wrote:
On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts
wrote:
Up to the KUnit maintainers to decide ;-)
To summarise my view: personally, I'd prefer things the way this patch
works: have everything e
Hi Nico,
On 14/04/2021 10:58, Nico Pache wrote:
Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the
KUNIT *_KUNIT_TEST config name format.
For MPTCP, we have multiple KUnit tests: crypto and token. That's why we
wrote TESTS with a S.
I'm fine without S if we need to stick
Hi Mat,
On 19/03/2021 19:33, Mat Martineau wrote:
The mailing list for MPTCP maintenance has moved to the
kernel.org-supported mp...@lists.linux.dev address.
Complete, combined archives for both lists are now hosted at
https://lore.kernel.org/mptcp
Cc: Matthieu Baerts
Signed-off-by: Mat
patch for net-next is coming and another flag can be set as
well. What's funny is that this other flag is "9" which works well with
"6" because their bits are not overlapping :)
Anyway, better with "BIT()" macro!
Reviewed-by: Matthieu Baerts
Cheers,
Ma
Hi Chuck,
(+ cc: MPTCP list)
On 01/03/2021 15:52, Chuck Lever wrote:
On Mar 1, 2021, at 8:49 AM, syzbot
wrote:
(...)
syzbot found the following issue on:
(...)
Hi, thanks for the report.
Initial analysis:
c8e88e3aa738 ("NFSD: Replace READ* macros in nfsd4_decode_layoutget()"
changes
g the hmac validation earlier.
Fixes: 4cf8b7e48a09 ("subflow: introduce and use
mptcp_can_accept_new_subflow()")
Tested-by: Davide Caratti
Signed-off-by: Paolo Abeni
Good catch! Thank you for the patch!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Naresh,
On 19/11/2020 08:04, Naresh Kamboju wrote:
While running kselftest net/mptcp: mptcp_join.sh on x86_64 device running
linux next 20201118 tag the following warning was noticed.
Thank you for testing MPTCP and having reported this bug!
It looks like it is similar to what syzbot repor
Hi Andrea,
On 18/11/2020 15:24, Andrea Claudi wrote:
add_addr_accepted value is not printed if add_addr_signal value is 0.
Fix this properly looking for add_addr_accepted value, instead.
Good catch! We missed that when reviewing the code on MPTCP ML!
Acked-by: Matthieu Baerts
Cheers,
Matt
Hi Randy,
On 16/11/2020 04:17, Randy Dunlap wrote:
The previous Kconfig patch led to some other build errors as
reported by the 0day bot and my own overnight build testing.
These are all in when KCOV is enabled but
SKB_EXTENSIONS is not enabled, so fix those by combining those conditions
in th
Hi Randy,
On 14/11/2020 02:11, Randy Dunlap wrote:
The previous Kconfig patch led to some other build errors as
reported by the 0day bot and my own overnight build testing.
Thank you for looking at that!
I had the same issue and I was going to propose a similar fix with one
small difference,
Hi Jakub,
09 Nov 2020 21:57:05 Jakub Kicinski :
> On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote:
>> A small detail (I think): the Signed-off-by of the sender (Geliang)
>> should be the last one in the list if I am not mistaken.
>> But I guess this is not blocki
already
do for the wmem one.
Fixes: ("mptcp: add missing memory scheduling in the rx path")
Signed-off-by: Paolo Abeni
Good catch, thank you for this patch!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 09/11/2020 14:59, Geliang Tang wrote:
This patch added NULL pointer check for mptcp_pm_alloc_anno_list, and
avoided similar static checker warnings in mptcp_pm_add_timer.
Signed-off-by: Geliang Tang
Reviewed-by: Dan Carpenter
I think Dan reviewed the v1 of your patch -- witho
detail (I think): the Signed-off-by of the sender (Geliang)
should be the last one in the list if I am not mistaken.
But I guess this is not blocking.
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Mat,
On 03/11/2020 20:05, Mat Martineau wrote:
Describe the two MPTCP sysctls, what the values mean, and the default
settings.
Acked-by: Geliang Tang
Signed-off-by: Mat Martineau
Thank you for this new patch!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid
on IPV6 instead of
selecting it")
Signed-off-by: Matthieu Baerts
---
tools/testing/selftests/net/mptcp/config | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/mptcp/config
b/tools/testing/selftests/net/mptcp/config
index 8df5cb8f71ff..741a1c4f4ae8 100644
--
Hi Geert,
On 21/10/2020 11:52, Geert Uytterhoeven wrote:
Hi Matthieu,
On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts
wrote:
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
On
G_IPV6=m. But selecting IPV6 like we did
before was forcing it to be built-in while it was maybe not what the
user wants.
Reported-by: Geert Uytterhoeven
Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of
selecting it")
Signed-off-by: Matthieu Baerts
---
Notes:
Fo
Hi Geert,
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
Hi Jakub,
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
On 20/10/2020 09:38, Geert Uytterhoeven wrote:
MPTCP_IPV6 selects IPV6, thus enabling an optional feature the
Hi Jakub,
On 19/10/2020 22:40, Jakub Kicinski wrote:
On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote:
Hi Geliang,
On 19/10/2020 12:23, Geliang Tang wrote:
This patchset deals with initializations of mptcp_options_received's two
fields, ahmac and port.
Geliang Tang (2):
Hi Geert,
On 20/10/2020 09:40, Geert Uytterhoeven wrote:
On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven
wrote:
On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts
wrote:
On 19/10/2020 13:32, Geert Uytterhoeven wrote:
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
ut a re-submit, here is my:
Reviewed-by: Matthieu Baerts
Also, if you don't mind and while I am here, I never know: is it OK for
you the maintainers to send one Acked/Reviewed-by for a whole series --
but then this is not reflected on patchwork -- or should we send one tag
for e
have an easy way to
enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.
But it probably makes sense to depend on MPTCP instead of selecting it.
So that's fine for me. But then please also send a patch to ext4
maintainer to do the same there.
Reviewed-by: Mat
netns".
The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line")
is very similar to this one. But the modification in simult_flows.sh was
missed because this commit above was done in parallel to one here below.
Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests&
(and read): the remaining bytes contained garbage.
Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
Reported-and-tested-by: Davide Caratti
Acked-by: Geliang Tang
Signed-off-by: Matthieu Baerts
---
Hi David, Jakub,
On 21/09/2020 16:57, Matthieu Baerts wrote:
From: Mat Martineau
When receiving a DATA_FIN MPTCP option on a TCP FIN packet, the DATA_FIN
information would be stored but the MPTCP worker did not get
scheduled. In turn, the MPTCP socket state would remain in
TCP_ESTABLISHED and
://github.com/multipath-tcp/mptcp_net-next/issues/84
Fixes: 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state machine")
Acked-by: Paolo Abeni
Signed-off-by: Mat Martineau
Signed-off-by: Matthieu Baerts
---
Notes:
This is a resend of v1 and v2 with the same code modification. The
Hi David, Jakub,
We have a few net-next MPTCP changes depending on:
- 57025817eaa4 ("mptcp: fix subflow's local_id issues")
- 2ff0e566faa4 ("mptcp: fix subflow's remote_id issues")
- f612eb76f349 ("mptcp: fix kmalloc flag in mptcp_pm_nl_get_local_id")
We guess you are going to send a pull reque
Hi Ye,
Thank you for this v2.
On 16/09/2020 13:41, Ye Bin wrote:
Fixes coccicheck warnig:
net/mptcp/protocol.c:164:11-18: WARNING: Unsigned expression compared with zero:
max_seq > 0
Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue")
Reported-by: Hulk Robot
Signed-off-b
8fbf241064 ("selftests: add test-cases for MPTCP MP_JOIN")
Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp")
Signed-off-by: Matthieu Baerts
---
Notes:
This commit improves the output in selftests in case of errors, mostly
seen when modifying MPTCP code.
dd netlink-based PM")
Fixes: ec3edaa7ca6ce ("mptcp: Add handling of outgoing MP_JOIN requests")
Fixes: f296234c98a8f ("mptcp: Add handling of incoming MP_JOIN requests")
Signed-off-by: Geliang Tang
Thank you for the v2!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
we ignore this
address.
Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM")
Signed-off-by: Geliang Tang
Thank you for the v2!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 07/09/2020 12:29, Geliang Tang wrote:
This patch set the init remote_id to zero, otherwise it will be a random
number.
Then it added the missing subflow's remote_id setting code both in
__mptcp_subflow_connect and in subflow_ulp_clone.
Thank you for this other patch!
Here as w
Hi Geliang,
On 07/09/2020 12:29, Geliang Tang wrote:
In mptcp_pm_nl_get_local_id, skc_local is the same as msk_local, so it
always return 0. Thus every subflow's local_id is 0. It's incorrect.
This patch fixed this issue.
Also, we need to ignore the zero address here, like 0.0.0.0 in IPv4. Whe
and add missing 'sendfile' mode.
Good catch!
I guess we don't need this on -net or further, this test program is
always used with its wrapper mptcp_connect.sh.
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
++--
Thank you for looking at that!
For MPTCP code:
Acked-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
ot perform the proper
cleanup and inet_sock_destruct() will later emit a warn.
Address the issue updating the condition tested in mptcp_sock_destruct().
Also update the related comment.
Thank you for this new patch!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Tim,
Thank you for having sent the patch!
On 06/08/2020 08:41, Tim Froidcoeur wrote:
Refactor the fastreuse update code in inet_csk_get_port into a small
helper function that can be called from other places.
(...)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_so
Hi Paolo,
On 05/08/2020 11:10, Paolo Abeni wrote:
On Tue, 2020-08-04 at 21:25 +0200, Matthieu Baerts wrote:
Hi Paolo,
On 04/08/2020 18:31, Paolo Abeni wrote:
Nicolas reported the following oops:
(...)
on some unconventional configuration.
The MPTCP protocol is trying to create a subflow
Hi Paolo,
On 04/08/2020 18:31, Paolo Abeni wrote:
Nicolas reported the following oops:
(...)
on some unconventional configuration.
The MPTCP protocol is trying to create a subflow for an
unaccepted server socket. That is allowed by the RFC, even
if subflow creation will likely fail.
Unaccep
other host didn't announce another one. This also
fixes inet_diag showing blank info about MPTCP sockets from unblocking
sockets doing a connect().
Fixes: 41be81a8d3d0 ("mptcp: fix unblocking connect()")
Signed-off-by: Matthieu Baerts
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1
ip mptcp endpoint
Fixes: 7e0767cd ("add support for mptcp netlink interface")
Signed-off-by: Matthieu Baerts
---
ip/ipmptcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index bc12418b..e1ffafb3 100644
--- a/ip/ipmptcp.c
+++ b
Schmidt [ieee802154]
---
net/mptcp/protocol.c | 12 +++
Thank you for the v2!
For MPTCP-related code:
Acked-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Christoph,
On 20/07/2020 14:47, Christoph Hellwig wrote:
Rework the remaining setsockopt code to pass a sockptr_t instead of a
plain user pointer. This removes the last remaining set_fs(KERNEL_DS)
outside of architecture specific code.
Signed-off-by: Christoph Hellwig
---
...
diff --git
wig
---
include/linux/net.h | 6 --
include/net/sock.h | 4
net/core/sock.c | 30 ++
net/mptcp/protocol.c | 6 --
Thank you for looking at that!
For MPTCP-related code:
Acked-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belg
Reported-by: Florian Westphal
Fixes: d47a72152097 ("mptcp: fix race in subflow_data_ready()")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/47
Signed-off-by: Davide Caratti
Thank you for the patch!
It looks good to me and it fixes the kselftests on my side as well
79a56-X4O6gS-ns3-ns4-MPTCP-MPTCP-10.0.3.1-10030-listener.pcap
It was a connection from ns3 to ns4, better to start with ns3 then. The
port is also added, easier to find the trace we want.
Co-developed-by: Christoph Paasch
Signed-off-by: Christoph Paasch
Signed-off-by: Matthieu Baerts
---
-> ns3 (dead:beef:3::2:10112) TCP (duration 5422ms) [ OK ]
ns4 TCP -> ns3 (dead:beef:3::2:10113) MPTCP (duration 5423ms) [ OK ]
Time: 296 seconds
Signed-off-by: Florian Westphal
Thank you for adding this very useful feature!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
% -r 0 -e "" -m mmap
Signed-off-by: Florian Westphal
Thank you for the patch! The new '-t' option was also very helpful when
investigating the issue 6 on Github!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
ding to v1
spec")
Signed-off-by: Geliang Tang
Thank you for this v2. It looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 18/06/2020 08:27, Geliang Tang wrote:
On Tue, Jun 16, 2020 at 05:18:56PM +0200, Matthieu Baerts wrote:
On 16/06/2020 08:47, Geliang Tang wrote:
>>
I would suggest you to discuss about that on MPTCP mailing list. We also
have meetings every Thursday. New devs are always w
Hi Geliang
On 16/06/2020 08:47, Geliang Tang wrote:
Add handling for sending and receiving the MP_PRIO, MP_FAIL, and
MP_FASTCLOSE suboptions.
Thank you for the patches!
Unfortunately, I don't think it would be wise to accept them now: for
the moment, these suboptions are ignored at the recep
ot;mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX"
Thank you for this v2, it looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 12/06/2020 07:27, Geliang Tang wrote:
Unify these two duplicate macros into 8.
Thank you for this new patch!
(...)
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 809687d3f410..86d265500cf6 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -135,7
, it looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
ang Tang
---
Changes in v2:
- Add "-net" subject and "Fixes" tag as Matt suggested.
Thanks for this v2! LGTM!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
Because this is a bug-fix for net, may you clearly indicate that in the
subject to help -net maintainers please? [PATCH net v2]
Also, may you add a "Fixes" tag as well as it is for -net ? I guess it
should be:
Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
T
is to remove #ifdef CONFIG_NETDEVICES from net/core/filter.c
and rely on sock_bindtoindex() returning ENOPROTOOPT in the extreme
case of oddly configured kernels.
Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
Suggested-by: Alexei Starovoitov
Signed-off-by:
Hi Alexei,
On 03/06/2020 20:14, Alexei Starovoitov wrote:
On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote:
Hi Ferenc,
On 03/06/2020 10:56, Ferenc Fejes wrote:
Matthieu Baerts ezt írta (időpont:
2020. jún. 3., Sze, 10:11):
A recent commit added new variables only used if
Hi Ferenc,
On 03/06/2020 10:56, Ferenc Fejes wrote:
Matthieu Baerts ezt írta (időpont:
2020. jún. 3., Sze, 10:11):
A recent commit added new variables only used if CONFIG_NETDEVICES is
set.
Thank you for noticing and fixed this!
A simple fix is to only declare these variables if the same
these variables in the related "case" section.
Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
Signed-off-by: Matthieu Baerts
---
Notes:
This fix currently applies on net-next and bpf-next only. Except that
net-next is now closed and -net w
"$err" is a variable pointing to a temp file. "$out" is not: only used
as a local variable in "check()" and representing the output of a
command line.
Fixes: eedbc685321b (selftests: add PM netlink functional tests)
Signed-off-by: Matthieu Baerts
---
too
-block. It also makes
tcpdumps much easier to read when the DSN and DATA_ACK are both either
32 or 64-bit.
Signed-off-by: Christoph Paasch
LGTM, thanks Christoph!
Reviewed-by: Matthieu Baerts
(nearly) duplicated code and eases the
addition of new socket types.
Signed-off-by: Matthieu Baerts
---
net/core/sock.c | 51 +++--
1 file changed, 3 insertions(+), 48 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index 9c6ebbdfebf3
69 matches
Mail list logo
