ies=&submitter=&state=*&q=sctp%3A+Fix+fall-through+warnings+for+Clang&archive=both&delegate=
I can, however, find it in the archives.
https://lore.kernel.org/netdev/20210305090717.GA139387%40embeddedor/T/
Dave and Jakub will know better.
Marcelo
On Mon, Apr 19, 2021 at 05:23:44PM +0200, Davide Caratti wrote:
> when 'act_mirred' tries to fragment IPv4 packets that had been previously
> re-assembled using 'act_ct', splats like the following can be observed on
> kernels built with KASAN:
Acked-by: Marcelo Ricardo Leitner
m/KSPP/linux/issues/109
> Reported-by: kernel test robot
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Marcelo Ricardo Leitner
Thanks.
_lock in sctp_destroy_sock
> instead of sctp_close.
>
> This addresses CVE-2021-23133.
>
> Reported-by: Or Cohen
> Reviewed-by: Xin Long
> Fixes: 610236587600 ("bpf: Add new cgroup attach type to enable sock
> modifications")
> Signed-off-by: Or Cohen
Thanks folks.
Acked-by: Marcelo Ricardo Leitner
) will be called without addr_wq_lock held
*/
Other than this, LGTM. Thanks.
Marcelo
's not a IP_DEFRAG_LOCAL_DELIVER, skb still holds a list
> >>> of fragments with their original size. Maybe we can fragment them based
> >>> on existing skb fragments instead of using the maximum fragment size and
> >>> get the same split as it was be
On Mon, Mar 29, 2021 at 06:21:57PM -0400, Sasha Levin wrote:
> From: liuyacan
>
> [ Upstream commit f211ac154577ec9ccf07c15f18a6abf0d9bdb4ab ]
>
> The "backlog" argument in listen() specifies
> the maximom length of pending connections,
> so the accept queue should be considered full
> if there
ecirc upcall is after the a rule installed
> in tc
> or a rule installed in ovs, as Marcelo mentioned.
Hi Louis,
Not sure if you noticed but both fixes landed in upstream kernel
already.
That's basically:
afa536d8405a ("net/sched: cls_flower: fix only mask bit check in the
validat
On Thu, Mar 25, 2021 at 10:46:12AM +0200, Oz Shlomo wrote:
> Hi Marcelo,
>
> On 3/24/2021 11:20 PM, Marcelo Ricardo Leitner wrote:
> > Maybe I'm just missing it but I'm not seeing how removals would only
> > happen after the entry is actually offloaded. As in, if
On Wed, Mar 24, 2021 at 01:24:53PM +0200, Oz Shlomo wrote:
> Hi,
Hi,
>
> On 3/24/2021 3:38 AM, Pablo Neira Ayuso wrote:
> > Hi Marcelo,
> >
> > On Mon, Mar 22, 2021 at 03:09:51PM -0300, Marcelo Ricardo Leitner wrote:
> > > On Wed, Mar 03, 2021 at 05:11
From: Marcelo Ricardo Leitner
Invalid detection works with two distinct moments: act_ct tries to find
a conntrack entry and set post_ct true, indicating that that was
attempted. Then, when flow dissector tries to dissect CT info and no
entry is there, it knows that it was tried and no entry was
g like this, if I got the idea right, would be even better. If
the entry actually expired before it had a chance of being offloaded,
there is no point in offloading it to then just remove it.
Marcelo
est, and it's worrying about
bits that shouldn't be considered if +inv is there.
I don't see a reason for it to be that restrictive, though, and it
will work as expected.
Reviewed-by: Marcelo Ricardo Leitner
> tb[TCA_FLOWER_KEY_CT_STATE_MASK],
> extack);
> if (err)
> --
> 1.8.3.1
>
et post_ct flag
> which will lead the ct_state_key with -trk flag.
>
> Fixes: 7baf2429a1a9 ("net/sched: cls_flower add CT_FLAGS_INVALID flag
> support")
> Signed-off-by: wenxu
Thanks for the quick fix.
Reviewed-by: Marcelo Ricardo Leitner
&&
> - state & ~(TCA_FLOWER_KEY_CT_FLAGS_TRACKED |
> + if (state_mask & TCA_FLOWER_KEY_CT_FLAGS_INVALID &&
> + state & TCA_FLOWER_KEY_CT_FLAGS_INVALID &&
> + state_mask & ~(TCA_FLOWER_KEY_CT_FLAGS_TRA
Hi there,
On Wed, Mar 10, 2021 at 12:06:52PM +0100, Ilya Maximets wrote:
> Hi, Louis. Thanks for your report!
>
> Marcelo, Paul, could you, please, take a look?
Thanks for the ping.
+wenxu
>
> Best regards, Ilya Maximets.
>
> On 3/10/21 8:51 AM, Louis Peens wrote:
>
On Tue, Feb 23, 2021 at 03:11:55PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Add invalid and reply flags validate in the fl_validate_ct_state.
> This makes the checking complete if compared to ovs'
> validate_ct_state().
>
> Signed-off-by: wenxu
Reviewed-by: Marcelo Ricardo Leitner
On Mon, Feb 22, 2021 at 02:09:50PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Add invalid and reply flags validate in the fl_validate_ct_state.
This makes the checking complete if compared to ovs'
validate_ct_state().
...
> + if (state & TCA_FLOWER_KEY_CT_FLAGS_INVALID &&
> + s
Hi everyone,
Since NetdevConf 0x12 some of us have been meeting to talk about tc
testing. We're taking a next step on that and a) expanding the scope,
so that general development on tc is also welcomed, and b) making it
more public.
The idea is for it to be an open place for brainstorming and
syn
On Tue, Feb 09, 2021 at 06:10:59PM +0200, Or Gerlitz wrote:
> On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote:
> > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote:
> > > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote:
>
> > >> > These operations imply that 7.7.7.5 is configured on some i
tack, tb,
> + "no trk, so no other flag can be set");
I just tested iproute2 and it can't report based on the attr here.
Nonetheless, that would be iproute2 job and not the errmsg, I think.
Reviewed-by: Marcelo Ricardo Leitner
Thanks!
>
On Mon, Feb 08, 2021 at 10:47:59AM -0800, Jakub Kicinski wrote:
> On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote:
> > On Sat, Feb 6, 2021 at 9:26 PM wrote:
> > > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) {
> > > + NL_SET_ERR_MSG_ATTR(extack, tb,
> > > +
On Sun, Feb 07, 2021 at 01:13:23PM +0800, we...@ucloud.cn wrote:
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -30,6 +30,11 @@
>
> #include
>
> +#define TCA_FLOWER_KEY_CT_FLAGS_MASK (TCA_FLOWER_KEY_CT_FLAGS_NEW | \
> + TCA_FLOWER_KEY_CT_F
On Mon, Feb 08, 2021 at 03:31:50PM +0200, Vlad Buslov wrote:
>
> On Mon 08 Feb 2021 at 15:25, Marcelo Ricardo Leitner
> wrote:
> > On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote:
> >>
> >> On Sat 06 Feb 2021 at 20:13, Marcelo Ricard
On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote:
>
> On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner
> wrote:
> > Hi,
> >
> > I didn't receive the cover letter, so I'm replying on this one. :-)
> >
> > This is nice. One thing is
ed on some interface on
the host. Most likely the VF representor itself, as that aids with ARP
resolution. Is that so?
Thanks,
Marcelo
s.
>
> So move the sctp_transport_put() call to ->next and ->stop.
>
> Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and
> interface")
> Reported-by: Xin Long
> Signed-off-by: NeilBrown
Acked-by: Marcelo Ricardo Leitner
On Thu, Feb 04, 2021 at 11:50:53PM +0800, wenxu wrote:
>
> 在 2021/2/4 21:38, Marcelo Ricardo Leitner 写道:
> > Hi,
> >
> > On Thu, Feb 04, 2021 at 12:17:24PM +0800, we...@ucloud.cn wrote:
> >> From: wenxu
> >>
> >> Reject the unknown ct_state
n strip the blank line above.
> Signed-off-by: wenxu
Reviewed-by: Marcelo Ricardo Leitner
Hi,
On Thu, Feb 04, 2021 at 12:17:24PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Reject the unknown ct_state flags of cls flower rules. This also make
> the userspace like ovs to probe the ct_state flags support in the
> kernel.
That's a good start but it could also do some combination sa
On Wed, Feb 03, 2021 at 10:48:16PM -0300, Marcelo Ricardo Leitner wrote:
> From: Marcelo Ricardo Leitner
>
> Often userspace won't request the extack information, or they don't log it
> because of log level or so, and even when they do, sometimes it's not
> enough t
From: Marcelo Ricardo Leitner
Often userspace won't request the extack information, or they don't log it
because of log level or so, and even when they do, sometimes it's not
enough to know exactly what caused the error.
Netlink extack is the standard way of reporting erros w
On Tue, Feb 02, 2021 at 09:16:28AM -0700, David Ahern wrote:
> On 2/2/21 5:30 AM, Marcelo Ricardo Leitner wrote:
> >
> > Also, if the message is a common one, one may not be able to easily
> > distinguish them. Ideally this shouldn't happen, but when debugging
> >
s a header copy, include/uapi/linux/pkt_cls.h.
I think it needs updating as well.
Marcelo
his will require
a firmware update as well?
Thanks,
Marcelo
On Mon, Feb 01, 2021 at 05:34:00PM -0800, Jakub Kicinski wrote:
> On Mon, 1 Feb 2021 15:12:19 -0300 Marcelo Ricardo Leitner wrote:
> > Often userspace won't request the extack information, or they don't log it
> > because of log level or so, and even when they do, sometim
the function
call to do_trace_netlink_extack() on the macros is not protected by
tracepoint_enabled() because the macros are called from modules, and this
would require exporting some trace structs. As this is error path, it's
better to export just the wrapper instead.
Signed-off-by
On Thu, Oct 01, 2020 at 04:47:31PM +0200, Frederic Weisbecker wrote:
> On Wed, Jul 22, 2020 at 02:58:24PM +, Alex Belits wrote:
> > From: Yuri Norov
> >
> > so we don't need to flush it.
>
> What guarantees that we have no backlog on it?
>From Paolo's work to use lockless reading of
per-C
On Tue, Nov 24, 2020 at 12:21:06AM +0100, Frederic Weisbecker wrote:
> On Mon, Nov 23, 2020 at 10:39:34PM +, Alex Belits wrote:
> >
> > On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote:
> > > External Email
> > >
> > > --
On Fri, Jan 22, 2021 at 02:18:34AM +0100, Pablo Neira Ayuso wrote:
> Hi Oz,
>
> On Wed, Jan 20, 2021 at 06:09:48PM +0200, Oz Shlomo wrote:
> > On 1/14/2021 11:50 PM, Marcelo Ricardo Leitner wrote:
> > >
> > > Thoughts?
> > >
> >
> > I wonde
from qdisc_skb_cb(skb)?
In this case, yes, but this way skb_flow_dissect_ct() can/is able to
not care about what the ->cb actually is. It could be called from
somewhere else too.
That's my rationale on it, not sure if wenxu thought the same.
Thanks,
Marcelo
On Wed, Jan 20, 2021 at 10:52:12AM +0800, we...@ucloud.cn wrote:
> +++ b/tc/f_flower.c
> @@ -340,6 +340,7 @@ static struct flower_ct_states {
> { "trk", TCA_FLOWER_KEY_CT_FLAGS_TRACKED },
> { "new", TCA_FLOWER_KEY_CT_FLAGS_NEW },
> { "est", TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED },
>
ermines that the packet is malformed.
• Packets are unexpected length for protocol.
Something like: The packet couldn't be associated to a connection.
> +.TP
> Example: +trk+est
> .RE
> .TP
Thanks,
Marcelo
Acked-by: Marcelo Ricardo Leitner
The patch looks good to me, just some side comments below.
On Tue, Jan 19, 2021 at 04:31:50PM +0800, we...@ucloud.cn wrote:
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3878,6 +3878,7 @@ int dev_loopback_xmit(struct net *net, struct sock *sk,
proute2 changes for flower, with a man page
update as well. Not sure if you planned to post them later on or not,
but it's nice to always have them paired together.
Thanks,
Marcelo
On Thu, Jan 14, 2021 at 04:03:43PM +0200, Oz Shlomo wrote:
>
>
> On 1/14/2021 3:02 PM, Marcelo Ricardo Leitner wrote:
> > On Tue, Jan 12, 2021 at 11:27:04AM +0200, Oz Shlomo wrote:
> > >
> > >
> > > On 1/12/2021 1:51 AM, Marcelo Ricardo Leitner wrote:
On Tue, Jan 12, 2021 at 11:27:04AM +0200, Oz Shlomo wrote:
>
>
> On 1/12/2021 1:51 AM, Marcelo Ricardo Leitner wrote:
> > On Sun, Jan 10, 2021 at 09:52:55AM +0200, Roi Dayan wrote:
> > >
> > >
> > > On 2021-01-10 9:45 AM, Roi Dayan wrote:
> &
on: it doesn't check if optval is big enough when handling
BT_PHY (which has the same value as SCTP_STATUS). It seems also miss a
check on if level != SOL_BLUETOOTH, but I may be wrong here.
l2cap_sock_getsockopt also lacks checking optlen.
Marcelo
On Sun, Jan 10, 2021 at 09:52:55AM +0200, Roi Dayan wrote:
>
>
> On 2021-01-10 9:45 AM, Roi Dayan wrote:
> >
> >
> > On 2021-01-08 11:48 PM, Marcelo Ricardo Leitner wrote:
> > > Hi,
> > >
> > > On Thu, Jan 07, 2021 at 09:30:47P
Hi,
On Thu, Jan 07, 2021 at 09:30:48PM -0800, Saeed Mahameed wrote:
> @@ -1429,6 +1600,14 @@ mlx5_tc_ct_add_ft_cb(struct mlx5_tc_ct_priv *ct_priv,
> u16 zone,
> if (err)
> goto err_insert;
>
> + nf_ct_zone_init(&ctzone, zone, NF_CT_DEFAULT_ZONE_DIR, 0);
> + ft->tmpl
forwarded to the slow
> path table.
AFAICU this new +trk+new ct table is a wildcard match on sport with
specific dports. Also AFAICU, such entries will not be visible to the
userspace then. Is this right?
Marcelo
")
> Signed-off-by: Oz Shlomo
> Reported-by: Marcelo Ricardo Leitner
Tested-by: Marcelo Ricardo Leitner
Thanks.
> Reviewed-by: Roi Dayan
> Reviewed-by: Paul Blakey
> Signed-off-by: Saeed Mahameed
On Mon, Dec 07, 2020 at 12:20:54PM +0200, Oz Shlomo wrote:
> On 12/1/2020 11:41 PM, Saeed Mahameed wrote:
> > On Fri, 2020-11-27 at 11:01 -0300, Marcelo Ricardo Leitner wrote:
...
> > > The same is visible on 'ovs-appctl dpctl/dump-conntrack -s' then.
> > > Sum
On Fri, Nov 27, 2020 at 06:00:32PM -0800, Jakub Kicinski wrote:
> On Thu, 26 Nov 2020 15:40:49 -0300 Marcelo Ricardo Leitner wrote:
> > By setting NF_FLOWTABLE_COUNTER. Otherwise, the updates added by
> > commit ef803b3cf96a ("netfilter: flowtable: add counter support in HW
&
ed only by hw resources constrains. That
said, I'm wondering, can this change be reverted somehow?
Marcelo
3192 ("net/sched: act_ct: update
nf_conn_acct for act_ct SW offload in flowtable") with the check on
NF_FLOWTABLE_COUNTER, as also done on other places.
Note that this shouldn't impact performance as these stats are only
enabled when net.netfilter.nf_conntrack_acct is enabled.
Signe
On Wed, Nov 25, 2020 at 12:01:23PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in cat_ct. But when several
typo ^^^
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will
On Wed, Nov 18, 2020 at 06:07:22PM +0100, Davide Caratti wrote:
> On Wed, 2020-11-18 at 13:47 -0300, Marcelo Ricardo Leitner wrote:
> > On Wed, Nov 18, 2020 at 05:36:52PM +0100, Davide Caratti wrote:
> >
> > Hi,
> >
> > > case TCA_MPLS_ACT_MODIFY:
&g
new_lse = tcf_mpls_get_lse(mpls_hdr(skb), p, false);
> if (skb_mpls_update_lse(skb, new_lse))
> goto drop;
Seems TCA_MPLS_ACT_DEC_TTL is also affected. skb_mpls_dec_ttl() will
also call mpls_hdr(skb) without this check.
Marcelo
isolated/contained as possible, and only so. So thumbs up from my
side.
To be clear, you're only talking about the module itself, right? It
would still need to have the Kconfig to enable this feature, or not?
Thanks,
Marcelo
gt; v1->v2:
> - Also use sctp_transport_put() for the "out_unlock:" path in
> sctp_generate_proto_unreach_event(), as Marcelo noticed.
>
> Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and
> connect()")
> Reported-by:
transport_put(transport);
>
> sctp_transport_put(transport);
Btw, quite noticeable on the above list of timers that only this timer
was using a reference on the asoc. Seems we're good now, then. :-)
Marcelo
On Thu, Nov 12, 2020 at 02:20:58PM -0800, Jakub Kicinski wrote:
> On Thu, 12 Nov 2020 11:24:57 +0800 we...@ucloud.cn wrote:
> > v7-v10: fix __rcu warning
>
> Are you reposting stuff just to get it build tested?
>
> This is absolutely unacceptable.
I don't know if that's the case, but maybe we c
he last one add implict packet fragment support to fix the over mtu for
> defrag in act_ct.
Acked-by: Marcelo Ricardo Leitner
he last one add implict packet fragment support to fix the over mtu for
> defrag in act_ct.
Acked-by: Marcelo Ricardo Leitner
On Mon, Nov 09, 2020 at 05:47:46PM +0200, Vlad Buslov wrote:
>
> On Mon 09 Nov 2020 at 16:50, Marcelo Ricardo Leitner
> wrote:
> > On Mon, Nov 09, 2020 at 03:24:37PM +0200, Vlad Buslov wrote:
> >> On Sun 08 Nov 2020 at 01:30, we...@ucloud.cn wrote:
...
> >>
t; +int tcf_set_xmit_hook(int (*xmit_hook)(struct sk_buff *skb,
> > + int (*xmit)(struct sk_buff *skb)))
> > +{
> > + if (!tcf_xmit_hook_enabled())
> > + xchg(&tcf_xmit_hook, xmit_hook);
>
> Marcelo, why did you suggest to use atomic ope
On Fri, Nov 06, 2020 at 10:48:24AM +0100, Petr Malat wrote:
> On Fri, Nov 06, 2020 at 05:46:34AM -0300, Marcelo Ricardo Leitner wrote:
> > On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote:
> > > Function sctp_dst_mtu() never returns lower MTU than
he frag xmit hook maybe reused by other modules.
>
> Signed-off-by: wenxu
Acked-by: Marcelo Ricardo Leitner
Thanks wenxu.
On Fri, Nov 06, 2020 at 05:14:15PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> This one is prepare for the next patch.
>
> Signed-off-by: wenxu
Acked-by: Marcelo Ricardo Leitner
On Thu, Nov 05, 2020 at 06:41:33PM +0800, we...@ucloud.cn wrote:
> From: wenxu
I see Davide's and Jakub's comments. Other than those, I don't have
further comments. LGTM!
On Thu, Nov 05, 2020 at 11:39:47AM +0100, Petr Malat wrote:
> Function sctp_dst_mtu() never returns lower MTU than
> SCTP_TRUNC4(SCTP_DEFAULT_MINSEGMENT) even when the actual MTU is less,
> in which case we rely on the IP fragmentation and must enable it.
This should be being handled at sctp_packe
On Thu, Nov 05, 2020 at 03:52:27PM +0800, we...@ucloud.cn wrote:
We cross-posted :)
I think my comments on the v1 still applies, btw.
...
> This patch add support for a xmit hook to mirred, that gets executed before
> xmiting the packet. Then, when act_ct gets loaded, it configs that hook.
> The
On Wed, Nov 04, 2020 at 04:56:32PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in cat_ct. But when several
^^^ typo
I like where this is going. More comments below.
> fragment packets go throu
appspotmail.com
> Fixes: a1dd2cf2f1ae ("sctp: allow changing transport encap_port by peer
> packets")
> Signed-off-by: Xin Long
Acked-by: Marcelo Ricardo Leitner
Thanks Xin.
On Wed, Nov 04, 2020 at 06:36:08PM +0100, Paolo Abeni wrote:
> On Tue, 2020-11-03 at 08:52 -0800, Jakub Kicinski wrote:
> > On Tue, 03 Nov 2020 16:22:07 +0100 Paolo Abeni wrote:
> > > The relevant use case is an host running containers (with the related
> > > orchestration tools) in a RT environmen
y: Petr Malat
Then, it also needs:
Fixes: 978aa0474115 ("sctp: fix some type cast warnings introduced since very
beginning")'
Acked-by: Marcelo Ricardo Leitner
(If the maintainers can't add the Fixes tag above, please keep the ack
on the v2)
Thanks.
On Thu, Oct 29, 2020 at 07:59:36PM -0300, Marcelo Ricardo Leitner wrote:
> Cc'ing Cong, Paul, Oz and Davide.
>
> On Thu, Oct 29, 2020 at 10:22:04AM +0800, wenxu wrote:
> > Only do gso for the reassembly big packet is also can't fix all the
> > case such for icmp pac
h a static branch key.
This leaves mirred almost untouched, 0 performance penalty for those
that don't use act_ct, can even have a Kconfig knob, is not CT or
ipfrag specific code on mirred so it's reusable later on and solves
our problem here. Thoughts?
Marcelo
rnel.
Acked-by: Marcelo Ricardo Leitner
Thanks Xin!
her than possibly causing
drop_watch to miss drops (by not listening to the new trace point).
Marcelo
m...
> >
> > But I still think that for curing that isolation stuff we want at least
> > some information from the driver. Alternative solution would be to grant
> > the allocation of interrupts and queues and have some sysfs knob to shut
> > down queues at runtime. If
On Mon, Oct 26, 2020 at 08:00:39PM +0100, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 14:30, Marcelo Tosatti wrote:
> > On Fri, Oct 23, 2020 at 11:00:52PM +0200, Thomas Gleixner wrote:
> >> So without information from the driver which tells what the best number
> >&
On Fri, Oct 23, 2020 at 11:00:52PM +0200, Thomas Gleixner wrote:
> On Fri, Oct 23 2020 at 09:10, Nitesh Narayan Lal wrote:
> > On 10/23/20 4:58 AM, Peter Zijlstra wrote:
> >> On Thu, Oct 22, 2020 at 01:47:14PM -0400, Nitesh Narayan Lal wrote:
> >> So shouldn't we then fix the drivers / interface fi
On Wed, Oct 21, 2020 at 10:25:48PM +0200, Thomas Gleixner wrote:
> On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote:
> > On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote:
> >> However, IMHO we would still need a logic to prevent the devices from
> >> creating excess vectors.
> >
> > Manage
On Tue, Oct 20, 2020 at 10:08:17PM +, David Laight wrote:
> From: Marcelo Ricardo Leitner
> > Sent: 20 October 2020 22:24
> ...
> > > > Did FreeBSD enable it by default too?
> > > No. The default is 0, which means that the encapsulation is turned off.
> &
On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote:
> > On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner
> > wrote:
> >
> > On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote:
> >> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner
>
On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote:
> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner
> wrote:
> >
> > On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote:
> > > --- a/Documentation/networking/ip-sysctl.rst
> > > +++ b/Do
Ah, please note that net-next is closed.
https://lore.kernel.org/netdev/20201015123116.743005ca%40kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/T/
Marcelo
On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote:
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2640,6 +2640,12 @@ addr_scope_policy - INTEGER
>
> Default: 1
>
> +udp_port - INTEGER
Need to be more verbose here, and also menti
On Mon, Oct 19, 2020 at 08:25:24PM +0800, Xin Long wrote:
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2640,6 +2640,15 @@ addr_scope_policy - INTEGER
>
> Default: 1
>
> +encap_port - INTEGER
> + The default remote UDP encapsalutio
On Mon, Oct 19, 2020 at 01:11:37PM +0200, Peter Zijlstra wrote:
> On Sun, Oct 18, 2020 at 02:14:46PM -0400, Nitesh Narayan Lal wrote:
> > >> +hk_cpus = housekeeping_num_online_cpus(HK_FLAG_MANAGED_IRQ);
> > >> +
> > >> +/*
> > >> + * If we have isolated CPUs for use by real-
Actually..
On Tue, Oct 13, 2020 at 03:27:41PM +0800, Xin Long wrote:
...
> Also add sysctl udp_port to allow changing the listening
> sock's port by users.
...
> ---
> net/sctp/protocol.c | 5 +
> net/sctp/sysctl.c | 50 ++
> 2 files changed,
implementation if the operating system does not
> > provide one.
>
> Marcelo, Neil - please review if you want this one to make 5.10.
On the works!
> Otherwise we can defer until after the merge window.
Probably not needed.
Thanks,
Marcelo
On Thu, Oct 08, 2020 at 01:38:31AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet
>
> After freeing ep->auth_hmacs we have to clear the pointer
> or risk use-after-free as reported by syzbot:
>
Acked-by: Marcelo Ricardo Leitner
On Sat, Oct 03, 2020 at 08:24:34PM +0800, Xin Long wrote:
> On Sat, Oct 3, 2020 at 7:23 PM Xin Long wrote:
> >
> > On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote:
> > >
> > > On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitner
> > > wrote:
> >
On Tue, Sep 29, 2020 at 09:49:07PM +0800, Xin Long wrote:
> This patch is to enable udp tunneling socks by calling
> sctp_udp_sock_start() in sctp_ctrlsock_init(), and
> sctp_udp_sock_stop() in sctp_ctrlsock_exit().
>
> Also add sysctl udp_port to allow changing the listening
> sock's port by user
On Tue, Sep 29, 2020 at 09:49:04PM +0800, Xin Long wrote:
> sk_setup_caps() was originally called in Commit 90017accff61 ("sctp:
> Add GSO support"), as:
>
> "We have to refresh this in case we are xmiting to more than one
>transport at a time"
>
> This actually happens in the loop of sctp_
On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote:
> Hi Xin,
>
> Thank you for the patch! Yet something to improve:
I wonder how are you planning to fix this. It is quite entangled.
This is not performance critical. Maybe the cleanest way out is to
move it to a .c file.
Adding a
On Tue, Sep 29, 2020 at 09:49:03PM +0800, Xin Long wrote:
> sctp_mtu_payload() is for calculating the frag size before making
> chunks from a msg. So we should only add udphdr size to overhead
> when udp socks are listening, as only then sctp can handling the
1 - 100 of 1404 matches
Mail list logo
