On Mon, Jan 18, 2021 at 01:18:47PM +0800, we...@ucloud.cn wrote: ... > --- a/net/sched/cls_flower.c > +++ b/net/sched/cls_flower.c > @@ -305,6 +305,9 @@ static int fl_classify(struct sk_buff *skb, const struct > tcf_proto *tp, > struct fl_flow_key skb_key; > struct fl_flow_mask *mask; > struct cls_fl_filter *f; > + bool post_ct; > + > + post_ct = qdisc_skb_cb(skb)->post_ct;
Patch-wise, only here I think you could initialize post_ct right on the declaration. No need for the extra line/block of lines here. But I'm missing the iproute2 changes for flower, with a man page update as well. Not sure if you planned to post them later on or not, but it's nice to always have them paired together. Thanks, Marcelo
