RE: [PATCH net] dpaa_eth: fix the access method for the dpaa_napi_portal

2021-02-19 Thread Madalin Bucur (OSS)
> -Original Message- > From: Camelia Alexandra Groza > Sent: 18 February 2021 20:21 > To: k...@kernel.org; da...@davemloft.net; s.ha...@pengutronix.de > Cc: bro...@redhat.com; Madalin Bucur (OSS) ; > netdev@vger.kernel.org; Camelia Alexandra Groza > Subject: [PATCH n

RE: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP

2021-02-05 Thread Madalin Bucur (OSS)
> -Original Message- > From: Camelia Alexandra Groza > Sent: 04 February 2021 18:49 > To: k...@kernel.org; da...@davemloft.net; maciej.fijalkow...@intel.com > Cc: Madalin Bucur (OSS) ; > netdev@vger.kernel.org; Camelia Alexandra Groza > Subject: [PATCH net v2 0

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 10 December 2020 12:06 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 10 December 2020 10:49 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 09 December 2020 16:17 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource

RE: [PATCH net-next] net: freescale: dpaa: simplify the return dpaa_eth_refill_bpools()

2020-12-09 Thread Madalin Bucur (OSS)
> -Original Message- > From: Zheng Yongjun > Sent: 09 December 2020 11:21 > To: da...@davemloft.net; netdev@vger.kernel.org > Cc: k...@kernel.org; linux-ker...@vger.kernel.org; Madalin Bucur > ; Zheng Yongjun > Subject: [PATCH net-next] net: freescale: dpaa

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 08 December 2020 16:56 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource

RE: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Madalin Bucur (OSS)
> -Original Message- > From: Arnd Bergmann > Sent: 04 December 2020 01:21 > To: Mark Einon ; David S. Miller > ; Jakub Kicinski ; Nicolas Ferre > ; Claudiu Beznea > ; Madalin Bucur ; > Saeed Mahameed ; Leon Romanovsky ; > Simon Horman ; Jiri Pirko &

RE: [PATCH] dpaa_eth: fix build errorr in dpaa_fq_init

2020-12-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Anders Roxell > Sent: 03 December 2020 16:44 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org; a...@kernel.org; dan...@iogearbox.net; h...@kernel.org; > john.fastab...@gmail.com > Cc: netdev@vger.kernel.org; linux-ker...

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-03 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 03 December 2020 15:51 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Patrick Havelange > Subject: [PATCH net 1/4] net: freescale/fman:

RE: [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 02 December 2020 18:16 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Patrick Havelange > Subject: [PATCH 2/4] net: freescale/fman-po

RE: [PATCH net-next v2 0/7] dpaa_eth: add XDP support

2020-11-16 Thread Madalin Bucur (OSS)
> From: Camelia Groza > To: k...@kernel.org; bro...@redhat.com; sa...@kernel.org; > da...@davemloft.net > Cc: Madalin Bucur (OSS) ; Ioana Ciornei > ; netdev@vger.kernel.org; Camelia Alexandra Groza > > Subject: [PATCH net-next v2 0/7] dpaa_eth: add XDP support > >

RE: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent

2020-11-11 Thread Madalin Bucur
> -Original Message- > From: linux-arm-kernel On > Behalf Of Shawn Guo > To: Madalin Bucur (OSS) > Subject: Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are > coherent > > On Mon, Oct 05, 2020 at 03:46:39PM +0300, Madalin Bucur wrote: > > Although

RE: [PATCH V2] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-06 Thread Madalin Bucur (OSS)
> -Original Message- > From: Jakub Kicinski > Sent: 05 November 2020 03:31 > To: Yu Kuai > Cc: Madalin Bucur ; da...@davemloft.net; Florinel > Iordache ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; yi.zh...@huawei.com > Subject: Re: [PATCH V

RE: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes

2020-11-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Camelia Groza > Sent: 02 November 2020 20:35 > To: willemdebruijn.ker...@gmail.com; Madalin Bucur (OSS) > ; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; Camelia Alexandra Groza > Subject: [PATCH net v3 0/2] dpaa_eth

RE: [PATCH -next] dpaa_eth: use false and true for bool variables

2020-11-03 Thread Madalin Bucur
> -Original Message- > From: Zou Wei > Sent: 03 November 2020 14:05 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Zou Wei > > Subject: [PATCH -next] dpaa_eth: use false and true for

RE: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup.

2020-11-03 Thread Madalin Bucur
> -Original Message- > From: Sebastian Andrzej Siewior > Sent: 02 November 2020 01:23 > To: netdev@vger.kernel.org > Cc: Horia Geanta ; Aymen Sghaier > ; Herbert Xu ; David S. > Miller ; Madalin Bucur ; Jakub > Kicinski ; Leo Li ; Thomas Gleixner > ; Sebastian

RE: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

2020-10-08 Thread Madalin Bucur (OSS)
; + NETIF_MSG_IFDOWN | NETIF_MSG_HW) > > #define DPAA_INGRESS_CS_THRESHOLD 0x1000 > /* Ingress congestion threshold on FMan ports > -- > 2.25.1 Reviewed-by: Madalin Bucur

[PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent

2020-10-05 Thread Madalin Bucur
Although the DPAA 1 FMan operations are coherent, the device tree node for the FMan does not indicate that, resulting in a needless loss of performance. Adding the missing dma-coherent property. Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes") Signed-off-by: Madalin Bucur

[PATCH] dt-bindings: net: correct description of phy-connection-type

2020-08-20 Thread Madalin Bucur
The phy-connection-type parameter is described in ePAPR 1.1: Specifies interface type between the Ethernet device and a physical layer (PHY) device. The value of this property is specific to the implementation. Signed-off-by: Madalin Bucur --- Documentation/devicetree/bindings/net/ethernet

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Russell King - ARM Linux admin > Sent: 03 August 2020 19:54 > To: Madalin Bucur (OSS) > Cc: Andrew Lunn ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ;

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Russell King - ARM Linux admin > Sent: 03 August 2020 17:10 > To: Madalin Bucur (OSS) > Cc: Andrew Lunn ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ;

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Andrew Lunn > Sent: 03 August 2020 15:58 > To: Madalin Bucur (OSS) > Cc: Russell King - ARM Linux admin ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ;

RE: [PATCH RFC net-next 2/3] net: phy: Move into subdirectories

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Andrew Lunn > Sent: 27 July 2020 23:48 > To: netdev > Cc: Ioana Ciornei ; Florian Fainelli > ; Russell King ; Heiner > Kallweit ; Andrew Lunn > Subject: [PATCH RFC net-next 2/3] net: phy: Move into subdirectories >

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Russell King - ARM Linux admin > Sent: 03 August 2020 12:07 > To: Madalin Bucur (OSS) > Cc: Andrew Lunn ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ;

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
S) > ; kuldip dwivedi > ; Madalin Bucur (OSS) > ; Vikas Singh > Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY > > On Sat, Aug 01, 2020 at 10:41:32AM +0100, Russell King - ARM Linux admin > wrote: > > On Sat, Aug 01, 2020 at 09:52:52AM +0530, Vikas

RE: [PATCH net v3 0/5] DPAA FMan driver fixes

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Florinel Iordache > Sent: 03 August 2020 10:07 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org; netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; Florinel Iordache > &g

RE: [PATCH net 4/5] fsl/fman: check dereferencing null pointer

2020-07-31 Thread Madalin Bucur
> -Original Message- > From: Florinel Iordache > Sent: 31 July 2020 09:46 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org; netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; Florinel Iordache > > Subject: [PATCH net 4/5] fsl/fman: check de

RE: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY under &mdio0 label

2020-07-22 Thread Madalin Bucur (OSS)
ozlabs.org; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; Madalin Bucur (OSS) ; > Radu-andrei Bulie ; fido_...@inbox.ru > Subject: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY > under &mdio0 label > > We're going to add 8 more PHYs in a future patch. It is e

RE: [PATCH v2 net] dpaa_eth: Fix one possible memleak in dpaa_eth_probe

2020-07-20 Thread Madalin Bucur (OSS)
> -Original Message- > From: Liu Jian > Sent: Monday, July 20, 2020 5:28 PM > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org; Laurentiu Tudor ; > netdev@vger.kernel.org > Subject: [PATCH v2 net] dpaa_eth: Fix one possible memleak in >

RE: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

2020-06-22 Thread Madalin Bucur (OSS)
vger.kernel.org; robh...@kernel.org; mark.rutl...@arm.com; > k...@kernel.org; cor...@lwn.net; shawn...@kernel.org; Leo Li > ; Madalin Bucur (OSS) ; > Ioana Ciornei ; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver > support > >

RE: [net-next PATCH v2 1/3] net: phy: Allow mdio buses to auto-probe c45 devices

2020-06-22 Thread Madalin Bucur (OSS)
> -Original Message- > From: Calvin Johnson (OSS) > Sent: Monday, June 22, 2020 11:19 AM > To: Jeremy Linton ; Russell King - ARM Linux admin > ; Jon ; Cristi Sovaiala > ; Ioana Ciornei ; Andrew > Lunn ; Andy Shevchenko ; > Florian Fainelli ; Madalin Bu

RE: [PATCH] dpaa_eth: fix usage as DSA master, try 3

2020-05-25 Thread Madalin Bucur (OSS)
> -Original Message- > From: Vladimir Oltean > Sent: Monday, May 25, 2020 12:23 AM > To: da...@davemloft.net > Cc: and...@lunn.ch; f.faine...@gmail.com; vivien.dide...@gmail.com; > Madalin Bucur (OSS) ; netdev@vger.kernel.org > Subject: [PATCH] dpaa_eth: fix usage

[PATCH net-next v3 3/7] dpaa_eth: remove redundant code

2019-10-23 Thread Madalin Bucur
Condition was previously checked, removing duplicate code. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

[PATCH net-next v3 4/7] fsl/fman: add API to get the device behind a fman port

2019-10-23 Thread Madalin Bucur
From: Laurentiu Tudor Add an API that retrieves the 'struct device' that the specified FMan port probed against. The new API will be used in a subsequent patch that corrects the DMA devices used by the dpaa_eth driver. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --

[PATCH net-next v3 2/7] dpaa_eth: defer probing after qbman

2019-10-23 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index b4b82b9c5cd6..75eeb2ef409f 100644

[PATCH net-next v3 7/7] dpaa_eth: add newline in dev_err() msg

2019-10-23 Thread Madalin Bucur
Newline was missing at the end of the error message. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa

[PATCH net-next v3 0/7] DPAA Ethernet changes

2019-10-23 Thread Madalin Bucur
code. Laurentiu Tudor (3): fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs dpaa_eth: defer probing after qbman fsl/fman: add API to get the device behind a fman port Madalin Bucur (4): dpaa_eth: remove redundant code dpaa_eth: change DMA device fsl/fman: remove unu

[PATCH net-next v3 6/7] fsl/fman: remove unused struct member

2019-10-23 Thread Madalin Bucur
Remove unused struct member second_largest_buf_size. Also, an out of bounds access would have occurred in the removed code if there was only one buffer pool in use. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_port.c | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH net-next v3 5/7] dpaa_eth: change DMA device

2019-10-23 Thread Madalin Bucur
. Signed-off-by: Madalin Bucur Signed-off-by: Laurentiu Tudor --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 105 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 8 +- 2 files changed, 62 insertions(+), 51 deletions(-) diff --git a/drivers/net/ethernet/freescale

[PATCH net-next v3 1/7] fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs

2019-10-23 Thread Madalin Bucur
From: Laurentiu Tudor The liodn base registers are specific to PAMU based NXP systems and are reserved on SMMU based ones. Don't access them unless PAMU is compiled in. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 6

[PATCH net-next v2 6/6] fsl/fman: remove unused struct member

2019-10-22 Thread Madalin Bucur
Remove unused struct member second_largest_buf_size. Also, an out of bounds access would have occurred in the removed code if there was only one buffer pool in use. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_port.c | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH net-next v2 4/6] fsl/fman: add API to get the device behind a fman port

2019-10-22 Thread Madalin Bucur
From: Laurentiu Tudor Add an API that retrieves the 'struct device' that the specified FMan port probed against. The new API will be used in a subsequent patch that corrects the DMA devices used by the dpaa_eth driver. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --

[PATCH net-next v2 5/6] dpaa_eth: change DMA device

2019-10-22 Thread Madalin Bucur
. Signed-off-by: Madalin Bucur Signed-off-by: Laurentiu Tudor --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 105 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 8 +- 2 files changed, 62 insertions(+), 51 deletions(-) diff --git a/drivers/net/ethernet/freescale

[PATCH net-next v2 2/6] dpaa_eth: defer probing after qbman

2019-10-22 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index b4b82b9c5cd6..75eeb2ef409f 100644

[PATCH net-next v2 3/6] dpaa_eth: remove redundant code

2019-10-22 Thread Madalin Bucur
Condition was previously checked, removing duplicate code. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

[PATCH net-next v2 0/6] DPAA Ethernet changes

2019-10-22 Thread Madalin Bucur
27;t touch liodn base regs reserved on non-PAMU SoCs dpaa_eth: defer probing after qbman fsl/fman: add API to get the device behind a fman port Madalin Bucur (3): dpaa_eth: remove redundant code dpaa_eth: change DMA device fsl/fman: remove unused struct member drivers/net/ethernet/free

[PATCH net-next v2 1/6] fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs

2019-10-22 Thread Madalin Bucur
From: Laurentiu Tudor The liodn base registers are specific to PAMU based NXP systems and are reserved on SMMU based ones. Don't access them unless PAMU is compiled in. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 6

[PATCH 08/20] dpaa_eth: use page backed rx buffers

2019-10-08 Thread Madalin Bucur
Change the buffers used for reception from netdev_frags to pages. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 51 +++--- 1 file changed, 22 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b

[PATCH 01/20] fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs

2019-10-08 Thread Madalin Bucur
From: Laurentiu Tudor The liodn base registers are specific to PAMU based NXP systems and are reserved on SMMU based ones. Don't access them unless PAMU is compiled in. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 6

[PATCH 04/20] fsl/fman: add API to get the device behind a fman port

2019-10-08 Thread Madalin Bucur
From: Laurentiu Tudor Add an API that retrieves the 'struct device' that the specified FMan port probed against. The new API will be used in a subsequent patch that corrects the DMA devices used by the dpaa_eth driver. Signed-off-by: Laurentiu Tudor Signed-off-by: Madalin Bucur --

[PATCH 11/20] dpaa_eth: simplify variables used in dpaa_cleanup_tx_fd()

2019-10-08 Thread Madalin Bucur
Avoid casts and repeated conversions. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa

[PATCH 13/20] dpaa_eth: use a page to store the SGT

2019-10-08 Thread Madalin Bucur
Use a page to store the scatter gather table on the transmit path. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 43 +- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b

[PATCH] dpaa_eth: NETIF_F_LLTX requires to do our own update of trans_start

2019-01-17 Thread Madalin Bucur
As txq_trans_update() only updates trans_start when the lock is held, trans_start does not get updated if NETIF_F_LLTX is declared. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet

[PATCH] soc: fsl: qbman: avoid race in clearing QMan interrupt

2018-12-21 Thread Madalin Bucur
By clearing all interrupt sources, not only those that already occurred, the existing code may acknowledge by mistake interrupts that occurred after the code checks for them. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 9 + 1 file changed

[PATCH v2] fsl/fman: remove unnecessary set_dma_ops() call and HAS_DMA dependency

2018-03-23 Thread Madalin Bucur
The platform device is no longer used for DMA mapping so the (questionable) setting of the DMA ops done here is no longer needed. Removing it together with the HAS_DMA dependency that it required. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 1 - drivers/net

[PATCH] fsl/fman: remove unnecessary set_dma_ops() call and HAS_DMA dependency

2018-03-21 Thread Madalin Bucur
The platform device is no longer used for DMA mapping so the (questionable) setting of the DMA ops done here is no longer needed. Removing it together with the HAS_DMA dependency that it required. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 1 - drivers/net

[PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread Madalin Bucur
couple of error counter fixes, a duplicated init in dpaa_eth. Madalin Camelia Groza (3): dpaa_eth: remove duplicate initialization dpaa_eth: increment the RX dropped counter when needed dpaa_eth: remove duplicate increment of the tx_errors counter Madalin Bucur (2): soc/fsl/qbman: fix

[PATCH 1/5] soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

2018-03-14 Thread Madalin Bucur
The wait_for_completion() call in qman_delete_cgr_safe() was triggering a scheduling while atomic bug, replacing the kthread with a smp_call_function_single() call to fix it. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 28

[PATCH 3/5] dpaa_eth: remove duplicate initialization

2018-03-14 Thread Madalin Bucur
From: Camelia Groza The fd_format has already been initialized at this point. Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa

[PATCH 2/5] dpaa_eth: fix error in dpaa_remove()

2018-03-14 Thread Madalin Bucur
The recent changes that make the driver probing compatible with DSA were not propagated in the dpa_remove() function, breaking the module unload function. Using the proper device to address the issue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file

[PATCH 4/5] dpaa_eth: increment the RX dropped counter when needed

2018-03-14 Thread Madalin Bucur
From: Camelia Groza Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 3e83d79..76b3c9e 1006

[PATCH 5/5] dpaa_eth: remove duplicate increment of the tx_errors counter

2018-03-14 Thread Madalin Bucur
From: Camelia Groza The tx_errors counter is incremented by the dpaa_xmit caller. Signed-off-by: Camelia Groza Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b

[net-next v2 1/4] dpaa_eth: fix SG mapping

2018-02-26 Thread Madalin Bucur
An issue in the code mapping the skb fragments into scatter-gather frames was evidentiated by netperf TCP_SENDFILE tests. The size was set wrong for all fragments but the first, affecting the transmission of any skb with more than one fragment. Signed-off-by: Madalin Bucur --- drivers/net

[net-next v2 0/4] DPAA Ethernet fixes

2018-02-26 Thread Madalin Bucur
Fixed an issue on the Tx path that was visible in netperf TCP_SENDFILE tests. Addressed another issue with Rx errors not being always counted. Adding control for allmulti. v2: rephrased commit message, reduced changes in the SG mapping fix Madalin Bucur (3): dpaa_eth: fix SG mapping dpaa_eth

[net-next v2 3/4] dpaa_eth: refactor frag count checking

2018-02-26 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index bdf57fe..9bd0ff0 100644

[net-next v2 4/4] dpaa_eth: Add allmulti option

2018-02-26 Thread Madalin Bucur
From: Radu Bulie This patch adds allmulticast option for memac, dtsec and 10GEC controllers. Signed-off-by: Radu Bulie --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 10 +++ drivers/net/ethernet/freescale/fman/fman_dtsec.c | 19 ++ drivers/net/ethernet/freescale/fman/fm

[net-next v2 2/4] dpaa_eth: make sure all Rx errors are counted

2018-02-26 Thread Madalin Bucur
Simplify the code and avoid some Rx errors not being accounted. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet

[PATCH net-next 0/4] DPAA Ethernet fixes

2018-02-19 Thread Madalin Bucur
Fixed an issue on the Tx path that was visible in netperf TCP_SENDFILE tests. Addressed another issue with Rx errors not being always counted. Adding control for allmulti. Madalin Bucur (3): dpaa_eth: fix SG mapping dpaa_eth: make sure all Rx errors are counted dpaa_eth: refactor frag

[PATCH net-next 2/4] dpaa_eth: make sure all Rx errors are counted

2018-02-19 Thread Madalin Bucur
Simplify the code and avoid some Rx errors not being accounted. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet

[PATCH net-next 4/4] dpaa_eth: Add allmulti option

2018-02-19 Thread Madalin Bucur
From: Radu Bulie This patch adds allmulticast option for memac, dtsec and 10GEC controllers. Signed-off-by: Radu Bulie --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 10 +++ drivers/net/ethernet/freescale/fman/fman_dtsec.c | 19 ++ drivers/net/ethernet/freescale/fman/fm

[PATCH net-next 1/4] dpaa_eth: fix SG mapping

2018-02-19 Thread Madalin Bucur
An issue in the code mapping the skb fragments into scatter-gather frames was evidentiated by netperf TCP_SENDFILE tests. This patch addresses the issue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 27 ++ 1 file changed, 15

[PATCH net-next 3/4] dpaa_eth: refactor frag count checking

2018-02-19 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 5e43840..2f53e8b 100644

[PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing

2018-01-09 Thread Madalin Bucur
If one of the child devices is missing the of_mdiobus_register_phy() call will return -ENODEV. When a missing device is encountered the registration of the remaining PHYs is stopped and the MDIO bus will fail to register. Propagate all errors except ENODEV to avoid it. Signed-off-by: Madalin

[PATCH net, v2] of_mdio: avoid MDIO bus removal when a PHY is missing

2018-01-09 Thread Madalin Bucur
If one of the child devices is missing the of_mdiobus_register_phy() call will return -ENODEV. When a missing device is encountered the registration of the remaining PHYs is stopped and the MDIO bus will fail to register. Propagate all errors except ENODEV to avoid it. Signed-off-by: Madalin

[PATCH net] of_mdio: avoid MDIO bus removal when a PHY is missing

2018-01-05 Thread Madalin Bucur
If one of the child devices is missing the of_mdiobus_register_phy() call will return -ENODEV. When a missing device is encountered the registration of the remaining PHYs is stopped and the MDIO bus will fail to register. Propagate all errors except ENODEV to avoid it. Signed-off-by: Madalin

[PATCH v3 1/6] fsl/fman: remove of_node

2017-10-16 Thread Madalin Bucur
-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/

[PATCH v3 0/6] adapt DPAA drivers for DSA

2017-10-16 Thread Madalin Bucur
leanup the dpaa_eth_probe() error paths Changes in v3: - remove obsolete comment in moved code - add explanation for module rename Madalin Bucur (6): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver dpaa_eth: change device used dpaa_eth: cleanup dpaa_eth_probe() e

[PATCH v3 4/6] dpaa_eth: cleanup dpaa_eth_probe() error paths

2017-10-16 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 53 ++ 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 823aa65..c6b97a1

[PATCH v3 5/6] fsl/fman: add dpaa in module names

2017-10-16 Thread Madalin Bucur
the DSA probing makes the previous rules written using this prefix fail, this change makes them work again, ensuring backwards compatibility for their users. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v3 2/6] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-16 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++-- drivers/net/ethernet/freescale/fman/mac.c | 97 ++ drivers/net/ethernet/freescale/fman/mac.h | 5 +- 3 files changed, 66 insertions(+), 84 deletions(-) diff

[PATCH v3 6/6] dpaa_eth: remove obsolete comment

2017-10-16 Thread Madalin Bucur
Comment is no longer valid for a long time now. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index c6b97a1

[PATCH v3 3/6] dpaa_eth: change device used

2017-10-16 Thread Madalin Bucur
Change device used for DMA mapping to the MAC device that is an of_device, with proper DMA ops. Using this device for the netdevice should also address the issue with DSA scenarios that need the netdevice to be backed by an of_device. Signed-off-by: Madalin Bucur --- drivers/net/ethernet

[PATCH v2 0/5] adapt DPAA drivers for DSA

2017-10-13 Thread Madalin Bucur
leanup the dpaa_eth_probe() error paths Madalin Bucur (5): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver dpaa_eth: change device used dpaa_eth: cleanup dpaa_eth_probe() error paths fsl/fman: add dpaa in module names drivers/net/ethernet/freescale/dpaa/dpaa_e

[PATCH v2 1/5] fsl/fman: remove of_node

2017-10-13 Thread Madalin Bucur
-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/

[PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++-- drivers/net/ethernet/freescale/fman/mac.c | 97 ++ drivers/net/ethernet/freescale/fman/mac.h | 5 +- 3 files changed, 66 insertions(+), 84 deletions(-) diff

[PATCH v2 4/5] dpaa_eth: cleanup dpaa_eth_probe() error paths

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 53 ++ 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 823aa65..c6b97a1

[PATCH v2 5/5] fsl/fman: add dpaa in module names

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile index 2c38119..4ae524a 100644 --- a/drivers

[PATCH v2 3/5] dpaa_eth: change device used

2017-10-13 Thread Madalin Bucur
Change device used for DMA mapping to the MAC device that is an of_device, with proper DMA ops. Using this device for the netdevice should also address the issue with DSA scenarios that need the netdevice to be backed by an of_device. Signed-off-by: Madalin Bucur --- drivers/net/ethernet

[PATCH 1/4] fsl/fman: remove of_node

2017-10-10 Thread Madalin Bucur
-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/

[PATCH 0/4] adapt DPAA drivers for DSA

2017-10-10 Thread Madalin Bucur
(). Several changes were required to enable this solution: refactoring the adjust_link (also resulted in lesser, cleaner code) and renaming the fman kernel modules to keep the legacy udev rules happy. Madalin Bucur (4): fsl/fman: remove of_node dpaa_eth: move of_phy_connect() to the eth driver

[PATCH 4/4] fsl/fman: add dpaa in module names

2017-10-10 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile index 2c38119..4ae524a 100644 --- a/drivers

[PATCH 3/4] dpaa_eth: change device used

2017-10-10 Thread Madalin Bucur
Change device used for DMA mapping to the MAC device that is an of_device, with proper DMA ops. Using this device for the netdevice should also address the issue with DSA scenarios that need the netdevice to be backed by an of_device. Signed-off-by: Madalin Bucur --- drivers/net/ethernet

[PATCH 2/4] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-10 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++-- drivers/net/ethernet/freescale/fman/mac.c | 97 ++ drivers/net/ethernet/freescale/fman/mac.h | 5 +- 3 files changed, 66 insertions(+), 84 deletions(-) diff

[PATCH] fsl/fman: remove of_node

2017-10-02 Thread Madalin Bucur
-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/

[PATCH v4 4/7] dpaa_eth: enable Rx hashing control

2017-08-27 Thread Madalin Bucur
Allow ethtool control of the Rx flow hashing. By default RSS is enabled, this allows to turn it off by bypassing the FMan Keygen block and sending all traffic on the default Rx frame queue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 113

[PATCH v4 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-27 Thread Madalin Bucur
: addressed compilation issues introduced in v3 Iordache Florinel-R70177 (1): fsl/fman: enable FMan Keygen Madalin Bucur (6): fsl/fman: move struct fman to header file dpaa_eth: use multiple Rx frame queues dpaa_eth: enable Rx hashing control dpaa_eth: add NETIF_F_RXHASH Documentation

[PATCH v4 3/7] dpaa_eth: use multiple Rx frame queues

2017-08-27 Thread Madalin Bucur
Add a block of 128 Rx frame queues per port. The FMan hardware will send traffic on one of these queues based on the FMan port Parse Classify Distribute setup. The hash computed by the FMan Keygen block will select the Rx FQ. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa

[PATCH v4 2/7] fsl/fman: enable FMan Keygen

2017-08-27 Thread Madalin Bucur
From: Iordache Florinel-R70177 Add support for the FMan Keygen with a hardcoded scheme to spread incoming traffic on a FQ range based on source and destination IPs and ports. Signed-off-by: Iordache Florinel Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile

[PATCH v4 1/7] fsl/fman: move struct fman to header file

2017-08-27 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 80 + drivers/net/ethernet/freescale/fman/fman.h | 75 +++ drivers/net/ethernet/freescale/fman/fman_port.c | 8 +-- 3 files changed, 82 insertions(+), 81 deletions

  1   2   3   >