[PATCH net-next 4/4] FDDI: defxx: Use driver's name with resource requests

A (TURBOchannel) adapters. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defxx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) Index: linux-defxx/drivers/net/fddi/defxx.c === --- linux-defxx.orig/d

[PATCH net-next 3/4] FDDI: defxx: Implement dynamic CSR I/O address space selection

aciej W. Rozycki --- drivers/net/fddi/Kconfig | 19 -- drivers/net/fddi/defxx.c | 60 +-- drivers/net/fddi/defxx.h |3 ++ 3 files changed, 25 insertions(+), 57 deletions(-) Index: linux-defxx/drivers/net/fddi/Kc

[PATCH net/net-next 2/4] FDDI: defxx: Make MMIO the configuration default except for EISA

the potentially ambiguous PIO acronym with IOP for "port I/O" vs "I/O ports" according to our nomenclature used elsewhere. Signed-off-by: Maciej W. Rozycki Fixes: e89a2cfb7d7b ("[TC] defxx: TURBOchannel support") Cc: sta...@vger.kernel.org # v2.6.21+ --- d

[PATCH 0/4] FDDI: defxx: CSR access fixes and improvements

Hi, As a lab upgrade I have recently replaced a dated 32-bit x86 server with a new POWER9 system. One of the purposes of the system has been providing network based resources to clients over my FDDI network. As such the new server has also received a new DEFPA FDDI network adapter. As it t

[PATCH net/net-next 1/4] FDDI: defxx: Bail out gracefully with unassigned PCI resource for CSR

he port I/O space anyway. While at it factor out the error message calls into helpers and fix an argument order bug with the `pr_err' call now in `dfx_register_res_err'. Signed-off-by: Maciej W. Rozycki Fixes: 4d0438e56a8f ("defxx: Clean up DEFEA resource management") Cc: sta

[PATCH net-next 3/3] FDDI: defza: Update my e-mail address

Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- Documentation/networking/device_drivers/fddi/defza.rst |2 +- drivers/net/fddi/defza.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index

[PATCH net-next 2/3] FDDI: defxx: Update my e-mail address

Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defxx.c |2 +- drivers/net/fddi/defxx.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-defxx/drivers/net/fddi/defxx.c

[PATCH net-next 1/3] FDDI: if_fddi.h: Update my e-mail address

Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- include/uapi/linux/if_fddi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-defxx/include/uapi/linux/if_fddi.h

[PATCH net-next 0/3] FDDI: Update my e-mail address througout

Hi, Following the recent update to MAINTAINERS update my e-mail addresses embedded througout the FDDI networking pieces. Change split into parts according to individual components. LMO (linux-mips.org) has not been recovered at this point, but in the interim I now have forwarding set up fro

Re: Usage of mdelay() inside Interrupt

On Fri, 29 May 2020, Andrew Lunn wrote: > > while browsing the sourcefile of lib8390.c in > > drivers/net/ethernet/8390/, i noticed that inside > > of ei_rx_overrun(), which is called from inside > > a Interrupt handler, mdelay() is being used. > > So i wonder if the usage of mdelay() inside the >

Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

On Wed, 6 Feb 2019, Yang Wei wrote: > From: Yang Wei > > dev_consume_skb_irq() should be called in dfx_xmt_done() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Reviewed-by: Maciej W. Rozycki It looks to me th

[PATCH 0/4] FDDI: defza: Fix a bunch of small issues

Hi, Here is a bunch of small fixes addressing issues that I missed in my final round of testing. None of these affect run-time behaviour. One was actually found by the kbuild bot, which turned out to be more pedantic than my compiler. See individual change descriptions for details. Please

[PATCH 2/4] FDDI: defza: Add missing comment closing

Fix: drivers/net/fddi/defza.h:238:1: warning: "/*" within comment [-Wcomment] by adding a missing comment closing. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defza.h |1 + 1 file changed, 1 insertion(+) linux-defza-cmd-size-comment-fix.diff Index: linux-201811

[PATCH 4/4] FDDI: defza: Make the driver version string constant

The driver version string is obviously not meant to be changed at run time, so mark it `const'. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defza.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) linux-defza-version-static-fix.patch Index: linux-20181104-4maxp64/driver

[PATCH 1/4] FDDI: defza: Fix SPDX annotation

The SPDX annotation for this driver does not match the license text, which specifies GNU GPL 2 or later. Make the two match by correcting the SPDX tag. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defza.c |2 +- drivers/net/fddi/defza.h |2 +- 2 files changed, 2 insertions

[PATCH 3/4] FDDI: defza: Move SMT Tx data buffer declaration next to its skb

Move the temporary data buffer used when tapping into the SMT Tx queue from the outer function level into the conditional block it's actually used in and its containing skb is also declared, making the structure of code better. Signed-off-by: Maciej W. Rozycki --- Hi, This was also pr

Re: [PATCH net-next v2 0/2] FDDI: DEC FDDIcontroller 700 TURBOchannel adapter support

On Mon, 15 Oct 2018, David Miller wrote: > Series applied, thank you. Great, thanks! Maciej

[PATCH net-next v2 2/2] FDDI: defza: Support capturing outgoing SMT traffic

wn network problems or do general traffic analysis. Call `dev_queue_xmit_nit' then in the SMT Tx path, having checked that a network tap is attached, with a newly-created `dev_nit_active' helper wrapping the usual condition used in the transmit path. Signed-off-by: Maciej W. Ro

[PATCH net-next v2 1/2] FDDI: defza: Add support for DEC FDDIcontroller 700 TURBOchannel adapter

r does some Frame Control byte decoding, so to avoid magic numbers some macros are added to . Signed-off-by: Maciej W. Rozycki --- Changes from v1: - driver version 1.1.4, due to completed 700-C adapter variant support, - DEC FDDIcontroller 700-C support verified and driver code updated accord

[PATCH net-next v2 0/2] FDDI: DEC FDDIcontroller 700 TURBOchannel adapter support

Hi, This is an update to . I believe I have addressed all the requests made in the previous review round. There is still one `checkpatch.pl' warning remaining: WARNING: quoted string split across lines #1652: FILE: drivers/net/fddi/defza.c:1442: +

Re: [PATCH] atm: idt77252: Replace mdelay with usleep_range in idt77252_preset

reset to be valid, so having the lower bound of .5ms still looks completely safe if not an overkill to me for real world applications where PCI is driven in the MHz clock range. Reviewed-by: Maciej W. Rozycki Maciej

Re: [PATCH 5/5] net: defxx: constify eisa_device_id

On Sat, 19 Aug 2017, Arvind Yadav wrote: > eisa_device_id are not supposed to change at runtime. All functions > working with eisa_device_id provided by work with > const eisa_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- Rev

Re: BPF relocations

On Fri, 12 May 2017, David Miller wrote: > Internally, we have to emit some kind of relocation as GAS makes it's > first pass over the instructions. Not really, you can defer that until the relaxation pass, e.g. to avoid figuring out what to do about forward local symbol references, especially

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

On Sun, 28 Feb 2016, Alexander Duyck wrote: > I actually found the root cause. The problem is in add32_with_carry3. > > > +static inline unsigned int add32_with_carry3(unsigned int a, unsigned int > > b, > > +unsigned int c) > > +{ > > + asm("ad

Re: [PATCH 5/9] net: fddi/defxx: avoid warning about uninitialized variable use

On Wed, 27 Jan 2016, Arnd Bergmann wrote: > This adds code to ensure that the BAR values are initialized > even in the impossible case when a device gets probed that > does not belong to any bus. This shuts up the warning. > > Signed-off-by: Arnd Bergmann > --- > drivers/net/fddi/defxx.c | 5 ++

Re: [PATCH] fddi: Fixup potential uninitialized bars

On Tue, 26 Jan 2016, Hannes Reinecke wrote: > dfx_get_bars() allocates the various bars, depending on the > bus type. But as the function itself returns void and there > is no default selection there is a risk of the function > returning without allocating any bars. > This patch moves the entries

Re: [PATCH v2] defxx: fix build warning

; them properly. But still lets have them initialized just to satisfy the > compiler (gcc 4.8.2). > > Signed-off-by: Sudip Mukherjee > --- Acked-by: Maciej W. Rozycki Thanks, Maciej

Re: [PATCH 3/3] defxx: fix build warning

On Mon, 25 Jan 2016, Sudip Mukherjee wrote: > We are getting many build warning about: > 'bar_start' may be used uninitialized > and > 'bar_len' may be used uninitialized > > They are not actually uninitialized as dfx_get_bars() will initialize > them properly. But still lets have them initialize

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

On Tue, 29 Jan 2008, Nate Case wrote: > +static struct phy_driver bcm5482_driver = { > +.phy_id = 0x0143bcb0, > + .phy_id_mask= 0xfff0, Please check formatting above and also I am a bit curious as to why the ID is so different from the other ones -- the number is meant

[PATCH] defxx.c: dfx_bus_init() is __devexit not __devinit

The dfx_bus_uninit() call is called from dfx_unregister() which is __devexit and which is ultimately the ->remove call for the device. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- It should be obvious. Please apply. Maciej patch-mips-2.6.23-rc5-20070904-defxx-devex

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Fri, 19 Oct 2007, Jarek Poplawski wrote: > Actually I'm not convinced with this explanation. It seems to me that > since there are such serious locking problems (especially with rntl), > there could be once more considered a private workqueue. You've > written earlier about being a lonely user

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Fri, 19 Oct 2007, Jarek Poplawski wrote: > But then... your patch seems to make it possible, because it enables > irq to the initial state of the counter. Of course, this could happen > on closing only. That's because free_irq() does not disable the interrupt in the correct manner. The scen

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Thu, 18 Oct 2007, Maciej W. Rozycki wrote: > > 1) phy_change() checks PHY_HALTED flag without lock; I think it's > > racy: eg. if it's done during phy_stop() it can check just before > > the flag is set and reenable interrupts just after phy_stop() ends. > >

Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Thu, 18 Oct 2007, Oleg Nesterov wrote: > If we can't just cancel the work, can't we do something like > > if (cancel_work_sync(w)) > w->func(w); > > instead? We do an equivalent of this -- all that we care about that w->func(w) would do is enable_irq() and the rest we w

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Thu, 18 Oct 2007, Jarek Poplawski wrote: > Technically until free_irq returns a handler should respond to calls > and with proper hardware it should have no problem with checking if > it's its interrupt, even after disabling this hardware, because of > possible races. Well, the hardirq handle

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Thu, 18 Oct 2007, Jarek Poplawski wrote: > After rethinking, it looks like this last cancel should be useless. > So, if phy_interrupt() schedules only if !PHY_HALTED and phy_change() > does enable_irq() with no exeptions, it seems phy_interrupt() even > without lock must see PHY_HALTED state be

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Wed, 17 Oct 2007, Jarek Poplawski wrote: > I'm not sure free_irq() should maintain the depth count - rather warn > on not zero. But, IMHO, any activity on freed irq seems suspicious to > me (and doesn't look like very common), even if it's safe with current > implementation. No way to avoid i

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Tue, 16 Oct 2007, Jarek Poplawski wrote: > Yes, it's all right here. Sorry for bothering - I should've found this > by myself. Ah, no problem -- even with the right keys you may sometimes get lost in the results. > I've still some doubts about this possible enable_irq() after > free_irq().

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Mon, 15 Oct 2007, Jarek Poplawski wrote: > Could you explain why cancel_work_sync() is better here than > flush_scheduled_work() wrt. rtnl_lock()? Well, this is actually the bit that made cancel_work_sync() be written in the first place. The short story is the netlink lock is most probably

Re: [PATCH] sb1250-mac: Driver model & phylib update

On Mon, 24 Sep 2007, Andrew Morton wrote: > > Well, this is against Jeff's netdev-2.6 tree which hopefully is not as > > crufty as Linus's old mainline; if it is not possible to queue this change > > for 2.6.25 or suchlike, then I will try to resubmit later. > > Most of Jeff's netdev tree got

Re: [PATCH] sb1250-mac: Driver model & phylib update

On Fri, 21 Sep 2007, Andrew Morton wrote: > > A driver model and phylib update. > > akpm:/usr/src/25> diffstat patches/git-net.patch | tail -n 1 > 1013 files changed, 187667 insertions(+), 23587 deletions(-) > > Sorry, but raising networking patches against Linus's crufty > old mainline tree j

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

On Thu, 20 Sep 2007, Andrew Morton wrote: > You always put boring, crappy, insufficient text in the for-the-changelog > section and interesting, useful, sufficient text in the not-for-the-changelog > section. I'll swap the sections in the future then. ;-) Frankly I was not sure whether the cha

[PATCH] sb1250-mac: Driver model & phylib update

rather than platform-specific macros. 4. Handling of the device using the driver model. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- This is a resubmission and this patch has waited for some time now as the original submission triggered some concerns on the way phylib handled int

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 20 Sep 2007, Jeff Garzik wrote: > Remove the "linux-" prefix. Hmm, it looks like a bad appl

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

On Thu, 20 Sep 2007, Jeff Garzik wrote: > > You may be pleased (or less so) to hear that the version of sb1250-mac.c in > > your tree does not even build (because of > > 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not > > address it. I ran out of time in the evening, but I

[PATCH] PHYLIB: Fix an interrupt loop potential when halting

Ensure the PHY_HALTED state is not entered with the IRQ asserted as it could lead to an interrupt loop. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- There is a small window in phy_stop(), where the state of the PHY machine indicates it has been halted, but its interrupt

[PATCH] PHYLIB: IRQ event workqueue handling fixes

Keep track of disable_irq_nosync() invocations and call enable_irq() the right number of times if work has been cancelled that would include them. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Now that the call to flush_work_keventd() (problematic because of rtnl_mutex bein

[PATCH] PHYLIB: Spinlock fixes for softirqs

Use spin_lock_bh()/spin_unlock_bh() for the phydev lock throughout as it is used in phy_timer() that is called as a softirq and all the other operations may happen in the user context. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- There has been a change recently that did

[PATCH] sb1250-mac.c: Fix "stats" references

Fix build errors resulting from a recent commit that added references to "stats" through "dev" from sbdma_rx_process() and sbdma_tx_process(), but no definitions of that variable. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- This is probably the simple

[PATCH] NET_SB1250_MAC: Rename to SB1250_MAC

Rename NET_SB1250_MAC to SB1250_MAC to follow the convention. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- The NET prefix seems to be used mainly for device groups (NET_ISA, NET_VENDOR_*, etc.) rather than single drivers and adds no information. I suggest it to be r

[PATCH] NET_SB1250_MAC: Update Kconfig entry

The SB1250 network interfaces are Gigabit Ethernet ones. Move the Kconfig entry to the appropriate section and add some help text. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- It should be obvious; I hope the help text will be useful to somebody and will preven

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Thu, 13 Sep 2007, Jeff Garzik wrote: > Net driver patches should apply on top of netdev-2.6.git#upstream,

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

On Wed, 12 Sep 2007, Jeff Garzik wrote: > > Remove typedefs, volatiles and convert kmalloc()/memset() pairs to > > kcalloc(). Also reformat the surrounding clutter. > > > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> > > --- > > ACK, but patc

[PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse. No semantic c

[PATCH] ipconfig.c: De-clutter IP configuration report

Reformat the printk() calls removing leading new-line characters, making output being done line-by-line rather than partially and defining the log level used. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- The new code builds fine; no semantic changes. Please apply,

Re: [PATCH] Prefix each line of multiline printk(KERN_ "foo\nbar") with KERN_

On Sun, 26 Aug 2007, Geert Uytterhoeven wrote: > What I mean is that probably there used to be a printk() call starting with > `\n'. Then someone added a `KERN_ERR' in front of it. I gather '\n' at the beginning is to assure the following line is output on a separate line rather than as a conti

[PATCH] defxx: Use __maybe_unused rather than a local hack

This is a change to remove a local hack in favour to __maybe_unused that has been recently added. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Hi, It should be obvious. The code builds, therefore it works. Please apply, Maciej patch-mips-2.6.22-20070710-defxx-unused-

[PATCH] defxx: Fix the handling of ioremap() failures

If ioremap_nocache() is unfortunate enough to fail, the error code is not set correctly leading to a false success from dfx_register(). This change fixes the problem. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. Maciej patch-mips-2.6.21-20070502-defxx-ior

[PATCH] declance: Remove a dangling spin_unlock_irq() thingy

The spin_unlock_irq() invocation in lance_start_xmit() has no matching locking request. The call is already protected by netif_tx_lock, so remove the statement. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. Maciej patch-mips-2.6.18-20060920-declance-lock-

Re: [PATCH] RFC: Broadcom PHY forcing fix

On Fri, 26 Jan 2007, Kumar Gala wrote: > It looks like phy_timer has changed a bit in 2.6.20-rc6, what exactly was the > intent of these changes? As I wrote, I'll have a look at these patches after 2.6.20 again. These bits are from September (see the timestamps) and some of them may well have

Re: [PATCH] RFC: Broadcom PHY forcing fix

Kumar, > I've got a BCM5461 that requires this fix to be able to force the speeds > on the PHY. Not sure if its needed on the other variants or not. The > problem is the genphy_config_aneg resets the PHY when forcing the speed > and once we reset the BCM5461 it doesn't remember any of its set

[PATCH 2.6.20-rc1 #2 03/10] defxx: TURBOchannel support

TURBOchannel requires it anyway. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Wed, 20 Dec 2006, Andrew Morton wrote: > > This is a set of changes to add TURBOchannel support to the defxx driver. > > my, what a lot of rejects. Hmm, I missed somebody having done q

Re: Network drivers that don't suspend on interface down

On Wed, 20 Dec 2006, Matthew Garrett wrote: > As far as I can tell, the following network devices don't put the > hardware into D3 on interface down: [...] > defxx No support in the hardware for that. Even revision 3 of the board which is the last one and the only to support PCI 2.2 says: Ca

[PATCH 2.6.20-rc1 00/10] TURBOchannel update to the driver model

Hello, It has been much longer than expected, but finally it is here! This series of patches converts support for the TURBOchannel bus to the driver model. As a nice side effect, the generic part of the code is now really generic, that is no more dependencies on MIPS specifics under drivers/

[PATCH 2.6.20-rc1 01/10] TURBOchannel update to the driver model

-mips/dec/ have been merged into linux/tc.h, which should be included by drivers. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. Maciej patch-mips-2.6.18-20060920-tc-sysfs-78 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/MAINTAINERS linux-mips-

[PATCH 2.6.20-rc1 05/10] if_fddi.h: Add a missing inclusion

This is a change to include in which is needed for "struct fddi_statistics". Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. Maciej patch-mips-2.6.18-20060920-if_fddi-netdev-0 diff -up --recursive --new-file linux-mips-2.6.18-20060920.mac

[PATCH 2.6.20-rc1 03/10] defxx: TURBOchannel support

TURBOchannel requires it anyway. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- These changes have been tested at the run time with TC and PCI variations of the board. EISA support has only been verified to build correctly. I do believe I got it mostly right, but if there is so

[PATCH 2.6.20-rc1 04/10] EISA registration with !CONFIG_EISA

This is a change for the EISA bus support to permit drivers to call un/registration functions even if EISA support has not been enabled. This is similar to what PCI (and now TC) does and reduces the need for #ifdef clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- T

Re: [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel

On Fri, 1 Dec 2006, Andrew Morton wrote: > > can you (or Andrew) please resend your patches against 2.6.19? > > > > I have then all (I think) queued up. Will send once I've done a round > of build-testing. Thanks a lot, Andrew. Maciej - To unsubscribe from this list: send the line "unsubsc

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

On Mon, 23 Oct 2006, Maciej W. Rozycki wrote: > > I'm not too enthusiastic about requiring the ethernet drivers to call > > phy_disconnect in a separate thread after "close" is called. Assuming > > there's > > not some sort of "squash work queue

[PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel

: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Tested with the onboard LANCE of a DECstation 5000/133. Please apply. Maciej patch-mips-2.6.18-20060920-declance-tc-0 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/declance.c linux-mips-2.6.18-20060920/drive

[PATCH 2.6.18] declance: Fix RX ownership handover

The change for PMAD support introduced a bug, where the ownership of RX descriptors was given back to the LANCE in the wrong way. Occasional lockups would happen as a result. This is a fix for this problem. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Tested with the o

[PATCH 2.6.18] defxx: Big-endian hosts support

: Maciej W. Rozycki <[EMAIL PROTECTED]> --- On Mon, 23 Oct 2006, Christoph Hellwig wrote: > On Mon, Oct 23, 2006 at 01:53:17PM +0100, Maciej W. Rozycki wrote: > > + data = cpu_to_le32(data); > > This is rather ugly and not provable by static typechecking. Please > alway

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

On Fri, 20 Oct 2006, Andy Fleming wrote: > I've been trying to figure out this problem since you posted this, and I'm not > sure I understand it fully (And I apologize profusely for the horror that is > the PHY interrupt handling code. I'd love to rewrite it if there's some First of all I don't

[PATCH 2.6.18] defxx: Big-endian hosts support

: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. Maciej patch-mips-2.6.18-20060920-defxx-eb-3 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/defxx.c linux-mips-2.6.18-20060920/drivers/net/defxx.c --- linux-mips-2.6.18-20060920.macro/drivers/net/d

Re: BCM5461 phy issue in 10M/Full duplex

On Wed, 18 Oct 2006, Rick Jones wrote: > > I believe, but need to double check, that if I leave the BCM5461 in > > autoneg, and foce the switch to 10M/full that the BCM5461 will autoneg at > > 10M/half duplex. > > Indeed, if one side is hardcoded, autoneg will "fail" and the side trying to > aut

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

On Mon, 16 Oct 2006, Andrew Morton wrote: > Vaguely. Why doesn't it deadlock if !current_is_keventd()? I mean, > whether or not the caller is keventd, the flush_scheduled_work() caller > will still be dependent upon rtnl_lock() being acquirable. This !current_is_keventd() condition is just wha

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

Andrew, > I don't get it. If some code does > > rtnl_lock(); > flush_scheduled_work(); > > and there's some work scheduled which does rtnl_lock() then it'll deadlock. > > But it'll deadlock whether or not the caller of flush_scheduled_work() is > keventd. > > Calling flush_schedul

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

On Thu, 5 Oct 2006, Andrew Morton wrote: > > 2. The driver uses schedule_work() for handling interrupts, but does not > >make sure any pending work scheduled thus has been completed before > >driver's structures get freed from memory. This is especially > >important as interrupts m

[PATCH 2.6.18 8/6]: sb1250-mac: Fix an incorrect use of kfree()

use it. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- This applies on top of the "typedef" change (7/6). Please consider. Maciej patch-mips-2.6.18-20060920-sb1250-mac-kfree-0 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/sb1250-m

[PATCH 2.6.18 7/6]: sb1250-mac: Remove "typedef" obfuscation

This is a set of changes to remove unneeded type definitions that only make code less obvious. It applies to all "enum" and "struct" types as well as to potentially unsafe use of them within sizeof(). Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> ---

[PATCH 2.6.18 4/6]: sb1250-mac: Driver model & phylib support

registers rather than platform-specific macros. 5. Handling of the device using the driver model. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- This revision fixes the problem with drivers/net/Kconfig. Please consider. Maciej patch-2.6.18-sb1250-mac-16 diff -up --recursive

[patch 6/6] 2.6.18: sb1250-mac: PHY interrupt polarity fixup

uch better for stress-testing interrupt handling; use that one instead if needed). Please consider. Maciej Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> patch-mips-2.6.18-20060920-swarm-setup-15 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/arch/mips/sibyte/swar

[patch 1/6] 2.6.18: sb1250-mac: Broadcom PHY support

. Please consider. Maciej Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> patch-mips-2.6.18-20060920-broadcom-phy-15 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/phy/Kconfig linux-mips-2.6.18-20060920/drivers/net/phy/Kconfig --- linux-mips-2.6.18-20

[patch 5/6] 2.6.18: sb1250-mac: Interrupt wiring for PHYs

Hello, This patch defines the wiring for the PHY interrupt lines for the supported Broadcom SiByte boards for which documentation is available. Please consider. Maciej Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> patch-mips-2.6.18-20060920-sibyte-phy-irq-15 diff -up --rec

[patch 0/6] 2.6.18: sb1250-mac: Driver model & phylib update

Hello, Here is a set of patches that update the sb1250-mac driver used for the onchip Gigabit Ethernet interfaces of the Broadcom SiByte family of SOCs including the BCM1250 and a couple of other members. These are used, among others, on various Broadcom evaluation boards together with Broadc

[patch 4/6] 2.6.18: sb1250-mac: The actual driver update

()ped handles to access MAC registers rather than platform-specific macros. 5. Handling of the device using the driver model. Please consider. Maciej Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> patch-mips-2.6.18-20060920-sb1250-mac-15 diff -up --recursive --new-file linu

[patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

.0 + +++ linux-mips-2.6.18-20060920/drivers/net/phy/phy.c2006-10-03 14:19:21.0 + @@ -7,6 +7,7 @@ * Author: Andy Fleming * * Copyright (c) 2004 Freescale Semiconductor, Inc. + * Copyright (c) 2006 Maciej W. Rozycki * * This program is free software; you can redi

[patch 2/6] 2.6.18: sb1250-mac: Missing inclusions from

Hello, The uses some types and macros defined in , , and , but fails to include these headers. Please consider. Maciej Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> patch-mips-2.6.18-20060920-include-phy-16 diff -up --recursive --new-file linux-mips-2.6.18-20060920

Re: mii-tool gigabit support.

On Wed, 27 Sep 2006, Auke Kok wrote: > > Older equipment, which may still be in use here and there, allowed > > full-duplex operation, but no auto-negotiation. The duplex setting was > > either fixed or selectable in a system-specific manner. In such a case you > > certainly want your modern oth

Re: mii-tool gigabit support.

On Wed, 27 Sep 2006, Rick Jones wrote: > > Another scenario: forcing the NIC to negotiate only full-duplex speeds. Not > > only fun if you try it against a hub, but possibly useful. [...] > I'm just worried (as in Fear Uncertainty and Doubt) that having people set the > allowed things to negotiate

Re: [PATCH] Add Broadcom PHY support

On Tue, 19 Sep 2006, Jeff Garzik wrote: > > And sb1250-mac.c would be happy to use it too. > > "would be happy to" != "is using". I don't want to add a phy driver until > there are already active users in the kernel. Fair enough, but Amy may be looking forward to seeing yet another piece of

Re: [PATCH] Add Broadcom PHY support

On Tue, 19 Sep 2006, Amy Fong wrote: > > And... where are the users of this phy driver? [...] > This phy driver is used by the WRS's sbc8560 (bcm5421s) and sbc843x > (bcm5461s) via the gianfar driver. And sb1250-mac.c would be happy to use it too. Maciej - To unsubscribe from this list: send

Re: Diff between Linus' and linux-mips git: declance

The first change is certainly correct > (as it is consistent with the rest of the file) and should be applied > to mainline; the other change seems correct too. And the third is > cosmetic. > > Signed-off-by: Martin Michlmayr <[EMAIL PROTECTED]> Acked-by: Maciej W. Rozycki <