Re: [PATCH 1/3] net: Add MDIO bus driver for the Hisilicon FEMAC

On 2016/6/15 6:27, Rob Herring wrote: > On Mon, Jun 13, 2016 at 02:07:54PM +0800, Dongpo Li wrote: >> This patch adds a separate driver for the MDIO interface of the >> Hisilicon Fast Ethernet MAC. >> >> Reviewed-by: Jiancheng Xue >> Signed-off-by: Dongpo Li >> --- >> .../bindings/net/hisilico

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

On 2016/6/13 17:06, Arnd Bergmann wrote: > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > >> +- reset-names: should contain the reset signal name "mac_reset"(required) >> +and "phy_reset"(optional). > > Maybe just name the resets 'mac' and 'phy'? The '_reset' part is > implied

Re: [PATCH 1/3] net: Add MDIO bus driver for the Hisilicon FEMAC

On 2016/6/13 21:32, Andrew Lunn wrote: > On Mon, Jun 13, 2016 at 02:07:54PM +0800, Dongpo Li wrote: >> This patch adds a separate driver for the MDIO interface of the >> Hisilicon Fast Ethernet MAC. >> >> Reviewed-by: Jiancheng Xue >> Signed-off-by: Dongpo Li >> --- >> .../bindings/net/hisilic