On Wed, Jan 30, 2019 at 12:17 PM Cong Wang wrote:
>
> On Wed, Jan 30, 2019 at 8:54 AM Ivan Babrou wrote:
> >
> > Hey,
> >
> > We've upgraded some machines from 4.19.13 to 4.19.18 and some of them
> > crashed with the following:
> >
> > [ 2313.192006] general protection fault: [#1] SMP PTI
>
printf("send time: %ld.%06ld seconds\n",
(long)delta.tv_sec, (long)delta.tv_usec);
exit(0);
}
Fixes: 515c7af85ed9 ("x32: Use compat shims for {g,s}etsockopt")
Reported-by: Gopal RajagopalSai
Signed-off-by: Lance Richardson
---
net/compat.c | 6
"ptr is non-null: %p\n", ptr);
}
Compile the code:
$ gcc -o foobar -O2 foo.c bar.c
Execute it (note second line of output, which might be surprising):
$ ./foobar
ptr is non-null: 0x7ffdc47daef0
ptr is non-null: (nil)
Regards,
Lance Richardson
> From: "Stephen Suryaputra Lin"
> To: netdev@vger.kernel.org
> Sent: Friday, 23 June, 2017 3:58:17 PM
> Subject: Faster TCP keepalive
>
> Greetings,
>
> I'm writing this to probe if there has been thoughts or efforts in
> allowing sub-second TCP keep alive interval? One application is for TCP
>
> From: "David Miller"
> To: lrich...@redhat.com
> Cc: netdev@vger.kernel.org, pab...@redhat.com
> Sent: Thursday, 1 June, 2017 2:46:48 PM
> Subject: Re: [PATCH net] vxlan: eliminate cached dst leak
>
> From: Lance Richardson
> Date: Mon, 29 May 2017
> From: "Lance Richardson"
> To: netdev@vger.kernel.org, pab...@redhat.com
> Sent: Monday, 29 May, 2017 1:25:57 PM
> Subject: [PATCH net] vxlan: eliminate cached dst leak
>
> After commit 0c1d70af924b ("net: use dst_cache for vxlan device"),
> cached d
e." messages to appear in the kernel log.
Fix by properly releasing cached dst and freeing resources in this
case.
Fixes: commit 0c1d70af924b ("net: use dst_cache for vxlan device")
Signed-off-by: Lance Richardson
---
drivers/net/vxlan.c | 20 +---
1 file changed,
info.key.tun_flags |= TUNNEL_CSUM;
>
> if (data[IFLA_GENEVE_UDP_ZERO_CSUM6_TX] &&
> --
> 1.8.3.1
>
>
Verified issue on 4.10.10 kernel. Note that this doesn't impact
lightweight geneve tunnels (e.g. as used by openvswitch).
Acked-by: Lance Richardson
> From: "Sudarsana Reddy Kalluru"
> To: da...@davemloft.net
> Cc: netdev@vger.kernel.org, "Yuval Mintz"
> Sent: Wednesday, 19 April, 2017 6:19:54 AM
> Subject: [PATCH net 3/4] qed: Fix possible system hang in the dcbnl-getdcbx()
> path.
>
> qed_dcbnl_get_dcbx() API uses kmalloc in GFT_KERNEL mo
> From: "Numan Siddique"
> To: netdev@vger.kernel.org, "ovs dev"
> Cc: "Joe Stringer" , "Andy Zhou" , ja...@ovn.org
> Sent: Thursday, March 16, 2017 8:25:06 AM
> Subject: [RFC] [net]openvswitch: Clear the ct flow key for the recirculated
> packet
>
> It is possible that the ct flow key informat
Cast second parameter of csum_sub() from __sum16 to __wsum.
Signed-off-by: Lance Richardson
---
include/net/checksum.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/checksum.h b/include/net/checksum.h
index 35d0fab..aef2b2b 100644
--- a/include/net/checksum.h
Eliminate sparse warning by maintaining type of dst_port
as __be16.
Signed-off-by: Lance Richardson
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index ca7196c..19b1653 100644
--- a/drivers/net/vxlan.c
+++ b
vxlan->cfg.dst_port is in network byte order, so an htons()
is needed here. Also reduced comment length to stay closer
to 80 column width (still slightly over, however).
Fixes: e1e5314de08b ("vxlan: implement GPE")
Signed-off-by: Lance Richardson
---
drivers/net/vxlan.c | 2 +-
1
Changed type of csum field in struct igmpv3_query from __be16 to
__sum16 to eliminate type warning, made same change in struct
igmpv3_report for consistency.
Fixed up an ntohs() where htons() should have been used instead.
Signed-off-by: Lance Richardson
---
include/uapi/linux/igmp.h | 4
8a436eaa2c ("openvswitch: Add conntrack action")
Signed-off-by: Lance Richardson
---
net/openvswitch/conntrack.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 6b78bab..54253ea 100644
--- a/net/openvswitch/c
> From: "Lance Richardson"
> To: "Stephen Rothwell"
> Cc: "Sven-Haegar Koch" , "Eli Cooper" ,
> netdev@vger.kernel.org, "Eric Dumazet"
>
> Sent: Monday, November 28, 2016 12:54:07 PM
> Subject: Re: Large performance re
gt; Hi Sven-Haegar,
>
> On Fri, 25 Nov 2016 05:06:53 +0100 (CET) Sven-Haegar Koch
> wrote:
> >
> > Somehow this problem description really reminds me of a report on
> > netdev a bit ago, which the following patch fixed:
> >
> > commit 9ee6c5dc8
This is a follow-up to commit 9ee6c5dc816a ("ipv4: allow local
fragmentation in ip_finish_output_gso()"), updating the comment
documenting cases in which fragmentation is needed for egress
GSO packets.
Suggested-by: Shmulik Ladkani
Reviewed-by: Shmulik Ladkani
Signed-off-by: Lance
This is a follow-up to commit eb96202f1e34 ("ipv4: allow local
fragmentation in ip_finish_output_gso()"), updating the comment
documenting cases in which fragmentation is needed for egress
GSO packets.
Suggested-by: Shmulik Ladkani
Signed-off-by: Lance Richardson
---
net/ipv4/ip_out
> From: "Shmulik Ladkani"
> To: "Lance Richardson"
> Cc: netdev@vger.kernel.org, f...@strlen.de, jtl...@redhat.com,
> han...@stressinduktion.org
> Sent: Friday, November 4, 2016 5:24:09 AM
> Subject: Re: [PATCH net v3] ipv4: allow local fragmentatio
> From: "Shmulik Ladkani"
> To: "Hannes Frederic Sowa"
> Cc: "Lance Richardson" , f...@strlen.de,
> netdev@vger.kernel.org, jtl...@redhat.com
> Sent: Friday, November 4, 2016 5:40:14 AM
> Subject: Re: [PATCH net v3] ipv4: allow local fragmentation
> From: "Shmulik Ladkani"
> To: "Lance Richardson" , f...@strlen.de,
> han...@stressinduktion.org
> Cc: netdev@vger.kernel.org, jtl...@redhat.com
> Sent: Thursday, November 3, 2016 4:27:51 PM
> Subject: Re: [PATCH net v3] ipv4: allow local fragmentatio
> From: "Shmulik Ladkani"
> To: "Lance Richardson"
> Cc: netdev@vger.kernel.org, f...@strlen.de, jtl...@redhat.com,
> han...@stressinduktion.org
> Sent: Thursday, November 3, 2016 3:42:39 AM
> Subject: Re: [PATCH net v3] ipv4: allow local fragmentation in
requiring fragmentation.
Fixes: c7ba65d7b649 ("net: ip: push gso skb forwarding handling down the stack")
Reported-by: Jan Tluka
Signed-off-by: Lance Richardson
---
v2: IPSKB_FRAG_SEGS is no longer useful, remove it.
v3: Eliminate unused variable warning.
include/net/ip.h
- Original Message -
> From: "Florian Westphal"
> To: "Lance Richardson"
> Cc: netdev@vger.kernel.org, f...@strlen.de, jtl...@redhat.com
> Sent: Wednesday, November 2, 2016 1:20:36 PM
> Subject: Re: [PATCH net] ipv4: allow local fragmentation in
requiring fragmentation.
Fixes: c7ba65d7b649 ("net: ip: push gso skb forwarding handling down the stack")
Reported-by: Jan Tluka
Signed-off-by: Lance Richardson
---
v2: IPSKB_FRAG_SEGS is no longer useful, remove it.
include/net/ip.h | 3 +--
net/ipv4/ip_forward.c
requiring fragmentation.
Fixes: c7ba65d7b649 ("net: ip: push gso skb forwarding handling down the stack")
Reported-by: Jan Tluka
Signed-off-by: Lance Richardson
---
net/ipv4/ip_output.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/ip_output.c b/
> From: "Nicolas Dichtel"
> To: da...@davemloft.net, "steffen klassert"
> Cc: netdev@vger.kernel.org, "Nicolas Dichtel" ,
> "Lance Richardson"
> Sent: Friday, September 30, 2016 5:11:07 AM
> Subject: [PATCH net] vti6: flush x-netns xf
Eliminate a sparse endianness mismatch warning, use nla_get_be32() to
extract a __be32 value instead of nla_get_u32().
Signed-off-by: Lance Richardson
---
net/ipv6/ip6_gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 397e1ed
> From: "Sergei Shtylyov"
> To: "Lance Richardson" , netdev@vger.kernel.org
> Cc: "shmulik ladkani" , jb...@redhat.com
> Sent: Friday, September 23, 2016 4:01:15 PM
> Subject: Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in
> ip6gre_xmit
> From: "Shmulik Ladkani"
> To: "Lance Richardson"
> Cc: netdev@vger.kernel.org
> Sent: Friday, September 23, 2016 3:00:36 PM
> Subject: Re: [PATCH net] ip6_gre: fix flowi6_proto value in
> ip6gre_xmit_other()
>
> On Fri, 23 Sep 2016 12:54:59 -04
gested-by: Jiri Benc
Fixes: commit c12b395a4664 ("gre: Support GRE over IPv6")
Reviewed-by: Shmulik Ladkani
Signed-off-by: Lance Richardson
---
v2: expanded commit description as suggested by Shmulik Ladkani.
net/ipv6/ip6_gre.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
path."), simply delete the line setting the incorrect flowi6_proto value.
Suggested-by: Jiri Benc
Fixes: commit c12b395a4664 ("gre: Support GRE over IPv6")
Signed-off-by: Lance Richardson
---
net/ipv6/ip6_gre.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv6/ip6_gr
> From: "Neal Cardwell"
> To: "David Miller"
> Cc: netdev@vger.kernel.org, "Eric Dumazet" , "Soheil
> Hassas Yeganeh" , "Neal
> Cardwell" , "Yuchung Cheng"
> Sent: Sunday, September 18, 2016 6:03:42 PM
> Subject: [PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size
> check in t
are three or fewer recursions through ovs_execute_actions().
Suggested-by: Pravin Shelar
Signed-off-by: Lance Richardson
---
net/openvswitch/actions.c | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/actions.c b/net/openvswitch
> From: "Jojy Varghese"
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net
> Sent: Thursday, September 8, 2016 3:08:29 PM
> Subject: Re: [PATCH] net_namespace: fixed net_device reference leak
>
> (Updating the patch for the case when a non-loopback dev could be
> unregistered)
>
> Currently
> From: "David Miller"
> To: az...@ovn.org
> Cc: d...@openvswitch.com, netdev@vger.kernel.org
> Sent: Friday, March 18, 2016 5:19:09 PM
> Subject: Re: [net] openvswitch: Allow deferred action fifo to expand during
> run time
>
> From: Andy Zhou
> Date: Thu, 17 Mar 2016 21:32:13 -0700
>
> > Cur
ned-off-by: Lance Richardson
---
net/sctp/sctp_diag.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c
index bb69153..f3508aa 100644
--- a/net/sctp/sctp_diag.c
+++ b/net/sctp/sctp_diag.c
@@ -424,11 +424,13 @@ static int sctp_dia
00.1 192.168.200.1
ip netns del secure
Reported-by: Hangbin Liu
Reported-by: Jan Tluka
Signed-off-by: Lance Richardson
---
v2: Perform garbage collection on NETDEV_DOWN notification (v1 did this
in uninit op handler).
net/ipv4/ip_vti.c | 31 +++
1 file c
ec secure ping -c 4 -i 0.02 -I 192.168.100.1 192.168.200.1
ip netns del secure
Reported-by: Hangbin Liu
Reported-by: Jan Tluka
Signed-off-by: Lance Richardson
---
net/ipv4/ip_vti.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip
- Original Message -
> From: "David Miller"
> To: lrich...@redhat.com
> Cc: netdev@vger.kernel.org, "nicolas dichtel"
> Sent: Saturday, June 11, 2016 6:43:40 PM
> Subject: Re: [PATCHi next] veth: advertise peer link relationship for both
> devic
4:54:8a:ac:f5 brd ff:ff:ff:ff:ff:ff
4: vm1@vm2: mtu 1500 qdisc noop state DOWN
link/ether b2:05:70:e0:fc:35 brd ff:ff:ff:ff:ff:ff
3: vm2@vm1: mtu 1500 qdisc noop state DOWN
link/ether e2:94:54:8a:ac:f5 brd ff:ff:ff:ff:ff:ff
Signed-off-by: Lance Richardson
---
drivers/net/ve
- Original Message -
> From: "Nicolas Dichtel"
> To: "Lance Richardson" , "Vincent Bernat"
>
> Cc: "David S. Miller" , "Vijay Pandurangan"
> , "Paolo Abeni"
> , netdev@vger.kernel.org
> Sent: Friday, Jun
- Original Message -
> From: "Nicolas Dichtel"
> To: "Vincent Bernat"
> Cc: "David S. Miller" , "Vijay Pandurangan"
> , "Paolo Abeni"
> , netdev@vger.kernel.org
> Sent: Tuesday, May 31, 2016 5:17:20 AM
> Subject: Re: [net v3] veth: advertise peer link once both links are tied
> together
- Original Message -
> From: "Sabrina Dubroca"
> To: netdev@vger.kernel.org
> Cc: "Hannes Frederic Sowa" , "Johannes Berg"
> , "Dan Carpenter"
> , "Sabrina Dubroca"
> Sent: Tuesday, April 19, 2016 1:36:38 PM
> Subject: [PATCH net 1/5] macsec: add missing NULL check after kmalloc
>
> Fix
Apologies, that should have been [PATCH v2 net].
- Original Message -
> From: "Lance Richardson"
> To: netdev@vger.kernel.org
> Cc: d...@cumulusnetworks.com
> Sent: Tuesday, March 22, 2016 2:56:57 PM
> Subject: [PATCH net] ipv4: initialize flowi4_flags
ch will prevent
similar issues as fields are added in the future by ensuring that
all fields are initialized to zero unless explicitly initialized
to another value.
Fixes: 58189ca7b2741 ("net: Fix vti use case with oif in dst lookups")
Suggested-by: David Ahern
Signed-off-by: Lance Richards
- Original Message -
> From: "David Ahern"
> To: "Lance Richardson" , netdev@vger.kernel.org
> Sent: Tuesday, March 22, 2016 2:29:02 PM
> Subject: Re: [PATCH net] ipv4: initialize flowi4_flags before calling
> fib_lookup()
>
> On 3/22/16 9:31
-off-by: Lance Richardson
---
net/ipv4/fib_frontend.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 21add55..896844a 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -304,6 +304,7 @@ __be32 fib_compute_spec_dst
- Forwarded Message -
> This trivial patch series addresses a number of endianness- and
> lock-related issues reported by sparse.
>
> Lance Richardson (3):
> ipv4: fix endianness warnings in ip_tunnel_core.c
> ipv4: eliminate endianness warnings in ip_fib.h
>
Add lock release/acquire annotations to ping_seq_start() and
ping_seq_stop() to satisfy sparse.
Signed-off-by: Lance Richardson
---
net/ipv4/ping.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index e89094a..c117b21 100644
--- a/net/ipv4/ping.c
+++ b
Eliminate endianness mismatch warnings (reported by sparse) in this file by
using appropriate nla_put_*()/nla_get_*() calls.
Signed-off-by: Lance Richardson
---
net/ipv4/ip_tunnel_core.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/ipv4
This trivial patch series addresses a number of endianness- and
lock-related issues reported by sparse.
Lance Richardson (3):
ipv4: fix endianness warnings in ip_tunnel_core.c
ipv4: eliminate endianness warnings in ip_fib.h
ipv4: eliminate lock count warnings in ping.c
include/net
fib_multipath_hash() computes a hash using __be32 values, force
cast these to u32 to pacify sparse.
Signed-off-by: Lance Richardson
---
include/net/ip_fib.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 9f4df68..7029527
54 matches
Mail list logo
