----- Original Message ----- > From: "Nicolas Dichtel" <nicolas.dich...@6wind.com> > To: "Lance Richardson" <lrich...@redhat.com>, "Vincent Bernat" > <vinc...@bernat.im> > Cc: "David S. Miller" <da...@davemloft.net>, "Vijay Pandurangan" > <vij...@vijayp.ca>, "Paolo Abeni" > <pab...@redhat.com>, netdev@vger.kernel.org > Sent: Friday, June 10, 2016 9:15:01 AM > Subject: Re: [net v3] veth: advertise peer link once both links are tied > together > > Le 08/06/2016 22:30, Lance Richardson a écrit : > [snip] > > I've been pondering how to fix this very problem off-and-on for a few > > months > > now, without having arrived at any solution that was particularly > > satisfying. > > > > The main constraints I've been trying to meet are: > > - User-space should be informed of veth pairing for both peers. > > - RTM_NEWLINK messages should not refer to interfaces that haven't > > been announced to user-space via previous RTM_NEWLINK messages. > > - The first (and only the first) RTM_NEWLINK message for a given > > interface should have ifi_changes set to ~0U, subsequent RTM_NEWLINK > > messages should have ifi_changes set to reflect the flags that > > have changed. > > > > This is the closest I've come to a satisfactory solution, it does meet > > the above constraints but still seems a little unnatural to me: > The patch looks good to me. Can you submit it formally? >
Will post in a bit, thanks! Lance