Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-30 Thread Kumar Gala
From: Anton Vorontsov <[EMAIL PROTECTED]> Subject: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure This patch converts cpmac to the new Fixed PHY infrastructure, though it doesn't fix all the problems with that driver. I didn't even bother to test this patch to compile, because cp

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
Is this going through netdev or do you want me to pick it via the powerpc route? Based on your comments I sorta assumed it was most convenient to lump in with the rest of the powerpc changes... That's fine. I'll push it via the powerpc trees. - k -- To unsubscribe from this list: send the

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into th

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-30 Thread Kumar Gala
On Jan 21, 2008, at 2:49 PM, Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following w

Re: [PATCH] FIXED_MII_100_FDX

2008-01-26 Thread Kumar Gala
On Jan 26, 2008, at 12:54 AM, Sean MacLennan wrote: On the last git pull, FIXED_MII_100_FDX was removed from the phy Kconfig, but the Kconfig for CPMAC still tried to select it. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- diff --git a/drivers/net/Kconfig b/drivers/ne

Re: [PATCH 2/5] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2008-01-25 Thread Kumar Gala
On Thu, 24 Jan 2008, Anton Vorontsov wrote: > device_type property is bogus, thus use proper compatible. > > Also change compatible property to "fsl,ucc-mdio". > > Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- >

Re: [PATCH for-2.6.25] [POWERPC] Rename commproc to cpm1 and cpm2_common.c to cpm2.c

2008-01-25 Thread Kumar Gala
On Fri, 25 Jan 2008, Jochen Friedrich wrote: > Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also > rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the > includes accordingly. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > arch/powerpc/platf

Re: [PATCH] [POWERPC] Add fixed-phy support for fs_enet

2008-01-23 Thread Kumar Gala
On Tue, 18 Dec 2007, Jochen Friedrich wrote: > This patch adds support to use the fixed-link property > of an ethernet node to fs_enet for the > CONFIG_PPC_CPM_NEW_BINDING case. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > Acked-by: Jeff Garzik <[EMAIL PROTECTED]> > Acked-by: Vitali B

Re: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property

2008-01-17 Thread Kumar Gala
On Fri, 7 Dec 2007, Vitaly Bordug wrote: > > fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that > not connected to the real MDIO bus. > > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > --- > > Documentation/powerpc/booting-

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus

2008-01-17 Thread Kumar Gala
On Fri, 7 Dec 2007, Vitaly Bordug wrote: > > ...thus use fixed-link to register proper "Fixed PHY" > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > applied. - k -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2008-01-17 Thread Kumar Gala
On Fri, 7 Dec 2007, Vitaly Bordug wrote: > > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-14 Thread Kumar Gala
On Jan 14, 2008, at 3:15 PM, Andrew Morton wrote: On Mon, 14 Jan 2008 12:00:51 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: On Thu, 10 Jan 2008 21:41:20 -0700 "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: Hello All I am waiting for more feedback on the patches. If there are no objections

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Kumar Gala
On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock p

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Kumar Gala
On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock p

Re: [PATCH 2/11] ibm_newemac: Add ET1011c PHY support

2007-11-30 Thread Kumar Gala
On Nov 30, 2007, at 2:59 PM, Benjamin Herrenschmidt wrote: On Fri, 2007-11-30 at 08:29 -0600, Olof Johansson wrote: Hi, On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote: This adds support for the Agere ET1011c PHY as found on the AMCC Taishan board. The whole p

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-20 Thread Kumar Gala
On Nov 19, 2007, at 7:30 PM, Jeff Garzik wrote: Kim Phillips wrote: On Mon, 5 Nov 2007 12:15:30 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: Hello all, the following patches fix RGMII timing for rev. 2.1 of the mpc8360, according to erratum #2 (erratum text included below). Basically the

Re: [PATCH 1/5] powerpc: document rgmii-rxid and rgmii-txid phy-connection-types

2007-11-19 Thread Kumar Gala
On Mon, 5 Nov 2007, Kim Phillips wrote: > A h/w bug requires we program the PHY in RGMII mode for internal delay > on the receive or transmit side only; document the new property values. > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > --- > Documentation/powerpc/booting-without-of.txt |

Re: [PATCH 5/5] powerpc: handle mpc8360 rev. 2.1 RGMII timing erratum

2007-11-19 Thread Kumar Gala
On Mon, 5 Nov 2007, Kim Phillips wrote: > if on a rev. 2.1, adjust UCC clock and data timing characteristics > as specified in the rev.2.1 erratum #2. > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 31 ++-- > 1 fil

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Kumar Gala
On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote: On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Valentine Barshak wrote: This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is

Re: [PATCH] gianfar: Fix compile regression caused by 09f75cd7

2007-10-15 Thread Kumar Gala
On Fri, 12 Oct 2007, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > drivers/net/gianfar.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) this patch got lost. - k > > diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c > index 2b758fa..6d1456a 1

Re: [PATCH] gianfar: Cleanup compile warning caused by 0795af57

2007-10-15 Thread Kumar Gala
On Mon, 15 Oct 2007, Jeff Garzik wrote: > Li Yang wrote: > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > > --- > > drivers/net/gianfar.c |1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > applied all three gianfar patches > Jeff, You seem to have lost one of the patches: [PATC

Re: [PATCH] gianfar: Cleanup compile warning caused by 0795af57

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] gianfar: Fix compile regression caused by 09f75cd7

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] gianfar: Fix compile regression caused by bea3348e

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Kumar Gala
On Oct 3, 2007, at 1:00 PM, Timur Tabi wrote: Stephen Hemminger wrote: Separate the changes into individual patches to allow for better comment/review and bisection in case of regression. That would be too difficult. Some of the changes are single lines, and this patch has already been

Fwd: [PATCH#2 3/4] [PPC] Compile fix for 8xx CPM Ehernet driver

2007-09-28 Thread Kumar Gala
Begin forwarded message: From: Jochen Friedrich <[EMAIL PROTECTED]> Date: September 24, 2007 12:15:35 PM CDT To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED], Marcelo Tosatti <[EMAIL PROTECTED]> Subject: [PATCH#2 3/4] [PPC] Compile fix for 8xx CPM Ehernet driver Jeff, Please pick up for 2.6.23 if

Re: [PATCH] ucc_geth: fix compilation

2007-09-18 Thread Kumar Gala
On Sep 18, 2007, at 3:56 AM, Li Yang-r58472 wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kumar Gala Sent: Friday, September 14, 2007 10:08 PM To: Jeff Garzik Cc: [EMAIL PROTECTED] list; netdev Subject: Re: [PATCH] ucc_geth: fix compilation

Re: [PATCH] ucc_geth: fix compilation

2007-09-14 Thread Kumar Gala
On Sep 13, 2007, at 10:23 AM, Anton Vorontsov wrote: Currently qe_bd_t is used in the macro call -- dma_unmap_single, which is a no-op on PPC32, thus error is hidden today. Starting with 2.6.24, macro will be replaced by the empty static function, and erroneous use of qe_bd_t will trigger compi

Re: [PATCH] ucc_geth: kill unused include

2007-08-25 Thread Kumar Gala
On Aug 24, 2007, at 11:37 PM, Jeff Garzik wrote: Kumar Gala wrote: The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala <[EM

Re: [PATCH 12/30] net: No point in casting kmalloc return values in Gianfar Ethernet Driver

2007-08-24 Thread Kumar Gala
On Aug 23, 2007, at 6:59 PM, Jesper Juhl wrote: kmalloc() returns a void ptr, so there's no need to cast its return value in drivers/net/gianfar.c . Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - k - To unsubscribe from this li

[PATCH] ucc_geth: kill unused include

2007-08-22 Thread Kumar Gala
The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Jeff, if you issue with this for 2.6.23, I'd prefer t

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-18 Thread Kumar Gala
On Aug 17, 2007, at 1:17 PM, Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM platforms are dropped from

Re: [PATCH 1/2] [POWERPC] Add support of platforms without PHY to gianfar driver

2007-07-26 Thread Kumar Gala
On Jul 25, 2007, at 4:21 PM, Jeff Garzik wrote: I'll let paulus and linuxppc merge this one (or not)... That would most likely be me, than paulus. Since this is for a Freescale PPC SoC. - k - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

[PATCH] gfar: Fix modpost warning

2007-07-25 Thread Kumar Gala
Fix the following modpost warning: WARNING: vmlinux.o(.init.text+0x1aa6c): Section mismatch: reference to .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init') Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- drivers/net/gianfar_mii.c |2 +- driver

Re: modpost warning question

2007-07-25 Thread Kumar Gala
On Jul 25, 2007, at 2:27 AM, Sam Ravnborg wrote: On Wed, Jul 25, 2007 at 02:14:12AM -0500, Kumar Gala wrote: I'm seeing the following warning: WARNING: vmlinux.o(.init.text+0x1acdc): Section mismatch: reference to .exit.text:gfar_mdio_exit (between 'gfar_init' and '

modpost warning question

2007-07-25 Thread Kumar Gala
I'm seeing the following warning: WARNING: vmlinux.o(.init.text+0x1acdc): Section mismatch: reference to .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init') I don't understand why its not ok to access .exit.text from .init.text The following addresses the issue, however I don't

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-19 Thread Kumar Gala
On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote: phy_read() returns a negative number if there's an error, but the error-checking code in the Vitesse driver's config_intr function triggers if phy_read() returns non-zero. Correct that. Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Jeff, C

Re: [PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Kumar Gala
Greg, Can you look at pulling these fixes for the next 2.6.22.x stable release. - k On Jul 17, 2007, at 12:07 AM, Jeff Garzik wrote: Andy Fleming wrote: A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was

[PATCH] gianfar: kill unused header

2007-07-12 Thread Kumar Gala
A long time ago we used OCP with the gianfar driver. Eventually when we kill arch/ppc including this will cause issues so lets just kill it now. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 4e2440a284a0bfaaf3baa0ba4de2c2300912c983 tree cd40eeafcd71577c95dc775b2e682ed852db5f71

Re: Please pull from 'from_linus' branch

2007-07-01 Thread Kumar Gala
On Jun 29, 2007, at 6:06 AM, Jeff Garzik wrote: Kumar Gala wrote: Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+),

Re: Please pull from 'from_linus' branch

2007-06-30 Thread Kumar Gala
On Jun 29, 2007, at 6:06 AM, Jeff Garzik wrote: Kumar Gala wrote: Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+),

Please pull from 'from_linus' branch

2007-06-28 Thread Kumar Gala
Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Kumar Gala (1): gianfar: Fix typo bug int

Please pull from 'from_linus' branch

2007-06-28 Thread Kumar Gala
Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/phy/mdio_bus.c |3 ++- drivers/net/phy/vitesse.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) Kum

Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

2007-05-23 Thread Kumar Gala
On May 18, 2007, at 10:33 AM, Kim Phillips wrote: On Fri, 18 May 2007 09:07:42 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: On May 17, 2007, at 8:53 PM, Jeff Garzik wrote: Kim Phillips wrote: On Tue, 15 May 2007 17:45:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Kim Ph

Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

2007-05-18 Thread Kumar Gala
On May 17, 2007, at 8:53 PM, Jeff Garzik wrote: Kim Phillips wrote: On Tue, 15 May 2007 17:45:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Kim Phillips wrote: It was agreed that phy-connection-type was a better name for the interface-type property, so this patch renames it. Also, the max

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread Kumar Gala
On May 17, 2007, at 4:01 AM, Christoph Hellwig wrote: On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote: index 49be393..830d851 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Kumar Gala
On May 16, 2007, at 3:53 AM, Auke Kok wrote: Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Kumar Gala
On Mon, 14 May 2007, Johannes Berg wrote: > Simon, > > > I don't think that this is quite right, or at least it isn't quite the > > same as before. > > Yeah, I think you're right. > > > I think that was is below will toggle > > SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected, > > which I

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Kumar Gala
On May 11, 2007, at 8:49 AM, Matvejchikov Ilya wrote: 2007/5/11, Kumar Gala <[EMAIL PROTECTED]>: On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: > Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]> > --- > > diff -purN linux-2.6.21-clean/drivers/net/phy/phy.

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Kumar Gala
On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]> --- diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c linux-2.6.21/drivers/net/phy/phy.c --- linux-2.6.21-clean/drivers/net/phy/phy.c 2007-04-26 07:08:32.0 +0400 +++ linux-2.6

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: > On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > > Try this patch: > > That certainly resolves the problem for me. > I'll see about doing something like that for the similar > Kconfig problems that I see.

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On May 10, 2007, at 8:25 PM, Simon Horman wrote: On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and "UCC_SLOW_TEMP"? At first I thought, just put it in drivers/ Kconfig, but that Kconfig does n

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: > > Simon Horman wrote: > > > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and > > >>"UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but > > >>that Kc

Re: support for bridging ethernet and 802.11

2007-05-10 Thread Kumar Gala
On May 10, 2007, at 12:25 PM, Jouni Malinen wrote: On Thu, May 10, 2007 at 07:19:35PM +0200, Johannes Berg wrote: Ah forgot about that, I had only thought about AP/wired bridging. How would the prism driver actually do bridging in STA mode though? If that is referring to Host AP driver, the

support for bridging ethernet and 802.11

2007-05-10 Thread Kumar Gala
I'm wondering how to tell if a given driver/device in the kernel supports the ability to bridge between ethernet and 802.11. From searching the web it looks like only the prism driver/device supports this. - k - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH v4] powerpc: change rheap functions to use ulongs instead of pointers

2007-05-09 Thread Kumar Gala
On Tue, 8 May 2007, Timur Tabi wrote: > The rheap allocation functions return a pointer, but the actual value is based > on how the heap was initialized, and so it can be anything, e.g. an offset > into a buffer. A ulong is a better representation of the value returned by > the allocation functio

Re: [PATCH 2/2] Rename get_property to of_get_property: drivers/net

2007-05-04 Thread Kumar Gala
On May 2, 2007, at 11:14 AM, Kumar Gala wrote: On Wed, 2 May 2007, Jeff Garzik wrote: Kumar Gala wrote: On May 2, 2007, at 9:17 AM, Jeff Garzik wrote: Kumar Gala wrote: On Apr 28, 2007, at 10:47 PM, David Miller wrote: From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Sun, 29 Ap

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Kumar Gala
On Wed, 2 May 2007, Scott Wood wrote: > Kumar Gala wrote: > > Why doesn't marking the bdp pointer volatile resolve the issue in > > gfar_clean_rx_ring() to ensure load ordering? > > Because that only addresses compiler reordering (and does so in a rather > clumsy wa

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Kumar Gala
On May 2, 2007, at 3:40 PM, Scott Wood wrote: Kumar Gala wrote: On May 2, 2007, at 3:12 PM, Scott Wood wrote: wmb() is a sync, smp_wmb() is an eieio. Andy told me he would not accept a sync in those spots. Sorry, was looking at the iobarrier code. And the driver is already ppc-specific

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Kumar Gala
On May 2, 2007, at 3:12 PM, Scott Wood wrote: Kumar Gala wrote: I'd rather see a wmb() instead of eieio() to keep this code non- ppc specific. (also, we implement wmb as eieio, so I don't keep the comment about it being too heavy, unless you mean generically). wmb() is a syn

Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Kumar Gala
On May 2, 2007, at 2:57 PM, Scott Wood wrote: The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are

Re: [PATCH 2/2] Rename get_property to of_get_property: drivers/net

2007-05-02 Thread Kumar Gala
On Wed, 2 May 2007, Jeff Garzik wrote: > Kumar Gala wrote: > > > > On May 2, 2007, at 9:17 AM, Jeff Garzik wrote: > > > > > Kumar Gala wrote: > > > > On Apr 28, 2007, at 10:47 PM, David Miller wrote: > > > > > From: Stephen Rothwell <

Re: [PATCH 2/2] Rename get_property to of_get_property: drivers/net

2007-05-02 Thread Kumar Gala
On May 2, 2007, at 9:17 AM, Jeff Garzik wrote: Kumar Gala wrote: On Apr 28, 2007, at 10:47 PM, David Miller wrote: From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Sun, 29 Apr 2007 11:44:46 +1000 So can I take this as a future OK for architecture specific network drivers changes

Re: patches for 2.6.22

2007-05-02 Thread Kumar Gala
On Apr 30, 2007, at 2:51 PM, Kim Phillips wrote: On Fri, 27 Apr 2007 21:25:19 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: If anyone has patches that I haven't picked up yet which they think should go into 2.6.22, please send me either a pointer to the these were missed: [PATCH 1/4 v5]

Re: [PATCH 2/2] Rename get_property to of_get_property: drivers/net

2007-05-02 Thread Kumar Gala
On Apr 28, 2007, at 10:47 PM, David Miller wrote: From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Sun, 29 Apr 2007 11:44:46 +1000 So can I take this as a future OK for architecture specific network drivers changes to go through the architecture trees (cc'd to you)? It's been my experience

[PATCH] Convert network devices to use struct device instead of class_device

2007-02-13 Thread Kumar Gala
Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Jeff, Sorry my mailer was completely screwed. I thought I had fixed the settings to turn of flowed text. I think this was w

[git patches] gianfar sysfs driver fix

2007-02-12 Thread Kumar Gala
-- 1 file changed, 55 insertions(+), 53 deletions(-) Kumar Gala (1): Convert network devices to use struct device instead of class_device diff --git a/drivers/net/gianfar_sysfs.c b/drivers/net/gianfar_sysfs.c index 9dd387f..6e2166a 100644 --- a/drivers/net/gianfar_sysfs.c +++ b/drivers/net/gianf

[PATCH][RESPIN] gianfar: Convert network devices to use struct device instead of class_device

2007-02-09 Thread Kumar Gala
Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Here's a respin of the patch against a recent linus.git tree. If this doesnt apply I'm at a los

Re: [NET]: Fix whitespace errors

2007-02-09 Thread Kumar Gala
On Feb 9, 2007, at 8:41 AM, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. Please pull "2.6.20-net-2.6-20070209-whitespace" branch at to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove whitespace at the end of line. under net. Tree is on top of curren

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Kumar Gala
On Feb 8, 2007, at 4:02 PM, Roland Dreier wrote: Andrew told me to drop it, so I dropped it :) That's odd -- do you know why? drivers/net/cxgb3 won't build at all in Linus's tree. I would have thought we want to fix it ASAP. I've posted a similar patch for drivers/net/gianfar_sysfs.c that

[PATCH][RESEND] gianfar: Convert network devices to use struct device instead of class_device

2007-02-08 Thread Kumar Gala
Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Got Jeff's email wrong the first time. commit 24c316396f71c6164f11ca1398151d8b15

[PATCH] Convert network devices to use struct device instead of class_device

2007-02-08 Thread Kumar Gala
Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 24c316396f71c6164f11ca1398151d8b15fd06e0 tree d02ee36eaf848d200dacf3bf795abaec1e55cbc2

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 8, 2007, at 1:36 AM, Li Yang-r58472 wrote: -Original Message- From: Kumar Gala [mailto:[EMAIL PROTECTED] Sent: Thursday, February 08, 2007 3:16 PM To: Li Yang-r58472 Cc: Tabi Timur-B04825; netdev@vger.kernel.org; linuxppc- [EMAIL PROTECTED] Subject: Re: [PATCH 1/4] ucc_geth

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 8, 2007, at 1:06 AM, Li Yang-r58472 wrote: MURAM is a mmio region so it don't share the characteristic of main memory that phy_addr = virt_addr - PAGE_OFFSET. While they can both be mapped through page table using iopa(). Right, so when do you know if you'll be using MURAM or normal m

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 8, 2007, at 12:48 AM, Li Yang-r58472 wrote: -Original Message- From: Kumar Gala [mailto:[EMAIL PROTECTED] Sent: Thursday, February 08, 2007 1:58 PM To: Li Yang-r58472 Cc: Tabi Timur-B04825; netdev@vger.kernel.org; linuxppc- [EMAIL PROTECTED] Subject: Re: [PATCH 1/4] ucc_geth

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 7, 2007, at 11:52 PM, Li Yang-r58472 wrote: -Original Message- From: Timur Tabi [mailto:[EMAIL PROTECTED] Sent: Thursday, February 08, 2007 1:03 AM To: Kumar Gala Cc: Li Yang-r58472; netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH 1/4] ucc_geth: Change private

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 7, 2007, at 10:43 AM, Timur Tabi wrote: Kumar Gala wrote: On Feb 6, 2007, at 5:31 AM, Li Yang wrote: Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Nack. iopa() isn't that generic, shouldn't we really be using the dma mapping API here? I'

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-07 Thread Kumar Gala
On Feb 7, 2007, at 3:34 AM, Li Yang-r58472 wrote: On Feb 6, 2007, at 5:31 AM, Li Yang wrote: Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Nack. iopa() isn't that generic, shouldn't we really be using the dma mapping API here? Do you mean the dma_map_single()?

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-06 Thread Kumar Gala
On Feb 6, 2007, at 5:31 AM, Li Yang wrote: Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Nack. iopa() isn't that generic, shouldn't we really be using the dma mapping API here? - k Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 29

Re: RFC: Provide setting of Link Partner Autonegotiation

2007-01-29 Thread Kumar Gala
On Jan 20, 2007, at 4:49 PM, Kumar Gala wrote: Here's the start of a patch to provide the state of the link partner's autoneg. This is useful to know if the link partner is trying to force a speed and we aren't matching. I wasn't sure how to handle this for all the

[PATCH] RFC: Broadcom PHY forcing fix

2007-01-25 Thread Kumar Gala
Maciej, I've got a BCM5461 that requires this fix to be able to force the speeds on the PHY. Not sure if its needed on the other variants or not. The problem is the genphy_config_aneg resets the PHY when forcing the speed and once we reset the BCM5461 it doesn't remember any of its settings.

RFC: Provide setting of Link Partner Autonegotiation

2007-01-20 Thread Kumar Gala
Here's the start of a patch to provide the state of the link partner's autoneg. This is useful to know if the link partner is trying to force a speed and we aren't matching. I wasn't sure how to handle this for all the drivers that handle phy's themselves. Is there some way to have this set

[PATCH] PHY: Export phy ethtool helpers

2007-01-20 Thread Kumar Gala
We need to export phy_ethtool_gset and phy_ethtool_sset to allow drivers that use these functions to be built as modules. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 7fff6ffb83f2543299df3ed8815976440abdd576 tree 0eea7a64a684a3d3970cec9a8c9c65ee2839ebfc

Re: [git patches] net driver fixes

2007-01-08 Thread Kumar Gala
On Jan 8, 2007, at 5:40 AM, Jeff Garzik wrote: Li Yang-r58472 wrote: Hi Jeff, Could you apply the updates for ucc_geth driver? The patches from Timur that make the driver compile correctly on 2.6.20. [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c [PATCH] Update ucc_geth.c

Re: [PATCH] Update ucc_geth.c for new workqueue structure

2007-01-05 Thread Kumar Gala
Jeff, Friendly reminder that this should go in for 2.6.20 - k On Dec 18, 2006, at 10:23 AM, Kumar Gala wrote: Jeff, Can you pickup this patch for 2.6.20 as it fixes a compile issue due to the workqueue changes. - kumar On Dec 13, 2006, at 5:08 PM, [EMAIL PROTECTED] wrote: From: Timur

Re: [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c

2007-01-05 Thread Kumar Gala
Jeff, Friendly reminder that this should go in for 2.6.20 - k On Dec 18, 2006, at 10:24 AM, Kumar Gala wrote: Jeff, Can you pickup this patch for 2.6.20. It addresses a name conflict issue with the phylib and the phy handling in the ucc driver. thanks - k On Dec 13, 2006, at 5:08 PM

Re: [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c

2006-12-18 Thread Kumar Gala
_write() in ucc_geth_phy.c conflict with the prototypes in include/linux/phy.h, so this patch renames them, moves them to the top of the file (while eliminating the redundant prototype), and makes them static. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> Signed-off-by: Kumar Gala <[

Re: [PATCH] Update ucc_geth.c for new workqueue structure

2006-12-18 Thread Kumar Gala
abi <[EMAIL PROTECTED]> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 1f05511..d33bb0c 100644 --- a/drivers/net/ucc_geth.c +++ b

Re: latest linux git doesn't compile ucc_geth_phy.c and ucc_geth.c

2006-12-13 Thread Kumar Gala
I just posted two patches to linuxppc-dev that fix these problems. The message are titled: [PATCH] Update ucc_geth.c for new workqueue structure [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c I've tested these on an 8360EMDS, and Kumar has reviewed and signed off on the c

Re: latest linux git doesn't compile ucc_geth_phy.c and ucc_geth.c

2006-12-13 Thread Kumar Gala
On Wed, 13 Dec 2006, Joakim Tjernlund wrote: drivers/net/ucc_geth.c:4083:45: macro "INIT_WORK" passed 3 arguments, but takes just 2 drivers/net/ucc_geth.c: In function `ucc_geth_open': drivers/net/ucc_geth.c:4083: error: `INIT_WORK' undeclared (first use in this function) drivers/net/ucc_geth.

examples of setting ip address/netmask/etc.. on a device

2006-12-12 Thread Kumar Gala
I was wondering if there were any examples of net devices that expect to be told the ip information for their connection (things doing forms of offload). If so can someone point me at a driver that does this. - kumar - To unsubscribe from this list: send the line "unsubscribe netdev" in th

status of route matching work?

2006-11-14 Thread Kumar Gala
Thomas, I came across this comment in DaveM's blog: "Next he described a way to do route matching based upon branching rules with a "GOTO" operation. Only forward GOTOs would be allowed in the tree in order to prevent loops, but this would allow to match on many key components and allow a

Re: [PATCH] Add support for configuring the PHY connection interface

2006-11-07 Thread Kumar Gala
, &fs_adjust_link, 0); + phydev = phy_connect(dev, fep->fpi->bus_id, &fs_adjust_link, 0, + PHY_INTERFACE_MODE_MII); else { printk("No phy bus ID specified in BSP code\n"); return -EINVAL; diff

BCM5461 phy issue in 10M/Full duplex

2006-10-18 Thread Kumar Gala
I was wondering if anyone has had any issues when trying to force a BCM5461 phy into 10M/full duplex. I seem to be having an issue in the two managed switches I've tried this on but autoneg to 10/half. This causes a problem in that I start seeing a large number of frame errors. I believ

use of tx_timeout in enet driver?

2006-10-13 Thread Kumar Gala
I'm working on a enet driver and trying to figure out what I should do in the tx_timeout function. The device I have doesn't interrupt on tx completions so I already have a timer loop to check to see if there have been any completions by looking at the ring pointers. So should I do somethi

Re: examples to model ethernet driver off of?

2006-09-13 Thread Kumar Gala
On Sep 13, 2006, at 3:11 PM, Auke Kok wrote: Francois Romieu wrote: Kumar Gala <[EMAIL PROTECTED]> : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) What is the feeling

examples to model ethernet driver off of?

2006-09-13 Thread Kumar Gala
What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? thanks - kumar - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH 0/2] PHYLIB: Fix forcing mode reduction

2006-07-24 Thread Kumar Gala
Jeff, Any status on accepting this patch, I've got some additional fixes that are based on having access to genphy_update_link() - kumar On Jun 5, 2006, at 6:45 PM, Nathaniel Case wrote: On Mon, 2006-06-05 at 17:08 -0500, Andy Fleming wrote: Looks good. Feel free to send these patches to

Re: [PATCH 1/3] Freescale QE UCC gigabit ethernet driver

2006-07-07 Thread Kumar Gala
On Jul 7, 2006, at 3:59 AM, Li Yang-r58472 wrote: -Original Message- From: Kumar Gala [mailto:[EMAIL PROTECTED] Sent: Thursday, July 06, 2006 9:45 PM To: Li Yang-r58472 Cc: Andrew Morton; [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH 1/3] Freescale QE

Re: [git patches] net driver fixes

2006-04-12 Thread Kumar Gala
On Apr 12, 2006, at 5:45 PM, Jeff Garzik wrote: Kumar Gala wrote: Jeff, Noticed Andy's gianfar fixes aren't in here. I'd be good to see if we can get them in for 2.6.17 Never saw them... Odd, posted to netdev, Andy may not have copied you on them. http://marc.theaimsgro

  1   2   >