[PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up

Check return value from ret_val to make error check actually work. Fixes: 4eb8080143a9 ("igc: Add setup link functionality") Signed-off-by: Kevin Lo --- diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c index 09cd0ec7ee87..67b8ffd21d8a 10

[PATCH v2] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr

This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr. Without this change it wouldn't lead to a shadow RAM write EEWR timeout. Fixes: ab4056126813 ("igc: Add NVM support") Signed-off-by: Kevin Lo --- v2: Add a Fixes tag. --- diff --git a/drivers/net/eth

Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr

On Sat, Dec 12, 2020 at 02:00:10PM -0800, Jakub Kicinski wrote: > > On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote: > > This patch sets the default return value to -IGC_ERR_NVM in > > igc_write_nvm_srwr. > > Without this change it wouldn't lead to a

[PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr

This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr. Without this change it wouldn't lead to a shadow RAM write EEWR timeout. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c

Re: [PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

On Fri, May 15, 2020 at 02:31:42PM -0700, Jakub Kicinski wrote: > > On Sat, 16 May 2020 01:24:47 +0800 Kevin Lo wrote: > > The BCM54811 PHY shares many similarities with the already supported > > BCM54810 > > PHY but additionally requires some semi-unique configuration

[PATCH net-next] net: phy: broadcom: fix checkpatch complains about tabs

This patch makes checkpatch happy for tabs Signed-off-by: Kevin Lo --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 8cd8d188542a..cd271de9609b 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -356,7 +356,7 @@ static int

Re: [PATCH net] net: phy: broadcom: add support for BCM54811 PHY

On Fri, May 15, 2020 at 08:53:37AM -0700, Florian Fainelli wrote: > > > > On 5/14/2020 10:22 PM, Kevin Lo wrote: > > The BCM54811 PHY shares many similarities with the already supported > > BCM54810 > > PHY but additionally requires some semi-unique configuratio

[PATCH net-next] net: phy: broadcom: add support for BCM54811 PHY

The BCM54811 PHY shares many similarities with the already supported BCM54810 PHY but additionally requires some semi-unique configuration. Signed-off-by: Kevin Lo Reviewed-by: Florian Fainelli --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 97201d5cf007

[PATCH net] net: phy: broadcom: add support for BCM54811 PHY

The BCM54811 PHY shares many similarities with the already supported BCM54810 PHY but additionally requires some semi-unique configuration. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index d14d91b759b7..0360a5cfdb9e 100644 --- a/drivers/net

Re: [PATCH net-next] net: phy: broadcom: fix BCM54XX_SHD_SCR3_TRDDAPD value for BCM54810

On Wed, May 13, 2020 at 06:31:29PM -0700, Florian Fainelli wrote: > > > > On 5/13/2020 5:57 PM, Kevin Lo wrote: > > Set the correct bit when checking for PHY_BRCM_DIS_TXCRXC_NOENRGY on the > > BCM54810 PHY. > > Indeed, good catch! > > > > Signed-o

[PATCH net-next] net: phy: broadcom: fix BCM54XX_SHD_SCR3_TRDDAPD value for BCM54810

Set the correct bit when checking for PHY_BRCM_DIS_TXCRXC_NOENRGY on the BCM54810 PHY. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 97201d5cf007..45d0aefb964c 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c

[PATCH net] r8152: fix typo in register name

It is likely that PAL_BDC_CR should be PLA_BDC_CR. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 39e0768d734d..0cc03a9ff545 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -50,7 +50,7 @@ #define PLA_TEREDO_WAKE_BASE