Re: [PATCH net-next 0/2] net: sched: act_ctinfo: fixes

2019-06-18 Thread Kevin 'ldir' Darbyshire-Bryant
> On 17 Jun 2019, at 22:01, David Miller wrote: > > From: Kevin Darbyshire-Bryant > Date: Mon, 17 Jun 2019 11:03:25 +0100 > >> >> If I ever get to a developer conference please feel free to >> tar/feather/apply cone of shame. > > :-) In kernel networking development we prefer brown paper

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-06-13 Thread Kevin 'ldir' Darbyshire-Bryant
> On 13 Jun 2019, at 10:33, Simon Horman wrote: > > On Wed, Jun 12, 2019 at 11:46:27AM -0700, Jakub Kicinski wrote: >> On Wed, 12 Jun 2019 15:02:39 -0300, Marcelo Ricardo Leitner wrote: >>> On Tue, May 28, 2019 at 05:03:50PM +, Kevin 'ldir&

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-06-13 Thread Kevin 'ldir' Darbyshire-Bryant
> On 13 Jun 2019, at 11:09, Kevin 'ldir' Darbyshire-Bryant > wrote: > > > Warning: Not even compile tested! Am I heading in the right direction? > I think this is even better. Does it help? Clues before I send as proper patch :-) Subject: [PATCH] sched:

Re: [PATCH iproute2-next v2] tc: add support for action act_ctinfo

2019-06-10 Thread Kevin 'ldir' Darbyshire-Bryant
> On 10 Jun 2019, at 18:33, David Ahern wrote: > > On 6/4/19 7:52 AM, Kevin Darbyshire-Bryant wrote: >> ctinfo is a tc action restoring data stored in conntrack marks to >> >> create mode 100644 include/uapi/linux/tc_act/tc_ctinfo.h >> create mode 100644 man/man8/tc-ctinfo.8 >> create mode 10

Re: [PATCH RFC iproute2-next v3] tc: add support for action act_ctinfo

2019-06-02 Thread Kevin 'ldir' Darbyshire-Bryant
> On 2 Jun 2019, at 21:39, Toke Høiland-Jørgensen wrote: > > Kevin Darbyshire-Bryant writes: > >> ctinfo is an action restoring data stored in conntrack marks to various >> fields. At present it has two independent modes of operation, >> restoration of DSCP into IPv4/v6 diffserv and restorat

Re: [PATCH RFC iproute2-next v2] tc: add support for act ctinfo

2019-06-02 Thread Kevin 'ldir' Darbyshire-Bryant
Please ignore this patch. Have just realised I’ve sent completely the wrong thing. Somehow managed to send the kernel space patch again which is already accepted. I will send a v3 of the user space patch shortly. Apologies. Kevin > On 31 May 2019, at 09:10, ldir@icloud.com wrote: > > Fro

Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

2019-05-31 Thread Kevin 'ldir' Darbyshire-Bryant
> On 30 May 2019, at 20:59, Stephen Hemminger > wrote: > > On Thu, 30 May 2019 16:43:20 +0000 > Kevin 'ldir' Darbyshire-Bryant wrote: > > Please don't use HTML encoded mail. I.e not exchange. As far as I know I’m not sending HTML emails, or I’m trying h

Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

2019-05-30 Thread Kevin 'ldir' Darbyshire-Bryant
> On 30 May 2019, at 18:32, Stephen Hemminger > wrote: > > On Thu, 30 May 2019 16:43:20 +0000 > Kevin 'ldir' Darbyshire-Bryant wrote: > >> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h >> index 51a0496f..b0c6a49a 1006

[PATCH net-next] net: sched: act_ctinfo: minor size optimisation

2019-05-30 Thread Kevin 'ldir' Darbyshire-Bryant
Since the new parameter block is initialised to 0 by kzmalloc we don't need to mask & clear unused operational mode bits, they are already unset. Drop the pointless code. Signed-off-by: Kevin Darbyshire-Bryant --- net/sched/act_ctinfo.c | 4 1 file changed, 4 deletions(-) diff --git a/net

[RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

2019-05-30 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is an action restoring data stored in conntrack marks to various fields. At present it has two independent modes of operation, restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack marks into packet skb marks. It understands a number of parameters specific to this action i

[RFC PATCH iproute2-next 0/1] tc: add support for act ctinfo

2019-05-30 Thread Kevin 'ldir' Darbyshire-Bryant
Still high on the goods of act_ctinfo being accepted into kernel net-next I thought it would be a good idea to offer the user space tc side of things to control the wee beastie. It's a pretty shameless copy/shunt/paste/hack of m_connmark and some of the other tc action control programs and does fu

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-05-30 Thread Kevin 'ldir' Darbyshire-Bryant
> On 30 May 2019, at 05:44, David Miller wrote: > > From: Kevin 'ldir' Darbyshire-Bryant > Date: Tue, 28 May 2019 17:03:50 + > >> ctinfo is a new tc filter action module. It is designed to restore >> information contained in firewall conntrack m

Re: [PATCH net-next v5] net: sched: Introduce act_ctinfo action

2019-05-29 Thread Kevin 'ldir' Darbyshire-Bryant
In fairness to everyone the below deserves a public answer: > On 27 May 2019, at 21:56, Toke Høiland-Jørgensen wrote: > > Kevin 'ldir' Darbyshire-Bryant writes: > >> I have to call it a day. I have no idea why the patches are becoming >> corrupt and

Re: [PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-05-28 Thread Kevin 'ldir' Darbyshire-Bryant
> On 28 May 2019, at 19:08, Toke Høiland-Jørgensen wrote: > > > Thank you for doing another iteration! > > No further comments on the actual code, but I still get the whitespace > issue with the patch... And now it results in stray ^M characters in the > Kconfig file, which makes the build b

[PATCH net-next v6] net: sched: Introduce act_ctinfo action

2019-05-28 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is a new tc filter action module. It is designed to restore information contained in firewall conntrack marks to other packet fields and is typically used on packet ingress paths. At present it has two independent sub-functions or operating modes, DSCP restoration mode & skb mark restorati

Re: [PATCH net-next v5] net: sched: Introduce act_ctinfo action

2019-05-27 Thread Kevin 'ldir' Darbyshire-Bryant
er I shall leave it that I’ve found the process completely discouraging. The professionals are of course paid to deal with this. > On 27 May 2019, at 16:47, Toke Høiland-Jørgensen wrote: > > Kevin 'ldir' Darbyshire-Bryant writes: > >> ctinfo is a new tc filter a

[PATCH net-next v5] net: sched: Introduce act_ctinfo action

2019-05-27 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is a new tc filter action module. It is designed to restore information contained in firewall conntrack marks to other packet fields and is typically used on packet ingress paths. At present it has two independent sub-functions or operating modes, DSCP restoration mode & skb mark restorati

Re: [PATCH net-next v4] net: sched: Introduce act_ctinfo action

2019-05-24 Thread Kevin 'ldir' Darbyshire-Bryant
> On 24 May 2019, at 11:30, Toke Høiland-Jørgensen wrote: > > Hi Kevin > > I couldn't get 'git am' to accept your email. Not sure if it's because > it's base64 encoded, or because it doesn't apply cleanly to current > net-next. Bizarre, haven’t changed the method by which I send in patches so

[PATCH net-next v4] net: sched: Introduce act_ctinfo action

2019-05-23 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is a new tc filter action module. It is designed to restore information contained in conntrack marks to other places. At present it can restore DSCP values to IPv4/6 diffserv fields and also copy conntrack marks to skb marks. As such the 2nd function effectively replaces the existing act_

[RFC net-next 1/1] net: sched: Introduce act_ctinfo action

2019-04-09 Thread Kevin 'ldir' Darbyshire-Bryant
ctinfo is a new tc filter action module. It is designed to restore DSCPs stored in conntrack marks into the ipv4/v6 diffserv field. The feature is intended for use and has been found useful for restoring ingress classifications based on egress classifications across links that bleach or otherwise

[RFC net-next 0/1] net: sched: Introduce act_ctinfo action

2019-04-09 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong & everyone. Another rename & some more tweaks. I'm not sure quite what version we're up to but on the basis of the name change (again) I'm assuming v1. Changes: Changed the netlink parameter passing to mostly indepedent flags/structures to hopefully facilitate easier future extension of

Re: [RFC net-next 0/1] net: sched: Introduce conntrack action

2019-04-03 Thread Kevin 'ldir' Darbyshire-Bryant
> On 3 Apr 2019, at 12:56, Paul Blakey wrote: > > > > Kevin 'ldir' Darbyshire-Bryant wrote on 03/04/2019 11:23: >> >> >>> On 3 Apr 2019, at 08:47, Paul Blakey wrote: >>> >>> >>> >>> Kevin 'ldir'

Re: [RFC net-next 0/1] net: sched: Introduce conntrack action

2019-04-03 Thread Kevin 'ldir' Darbyshire-Bryant
> On 3 Apr 2019, at 08:47, Paul Blakey wrote: > > > > Kevin 'ldir' Darbyshire-Bryant wrote on 02/04/2019 12:24: >> Hi Cong & all, >> >>> On 1 Apr 2019, at 22:06, Cong Wang wrote: >>> >>> On Mon, Apr 1, 2019 at 7:22 AM

Re: [RFC net-next 0/1] net: sched: Introduce conntrack action

2019-04-02 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong & all, > On 1 Apr 2019, at 22:06, Cong Wang wrote: > > On Mon, Apr 1, 2019 at 7:22 AM Paul Blakey wrote: >> > > >> >> This would probably be better off with the previous name act_conndscp. > > > If naming is the only concern here, then it is not hard to find > a name we are all s

Re: [RFC net-next 0/1] net: sched: Introduce conntrack action

2019-04-01 Thread Kevin 'ldir' Darbyshire-Bryant
> On 1 Apr 2019, at 14:14, Marcelo Ricardo Leitner > wrote: > > Hi, > > On Fri, Mar 29, 2019 at 08:45:06PM +0000, Kevin 'ldir' Darbyshire-Bryant > wrote: >> Hi Cong, >> >> OK, so I've renamed conndscp to conntrack and hopefully

[RFC net-next 0/1] net: sched: Introduce conntrack action

2019-03-29 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong, OK, so I've renamed conndscp to conntrack and hopefully this are flexible enough for future conntrack->skb operations to be added in the future. How does this one fly? Cheers, Kevin Kevin Darbyshire-Bryant (1): net: sched: Introduce conntrack action include/net/tc_act/tc_conntrack

[RFC net-next 1/1] net: sched: Introduce conntrack action

2019-03-29 Thread Kevin 'ldir' Darbyshire-Bryant
conntrack is a new tc filter action module. It is designed to restore DSCPs stored in conntrack marks The feature is intended for use and has been found useful for restoring ingress classifications based on egress classifications across links that bleach or otherwise change DSCP, typically home I

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-27 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong, Thanks for getting back to me once again and apologies for the delayed reply. > On 25 Mar 2019, at 19:17, Cong Wang wrote: > > On Sat, Mar 23, 2019 at 10:45 AM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> I will remove the functionality from c

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-23 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong, Thanks for your responses so far. > On 22 Mar 2019, at 23:09, Cong Wang wrote: > > On Fri, Mar 22, 2019 at 3:06 PM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> >> >>> On 22 Mar 2019, at 21:31, Cong Wang wrote: >>> &

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-22 Thread Kevin 'ldir' Darbyshire-Bryant
> On 22 Mar 2019, at 21:31, Cong Wang wrote: > > On Fri, Mar 22, 2019 at 1:50 PM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> >> >>> On 22 Mar 2019, at 20:05, Cong Wang wrote: >>> >>> On Fri, Mar 22, 2019 at 11:

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-22 Thread Kevin 'ldir' Darbyshire-Bryant
> On 22 Mar 2019, at 20:05, Cong Wang wrote: > > On Fri, Mar 22, 2019 at 11:26 AM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> Hi Cong, >> >> Thanks for your questions. >> >>> On 22 Mar 2019, at 17:39, Cong Wang wrote: >>

Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-22 Thread Kevin 'ldir' Darbyshire-Bryant
Hi Cong, Thanks for your questions. > On 22 Mar 2019, at 17:39, Cong Wang wrote: > > Hello, > > On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir' Darbyshire-Bryant > wrote: >> >> Conndscp is a new tc filter action module. It is designed to copy DSC

[RFC PATCH 1/1 v2] net: sched: Introduce conndscp action

2019-03-22 Thread Kevin 'ldir' Darbyshire-Bryant
Conndscp is a new tc filter action module. It is designed to copy DSCPs to conntrack marks and the reverse operation of conntrack mark contained DSCPs to the diffserv field of suitable skbs. The feature is intended for use and has been found useful for restoring ingress classifications based on e

[PATCH 1/1] net: sched: Introduce conndscp action

2019-03-19 Thread Kevin 'ldir' Darbyshire-Bryant
Conndscp is a new tc filter action module. It is designed to copy DSCPs to conntrack marks and the reverse operation of conntrack mark contained DSCPs to the diffserv field of suitable skbs. The feature is intended for use and has been found useful for restoring ingress classifications based on e

[RFC PATCH 0/1 net-next] net: sched: Introduce conndscp action

2019-03-19 Thread Kevin 'ldir' Darbyshire-Bryant
With nervousness and trepidation I'm submitting the attached RFC patch for 'conndscp'. Conndscp is a new tc filter action module. It is designed to copy DSCPs to conntrack marks and the reverse operation of conntrack mark contained DSCPs to the diffserv field of suitable skbs. The feature is int

[PATCH iproute2-next] tc: m_connmark: fix action error messages

2019-03-15 Thread Kevin 'ldir' Darbyshire-Bryant
action m_connmark returns error messages identifying itself as the 'simple' action instead of 'connmark' action. e.g. tc filter add dev eth0 protocol all u32 match u32 0 0 flowid 1:1 \ action connmark index wrong simple: Illegal "index" bad action parsing parse_action: bad value (3:connmar