Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [9/9] netconsole: Support dynamic reconfiguration using configfs > > This patch introduces support for dynamic reconfiguration (adding, removing > and/or modifying parameters of netconsole targets at runtime) using a > userspace interface

Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [8/9] netconsole: Support multiple logging targets > > This patch introduces support for multiple targets: > > Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful > even in the default case and (including the infras

Re: [PATCH v2 -mm 6/9] netconsole: Introduce netconsole_netdev_notifier

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [6/9] netconsole: Introduce netconsole_netdev_notifier > > To update fields of underlying netpoll structure at runtime on > corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications. > > ioctl(SIOCSIFHWADDR) {or ioctl(SIOCSIFNAME

Re: [PATCH v2 -mm 7/9] netconsole: Use netif_running() in write_msg()

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [7/9] netconsole: Use netif_running() in write_msg() > > Avoid unnecessarily disabling interrupts and calling netpoll_send_udp() > if the corresponding local interface is not up. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Cc:

Re: [PATCH v2 (updated) -mm 4/9] netconsole: Add some useful tips to documentation

Hi Satyam, > [4/9 (updated)] netconsole: Add some useful tips to documentation > > Add some useful general-purpose tips. Also suggest solution for the frequent > problem of console_loglevel set too low numerically (i.e. for high priority > messages only) on the sender. > > Cc: Matt Mackall <[EMA

Re: [PATCH v2 -mm 5/9] netconsole: Introduce netconsole_target

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [5/9] netconsole: Introduce netconsole_target > > Introduce a wrapper structure over netpoll to represent logging targets > configured in netconsole. This will get extended with other members in > further patches. > > The original patchse

Re: [PATCH v2 -mm 3/9] netconsole: Simplify boot/module option setup logic

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [3/9] netconsole: Simplify boot/module option setup logic > > Presently, for built-in netconsole: > > __setup(..., option_setup) ensures that the option_setup() function is > called at boot-time from obsolete_checksetup() with the string

Re: [PATCH v2 -mm 2/9] netconsole: Remove bogus check

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [2/9] netconsole: Remove bogus check > > The (!np.dev) check in write_msg() is bogus (always false), because: > np.dev is set by netpoll_setup(), which is called by the target init > code in init_netconsole() _before_ register_console() =>

Re: [PATCH v2 -mm 1/9] netconsole: Cleanups, codingstyle, prettyfication

Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [1/9] netconsole: Cleanups, codingstyle, prettyfication > > (1) Remove unwanted headers. > (2) Mark __init and __exit as appropriate. > (3) Various trivial codingstyle and prettification stuff. > > Signed-off-by: Satyam Sharma <[EMAIL PRO

Re: [RFC][PATCH v2 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

Hi Satyam, > [0/9] netconsole: Multiple targets and dynamic reconfigurability > > This patchset is a rework of the original idea and patches posted by > Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72 > > This is v2 of the patchset, the previous version is available at: > h

Re: [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_notifier

Hi Satyam, > [4/9] netconsole: Introduce netconsole_netdev_notifier > > To update fields of underlying netpoll structure at runtime on > corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Cc: Keiichi Kii <[EMAIL PROTECTED]>

Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

Hi Satyam, > After more discussion, Joel suggested the idea to separately manage the > lifetimes of the two kinds of netconsole_target objects, those created while > parsing boot/module options and those created via configfs mkdir(2) from > userspace, in my driver itself. That adds a little bit of

Re: [PATCH -mm 8/9] netconsole: Update documentation for dynamic reconfigurability

Hi Satyam, BTW I did some testing myself, and have found another *embarrassing* bug: if netconsole is loaded _without_ specifying any "netconsole=" parameter, module is still kept loaded, but on unloading configfs_unregister_...() obviously panics! :-) This should've been found by me earlier, ju

Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

Hi Satyam, The following comments aren't essential. > if (!(event == NETDEV_UP || event == NETDEV_DOWN || > event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > - goto done; > + goto done; The above diff lines are extra. > + spin_lock_irqsav