Hi Satyam, > From: Satyam Sharma <[EMAIL PROTECTED]> > > [3/9] netconsole: Simplify boot/module option setup logic > > Presently, for built-in netconsole: > > __setup(..., option_setup) ensures that the option_setup() function is > called at boot-time from obsolete_checksetup() with the string matching > "netconsole=" passed to it from the kernel's command line. We call the > netpoll_parse_options() from in there, and populate the netpoll struct > with the passed values. Then, when init_netconsole() is called during the > initcall phase, strlen(config) fails, thus skipping option_setup(). > > For modular netconsole: > > module_param_string() ensures that the string corresponding to the > "netconsole" module parameter passed from the modprobe command line is > copied into the "config" static variable. This time, when the module is > being initialized, strlen(config) is true and so option_setup() is called > on "config" from init_netconsole() and the input string is parsed and the > netpoll struct populated. > > Hence, quite different things happen in the copying and parsing of the > passed netpoll parameters for the modular / built-in cases. This patch > makes both of them similar by doing exactly the equivalent of a > module_param_string() in option_setup() also -- just copying the param > string passed from the kernel command line into the "config" static > variable. So, init_netconsole() parses (using netpoll_parse_options()) > it in both the cases, and makes the logic somewhat simpler. > > Now, option_setup() is only ever called / used for the built-in case, > so we put it inside a #ifndef MODULE, otherwise gcc will complain about > option_setup() being "defined but not used". > > Also, the "configured" variable is redundant with this patch and so removed. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > Cc: Keiichi Kii <[EMAIL PROTECTED]> > Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]>
Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
