Re: [PATCH net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments.

> On Aug 25, 2019, at 1:40 PM, Pravin Shelar wrote: > > Actually I am not sure about this change. caller of this function > (ovs_ct_execute()) does skb-pull and push of L2 header, calling > ovs_flow_key_update() is not safe here, it expect skb data to point to > L2 header. Thanks for the feedb

[PATCH net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments.

ce we have a reassembled datagram. Signed-off-by: Justin Pettit --- net/openvswitch/conntrack.c | 4 1 file changed, 4 insertions(+) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 848c6eb55064..f40ad2a42086 100644 --- a/net/openvswitch/conntrack.c +++

[PATCH net 2/2] openvswitch: Clear the L4 portion of the key for "later" fragments.

would be sent in the key for "later" fragments. This patch clears the L4 fields in that circumstance to prevent sending those garbage values as part of the upcall. Signed-off-by: Justin Pettit --- net/openvswitch/flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff -

[PATCH net] openvswitch: meter: Fix setting meter id for new entries

cture") Signed-off-by: Justin Pettit Cc: Andy Zhou --- net/openvswitch/meter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c index b891a91577f8..c038e021a591 100644 --- a/net/openvswitch/meter.c +++ b/net/o

Issue in __vlan_put_tag?

The function __vlan_put_tag modifies adds a VLAN tag to an existing Ethernet packet. In the process, the front of the packet is extended by four bytes to accommodate the tag. This function correctly adjusts the mac_header offset, but I think this line is problematic: skb->network_