On 14.04.21 15:19, Sven Van Asbroeck wrote:
> Hi Julian,
>
> On Wed, Apr 14, 2021 at 8:53 AM Julian Wiedmann wrote:
>>
>> On a cursory glance, using __netdev_alloc_skb_ip_align() here should
>> allow you to get rid of all the RX_HEAD_PADDING gymnastics.
>>
>&
On 09.04.21 02:39, Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> The ethernet frame length is calculated incorrectly. Depending on
> the value of RX_HEAD_PADDING, this may result in ethernet frames
> that are too short (cut off at the end), or too long (garbage added
> to the end).
>
>
On 29.03.21 14:13, Eric Dumazet wrote:
> On Mon, Mar 29, 2021 at 12:30 PM Kurt Kanzenbach wrote:
>>
>> On Mon Mar 29 2021, Eric Dumazet wrote:
>>> Note that last year, I addressed the issue differently in commit
>>> 96cc4b69581db68efc9749ef32e9cf8e0160c509
>>> ("macvlan: do not assume mac_header i
Pending TX buffers are completed from the same NAPI code as normal
TX buffers. Pass the NAPI budget to qeth_tx_complete_buf() so that
the freeing of the completed skbs can be deferred.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 8
1 file changed, 4
name.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index a814698387bc..abd1e49cf97a 100644
--- a/drivers/s390/net/qeth_core_ma
The callbacks have been slimmed down to a level where they no longer do
any actual work. So stop pretending that we support the
NETIF_F_HW_VLAN_CTAG_FILTER feature.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 25 +
1 file changed, 1 insertion
Hi Dave & Jakub,
please apply the following patch series for qeth to netdev's net-next
tree.
This brings two small optimizations (replace a hard-coded GFP_ATOMIC,
pass through the NAPI budget to enable napi_consume_skb()), and removes
some redundant VLAN filter code.
Thanks,
Julia
storage blocks")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index 3763cd6d14f8..d0a56afec028 100644
--
queue list_head,
and scan this list on every TX NAPI cycle.
Fixes: 0da9581ddb0f ("qeth: exploit asynchronous delivery of storage blocks")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 3 +-
drivers/s390/net/qeth_core_main.c | 69 +--
completion path.
Fixes: 8908f36d20d8 ("s390/qeth: fix af_iucv notification race")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_ma
teardown path.
Thanks,
Julian
Julian Wiedmann (4):
s390/qeth: fix memory leak after failed TX Buffer allocation
s390/qeth: improve completion of pending TX buffers
s390/qeth: schedule TX NAPI on QAOB completion
s390/qeth: fix notification for pending buffers during teardown
drivers
tput_queue(), and deal with
such errors internally.
Fixes: 0da9581ddb0f ("qeth: exploit asynchronous delivery of storage blocks")
Signed-off-by: Julian Wiedmann
Reviewed-by: Alexandra Winter
---
drivers/s390/net/qeth_core_main.c | 35 +++
1 file changed,
On 08.02.21 18:59, Taehee Yoo wrote:
> MLD module's context is atomic although most logic is called from
> control-path, not data path. Only a few functions are called from
> datapath, most of the functions are called from the control-path.
> Furthermore, MLD's response is not processed immediately
On 01.02.21 06:57, Xie He wrote:
> When sending a packet, we will prepend it with an LAPB header.
> This modifies the shared parts of a cloned skb, so we should copy the
> skb rather than just clone it, before we prepend the header.
>
> In "Documentation/networking/driver.rst" (the 2nd point), it
Whoever called iucv_sk(sk)->sk_txnotify() must already know that they're
dealing with an af_iucv socket.
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv
c4ab4>] system_call+0xe0/0x28c arch/s390/kernel/entry.S:415
Last Breaking-Event-Address:
[<b8dc64d4>] __s390_indirect_jump_r14+0x0/0xc
Malformed RX packets shouldn't generate any warnings because
debugging info already flows to dropmon via the kfree_skb().
Signed-off-by: Alexander Egorenkov
kbs' shinfo location) is
frustratingly fragile, and breaks if the skb's head is mangled in any
sort of way while passing from dev_queue_xmit() to the device's
HW queue.
Also adjust the interface for ->sk_txnotify(), to make clear that we
don't actually care about any skb interna
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 0e0656db4ae7..6092d5cb7168 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -256,7 +256,9 @@ static int afiucv
look at the skb list's
fill level.
Signed-off-by: Julian Wiedmann
---
include/net/iucv/af_iucv.h | 1 +
net/iucv/af_iucv.c | 30 --
2 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.
an
Alexander Egorenkov (1):
net/af_iucv: remove WARN_ONCE on malformed RX packets
Julian Wiedmann (4):
net/af_iucv: don't lookup the socket on TX notification
net/af_iucv: count packets in the xmit path
net/af_iucv: don't track individual TX skbs for TRANS_HIPER sockets
net/af_
Hi Dave & Jakub,
please apply the following patch series for qeth to netdev's net-next tree.
Nothing special, mostly fine-tuning and follow-on cleanups for earlier fixes.
Thanks,
Julian
Julian Wiedmann (5):
s390/qeth: clean up load/remove code for disciplines
s390/qet
processing accordingly.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 34 ---
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index de9d27e1c529..ea2e139cd592 10
stead that does the right thing.
When later building the HW header for such skbs, don't hard-code the
cast type but follow the same path as for other protocol types. Here
the cast type should naturally come from the skb's queue mapping.
Signed-off-by: Julian Wiedmann
---
d
We have two usage patterns:
1. get & ->setup() a new discipline, or
2. ->remove() & put the currently loaded one.
Add corresponding helpers that hide the internals & error handling.
Signed-off-by: Julian Wiedmann
Reviewed-by: Alexandra Winter
---
drivers/s390/net/qet
statement.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 40 -
drivers/s390/net/qeth_core_main.c | 18 +-
drivers/s390/net/qeth_l2_main.c | 6 ++--
drivers/s390/net/qeth_l3_main.c | 60 ++-
4 files changed, 62
qeth_l3_hard_start_xmit() already determined the skb's proto. Avoid
doing so a second time when it calls qeth_l3_get_cast_type().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/s39
patch by Ursula Braun.
Fixes: 9dc48ccc68b9 ("qeth: serialize sysfs-triggered device configurations")
Signed-off-by: Julian Wiedmann
Reviewed-by: Alexandra Winter
---
drivers/s390/net/qeth_core_main.c | 7 +--
drivers/s390/net/qeth_l2_main.c | 5 +
drivers/s390/net/qeth_l3_ma
Hi Dave & Jakub,
please apply the following patch series to netdev's net tree.
This brings two locking fixes for the device control path.
Also one fix for a path where our .ndo_features_check() attempts to
access a non-existent L2 header.
Thanks,
Julian
Julian Wiedmann (3):
s390/
() itself is under no risk
of having card->discipline ripped out while it's running, and thus
doesn't need to take the discipline_mutex.
Fixes: 9dc48ccc68b9 ("qeth: serialize sysfs-triggered device configurations")
Signed-off-by: Julian Wiedmann
Reviewed-by: Alexandra Winter
Fixes: f13ade199391 ("s390/qeth: run non-offload L3 traffic over common xmit
path")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
ind
On 21.12.20 12:23, Jason A. Donenfeld wrote:
> Hi Dmitry,
>
...
> fall on the border of a mapping? Is UBSAN non-deterministic as an
> optimization? Or is there actually some mysterious UaF happening with
> my usage of skbs that I shouldn't overlook?
>
One oddity is that wg_xmit() returns negat
re.c:629:30:got restricted __be16 [usertype]
The TUNNEL_* types are big-endian, so adjust the type of the local
variable in ip_tun_parse_opts().
Cc: Alexey Kuznetsov
Cc: Hideaki YOSHIFUJI
Signed-off-by: Julian Wiedmann
---
net/ipv4/ip_tunnel_core.c | 9 +
1 file chan
flavour of byte-swap. Use ntohs(), which of course
gives the same result.
Cc: Dmitry Kozlov
Signed-off-by: Julian Wiedmann
---
drivers/net/ppp/pptp.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
index ee5058445d06..0
On 13.12.20 18:20, Vincent Stehlé wrote:
> The ndo_start_xmit() method must not attempt to free the skb to transmit
> when returning NETDEV_TX_BUSY. Fix the korina_send_packet() function
> accordingly.
>
> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
> Signed-off-by: V
On 07.12.20 16:57, David Miller wrote:
> From: Julian Wiedmann
> Date: Mon, 7 Dec 2020 14:12:27 +0100
>
>> Hi Jakub,
>>
>> please apply the following patch series for qeth to netdev's net-next tree.
>>
>> Some sysfs cleanups (with the prep wo
INIT_LIST_HEAD() only needs to be called on actual list heads.
While at it clarify the naming of the field.
Suggested-by: Vasily Gorbik
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 2 +-
drivers/s390/net/qeth_core_main.c | 9 -
2 files changed, 5 insertions
igned-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index da27ef451d05..f4b60294a969 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers
patch from the previous net-next submission.
Thanks,
Julian
Julian Wiedmann (6):
s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry
s390/ccwgroup: use bus->dev_groups for bus-based sysfs attributes
s390/qeth: use dev->groups for common sysfs attributes
s390/qeth:
ration for
qeth_init_qdio_out_buf().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 89 ++-
1 file changed, 51 insertions(+), 38 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index 05d0b16bd7d6..869694217
Reuse the QETH_QDIO_BUF_EMPTY state to indicate that a TX buffer has
been completed with a QAOB notification, and may be cleaned up by
qeth_cleanup_handled_pending().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 2 --
drivers/s390/net/qeth_core_main.c | 5 ++---
2
ned-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 6 ++---
drivers/s390/net/qeth_core_main.c | 7 --
drivers/s390/net/qeth_core_sys.c | 41 ++-
drivers/s390/net/qeth_l2.h| 2 --
drivers/s390/net/qeth_l2_main.c | 4 +--
drivers/s390/
GROUPS() to get rid
of some boilerplate code.
Signed-off-by: Julian Wiedmann
Acked-by: Heiko Carstens
---
drivers/s390/cio/ccwgroup.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index 483a9ecfcbb1..444385
This gets us compile-time size checking.
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index db7d888914fa..882f028992c3 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv
On 02.12.20 14:45, Enrico Weigelt, metux IT consult wrote:
> Use netdev_info() instead of pr_info() for more consistent log output.
>
> Signed-off-by: Enrico Weigelt
> ---
> net/8021q/vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021
argument passed by the
caller, which usually knows the context.
The call chain of ctcmpc_unpack_skb():
ctcmpc_bh()
-> ctcmpc_unpack_skb()
ctcmpc_bh() is a tasklet handler so GFP_ATOMIC is needed.
Use GFP_ATOMIC as allocation type in ctcmpc_unpack_skb().
Reviewed-by: Julian Wiedmann
Signed-
id an allocation of struct pdu and use the resulting skb pointer
instead.
Signed-off-by: Sebastian Andrzej Siewior
[jwi: Fix-up the pdu_offset, adjust skb->len for the pushed length.
Reflow the commit msg.]
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/ctcm_mai
Avoid an allocation of struct qllc and use the resulting skb pointer
instead.
Signed-off-by: Sebastian Andrzej Siewior
[jwi: remove a newline, reflow the commit msg]
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/ctcm_mpc.c | 21 -
1 file changed, 4 insertions(+
x27;s data part instead of using memcpy() for it.
Avoid an allocation of struct th_sweep/th_header and use the resulting
skb pointer instead.
Signed-off-by: Sebastian Andrzej Siewior
[jwi: use skb_put_zero(), instead of skb_put() + memset to 0]
Signed-off-by: Julian Wiedmann
---
drivers/s39
argument passed by the
caller, which usually knows the context.
The memory allocation of `ch' a few lines above is using GFP_KERNEL,
also an allocation a few lines later is using GFP_KERNEL.
Use GFP_KERNEL for the memory allocation.
Reviewed-by: Julian Wiedmann
Signed-off-by: Sebastian An
Wiedmann
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/ctcm_main.c | 2 +-
drivers/s390/net/ctcm_main.h | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index
Hi Jakub,
please apply the following patch series for ctcm to netdev's net-next tree.
Some rare ctcm updates by Sebastian, who cleans up all places where
in_interrupt() was used to determine the correct GFP_* mask for
allocations.
In the first three patches we can get rid of those allocations ent
n skb_dump() right).
Fixes: eac3731bd04c ("[S390]: Add AF_IUCV socket support")
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 047238f01ba6..db7d888914fa 100
From: Alexandra Winter
Remove workaround that supported early hardware implementations
of PNSO OC3. Rely on the 'enarf' feature bit instead.
Fixes: fa115adff2c1 ("s390/qeth: Detect PNSO OC3 capability")
Signed-off-by: Alexandra Winter
Reviewed-by: Julian Wiedmann
[jwi: us
tracking of pending transmits.
Rework the notification code, so that qeth_qdio_handle_aob() defers its
notification if the TX completion code is still active.
Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport")
Signed-off-by: Julian Wiedmann
---
driver
if there's any issues on their end.
Thanks,
Julian
Alexandra Winter (1):
s390/qeth: Remove pnso workaround
Julian Wiedmann (3):
s390/qeth: make af_iucv TX notification call more robust
s390/qeth: fix af_iucv notification race
s390/qeth: fix tear down of async TX buffers
d
se it after a potential recovery has
completed. The qeth_clear_output_buffer() in qeth_drain_output_queue()
will ensure that it's in a clean state again.
Fixes: 72861ae792c2 ("qeth: recovery through asynchronous delivery")
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_cor
Calling into socket code is ugly already, at least check whether we are
dealing with the expected sk_family. Only looking at skb->protocol is
bound to cause troubles (consider eg. af_packet).
Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport")
Signed-o
On 19.11.20 03:35, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 17:15:11 +0100 Julian Wiedmann wrote:
>> please apply the following patch series for qeth to netdev's net-next tree.
>>
>> This brings some cleanups, and a bunch of improvements for our
>> .get_lin
INIT_LIST_HEAD() only needs to be called on actual list heads.
While at it clarify the naming of the field.
Suggested-by: Vasily Gorbik
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 2 +-
drivers/s390/net/qeth_core_main.c | 9 -
2 files changed, 5 insertions
call_switchdev_notifiers() doesn't require holding the RTNL lock since
commit ff5cf100110c ("net: switchdev: Change notifier chain to be atomic").
We still need it for the "lost event" slow path, to avoid racing against
a concurrent .ndo_bridge_setlink().
Signed-off-by:
(ie. it's much more likely that any future link_type
will represent a PORT_FIBRE link ...).
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_ethtool.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/s390/net/qeth_ethtool.c b/d
Hi Jakub,
please apply the following patch series for qeth to netdev's net-next tree.
This brings some cleanups, and a bunch of improvements for our
.get_link_ksettings() code.
Julian Wiedmann (8):
s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry
s390/qeth: reduce r
ferentiate between 1baseSR and 1baseLR, use the detailed
media_type information that QUERY OAT provides.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 7 ++
drivers/s390/net/qeth_core_main.c | 11 +++
drivers/s390/net/qeth_ethtool.c | 124 ++-
#x27; cases for
SPEED_UNKNOWN, PORT_OTHER and DUPLEX_UNKNOWN.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 14 +++---
drivers/s390/net/qeth_core_main.c | 67 +---
drivers/s390/net/qeth_ethtool.c | 74 +--
3 files changed
recent OSA adapter generations (where the .card_type field in
QUERY CARD INFO is no longer sufficient).
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 107 ++
drivers/s390/net/qeth_core_mpc.h | 40 ++-
2 files changed, 145 insertions(+), 2
By the time that our .get_link_ksettings() code issues a QUERY CARD INFO
cmd to get link-related information, we already set up a good amount of
static link data.
Return this data when the cmd fails, same as when the cmd is not
supported.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net
d-by: Tosk Robot
Signed-off-by: Kaixu Xia
[jwi: point to the commit that introduced this]
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_ma
uture type.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 1 +
drivers/s390/net/qeth_core_main.c | 38 +++
drivers/s390/net/qeth_ethtool.c | 34 +++
3 files changed, 42 insertions(+), 31 deletions(-)
diff --git a/driver
Hi Jakub,
please apply the following patch series to netdev's net tree.
One fix in the shutdown path for af_iucv sockets. This is relevant for
stable as well.
Also sending along an update for the Maintainers file.
v1 -> v2: use the correct Fixes tag in patch 1 (Jakub)
Thanks,
Julian
Ursula Bra
From: Ursula Braun
I am retiring soon. Thus this patch removes myself from the
MAINTAINERS file (s390 network).
Signed-off-by: Ursula Braun
[jwi: fix up the subject]
Signed-off-by: Julian Wiedmann
---
MAINTAINERS | 3 ---
1 file changed, 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
shutdown for HS transport")
Reviewed-by: Vasily Gorbik
Signed-off-by: Ursula Braun
[jwi: correct one Fixes tag]
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index d8057207
On 06.11.20 18:59, Jakub Kicinski wrote:
> On Fri, 6 Nov 2020 13:50:07 +0100 Julian Wiedmann wrote:
>> From: Ursula Braun
>>
>> syzbot reported the following KASAN finding:
>>
>> BUG: KASAN: nullptr-dereference in iucv_send_ctrl+0x390/0x3f0
>> net/iucv/
shutdown for HS transport")
Reviewed-by: Vasily Gorbik
Signed-off-by: Ursula Braun
Signed-off-by: Julian Wiedmann
---
net/iucv/af_iucv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index d80572074667..047238f01ba6 100644
---
From: Ursula Braun
I am retiring soon. Thus this patch removes myself from the
MAINTAINERS file (s390 network).
Signed-off-by: Ursula Braun
[jwi: fix up the subject]
Signed-off-by: Julian Wiedmann
---
MAINTAINERS | 3 ---
1 file changed, 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
Hi Jakub,
please apply the following patch series to netdev's net tree.
One fix in the shutdown path for af_iucv sockets. This is relevant for
stable as well.
Also sending along an update for the Maintainers file.
Thanks,
Julian
Ursula Braun (2):
net/af_iucv: fix null pointer dereference on s
On 03.11.20 18:13, Vladimir Oltean wrote:
> On Thu, Oct 29, 2020 at 10:10:56AM +0200, Claudiu Manoil wrote:
>> When PTP timestamping is enabled on Tx, the controller
>> inserts the Tx timestamp at the beginning of the frame
>> buffer, between SFD and the L2 frame header. This means
>> that the skb
e data after the
.siucv_user_id field, and we checked the size of the passed data earlier
on. So the memcpy() won't accidentally read from an invalid location.
Fix the warning by reducing the size of the uid variable to what's
actually needed, and thus reducing the amount of copied da
Hi Dave & Jakub,
please apply the following patch series for iucv to netdev's net-next
tree.
Just two (rare) patches, and both deal with smatch warnings.
Thanks,
Julian
Julian Wiedmann (2):
net/af_iucv: right-size the uid variable in iucv_sock_bind()
net/iucv: fix inden
smatch complains about
net/iucv/iucv.c:1119 __iucv_message_receive() warn: inconsistent indenting
While touching this line, also make the return logic consistent and thus
get rid of a goto label.
Signed-off-by: Julian Wiedmann
Reviewed-by: Karsten Graul
---
net/iucv/iucv.c | 8 +++-
1
Replace our custom version of netdev_name().
Once we started to allocate the netdev at probe time with
commit d3d1b205e89f ("s390/qeth: allocate netdevice early"), this
stopped working as intended anyway.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 3 -
aced ctc driver")
Reviewed-by: Julian Wiedmann
Signed-off-by: Vasily Gorbik
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/ctcm_fsms.h | 1 -
drivers/s390/net/ctcm_mpc.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/s390/net/ctcm_fsms.h b/drivers/s390/net/ctcm_fsms.
The discipline struct is a fixed group of function pointers.
So declare the L2 and L3 disciplines as constant.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h| 6 +++---
drivers/s390/net/qeth_l2_main.c | 2 +-
drivers/s390/net/qeth_l3_main.c | 2 +-
3 files changed, 5
- Add/delete some blanks, white spaces and braces.
- Fix misindentations.
- Adjust a deprecated header include, and htons() conversion.
- Remove extra 'return' statements.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 7 ---
drivers/s390/net/qeth_core_m
ith a minimal
number of TX queues for compatibility reasons.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 18 +
drivers/s390/net/qeth_core_main.c | 32 ---
drivers/s390/net/qeth_core_sys.c | 4 +++-
drivers/s390/net/qeth_etht
Use a proper struct, and only program the QIB extensions for devices
where they are supported.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 11 ++
drivers/s390/net/qeth_core_main.c | 65 ++-
2 files changed, 41 insertions(+), 35
we can't re-enable the actually expected number of TX queues later
because we lost the needed information.
So keep track of the wanted TX queues (on initial setup, and whenever
its changed via .set_channels), and later use that information when
re-enabling the netdevice.
Signed-off-by
cleanups.
(Even one for ctcm!)
Thanks,
Julian
Julian Wiedmann (6):
s390/qeth: keep track of wanted TX queues
s390/qeth: de-magic the QIB parm area
s390/qeth: allow configuration of TX queues for OSA devices
s390/qeth: constify the disciplines
s390/qeth: use netdev_name()
s390/qeth: stati
On 23.09.20 12:55, David Laight wrote:
> From: Julian Wiedmann
>> Sent: 23 September 2020 09:37
>>
>> Indicate the max number of to-be-parsed characters, and avoid copying
>> the address sub-string.
>>
>> Signed-off-by: Julian Wiedmann
>>
.
Thanks,
Julian
Julian Wiedmann (9):
s390/qeth: don't init refcount twice for mcast IPs
s390/qeth: relax locking for ipato config data
s390/qeth: clean up string ops in qeth_l3_parse_ipatoe()
s390/qeth: replace deprecated simple_stroul()
s390/qeth: tighten ucast IP locking
s39
onger needed.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h| 7 +--
drivers/s390/net/qeth_l3_main.c | 4
drivers/s390/net/qeth_l3_sys.c | 22 +++---
3 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/s390/net/qeth_core.h b/driv
Move duplicated code from the disciplines into the core path.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 6 +
drivers/s390/net/qeth_core_main.c | 41 ---
drivers/s390/net/qeth_l2_main.c | 20 +--
drivers/s390/net
Convert the remaining occurences in sysfs code to kstrtouint().
While at it move some input parsing out of locked sections, replace an
open-coded clamp() and remove some unnecessary run-time checks for
ipatoe->mask_bits that are already enforced when creating the object.
Signed-off-by: Jul
mcast IP objects are allocated within qeth_l3_add_mcast_rtnl(),
with .ref_counter already set to 1 via qeth_l3_init_ipaddr().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net
step a little earlier into the teardown sequence.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 1 -
drivers/s390/net/qeth_core_main.c | 6 --
drivers/s390/net/qeth_l2_main.c | 4 +---
drivers/s390/net/qeth_l3_main.c | 1 -
4 files changed, 5 insertions(+), 7
Shuffle some code around (primarily all the discipline-related stuff) to
get rid of all the unnecessary forward declarations.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l2.h | 7 +
drivers/s390/net/qeth_l2_main.c | 378 +++-
2 files changed, 188
in mind, we can now drop the conf_mutex from the
qeth_l3_modify_rxip_vipa() wrapper.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
them to the
common qeth_set_offline().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 4 ---
drivers/s390/net/qeth_core_main.c | 24 ++-
drivers/s390/net/qeth_l2_main.c | 50 +++
drivers/s390/net/qeth_l3_main.c | 46
Indicate the max number of to-be-parsed characters, and avoid copying
the address sub-string.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_l3_sys.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_sys.c b
can be used in the
bridge.
The card reports all MACs that are in its FDB, but we must not pass on
MACs that are registered for this interface.
Signed-off-by: Alexandra Winter
Reviewed-by: Julian Wiedmann
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h| 1 +
drivers/s390
n be attached to other
NICs with different properties.
2) We want a means to enable this notification explicitly. There may be
cases where a bridgeport is set to 'learning', but we do not want to
enable the notification.
Signed-off-by: Alexandra Winter
Reviewed-by: Julian Wiedmann
Sign
1 - 100 of 609 matches
Mail list logo
