Re: [PATCH v2 net-next] net: netlink: Update attr validation to require exact length for some types

2017-12-01 Thread Jouni Malinen
if the kernel is updated without a user space fix going in first. -- Jouni MalinenPGP id EFC895FA

Re: [PATCH] bridge: Add support for IEEE 802.11 Proxy ARP for IPv6

2017-03-06 Thread Jouni Malinen
modify the frame to change the source address. Would you happen to know any convenient means for modifying the IPv6 stack behavior for ndisc_send_skb() cases conditionally to allow the link layer source address to be modified while still being able to use the existing I

[PATCH] bridge: Add support for IEEE 802.11 Proxy ARP for IPv6

2017-02-24 Thread Jouni Malinen
nk layer header needs to be built with a custom function instead of going through the existing ndisc.c implementation. Signed-off-by: Jouni Malinen --- net/bridge/br_multicast.c | 268 ++ 1 file changed, 268 insertions(+) diff --git a/net/bridge/br_mu

Re: [PATCH] mac80211_hwsim: Added vendor echo command

2016-06-25 Thread Jouni Malinen
hat requests a new subcommand/attribute to be assigned and once that gets applied to the hostap.git master branch, the values have been assigned and can be used for whatever purpose they were assigned, e.g., in mac80211_hwsim. More details on how to make such a

Re: [PATCH] mac80211_hwsim: Added vendor echo command

2016-06-24 Thread Jouni Malinen
e, a value that have already been assigned for a completely different purpose. -- Jouni MalinenPGP id EFC895FA

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread Jouni Malinen
there, so if someone needs python code to do rfkill operations..). -- Jouni MalinenPGP id EFC895FA

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-26 Thread Jouni Malinen
if (rfkill->idx == ev.idx && rfkill->type == ev.type) + if (rfkill->idx == ev.idx && + (rfkill->type == ev.type || +ev.type == RFKILL_TYPE_ALL)) rfkill_se

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-02 Thread Jouni Malinen
02.11 use cases. The exact length depends on the IEEE 802.11 frame type, but AAD is constructed in a way that it is normally a bit over 20 octets while allowing CCM to fit the related operations into two AES blocks. -- Jouni MalinenPGP id EFC895FA -- To

Re: [RFC] mac80211: clean up frame receive handling

2007-12-17 Thread Jouni Malinen
nd as the only valid source address for transmitted ones). -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [RFC] mac80211: clean up frame receive handling

2007-12-17 Thread Jouni Malinen
rection) sounds reasonable workaround to prevent cases where wireless clients could otherwise mess with other IEEE 802.1X authentications (e.g., for the wired port of an AP). PS. I added the C.3.3 vs. C.1.1 issue to my pending comments for the next IEEE 802.11 maintenan

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Jouni Malinen
On Sun, Dec 16, 2007 at 06:10:10PM -0500, Dan Williams wrote: > On Sun, 2007-12-16 at 10:11 -0800, Jouni Malinen wrote: > > It is a new key type regardless of whether it is PSK or passphrase. The > > current key types (IW_AUTH_CIPHER_*) are WEP40, TKIP, CCMP, and WEP104.. > Ah

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-16 Thread Jouni Malinen
ew capability to figure out whether this is needed). That PMK would be PSK for WPA-Personal, but it could also be used as PMK for WPA-Enterprise, so the more generic PMK name. -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-14 Thread Jouni Malinen
convinced to allow EAPOL frames to go through between association and 4-way handshake (which would be completed by driver/firmware). This is the way I can support WPA/WPA2-Enterprise with OSX.. -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this l

Re: [RFC] mac80211: clean up frame receive handling

2007-12-13 Thread Jouni Malinen
n for TX part, but I would assume that it is possible to select whether an EAPOL frame will be encrypted when injecting it(?). -- Jouni MalinenPGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: support for bridging ethernet and 802.11

2007-05-10 Thread Jouni Malinen
e., no additional netdev needed for the WDS link) and as such, this would look like working layer 2 bridging between wlan0 and eth0 even in managed mode. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev&q

Re: support for bridging ethernet and 802.11

2007-05-10 Thread Jouni Malinen
s the source address (addr2) when operating as a non-AP STA in BSS (client in Managed mode). In other words, layer 2 bridging does not work properly. AP mode and WDS links can be used for bridging without problems, but this will of course require the driver to support these. -- Jouni Malinen

Re: [HOSTAP] Make debug a run-time option

2007-03-14 Thread Jouni Malinen
o disable everything. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [HOSTAP] Make debug a run-time option

2007-03-14 Thread Jouni Malinen
sable all) may make it more difficult to understand reported issues. I would be more open to disabling debug messages one-by-one if there is something specific that can be agreed to cause more harm than benefit with extra output. -- Jouni MalinenP

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jouni Malinen
hether any of these would be affected by the 64/32-bit issue, but I would assume some of the apps are indeed parsing the scan results with internal implementation. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jouni Malinen
eless tools 29.pre14 and pre15 that are clearly related to this. Diff of pre14 vs. pre16 or pre15 vs. pre16 includes more changes and some of them do not seem to be related to issue. Unfortunately I do not have access to any system to test this workaround, so I cannot easi

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jouni Malinen
ossible solution is user space workaround, it better be documented (and communicated to maintainers of user space apps) well so that all user space programs not using iwlib can be modified, too. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from thi

Re: Hidden SSID's

2007-02-01 Thread Jouni Malinen
the hidden SSIDs are resolved in the BSS list based on information from Probe Responses and user space programs will get proper information in the scan results regardless of how the real SSID was learned. -- Jouni MalinenPGP id EFC895FA - To unsubscribe

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
nal SSID when "hiding" the SSID while others just use 0-length SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: Hidden SSID's

2007-01-30 Thread Jouni Malinen
re being processed would be likely to leave windows open for reporting incorrect SSID. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
he missing pieces for the pair. Generating false scan results by locally guessing what the SSID could be is just plain wrong. The scan results need to be based on real frames from the APs. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from

Re: Hidden SSID's

2007-01-29 Thread Jouni Malinen
care about in d80211, but I don't think we can remove it > from ieee80211 either. Use of '' is just not acceptable. IMHO, it should be removed from everywhere, including net/ieee80211. The sooner this is done, the better. -- Jouni Malinen

Re: d80211: clean up some list and loop code

2006-11-16 Thread Jouni Malinen
s to use list_for_each*() is of course welcome. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-11-16 Thread Jouni Malinen
eFrag flag is set or seq# != 0). That's the way it was done with hardware designs that allow full TKIP hwaccel for MSDUs that are not fragmented, but require software implementation of Michael MIC if MSDU is fragmented. -- Jouni MalinenPGP id EFC89

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-11-16 Thread Jouni Malinen
exported from the stack are the same ones that the stack would be using anyway (i.e., not having to maintain two versions of the same code). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] bcm43xx: Drain TX status before starting IRQs

2006-11-03 Thread Jouni Malinen
johannes > > [1] by that, I mean sending out frames, turning off and on the > interface, and then hoping to get a transmit status for frames sent > before off/on cycle. wpa_supplicant does not receive or query TX status (at least yet; in the user space MLME case this

Re: about 802.11i IBSS support

2006-10-25 Thread Jouni Malinen
hostapd 0.6 branch where it will be possible to link in part of wpa_supplicant and hostapd together into a single program. In other words, the authenticator code (both IEEE 802.1X/EAPOL and WPA/WPA2) will be available from hostapd. -- Jouni Malinen

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-24 Thread Jouni Malinen
goto cis_error; > I'm rewriting this with "<" because it's easier to read. Next tuple at > exactly CIS_MEX_LEN is fine - we just stop precessing at that point. > > I'm going to combine this with my previous fix and resend. Great, thanks! -- J

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-24 Thread Jouni Malinen
It doesn't need to know anything about the CIS structure. The driver must not be allowed to run over a buffer even if given an invalid CIS data. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev&q

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-20 Thread Jouni Malinen
s function into a separate program to run it against CIS dumps. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 5/5] d80211: allow wireless vlan interface to have sameMAC an AP interface

2006-10-09 Thread Jouni Malinen
g. Well, that would probably be correct for most (all?) cases, but then again, I would probably not bother with this level of validation in kernel. Whatever is taking care of binding the STA in user space (e.g., hostapd) can do the validation. -- Jouni Malinen

Re: Request to postpone WE-21

2006-10-05 Thread Jouni Malinen
ength be zero here (with WE-21)? Maybe better add 'iwr->u.data.length > 0 &&'.. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: Request to postpone WE-21

2006-10-05 Thread Jouni Malinen
octets) it can also be the last octet of the SSID and WE-21 style case could have essid[iwr->u.data.length - 1] == '\0'.. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] cfg80211 and nl80211

2006-10-05 Thread Jouni Malinen
andard WLAN security protocols (look at Cisco) and one needs to keep in mind that just looking at 802.11 MLME may not cover all cases that, in practice, have to be supported.. Anyway, I agree that MLME primitives do change and there will be new commands needed to cover

Re: [RFC] cfg80211 and nl80211

2006-10-05 Thread Jouni Malinen
- Use WPA IEs > - 802.11 Auth: Open System > - Crypto: TKIP or CCMP > - Key Mgmt/Auth: WPA-PSK (elided 802.1x) > There are pairwise keys and up to four group keys (Notice the pattern? this is same as WEP above..). > * WPA Enterprise > * WPA2 PSK > * WPA2 Enter

Re: [PATCH] wext

2006-10-04 Thread Jouni Malinen
uld not prevent us from extending WEXT at this point and stop all changes in something that is currently available. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH] prism54: wpa support for fullmac cards

2006-10-04 Thread Jouni Malinen
es, saying that the version in kernel tree never worked in AP mode would probably be valid. And as far as the WEXT interface in hostapd is concerned, no, there is no such thing yet. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the

Re: kernel: TKIP: replay detected:

2006-09-28 Thread Jouni Malinen
ed when combining this with defragmentation (see, e.g., net/d80211/ieee80211.c ieee80211_rx_h_check). Did the replay messages still show the same TSC/PN or did you get rid of all messages that had the same number repeated? -- Jouni MalinenPGP id EFC895FA

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Jouni Malinen
and authenticator functionality into the same program (e.g., for IEEE 802.11i IBSS). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ieee80211: quiet TKIP and CCMP replay messages for identical TSCs

2006-09-28 Thread Jouni Malinen
v16 are same). Even this is a case that should not really happen unless something is broken since IEEE 802.11 duplicate detection should have filtered the frames before (and it should be fixed if it did not do its job correctly). -- Jouni MalinenPGP id EF

Re: softmac mtu

2006-09-28 Thread Jouni Malinen
t 10 (256 octet min frag len and 2304 max MSDU len with some extra needed to cover the extra header in each fragment). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: kernel: TKIP: replay detected:

2006-09-28 Thread Jouni Malinen
ling to accept patches that silence these messages (as long as the replay statistics are easily available in other ways) by default, but I would still not remove them completely. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the l

Re: softmac mtu

2006-09-28 Thread Jouni Malinen
PDU. In other words, fragmentation in IEEE 802.11 is different from fragmentation in IP and it is also used for different purpose. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jouni Malinen
need the feature ;-) There's more than one PhD student needing this and I would be very much against removing it. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: roaming support for d80211 stack

2006-09-07 Thread Jouni Malinen
to use space. The main changes in roaming logic would be wpa_supplicant. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Jouni Malinen
to mainline now, it's another thing we'll have to carry > for a long time even though it currently has no users... I don't know about the others, but long/short retry limits have users (e.g., Host AP driver) and these drivers are currently forced to use a hack to do this without

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-08-30 Thread Jouni Malinen
kfree(supp); > + supp = NULL; Shouldn't these return an error and not replace the current rate configuration? > + if (old_supp) > + kfree(old_supp); No need for 'if (old_supp)' before calling kfree(old_supp). -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-30 Thread Jouni Malinen
On Wed, Aug 30, 2006 at 09:26:21AM +0200, Johannes Berg wrote: > On Tue, 2006-08-29 at 11:39 -0700, Jouni Malinen wrote: > > > What would be the preferred way of doing the conversion here? I think I > > would prefer to get the radar detection code in as-is and then move all &

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-08-30 Thread Jouni Malinen
registered callbacks from the hardware driver. At minimum, this would need to be documented very clearly to make sure that whoever is writing low-level drivers would be aware of this. In general, it would just be simpler if this can be avoided altogether. -- Jouni Malinen

Re: [patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-29 Thread Jouni Malinen
msg_ types to see the different types of status messages that are used. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-08-29 Thread Jouni Malinen
it's useless. */ The proposed use here is against this and should not be applied. SIOCGIWAP can be used to indicate association status and SIOCGIWTXPOW can be used to indicate whether TX is powered which is quite close to radio off indication. -- Jouni Malinen

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-08-29 Thread Jouni Malinen
e scripts. I do not use any distro configuration mechanisms for setting up wireless, so I do not know what is currently being used. I would not add these ioctls into d80211 unless someone can point out an existing (and widely used) mechanism that depends on

Re: [PATCH 01/3] d80211: add support for SIOCSIWRATE, SIOCSIWTXPOW and SIOCSIWPOWER

2006-08-25 Thread Jouni Malinen
y I see rate settings working is that the control would be applied to the rate control algorithm and not to the list of rates itself. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH wireless-dev 4/6] d80211: Send Layer 2 Update frames in kernel

2006-08-24 Thread Jouni Malinen
On Thu, Aug 24, 2006 at 01:43:16PM +0200, Jiri Benc wrote: > On Wed, 23 Aug 2006 22:39:30 -0700, Jouni Malinen wrote: > > Which part do you think is hackish here? Sending the layer 2 update > > frame or moving it to kernel? > > The latter. > > Is it really needed to

Re: [PATCH wireless-dev 4/6] d80211: Send Layer 2 Update frames in kernel

2006-08-23 Thread Jouni Malinen
On Wed, Aug 23, 2006 at 07:22:56PM +0200, Jiri Benc wrote: > On Mon, 07 Aug 2006 16:16:12 -0700, Jouni Malinen wrote: > > Send Layer 2 Update frame from the 802.11 code in kernel to the netdev > > that the STA is bound to. If the STA is bound to another VLAN netdev, > > send

Re: [PATCH 01/18] d80211: LED triggers

2006-08-22 Thread Jouni Malinen
one using these or planning on using them? I have been open to just removing all code due to lack of active use. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH 08/18] d80211: clean up exports

2006-08-22 Thread Jouni Malinen
rst place since I believe the GPL should cover this without additional changes in the source code. In other words, I would prefer that the EXPORT_SYMBOL would not be changed to EXPORT_SYMBOL_GPL here. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from th

Re: [clarification request] ieee80211_tx_control.pkt_type

2006-08-18 Thread Jouni Malinen
level driver to even look at the 802.11 header when queuing the frame for transmission. Taken into account how simple operation it is to get the type and subtype from the frame control field, this tx ctrl pkt_type could be removed, if desired. However, it was added there for a reason. -- Jouni Mal

Re: [PATCH] d80211: get rid of the WME bitfield

2006-08-14 Thread Jouni Malinen
lementation, but I would be a bit careful with this type of change here. This can be done easily with u8 since the qos_control field has 8 bits of used data and 8 bits of reserved field. My change was handling this as two separate 8-bit values, so no issues wi

Re: ieee80211_set_encryption...

2006-08-14 Thread Jouni Malinen
d similar is > difficult, but this seems overly complex. Comments? WPA2 is not the complex part; adding WMM into the picture with some hardware design was and multi-BSS support adds quite a bit more complexity here. -- Jouni MalinenPGP id EFC895FA - To un

Re: wlan#ap seems bogus

2006-08-14 Thread Jouni Malinen
ntrolling wlan0), but if that name is > already taken it simply appends a number or something until it hits a device > name that's still free (or gives up after 100 tries or so...) :) Same here.. hostapd gets the ifindex from kernel and doesn't care about the name. -- Jouni Mali

Re: [PATCH] d80211: fix some 0 vs. NULL comparisons

2006-08-14 Thread Jouni Malinen
ather not see != NULL.. Not very consistent, but can't really help with that on this kind of coding style opinions. Anyway, replacing 0 with NULL is a good change. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubs

Re: d80211 merge plans

2006-08-09 Thread Jouni Malinen
ntained. We have a group of people working on this and merging rest of our AP product to be based on this version. I'll try to be more actively involved in getting the changes submitted to wireless-dev (and hopefully, into mainline once the code gets there). -- Jouni Malinen

Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Jouni Malinen
sed tabs myself, but some of the areas of the code that I did not write was done using spaces. Anyway, this should move to using tabs over time whenever source code is being modified. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send

Re: 3945 driver using d80211

2006-08-09 Thread Jouni Malinen
> have any test script the cause this SMP problems? Or steps to reproduce it. I have heard of open claims on there being SMP issues, but I don't think I've ever seen any details on this. I've also added a dual core laptop to my testbed, so it will be interesting to see whether I ca

Re: 3945 driver using d80211

2006-08-09 Thread Jouni Malinen
On Tue, Aug 08, 2006 at 05:06:31PM -0700, Jouni Malinen wrote: > On Tue, Aug 08, 2006 at 02:27:37PM -0700, Mohamed Abbas wrote: > > > 1- I needed to use sta_info_get function to do rate scaling for 3945, > > although this function is exported but it was missing from d8021

Re: 802.11/crypto questions

2006-08-08 Thread Jouni Malinen
On Tue, Aug 08, 2006 at 01:35:22PM +0200, Johannes Berg wrote: > Jouni Malinen wrote: > >Depends on what exactly you mean with "on the fly". We have indeed > >changed between doing software and hardware crypto for some cases, e.g., > >when enabling another BSS wh

[PATCH wireless-dev 5/6] d80211: Fix ieee80211_remove_tx_extra() if key not configured

2006-08-07 Thread Jouni Malinen
QoS header processing mangled unencrypted WMM frames on software retry. The QoS data needs to be removed even when encryption key is not configured. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee8

[PATCH wireless-dev 1/6] d80211: Fix RTS threshold use

2006-08-07 Thread Jouni Malinen
Fixed dot11RTSThreshold use which was off-by-3: - must add FCS_LEN to the skb->len - frame length needs to be greater than threshold; not greater than or equal Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ie

[PATCH wireless-dev 6/6] d80211: Fix TKIP replay protection

2006-08-07 Thread Jouni Malinen
Fixed TKIP replay protection for the case where hwaccel is enabled. rx_initialized flag was not set in this case and the TSC validation was skipped for the frames. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/

[PATCH wireless-dev 0/6] Set of small fixes to net/d80211

2006-08-07 Thread Jouni Malinen
Here's a set of small fixes to net/d80211 from the Devicescape tree. Please consider applying. -- -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

[PATCH wireless-dev 3/6] d80211: Fix PLCP header length comment

2006-08-07 Thread Jouni Malinen
Fixed a typo in a comment: PLCP header length is in microseconds, not milliseconds. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee8

[PATCH wireless-dev 4/6] d80211: Send Layer 2 Update frames in kernel

2006-08-07 Thread Jouni Malinen
Send Layer 2 Update frame from the 802.11 code in kernel to the netdev that the STA is bound to. If the STA is bound to another VLAN netdev, send another update frame. This fixes an issue in which a local bridge table was not updated when hostapd sent this frame. Signed-off-by: Jouni Malinen

[PATCH wireless-dev 2/6] d80211: Fix PS-Poll frame dropping

2006-08-07 Thread Jouni Malinen
Fixed PS-Poll processing for STAs that are not authenticated or associated: - 80211.ko dropped these frames even though it should have sent them to hostapd (this was broken by addition of IBSS support) Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee8

Re: 802.11/crypto questions

2006-08-07 Thread Jouni Malinen
accelaration is concerned. Depending on the hardware design, there may be multiple different ways of doing this and some multi-BSS configurations are likely to require changes in how the keys are used between hardware and software. -- Jouni MalinenPGP id EFC895

Re: [PATCH wireless-dev] d80211: Switch d80211_mgmt.h to ieee80211.h style definitions

2006-08-07 Thread Jouni Malinen
_mgmt.h to use enum's with old names. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] d80211: Switch d80211 to IEEE80211_ style names

2006-08-04 Thread Jouni Malinen
E_QOS_DATA << 4); + fc &= ~(IEEE80211_STYPE_QOS_DATA << 4); wme.c: - qos = fc & (WLAN_FC_STYPE_QOS_DATA << 4); + qos = fc & (IEEE80211_STYPE_QOS_DATA << 4); -- Jouni MalinenPGP id EFC895FA

Re: michael_mic in crypto api?

2006-07-19 Thread Jouni Malinen
TKIP implementations (net/ieee80211 and net/d80211) so this would mean duplicating Michael MIC implementation and I would rather not do that. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: hostapd patch for d80211

2006-06-23 Thread Jouni Malinen
t a similar change was already in my pending merge queue from Devicescape, but anyway, either this patch or something similar will end up into hostapd repository. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] Make in-kernel hostap less annoying

2006-06-14 Thread Jouni Malinen
is only relevant to the in-kernel driver, > I see no reason to change the out-of-tree driver.) That would be even more confusing for the default mode.. I believe that both versions should continue to use Master mode as the default unless overridden by user. -- Jouni Malinen

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread Jouni Malinen
rspace? These used to be visible from procfs in the original implementation in Host AP driver. However, it looks like print_stats function is not called at all in the version that is in net/ieee80211, so the counters may not be exposed at the moment. They should be, though.. -- Jouni Malinen

Re: [PATCH] hush noisy ieee80211 CCMP printks

2006-06-05 Thread Jouni Malinen
nst removing the messages in default kernel builds. If there is a suitable build time debug option, that might be nicer way of doing this, though, since these can provide valuable information when figuring out why something does not work. -- Jouni Malinen

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jouni Malinen
(usually, a private ioctl) with wpa_supplicant. If there were a standard way of doing that, it could be helpful. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hardware button support for Wireless cards

2006-05-15 Thread Jouni Malinen
ving a UI mechanism for triggering this) would allow more consistent behavior. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jouni Malinen
s only configuring the SSID and requesting the driver (or well, kernel side 802.11 management code) to figure out which AP to use. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH wireless-dev] d80211: Add support for user space clientMLME

2006-05-10 Thread Jouni Malinen
On Thu, May 04, 2006 at 02:26:53PM +0200, Johannes Berg wrote: > On Wed, 2006-05-03 at 09:44 -0700, Jouni Malinen wrote: > > But there is.. I committed changes to the wpa_supplicant devel branch > > for this yesterday. It seems to work fine with net/d80211 and bcm43xx > > wit

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jouni Malinen
o TX or RX happened. This could, e.g., mean masking out interrupts and/or disabling receive part of the radio. This has been used to provide a mechanism for disabling the radio without having to set the interface down, i.e., without causing IP addresses to be dropped or

Re: [RFC] Proposed structure for Regulatory/Geographical Wireless database

2006-05-05 Thread Jouni Malinen
Power in mW EIRP I would prefer to see the maximum TX power in dBm, not mW. > # Flag Codes > # B - Both Indoor and Outdoor > # I - Indoor Only > # O - Outdoor Only > # P - Passive Scan Only Some more flags may need to be added in the future. It looks like the format used here make

Re: [PATCH wireless-dev] d80211: Add support for user space client MLME

2006-05-04 Thread Jouni Malinen
out requiring user configuration. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH wireless-dev] d80211: Add support for user space client MLME

2006-05-03 Thread Jouni Malinen
e. This disables host-based MLME implementation for client mode. In addition to changes in net/d80211, this patch fixes client mode for the Prism2/2.5/3 driver in drivers/net/wireless/d80211 by using the new mode of implementing client MLME in firmware. AP mode (Host AP) is still using host-based MLM

Re: [PATCH wireless-dev] d80211: Add support for user space client MLME

2006-05-03 Thread Jouni Malinen
his was mainly avoiding calls to some ieee80211_sta.c functions. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH wireless-dev] d80211: Add support for user space client MLME

2006-05-02 Thread Jouni Malinen
-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/hostapd_ioctl.h === --- wireless-dev.orig/net/d80211/hostapd_ioctl.h +++ wireless-dev/net/d80211/hostapd_ioctl.h @@ -91,6 +91,7 @

net/d80211 and management interface (wmaster0ap)

2006-05-02 Thread Jouni Malinen
sent through it by making sure that is_ieee80211_device(apdev) returns 1. Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211.c === --- wireless-dev.orig/net/d80211/ieee80211.c +++ wirel

Re: [RFC] Geographical/regulatory information for ieee80211

2006-04-28 Thread Jouni Malinen
open source tools and having some kind of simple signature on the data file would be good starting point. It is up to vendors then to decide whether they are fine with such a mechanism or whether some additional tool (like the Intel plan on using a closed source user space tool) would be

Re: [PATCH 8/10] d80211: get rid of default management interface

2006-04-22 Thread Jouni Malinen
rames into user space. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: SIOCGIWSCAN wireless event behaviour

2006-04-20 Thread Jouni Malinen
from that what the impact on behavior is. I can try to reproduce this, but I would like to know what version to test with in order to avoid any possible workarounds from hiding the issue. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send

  1   2   3   >