nci_uart_register returns -EINVAL immediately when nu->ops.recv is not
set. So the same 'if' later never triggers so nci_uart_default_recv is
never used. Drop it.
Signed-off-by: Jiri Slaby
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
---
There is noone setting nci_uart_ops::recv_buf, so the default one
(nci_uart_default_recv_buf) is always used. So drop this hook, move
nci_uart_default_recv_buf before the use in nci_uart_tty_receive and
remove unused parameter flags.
Signed-off-by: Jiri Slaby
Cc: "David S. Miller"
nci_uart_drivers is a global definition, so there is no need to
initialize its memory to zero during module load.
Signed-off-by: Jiri Slaby
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
---
net/nfc/nci/uart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/n
register_ldisc only calls tty_register_ldisc. Inline register_ldisc into
the only caller of register_ldisc, i.e. caif_ser_init. Now,
caif_ser_init is symmetric to caif_ser_exit in this regard.
Signed-off-by: Jiri Slaby
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.
On 17. 08. 20, 11:06, Allen Pais wrote:
> From: Allen Pais
>
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts
> all the wireless drivers to use the new tasklet_setup() API
General question for the whole seri
n case we need to change the
memory.
Signed-off-by: Jiri Slaby
Reported-by: Dieter Nützel
Tested-by: Dieter Nützel
Cc: Johannes Berg
Cc: Emmanuel Grumbach
Cc: Luca Coelho
Cc: Intel Linux Wireless
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: linux-wirel...@vg
On 04. 06. 18, 14:05, Björn Töpel wrote:
> From: Björn Töpel
>
> The xdp_umem_page holds the address for a page. Trade memory for
> faster lookup. Later, we'll add DMA address here as well.
...
> --- a/include/net/xdp_sock.h
> +++ b/include/net/xdp_sock.h
...
> --- a/net/xdp/xdp_umem.c
> +++ b/ne
On 18. 02. 19, 15:00, David Chen wrote:
> From: David Chen
>
> RTL8153-BD is used in Dell DA300 type-C dongle.
> It should be added to the whitelist of devices to activate MAC address
> pass through.
>
> Per confirming with Realtek all devices containing RTL8153-BD should
> activate MAC pass thr
On 05/16/2018, 03:36 PM, Jiri Slaby wrote:
> So I assume it must be a problem of making usb->disconnect without prior
> ndo->close (or alike).
So according to my debug messages, I think this should workaround the
problem:
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.
On 05/16/2018, 03:29 PM, Jiri Slaby wrote:
> On 05/16/2018, 02:07 PM, Hayes Wang wrote:
>> Oliver Neukum [mailto:oneu...@suse.com]
>>> Sent: Wednesday, May 16, 2018 6:10 PM
>> [...]
>>>> Besides, I find a similar issue as following.
>>>> htt
On 05/16/2018, 02:07 PM, Hayes Wang wrote:
> Oliver Neukum [mailto:oneu...@suse.com]
>> Sent: Wednesday, May 16, 2018 6:10 PM
> [...]
>>> Besides, I find a similar issue as following.
>>> https://www.spinics.net/lists/netdev/msg493512.html
>>
>> Well, if we have an imbalance in NAPI it should strik
Hi,
I have just got this lockdep warning during suspend:
> [ 2891.586061]
> [ 2891.586063] WARNING: possible recursive locking detected
> [ 2891.586065] 4.16.2-10.ge881e16-default #1 Not tainted
> [ 2891.586067] -
On 03/30/2018, 03:17 PM, Jiri Slaby wrote:
> Hi,
>
> I have seen r8152 from my docking station to kill my box several times
> in the last few days. The notebook is new, so I don't know if this is a
> regression.
Forgot to add, I am seeing this in dmesg:
[ 13.353239] r815
Hi,
I have seen r8152 from my docking station to kill my box several times
in the last few days. The notebook is new, so I don't know if this is a
regression.
I have the NIC connected all the time. And when I return to the notebook
after a while, the networking is dead. Looking at the stack trace
by: Daniel Borkmann
Signed-off-by: Alexei Starovoitov
Signed-off-by: Jiri Slaby
---
kernel/bpf/arraymap.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 56f8a8306a49..3608fa1aec8a 100644
--- a/kernel/bpf/arra
rename and move existing
jump target.
Suggested-by: Alexei Starovoitov
Signed-off-by: Jakub Kicinski
Acked-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
kernel/bpf/verifier.c | 67
Hi,
this is a backport of these patches which I did for our kernels:
c237ee5eb33b bpf: add bpf_patch_insn_single helper
3df126f35f88 bpf: don't (ab)use instructions to store state
e245c5c6a565 bpf: move fixup_bpf_calls() function
79741b3bdec0 bpf: refactor fixup_bpf_calls()
8041902dae52 bpf: adjus
Fastabend
Signed-off-by: Daniel Borkmann
Signed-off-by: Jiri Slaby
---
include/linux/bpf.h | 2 ++
kernel/bpf/arraymap.c | 24 +++-
kernel/bpf/verifier.c | 46 ++
3 files changed, 63 insertions(+), 9 deletions(-)
diff --git
-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
include/linux/filter.h | 3 +++
kernel/bpf/core.c | 71 ++
kernel/bpf/verifier.c | 53 +++--
3
e matching insn and insn_aux_data.
Signed-off-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
kernel/bpf/verifier.c | 40 +---
1 file changed, 37 insertions(+), 3 deletions(-)
diff --git a/kernel/b
ff-by: Jiri Slaby
---
kernel/bpf/syscall.c | 54 --
kernel/bpf/verifier.c | 55 +++
2 files changed, 55 insertions(+), 54 deletions(-)
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 4e32cc9
-by: David S. Miller
Signed-off-by: Jiri Slaby
---
kernel/bpf/verifier.c | 72 +++
1 file changed, 33 insertions(+), 39 deletions(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 198737d36754..47bb3eee950c 100644
--- a/kernel/bpf
l2tp_tunnel_delete does not return anything since commit 62b982eeb458
("l2tp: fix race condition in l2tp_tunnel_delete"). But call sites of
l2tp_tunnel_delete still do casts to void to avoid unused return value
warnings.
Kill these now useless casts.
Signed-off-by: Jiri Slaby
C
On 06/27/2017, 07:32 PM, Marcel Holtmann wrote:
>> It looks like bnep_session has same pattern as the issue reported in
>> old rfcomm:
>>
>> while (1) {
>> set_current_state(TASK_INTERRUPTIBLE);
>> if (condition)
>> break;
>> // may c
Hi,
we have got an UBSAN report from opensuse's user who booten
UBSAN-enabled kernel by mistake:
UBSAN: Undefined behaviour in
drivers/net/wireless/intel/iwlwifi/mvm/utils.c:667:49
shift exponent 255 is too large for 64-bit type 'long unsigned int'
CPU: 2 PID: 1590 Comm: wpa_supplicant Not tainted
On 04/24/2017, 08:24 PM, David Miller wrote:
> From: Jiri Slaby
> Date: Mon, 24 Apr 2017 19:51:54 +0200
>
>> For example what's the point of making the sk_load_word_positive_offset
>> label a global, callable function? Note that this is exactly the reason
>> wh
On 04/24/2017, 06:47 PM, Alexei Starovoitov wrote:
> On Mon, Apr 24, 2017 at 06:02:51PM +0200, Jiri Slaby wrote:
>> On 04/24/2017, 05:55 PM, Ingo Molnar wrote:
>>> * Jiri Slaby wrote:
>>>
>>>> On 04/24/2017, 05:08 PM, David Miller wrote:
>>>>>
On 04/24/2017, 05:55 PM, Ingo Molnar wrote:
> * Jiri Slaby wrote:
>
>> On 04/24/2017, 05:08 PM, David Miller wrote:
>>> If you align the entry points, then the code sequence as a whole is
>>> are no longer densely packed.
>>
>> Sure.
>>
On 04/24/2017, 05:51 PM, David Miller wrote:
> I said I'm not OK with the alignment
So in short, the suggested macros add no alignment.
--
js
suse labs
On 04/24/2017, 05:08 PM, David Miller wrote:
> If you align the entry points, then the code sequence as a whole is
> are no longer densely packed.
Sure.
> Or do I misunderstand how your macros work?
Perhaps. So the suggested macros for the code are:
#define BPF_FUNC_START_LOCAL(name) \
On 04/24/2017, 04:41 PM, David Miller wrote:
>> It cannot stay as-is simply because we want to know where the functions
>> end to inject debuginfo properly. The code above does not warrant for
>> any exception.
>
> I totally and completely disagree.
You can disagree as you wish but there is reall
On 04/21/2017, 09:32 PM, Alexei Starovoitov wrote:
> On Fri, Apr 21, 2017 at 04:12:43PM +0200, Jiri Slaby wrote:
>> Do not use a custom macro FUNC for starts of the global functions, use
>> ENTRY instead.
>>
>> And while at it, annotate also ends of the functions by E
Do not use a custom macro FUNC for starts of the global functions, use
ENTRY instead.
And while at it, annotate also ends of the functions by ENDPROC.
Signed-off-by: Jiri Slaby
Cc: "David S. Miller"
Cc: Alexey Kuznetsov
Cc: James Morris
Cc: Hideaki YOSHIFUJI
Cc: Patrick McHardy
These are all functions which are invoked from elsewhere, so we annotate
them as global using the new SYM_FUNC_START (and their ENDPROC's by
SYM_FUNC_END.)
And make sure ENTRY/ENDPROC is not defined on X86_64.
Signed-off-by: Jiri Slaby
Cc: "H. Peter Anvin"
Cc: Thomas Gleixner
On 03/06/2017, 01:25 PM, Johannes Berg wrote:
> On Fri, 2017-03-03 at 13:45 +0100, Jiri Slaby wrote:
>> From: Ondřej Lysoněk
>>
>> Use setup_timer() and setup_deferrable_timer() to set the data and
>> function timer fields. It makes the code cleaner and will allow
From: Ondřej Lysoněk
Use setup_timer() and setup_deferrable_timer() to set the data and
function timer fields. It makes the code cleaner and will allow for
easier change of the timer struct internals.
Signed-off-by: Ondřej Lysoněk
Signed-off-by: Jiri Slaby
Cc: Johannes Berg
Cc: "Da
From: Jan Koniarik
Stop accessing timer struct members directly and use setup_timer and
mod_timer helpers intended for that use. It makes the code cleaner and
will allow for easier change of the timer struct internals.
Signed-off-by: Jan Koniarik
Signed-off-by: Jiri Slaby
Cc: Chas Williams
__kmalloc+0x330/0x540
[] ? sctp_getsockopt_local_addrs+0x174/0xca0 [sctp]
[] ? sctp_getsockopt+0x10d/0x1b0 [sctp]
[] ? sock_common_getsockopt+0xb9/0x150
[] ? SyS_getsockopt+0x1a5/0x270
Signed-off-by: Jiri Slaby
Cc: Vlad Yasevich
Cc: Neil Horman
Cc: "David S. Miller"
Cc: linux-s...@vger.kernel.org
Cc: netde
__kmalloc+0x330/0x540
[] ? sctp_getsockopt_local_addrs+0x174/0xca0 [sctp]
[] ? sctp_getsockopt+0x10d/0x1b0 [sctp]
[] ? sock_common_getsockopt+0xb9/0x150
[] ? SyS_getsockopt+0x1a5/0x270
Signed-off-by: Jiri Slaby
Cc: Vlad Yasevich
Cc: Neil Horman
Cc: "David S. Miller"
Cc: linux
On 10/24/2016, 03:03 PM, Eric Dumazet wrote:
> On Mon, 2016-10-24 at 14:54 +0200, Jiri Slaby wrote:
>> Hello,
>>
>> as per man 7 udp:
>> In order to receive packets, the socket can be bound to
>> a local address first by using bind(2). Otherwise,
>>
owledge is very limited in that area, so I have
no idea whether that is correct at all.
thanks,
--
js
suse labs
>From 57c320998feb2e1e705a4ab6d3bbcb74c6ae65f0 Mon Sep 17 00:00:00 2001
From: Jiri Slaby
Date: Sat, 22 Oct 2016 12:10:53 +0200
Subject: [PATCH] net: autobind UDP on recv
Signed-off-b
5/0x270
Signed-off-by: Jiri Slaby
Cc: Vlad Yasevich
Cc: Neil Horman
Cc: "David S. Miller"
Cc: linux-s...@vger.kernel.org
Cc: netdev@vger.kernel.org
---
net/sctp/socket.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index f
the correct size to memset.
Signed-off-by: Jiri Slaby
Cc: Christian Lamparter
Cc: Kalle Valo
Cc: linux-wirel...@vger.kernel.org
Cc: netdev@vger.kernel.org
---
drivers/net/wireless/intersil/p54/fwio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/in
On 09/13/2016, 05:35 PM, Tejun Heo wrote:
> Hello,
>
> On Sat, Sep 10, 2016 at 11:33:48AM +0200, Dmitry Vyukov wrote:
>> Hit the WARNING with the patch. It showed "Showing busy workqueues and
>> worker pools:" after the WARNING, but then no queue info. Was it
>> already destroyed and removed from
aused by a missing free in the ->release path. So fix it by
providing seq_release_net as the ->release method.
Signed-off-by: Jiri Slaby
Fixes: cd6e111bf5 (kcm: Add statistics and proc interfaces)
Cc: "David S. Miller"
Cc: Tom Herbert
Cc: netdev@vger.kernel.org
---
net/kcm/kcmproc.
is fairly simple: disable irqs before taking the
mems_allowed_seq lock.
Signed-off-by: John Stultz
Signed-off-by: Peter Zijlstra
Acked-by: Li Zefan
Cc: Mathieu Desnoyers
Cc: Steven Rostedt
Cc: "David S. Miller"
Cc: netdev@vger.kernel.org
Link:
http://lkml.kernel.org/r/13811863
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
net/vmw_vsock/af_vsock.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 85d232bed87d..e8d3313ea2c9 100644
--- a/net/vmw_vsock/af_vsock.c
dev@vger.kernel.org
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
net/vmw_vsock/af_vsock.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 85d232bed87d..e8d3313ea2c9 100644
--- a/net/
In ircomm_tty_get_serial_info, struct serial_struct is memset to 0 and
then some members set to 0 explicitly.
Remove the latter as it is obviously superfluous.
And remove the retinfo check against NULL. copy_to_user will take care
of that.
Part of hub6 cleanup series.
Signed-off-by: Jiri Slaby
adlock
to trigger, a fix is fairly simple: disable irqs before taking the
mems_allowed_seq lock.
Signed-off-by: John Stultz
Signed-off-by: Peter Zijlstra
Acked-by: Li Zefan
Cc: Mathieu Desnoyers
Cc: Steven Rostedt
Cc: "David S. Miller"
Cc: netdev@vger.kernel.org
Link:
http://lkml.k
On 03/31/2016, 02:13 AM, Daniel Borkmann wrote:
> Sasha Levin reported a suspicious rcu_dereference_protected() warning
> found while fuzzing with trinity that is similar to this one:
>
> [ 52.765684] net/core/filter.c:2262 suspicious
> rcu_dereference_protected() usage!
> [ 52.765688] ot
On 03/21/2016, 04:58 PM, Jiri Slaby wrote:
> Hello,
>
> On 03/18/2016, 09:52 PM, Tejun Heo wrote:
>> On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote:
>>>>> I have not done that yet, but today, I see:
>>>>> destroy_workqueue: name=
Hello,
On 03/18/2016, 09:52 PM, Tejun Heo wrote:
> On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote:
>>>> I have not done that yet, but today, I see:
>>>> destroy_workqueue: name='req_hci0' pwq=88002f590300
>>>> wq->dfl
Hello,
On 03/11/2016, 06:12 PM, Tejun Heo wrote:
> On Thu, Mar 03, 2016 at 10:12:01AM +0100, Jiri Slaby wrote:
>> On 03/02/2016, 04:45 PM, Tejun Heo wrote:
>>> On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote:
>>>>> 1. didn't help, the problem pe
Hi,
On 03/02/2016, 04:45 PM, Tejun Heo wrote:
> On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote:
>>> 1. didn't help, the problem persists. So I haven't applied the patch from 2.
>>
>> FWIW I dumped more info about the wq:
>> wq->n
On 02/19/2016, 11:20 AM, Jiri Slaby wrote:
> On 02/18/2016, 06:44 PM, Tejun Heo wrote:
>> Hello,
>>
>> Can you please do the followings?
>>
>> 1. Remove WQ_MEM_RECLAIM from the affected workqueue and see whether
>>the problem is reproducible. WQ_MEM_RECL
On 02/18/2016, 06:44 PM, Tejun Heo wrote:
> Hello,
>
> Can you please do the followings?
>
> 1. Remove WQ_MEM_RECLAIM from the affected workqueue and see whether
>the problem is reproducible. WQ_MEM_RECLAIM on anything bluetooth
>doesn't make sense btw. Why is it there?
>
> 2. If WQ_ME
Cc Tejun (workqueues), Takashi (debug patch)
On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote:
> Hello,
>
> I've hit the following warning while running syzkaller fuzzer:
Hi,
I am hitting it over and over again using syzkaller.
> WARNING: CPU: 2 PID: 17409 at kernel/workqueue.c:3968
> destroy_work
On 02/12/2016, 11:36 AM, Jiri Slaby wrote:
> It there some compilation flag missing? -f flags when compiling that file are:
> -falign-jumps=1
> -falign-loops=1
> -fconserve-stack
> -fno-asynchronous-unwind-tables
> -fno-common
> -fno-delete-null-pointer-checks
> -fno-inli
On 01/21/2016, 11:49 PM, Josh Poimboeuf wrote:
> This is v16 of the compile-time stack metadata validation patch set,
> along with proposed fixes for most of the warnings it found. It's based
> on the tip/master branch.
Hi,
with this config:
https://github.com/openSUSE/kernel-source/blob/master/
netdev@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Vijay Pandurangan
Acked-by: Cong Wang
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
drivers/net/veth.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index
oshiaki Makita
Cc: netdev@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Vijay Pandurangan
Acked-by: Cong Wang
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
drivers/net/veth.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/veth.c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 01/05/2016, 05:40 PM, Ben Hutchings wrote:
> On Tue, 2016-01-05 at 17:36 +0100, Jiri Slaby wrote:
>> On 12/28/2015, 03:01 PM, Michal Kubecek wrote:
>>> Recent fix "net: add length argument to
>>> skb_copy_and_cs
On 12/28/2015, 03:01 PM, Michal Kubecek wrote:
> Recent fix "net: add length argument to
> skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable
> branches, namely
>
> stable-3.2.y: commit 127500d724f8
> stable-3.12.y: commit 3e1ac3aafbd0
Applied this fix to 3.12. Thanks!
> doesn't
On 10/21/2015, 04:55 PM, Punit Vara wrote:
> This patch is to the ath10k/pci.h file that fixes following warning
> reported by coccicheck:
>
> WARNING: sum of probable bitmasks, consider |
>
> I have replaced + with OR operator | for summing bitmasks
>
> Signed-off-by: Punit Vara
> ---
> driv
On 10/21/2015, 04:55 PM, Punit Vara wrote:
> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
> static int at76_remap(struct usb_device *udev)
> {
> int ret;
> - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
> + return usb_control_msg(udev, usb_sndctrlp
On 10/05/2015, 07:29 PM, Roland Dreier wrote:
> From: Roland Dreier
>
> Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across
> multiple skbs") introduced a regression in "ip rule show" - it ends up
> dumping the first rule over and over and never exiting, because 3.19
> and earlier ar
On 06/04/2015, 10:54 PM, Michal Kubecek wrote:
> Hello,
>
> please queue mainline commit
>
> ac37e2515c1a ("xfrm: release dst_orig in case of error in xfrm_lookup()")
>
> for stable branches 3.12, 3.14 and 3.18. It fixes a dst_entry reference
> leak introduced by commit
>
> f92ee61982d6 ("x
EXTRA_CFLAGS should be used on the command line only.
Since EXTRA_CFLAGS here add only a non-existant path to compiler
include paths (by -I), remove EXTRA_CFLAGS completely.
Signed-off-by: Jiri Slaby
---
drivers/net/ethernet/brocade/bna/Makefile | 2 --
1 file changed, 2 deletions(-)
diff
AM on supported controllers
so we can always use the NOUFLO bit.
Cc:
Cc:
Cc: Don Fry
Signed-off-by: Markos Chandras
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
drivers/net/ethernet/amd/pcnet32.c | 31 +--
1 file changed, 29 insertions(+), 2 dele
On 04/27/2015, 06:25 PM, David Miller wrote:
> From: ebied...@xmission.com (Eric W. Biederman)
> Date: Mon, 27 Apr 2015 10:35:51 -0500
>
>> Jiri Slaby writes:
>>
>>> On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
>>>> Several powerpc build fail with
On 04/21/2015, 08:30 PM, David Miller wrote:
> Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
> 3.19, and 4.0 -stable, respectively.
Hi,
similar to other "Call dev_kfree_skby_any instead of dev_kfree_skb.", I
believe, that mlx4 (only) in 3.14 should receive the fix too:
On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
> Several powerpc build fail with:
>
> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration
> of
> function 'dev_consume_skb_any' [-Werror=implicit-func
best to setup the SRAM on supported controllers
so we can always use the NOUFLO bit.
Cc:
Cc:
Cc: Don Fry
Signed-off-by: Markos Chandras
Signed-off-by: David S. Miller
Signed-off-by: Jiri Slaby
---
drivers/net/ethernet/amd/pcnet32.c | 31 +--
1 file change
On 02/11/2008 08:42 PM, Matt Mackall wrote:
BUG: unable to handle kernel paging request at 8102366213f8
IP: [] twothirdsMD4Transform+0xc4/0x3b0
You should mention what kernel you're using.
Kernel version is in the bug below modules and above registers.
This bug is only in -mm
(you didn
Hi,
I get this with 32 bit Firefox 3b2 and java 1.6.0_03 on 64 bit:
BUG: unable to handle kernel paging request at 8102366213f8
IP: [] twothirdsMD4Transform+0xc4/0x3b0
PGD 8063 PUD 0
Oops: [1] SMP
last sysfs file: /sys/devices/virtual/net/tun0/statistics/collisions
CPU 1
Modules linked
On 02/04/2008 10:40 PM, Oliver Pinter wrote:
On 2/4/08, Oliver Pinter <[EMAIL PROTECTED]> wrote:
On 2/4/08, Jiri Slaby <[EMAIL PROTECTED]> wrote:
On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote:
[ 413.118874] wpa_supplicant[4388]: segfault at 30 ip 080697ca sp
bfc9cab
On 02/04/2008 10:52 PM, Dan Williams wrote:
On Mon, 2008-02-04 at 22:34 +0100, Oliver Pinter wrote:
On 2/4/08, Jiri Slaby <[EMAIL PROTECTED]> wrote:
On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote:
ioctl[SIOCSIWAUTH]: Operation not supported
WEXT auth param 4 value 0x0
On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote:
git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150
[ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp
bf87a690 error 4 in wpa_supplicant[8048000+4c000]
[ 406.277199] wpa_supplicant[4384]: segfault at 30 ip 080697ca sp
b
On 12/02/2007 12:13 AM, Eric W. Biederman wrote:
> Mark Lord <[EMAIL PROTECTED]> writes:
>> Fine. But all of them want to call sk_alloc(),
>
> network drivers should be calling sk_alloc less then they should
> call dev_get_by_. Only protocols call sk_alloc.
>
>> and many want to do register
business (and they should use sock_set_flag/sock_reset_flag) or should
this be reverted?
thanks,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTE
sunrpc, remove SPIN_LOCK_UNLOCKED
SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit d5e782e62a4fe2663a012571c345d9887b02
tree b993038b020d8c619f6ffdad412fbb992c073513
parent 828042d12cc0aa515e049889aa76d4066df100c0
ibm_newemac, remove SPIN_LOCK_UNLOCKED
SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
---
commit aefcf0f6b6ab925184e7cebff8b609e4da1f5c0d
tree 9e1e6240f26c759826959e8812885726c52
inks: 4
Access: (0555/dr-xr-xr-x) Uid: (0/root) Gid: (0/root)
Access: 2007-09-28 18:26:48.813048220 +0200
Modify: 2007-09-28 18:26:48.813048220 +0200
Change: 2007-09-28 18:26:48.813048220 +0200
hmm, this is some kind of weirdness :)
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
F
On 09/17/2007 06:29 PM, Kok, Auke wrote:
> Jiri Slaby wrote:
>> On 12/23/-28158 08:59 PM, Auke Kok wrote:
>>> This incorporates the new napi_struct changes into e1000e. Included
>>> bugfix for ifdown hang from Krishna Kumar for e1000.
>>>
>>> Disabling
0445d9978 CR3: 04c49000 CR4: 06e0
DR0: DR1: DR2: 00000000
DR3: DR6: 0ff0 DR7: 0400
Call Trace:
[] e1000_clean+0xdd/0x250
[] hrtimer_run_queues+0x33/0x1b0
[] net_rx_action+0xd7/0x190
[] __d
Kok, Auke napsal(a):
> Jiri Slaby wrote:
>> I still have problems with the driver. When I do `ip link set eth0
>> up', ksoftirq
>> runs with 100 % cpu time, so I think you endlessly re-schedule some
>> timer (or
>> the new napi layer?)
>
> something cha
On 09/07/2007 09:19 AM, Jiri Slaby wrote:
> Hi,
>
> I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver.
> napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot.
Ok, after these changes:
diff --git a/drivers/net/e1000e/netdev.c b/drivers/
remove asm/bitops.h includes
including asm/bitops directly may cause compile errors. don't include it
and include linux/bitops instead. next patch will deny including asm header
directly.
Cc: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED
Hi,
I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver.
napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot.
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "
-->
>
> Either #include must become forbidden and #error or the
> move of the #define's to include/linux/bitops.h reverted.
Just to let you know, that I'm working on the former.
thanks,
--
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk
John W. Linville napsal(a):
> On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
>> ath5k, use int as retval
>>
>> Convert some functions to return int and proper negative return value on
>> error as we are used to.
>
> Since I didn't apply 1/5, t
On 8/29/07, Johannes Berg <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-08-28 at 12:00 -0400, Jiri Slaby wrote:
>
> > The files are available only under GPLv2 since now.
>
> Since the BSD people are already getting upset about (for various
> reasons among which seem to b
ath5k, kconfig changes
- build 5120, 5111 and 5112 optionally
- alter Kconfig text
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit 0902114e92b19bc080780f21f98807688244fc8f
tree d7b4a039e4d14ae73faf1b33907c38825d198461
parent 330c2ab9a53ddce27003218bd546034e8eeeff17
author Jiri
ath5k, license is GPLv2
The files are available only under GPLv2 since now.
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit 330c2ab9a53ddce27003218bd546034e8eeeff17
tree b24cecd991fbe3046d5c5269c61e0090427e4fd3
parent ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470
author Jiri Slaby &
ath5k, use int as retval
Convert some functions to return int and proper negative return value on
error as we are used to.
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470
tree 44cd0736147325e35c32274eb53bd543fb1510a9
ath5k, switch to ioread/iowrite
Do not use readl/writel, since iomap retval is platform dependent and
needn't be virtual address awaited by readl/writel.
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit 64b9d0578668fe8c7a43eadace673bc3e5
Johannes Berg napsal(a):
> On Sat, 2007-08-25 at 03:58 -0400, Jiri Slaby wrote:
>> ath5k, use short preamble for some rates
>>
>> 2, 5.5 and 11 in b/g are now in short preamble mode
>
> umm, mac80211 needs to be able to choose depending on the network.
Hmm, misleadin
MAINTAINERS, order NETERION alphabetically
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
---
commit f5f10b061961546a77300f3ebe92abd9cb5b9b48
tree 90ad6e22504aeaadb17309d01996eb6cd7eb5a93
parent c858c1b27bfb4c58c9ebfa24de0d6442e364db97
author Jiri Slaby <[EMAIL PROTECTED]> Sat, 25 Au
ath5k, remove some ieee80211 re-defines
use mac80211 defines directly instead. this means MODULATION_* to
IEEE80211_RATE_* switch.
Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
---
commit c858c1b27bfb4c58c9ebfa24de0d6442e
1 - 100 of 142 matches
Mail list logo
