Re: [RFC bpf-next 0/8] bpf: accelerate insn patching speed

Alexei Starovoitov writes: > On Tue, Jul 16, 2019 at 09:50:25AM +0100, Jiong Wang wrote: >> >> Let me digest a little bit and do some coding, then I will come back. Some >> issues can only shown up during in-depth coding. I kind of feel handling >> aux reference in

Re: [RFC bpf-next 0/8] bpf: accelerate insn patching speed

Andrii Nakryiko writes: > On Mon, Jul 15, 2019 at 2:21 AM Jiong Wang wrote: >> >> >> Andrii Nakryiko writes: >> >> > On Thu, Jul 11, 2019 at 4:22 AM Jiong Wang >> > wrote: >> >> >> >> >> >> Andrii Nakryik

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

Andrii Nakryiko writes: > On Mon, Jul 15, 2019 at 3:02 AM Jiong Wang wrote: >> >> >> Andrii Nakryiko writes: >> >> > On Thu, Jul 11, 2019 at 5:20 AM Jiong Wang >> > wrote: >> >> >> >> >> >> Jiong Wang writes: &

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

Andrii Nakryiko writes: > On Thu, Jul 11, 2019 at 5:20 AM Jiong Wang wrote: >> >> >> Jiong Wang writes: >> >> > Andrii Nakryiko writes: >> > >> >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang >> >> wrote: >>

Re: [RFC bpf-next 1/8] bpf: introducing list based insn patching infra to core layer

Andrii Nakryiko writes: > On Thu, Jul 11, 2019 at 4:53 AM Jiong Wang wrote: >> >> >> Andrii Nakryiko writes: >> >> > On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >> >> >> >> This patch introduces list based bpf insn patching in

Re: [RFC bpf-next 0/8] bpf: accelerate insn patching speed

Andrii Nakryiko writes: > On Thu, Jul 11, 2019 at 4:22 AM Jiong Wang wrote: >> >> >> Andrii Nakryiko writes: >> >> > On Thu, Jul 4, 2019 at 2:31 PM Jiong Wang wrote: >> >> >> >> This is an RFC based on latest bpf-next about accler

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

Jiong Wang writes: > Andrii Nakryiko writes: > >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >>> >>> Verification layer also needs to handle auxiliar info as well as adjusting >>> subprog start. >>> >>> At this layer, insns inside

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

Andrii Nakryiko writes: > On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >> >> Verification layer also needs to handle auxiliar info as well as adjusting >> subprog start. >> >> At this layer, insns inside patch buffer could be jump, but they should &g

Re: [RFC bpf-next 1/8] bpf: introducing list based insn patching infra to core layer

Andrii Nakryiko writes: > On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >> >> This patch introduces list based bpf insn patching infra to bpf core layer >> which is lower than verification layer. >> >> This layer has bpf insn sequence as the solo input, ther

Re: [RFC bpf-next 0/8] bpf: accelerate insn patching speed

Andrii Nakryiko writes: > On Thu, Jul 4, 2019 at 2:31 PM Jiong Wang wrote: >> >> This is an RFC based on latest bpf-next about acclerating insn patching >> speed, it is now near the shape of final PATCH set, and we could see the >> changes migrating to list patchin

[RFC bpf-next 4/8] bpf: migrate convert_ctx_accesses to list patching infra

This patch migrate convert_ctx_accesses to new list patching infrastructure. pre-patch is used for generating prologue, because what we really want to do is insert the prog before prog start without touching the first insn. Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 98

[RFC bpf-next 5/8] bpf: migrate fixup_bpf_calls to list patching infra

This patch migrate fixup_bpf_calls to new list patching infrastructure. Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 94 +++ 1 file changed, 49 insertions(+), 45 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c

[RFC bpf-next 8/8] bpf: delete all those code around old insn patching infrastructure

This patch delete all code around old insn patching infrastructure. Signed-off-by: Jiong Wang --- include/linux/bpf_verifier.h | 1 - include/linux/filter.h | 4 - kernel/bpf/core.c| 169 - kernel/bpf/verifier.c| 221

[RFC bpf-next 6/8] bpf: migrate zero extension opt to list patching infra

This patch migrate 32-bit zero extension insertion to new list patching infrastructure. Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf

[RFC bpf-next 3/8] bpf: migrate jit blinding to list patching infra

List linerization function will figure out the new jump destination of patched/blinded jumps. No need of destination adjustment inside bpf_jit_blind_insn any more. Signed-off-by: Jiong Wang --- kernel/bpf/core.c | 76 ++- 1 file changed, 36

[RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

27;t touch insns inside patch buffer. Adjusting subprog is finished along with adjusting jump target when the input will cover bpf to bpf call insn, re-register subprog start is cheap. But adjustment when there is insn deleteion is not considered yet. Signed-off-by: Jiong Wang --- kernel/bpf/verifi

[RFC bpf-next 7/8] bpf: migrate insn remove to list patching infra

This patch migrate dead code remove pass to new list patching infrastructure. Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 59 +-- 1 file changed, 19 insertions(+), 40 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf

[RFC bpf-next 0/8] bpf: accelerate insn patching speed

e retained, it is purely insn insertion, so need to use the pre-patch API. I plan to send out a PATCH set once I finished insn deletion line info adj support, please have a looks at this RFC, and appreciate feedbacks. Jiong Wang (8): bpf: introducing list based insn patching infra to core

[RFC bpf-next 1/8] bpf: introducing list based insn patching infra to core layer

. Suggested-by: Alexei Starovoitov Suggested-by: Edward Cree Signed-off-by: Jiong Wang --- include/linux/filter.h | 25 + kernel/bpf/core.c | 268 + 2 files changed, 293 insertions(+) diff --git a/include/linux/filter.h b/include/linux/filter.h

[PATCH bpf] bpf: fix BPF_ALU32 | BPF_ARSH on BE arches

serve the low 32-bit as signed integer, this is all we want. Fixes: 2dc6b100f928 ("bpf: interpreter support BPF_ALU | BPF_ARSH") Reported-by: Yauheni Kaliuta Reviewed-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: Jiong Wang --- kernel/bpf/core.c | 4 ++-- 1 file change

Re: [PATCH] bpf: optimize constant blinding

Edward Cree writes: > On 17/06/2019 21:40, Jiong Wang wrote: >> Now if we don't split patch when patch an insn inside patch, instead, if we >> replace the patched insn using what you suggested, then the logic looks to >> me becomes even more complex, something like

Re: [PATCH] bpf: optimize constant blinding

Alexei Starovoitov writes: > On Mon, Jun 17, 2019 at 1:40 PM Jiong Wang wrote: >> >> After digest Alexei and Andrii's reply, I still don't see the need to turn >> branch target into list, and I am not sure whether pool based list sound >> good? it sa

Re: [PATCH] bpf: optimize constant blinding

Edward Cree writes: > On 17/06/2019 20:59, Jiong Wang wrote: >> Edward Cree writes: >> >>> On 14/06/2019 16:13, Jiong Wang wrote: >>>> Just an update and keep people posted. >>>> >>>> Working on linked list based approach, the imple

Re: [PATCH] bpf: optimize constant blinding

Edward Cree writes: > On 14/06/2019 16:13, Jiong Wang wrote: >> Just an update and keep people posted. >> >> Working on linked list based approach, the implementation looks like the >> following, mostly a combine of discussions happened and Naveen's patch

Re: [PATCH] bpf: optimize constant blinding

Alexei Starovoitov writes: > On Wed, Jun 12, 2019 at 8:25 AM Jiong Wang wrote: >> >> >> Jiong Wang writes: >> >> > Alexei Starovoitov writes: >> > >> >> On Wed, Jun 12, 2019 at 4:32 AM Naveen N. Rao >> >> wrote: >> >

Re: [PATCH] bpf: optimize constant blinding

Jiong Wang writes: > Alexei Starovoitov writes: > >> On Wed, Jun 12, 2019 at 4:32 AM Naveen N. Rao >> wrote: >>> >>> Currently, for constant blinding, we re-allocate the bpf program to >>> account for its new size and adjust all branches to accom

Re: [PATCH] bpf: optimize constant blinding

Alexei Starovoitov writes: > On Wed, Jun 12, 2019 at 4:32 AM Naveen N. Rao > wrote: >> >> Currently, for constant blinding, we re-allocate the bpf program to >> account for its new size and adjust all branches to accommodate the >> same, for each BPF instruction that needs constant blinding. Th

[PATCH v2 bpf-next] bpf: doc: update answer for 32-bit subregister question

) v1: - Integrated rephrase from Quentin and Jakub Reviewed-by: Quentin Monnet Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- Documentation/bpf/bpf_design_QA.rst | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/Documentation/bpf

Re: [PATCH bpf-next] bpf: doc: update answer for 32-bit subregister question

Song Liu writes: > On Thu, May 30, 2019 at 12:46 AM Jiong Wang wrote: >> >> There has been quite a few progress around the two steps mentioned in the >> answer to the following question: >> >> Q: BPF 32-bit subregister requirements >> >> This patc

[PATCH bpf-next] bpf: doc: update answer for 32-bit subregister question

Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- Documentation/bpf/bpf_design_QA.rst | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/Documentation/bpf/bpf_design_QA.rst b/Documentation/bpf/bpf_design_QA.rst index cb402c5..5092a2a 100644

[PATCH bpf 2/2] selftests: bpf: complete sub-register zero extension checks

-ends failed to guarantee the mentioned semantics, these unit tests will fail. Acked-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: Jiong Wang --- tools/testing/selftests/bpf/verifier/subreg.c | 516 +- 1 file changed, 505 insertions(+), 11 deletions

[PATCH bpf 1/2] selftests: bpf: move sub-register zero extension checks into subreg.c

It is better to centralize all sub-register zero extension checks into an independent file. This patch takes the first step to move existing sub-register zero extension checks into subreg.c. Acked-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: Jiong Wang --- tools/testing

[PATCH bpf 0/2] selftests: bpf: more sub-register zero extension unit tests

JIT back-ends need to guarantee high 32-bit cleared whenever one eBPF insn write low 32-bit sub-register only. It is possible that some JIT back-ends have failed doing this and are silently generating wrong image. This set completes the unit tests, so bug on this could be exposed. Jiong Wang (2

Re: [PATCH v9 bpf-next 00/17] bpf: eliminate zero extensions for sub-register writes

Alexei Starovoitov writes: > On Fri, May 24, 2019 at 11:25:11PM +0100, Jiong Wang wrote: >> v9: >> - Split patch 5 in v8. >> make bpf uapi header file sync a separate patch. (Alexei) > > 9th time's a charm? ;) Yup :), it's all good things and he

[PATCH v9 bpf-next 03/17] bpf: introduce new mov32 variant for doing explicit zero extension

insn using this new mov32 variant. One helper function insn_is_zext is added for checking one insn is an zero extension on dst. This will be widely used by a few JIT back-ends in later patches in this set. Signed-off-by: Jiong Wang --- include/linux/filter.h | 14 ++ 1 file changed

[PATCH v9 bpf-next 04/17] bpf: verifier: insert zero extension according to analysis result

s hardware zero extension support. The peephole could be as simple as looking the next insn, if it is a special zero extension insn then it is safe to eliminate it if the current insn has hardware zero extension support. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf.h

[PATCH v9 bpf-next 10/17] selftests: bpf: enable hi32 randomization for all tests

used load APIs to the test version, hence enable high 32-bit randomization for these tests without changing source code. Besides all these, there are several testcases are using "bpf_prog_load_attr" directly, their call sites are updated to pass BPF_F_TEST_RND_HI32. Signed-off-by: Ji

[PATCH v9 bpf-next 12/17] powerpc: bpf: eliminate zero extension code-gen

Cc: Naveen N. Rao Cc: Sandipan Das Signed-off-by: Jiong Wang --- arch/powerpc/net/bpf_jit_comp64.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c index 21a1dcd

[PATCH v9 bpf-next 07/17] bpf: verifier: randomize high 32-bit when BPF_F_TEST_RND_HI32 is set

This patch randomizes high 32-bit of a definition when BPF_F_TEST_RND_HI32 is set. Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 68 ++- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git a

[PATCH v9 bpf-next 01/17] bpf: verifier: mark verified-insn with sub-register zext flag

A new sub-register write overrides the old one. - When propagating read64 during path pruning, also mark any insn defining a sub-register that is read in the pruned path as full-register. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf_verifier.h | 14 +++- kerne

[PATCH v9 bpf-next 09/17] selftests: bpf: adjust several test_verifier helpers for insn insertion

efficient that 1M call to it will hang computer. So , change to BPF_ALU64_IMM to avoid hi32 randomization. Signed-off-by: Jiong Wang --- tools/testing/selftests/bpf/test_verifier.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH v9 bpf-next 13/17] s390: bpf: eliminate zero extension code-gen

Cc: Martin Schwidefsky Cc: Heiko Carstens Signed-off-by: Jiong Wang --- arch/s390/net/bpf_jit_comp.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index 5e7c630..e636728

[PATCH v9 bpf-next 02/17] bpf: verifier: mark patched-insn with sub-register zext flag

Patched insns do not go through generic verification, therefore doesn't has zero extension information collected during insn walking. We don't bother analyze them at the moment, for any sub-register def comes from them, just conservatively mark it as needing zero extension. Signed-off

[PATCH v9 bpf-next 05/17] bpf: introduce new bpf prog load flags "BPF_F_TEST_RND_HI32"

any later insn. Such randomization is only enabled under testing mode which is gated by the new bpf prog load flags "BPF_F_TEST_RND_HI32". Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- include/uapi/linux/bpf.h | 18 ++ kernel/bpf/syscall.c | 4 +

[PATCH v9 bpf-next 15/17] x32: bpf: eliminate zero extension code-gen

Cc: Wang YanQing Tested-by: Wang YanQing Signed-off-by: Jiong Wang --- arch/x86/net/bpf_jit_comp32.c | 83 +-- 1 file changed, 56 insertions(+), 27 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c index b29e82f

[PATCH v9 bpf-next 14/17] sparc: bpf: eliminate zero extension code-gen

Cc: David S. Miller Signed-off-by: Jiong Wang --- arch/sparc/net/bpf_jit_comp_64.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 65428e7..3364e2a 100644 --- a/arch

[PATCH v9 bpf-next 17/17] nfp: bpf: eliminate zero extension code-gen

ed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 115 +- drivers/net/ethernet/netronome/nfp/bpf/main.h | 2 + drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 12 +++ 3 files changed, 81 insertions(+), 48 dele

[PATCH v9 bpf-next 11/17] arm: bpf: eliminate zero extension code-gen

Cc: Shubham Bansal Signed-off-by: Jiong Wang --- arch/arm/net/bpf_jit_32.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index c8bfbbf..97a6b4b 100644 --- a/arch/arm/net

[PATCH v9 bpf-next 08/17] libbpf: add "prog_flags" to bpf_program/bpf_prog_load_attr/bpf_load_program_attr

stomizing program loading. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- tools/lib/bpf/bpf.c| 1 + tools/lib/bpf/bpf.h| 1 + tools/lib/bpf/libbpf.c | 3 +++ tools/lib/bpf/libbpf.h | 1 + 4 files changed, 6 insertions(+) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index

[PATCH v9 bpf-next 16/17] riscv: bpf: eliminate zero extension code-gen

Cc: Björn Töpel Acked-by: Björn Töpel Tested-by: Björn Töpel Signed-off-by: Jiong Wang --- arch/riscv/net/bpf_jit_comp.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net

[PATCH v9 bpf-next 06/17] tools: bpf: sync uapi header bpf.h

Sync new bpf prog load flag "BPF_F_TEST_RND_HI32" to tools/. Signed-off-by: Jiong Wang --- tools/include/uapi/linux/bpf.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 68d4470..7c6aef2 10

[PATCH v9 bpf-next 00/17] bpf: eliminate zero extensions for sub-register writes

set enabled, > 25% of those 4460 could be identified as doesn't needing zero extension on the destination, and the percentage could go further up to more than 50% with some follow up optimizations based on the infrastructure offered by this set. This leads to significant save on JITed

Re: [PATCH v8 bpf-next 05/16] bpf: introduce new bpf prog load flags "BPF_F_TEST_RND_HI32"

On 24/05/2019 21:43, Alexei Starovoitov wrote: On Fri, May 24, 2019 at 12:35:15PM +0100, Jiong Wang wrote: x86_64 and AArch64 perhaps are two arches that running bpf testsuite frequently, however the zero extension insertion pass is not enabled for them because of their hardware support. It is

Re: [PATCH v8 bpf-next 15/16] riscv: bpf: eliminate zero extension code-gen

Björn Töpel writes: > On Fri, 24 May 2019 at 13:36, Jiong Wang wrote: >> >> Cc: Björn Töpel >> Acked-by: Björn Töpel >> Tested-by: Björn Töpel >> Signed-off-by: Jiong Wang >> --- >> arch/riscv/net/bpf_jit_comp.c | 43 >> +++

[PATCH v8 bpf-next 12/16] s390: bpf: eliminate zero extension code-gen

Cc: Martin Schwidefsky Cc: Heiko Carstens Signed-off-by: Jiong Wang --- arch/s390/net/bpf_jit_comp.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index 5e7c630..e636728

[PATCH v8 bpf-next 06/16] bpf: verifier: randomize high 32-bit when BPF_F_TEST_RND_HI32 is set

This patch randomizes high 32-bit of a definition when BPF_F_TEST_RND_HI32 is set. Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 68 ++- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git a

[PATCH v8 bpf-next 13/16] sparc: bpf: eliminate zero extension code-gen

Cc: David S. Miller Signed-off-by: Jiong Wang --- arch/sparc/net/bpf_jit_comp_64.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 65428e7..3364e2a 100644 --- a/arch

[PATCH v8 bpf-next 07/16] libbpf: add "prog_flags" to bpf_program/bpf_prog_load_attr/bpf_load_program_attr

stomizing program loading. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- tools/lib/bpf/bpf.c| 1 + tools/lib/bpf/bpf.h| 1 + tools/lib/bpf/libbpf.c | 3 +++ tools/lib/bpf/libbpf.h | 1 + 4 files changed, 6 insertions(+) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index

[PATCH v8 bpf-next 09/16] selftests: bpf: enable hi32 randomization for all tests

used load APIs to the test version, hence enable high 32-bit randomization for these tests without changing source code. Besides all these, there are several testcases are using "bpf_prog_load_attr" directly, their call sites are updated to pass BPF_F_TEST_RND_HI32. Signed-off-by: Ji

[PATCH v8 bpf-next 16/16] nfp: bpf: eliminate zero extension code-gen

ed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 115 +- drivers/net/ethernet/netronome/nfp/bpf/main.h | 2 + drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 12 +++ 3 files changed, 81 insertions(+), 48 dele

[PATCH v8 bpf-next 10/16] arm: bpf: eliminate zero extension code-gen

Cc: Shubham Bansal Signed-off-by: Jiong Wang --- arch/arm/net/bpf_jit_32.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index c8bfbbf..97a6b4b 100644 --- a/arch/arm/net

[PATCH v8 bpf-next 04/16] bpf: verifier: insert zero extension according to analysis result

upport and want verifier insert zero extension explicitly. Offload targets do not use this native target hook, instead, they could get the optimization results using bpf_prog_offload_ops.finalize. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf.h| 1 + include/linu

[PATCH v8 bpf-next 11/16] powerpc: bpf: eliminate zero extension code-gen

Cc: Naveen N. Rao Cc: Sandipan Das Signed-off-by: Jiong Wang --- arch/powerpc/net/bpf_jit_comp64.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c index 21a1dcd

[PATCH v8 bpf-next 05/16] bpf: introduce new bpf prog load flags "BPF_F_TEST_RND_HI32"

any later insn. Such randomization is only enabled under testing mode which is gated by the new bpf prog load flags "BPF_F_TEST_RND_HI32". Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- include/uapi/linux/bpf.h | 18 ++ kernel/bpf/syscall.c

[PATCH v8 bpf-next 08/16] selftests: bpf: adjust several test_verifier helpers for insn insertion

efficient that 1M call to it will hang computer. So , change to BPF_ALU64_IMM to avoid hi32 randomization. Signed-off-by: Jiong Wang --- tools/testing/selftests/bpf/test_verifier.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH v8 bpf-next 15/16] riscv: bpf: eliminate zero extension code-gen

Cc: Björn Töpel Acked-by: Björn Töpel Tested-by: Björn Töpel Signed-off-by: Jiong Wang --- arch/riscv/net/bpf_jit_comp.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net

[PATCH v8 bpf-next 00/16] bpf: eliminate zero extensions for sub-register writes

cat dump | grep -P "r.*=.*u32" | wc -l (READ_W) cat dump | grep -P "r.*=.*u16" | wc -l (READ_H) cat dump | grep -P "r.*=.*u8" | wc -l (READ_B) After this patch set enabled, > 25% of those 4460 could be identified as doesn't needing zero extension

[PATCH v8 bpf-next 14/16] x32: bpf: eliminate zero extension code-gen

Cc: Wang YanQing Tested-by: Wang YanQing Signed-off-by: Jiong Wang --- arch/x86/net/bpf_jit_comp32.c | 83 +-- 1 file changed, 56 insertions(+), 27 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c index b29e82f

[PATCH v8 bpf-next 02/16] bpf: verifier: mark patched-insn with sub-register zext flag

Patched insns do not go through generic verification, therefore doesn't has zero extension information collected during insn walking. We don't bother analyze them at the moment, for any sub-register def comes from them, just conservatively mark it as needing zero extension. Signed-off

[PATCH v8 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

A new sub-register write overrides the old one. - When propagating read64 during path pruning, also mark any insn defining a sub-register that is read in the pruned path as full-register. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf_verifier.h | 14 +++- kerne

[PATCH v8 bpf-next 03/16] bpf: introduce new mov32 variant for doing explicit zero extension

insn using this new mov32 variant. One helper function insn_is_zext is added for checking one insn is an zero extension on dst. This will be widely used by a few JIT back-ends in later patches in this set. Signed-off-by: Jiong Wang --- include/linux/filter.h | 14 ++ 1 file changed

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

Alexei Starovoitov writes: > well, it made me realize that we're probably doing it wrong, > since after calling check_reg_arg() we need to re-parse insn encoding. > How about we change check_reg_arg()'s enum reg_arg_type instead? This is exactly what I had implemented in my initial internal v

Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor

> On 23 May 2019, at 15:02, Daniel Borkmann wrote: > > On 05/23/2019 08:38 AM, Y Song wrote: >> On Wed, May 22, 2019 at 1:46 PM Björn Töpel wrote: >>> On Wed, 22 May 2019 at 20:13, Y Song wrote: On Wed, May 22, 2019 at 2:25 AM Björn Töpel wrote: > > Add three tests to test_veri

Re: [PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

> On 23 May 2019, at 03:07, Alexei Starovoitov > wrote: > > On Wed, May 22, 2019 at 07:54:57PM +0100, Jiong Wang wrote: >> eBPF ISA specification requires high 32-bit cleared when low 32-bit >> sub-register is written. This applies to destination register of ALU32 et

[PATCH v7 bpf-next 05/16] bpf: introduce new bpf prog load flags "BPF_F_TEST_RND_HI32"

any later insn. Such randomization is only enabled under testing mode which is gated by the new bpf prog load flags "BPF_F_TEST_RND_HI32". Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- include/uapi/linux/bpf.h | 18 ++ kernel/bpf/syscall.c

[PATCH v7 bpf-next 08/16] selftests: bpf: adjust several test_verifier helpers for insn insertion

efficient that 1M call to it will hang computer. So , change to BPF_ALU64_IMM to avoid hi32 randomization. Signed-off-by: Jiong Wang --- tools/testing/selftests/bpf/test_verifier.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH v7 bpf-next 09/16] selftests: bpf: enable hi32 randomization for all tests

used load APIs to the test version, hence enable high 32-bit randomization for these tests without changing source code. Besides all these, there are several testcases are using "bpf_prog_load_attr" directly, their call sites are updated to pass BPF_F_TEST_RND_HI32. Signed-off-by: Ji

[PATCH v7 bpf-next 11/16] powerpc: bpf: eliminate zero extension code-gen

Cc: Naveen N. Rao Cc: Sandipan Das Signed-off-by: Jiong Wang --- arch/powerpc/net/bpf_jit_comp64.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c index 21a1dcd

[PATCH v7 bpf-next 10/16] arm: bpf: eliminate zero extension code-gen

Cc: Shubham Bansal Signed-off-by: Jiong Wang --- arch/arm/net/bpf_jit_32.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index c8bfbbf..97a6b4b 100644 --- a/arch/arm/net

[PATCH v7 bpf-next 15/16] riscv: bpf: eliminate zero extension code-gen

Cc: Björn Töpel Acked-by: Björn Töpel Tested-by: Björn Töpel Signed-off-by: Jiong Wang --- arch/riscv/net/bpf_jit_comp.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net

[PATCH v7 bpf-next 07/16] libbpf: add "prog_flags" to bpf_program/bpf_prog_load_attr/bpf_load_program_attr

stomizing program loading. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- tools/lib/bpf/bpf.c| 1 + tools/lib/bpf/bpf.h| 1 + tools/lib/bpf/libbpf.c | 3 +++ tools/lib/bpf/libbpf.h | 1 + 4 files changed, 6 insertions(+) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index

[PATCH v7 bpf-next 13/16] sparc: bpf: eliminate zero extension code-gen

Cc: David S. Miller Signed-off-by: Jiong Wang --- arch/sparc/net/bpf_jit_comp_64.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 65428e7..3364e2a 100644 --- a/arch

[PATCH v7 bpf-next 12/16] s390: bpf: eliminate zero extension code-gen

Cc: Martin Schwidefsky Cc: Heiko Carstens Signed-off-by: Jiong Wang --- arch/s390/net/bpf_jit_comp.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index 5e7c630..e636728

[PATCH v7 bpf-next 14/16] x32: bpf: eliminate zero extension code-gen

Cc: Wang YanQing Tested-by: Wang YanQing Signed-off-by: Jiong Wang --- arch/x86/net/bpf_jit_comp32.c | 83 +-- 1 file changed, 56 insertions(+), 27 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c index b29e82f

[PATCH v7 bpf-next 16/16] nfp: bpf: eliminate zero extension code-gen

ed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 115 +- drivers/net/ethernet/netronome/nfp/bpf/main.h | 2 + drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 12 +++ 3 files changed, 81 insertions(+), 48 dele

[PATCH v7 bpf-next 02/16] bpf: verifier: mark patched-insn with sub-register zext flag

Patched insns do not go through generic verification, therefore doesn't has zero extension information collected during insn walking. We don't bother analyze them at the moment, for any sub-register def comes from them, just conservatively mark it as needing zero extension. Signed-off

[PATCH v7 bpf-next 06/16] bpf: verifier: randomize high 32-bit when BPF_F_TEST_RND_HI32 is set

This patch randomizes high 32-bit of a definition when BPF_F_TEST_RND_HI32 is set. Suggested-by: Alexei Starovoitov Signed-off-by: Jiong Wang --- kernel/bpf/verifier.c | 68 ++- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git a

[PATCH v7 bpf-next 00/16] bpf: eliminate zero extensions for sub-register writes

.*u8" | wc -l (READ_B) After this patch set enabled, more than half of those 4460 could be identified as doesn't needing zero extension on the destination, this could lead significant save on JITed image. Jiong Wang (16): bpf: verifier: mark verified-insn with sub-register zext f

[PATCH v7 bpf-next 01/16] bpf: verifier: mark verified-insn with sub-register zext flag

A new sub-register write overrides the old one. - When propagating read64 during path pruning, also mark any insn defining a sub-register that is read in the pruned path as full-register. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf_verifier.h | 14 +++- kerne

[PATCH v7 bpf-next 04/16] bpf: verifier: insert zero extension according to analysis result

s hardware zero extension support. The peephole could be as simple as looking the next insn, if it is a special zero extension insn then it is safe to eliminate it if the current insn has hardware zero extension support. Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- include/linux/bpf.h

[PATCH v7 bpf-next 03/16] bpf: introduce new mov32 variant for doing explicit zero extension

insn using this new mov32 variant. One helper function insn_is_zext is added for checking one insn is an zero extension on dst. This will be widely used by a few JIT back-ends in later patches in this set. Signed-off-by: Jiong Wang --- include/linux/filter.h | 14 ++ 1 file changed

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Alexei Starovoitov writes: > On Fri, May 10, 2019 at 09:30:28AM +0100, Jiong Wang wrote: >> >> Alexei Starovoitov writes: >> >> > On Thu, May 09, 2019 at 01:32:30PM +0100, Jiong Wang wrote: >> >> >> >> Alexei Starovoitov writes: >>

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Alexei Starovoitov writes: > On Thu, May 09, 2019 at 01:32:30PM +0100, Jiong Wang wrote: >> >> Alexei Starovoitov writes: >> >> > On Wed, May 08, 2019 at 03:45:12PM +0100, Jiong Wang wrote: >> >> >> >> I might be misunde

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Jiong Wang writes: > At the moment we have single backend hook "bpf_jit_hardware_zext", once a > backend enable it, verifier just insert zero extension for all identified > alu32 and narrow loads. > > Given verifier analysis info is not pushed down to JIT back-ends, v

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Alexei Starovoitov writes: > On Wed, May 08, 2019 at 03:45:12PM +0100, Jiong Wang wrote: >> >> I might be misunderstanding your points, please just shout if I am wrong. >> >> Suppose the following BPF code: >> >> unsigned helper(unsigned long long,

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Alexei Starovoitov writes: > On Fri, May 03, 2019 at 11:42:28AM +0100, Jiong Wang wrote: >> BPF helper call transfers execution from eBPF insns to native functions >> while verifier insn walker only walks eBPF insns. So, verifier can only >> knows argument and return valu

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

Jiong Wang writes: > Daniel Borkmann writes: > >> On 05/03/2019 12:42 PM, Jiong Wang wrote: >>> BPF helper call transfers execution from eBPF insns to native functions >>> while verifier insn walker only walks eBPF insns. So, verifier can only >>> kno

[PATCH bpf] nfp: bpf: fix static check error through tightening shift amount adjustment

eported-by: Oleksandr Natalenko Reported-by: Pablo Cascón Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/d

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

Jiong Wang writes: > Alexei Starovoitov writes: > >> On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: >>> This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused >>> opcode 0xe0 to it. >>> >>> Compared with the other

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

Alexei Starovoitov writes: > On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: >> This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused >> opcode 0xe0 to it. >> >> Compared with the other alu32 insns, zero extension on low 32-bit is the

  1   2   3   4   5   >