On 18/01/2008, Samuel Ortiz <[EMAIL PROTECTED]> wrote:
> Hi Dave,
>
> Here goes an IrDA patch against your latest net-2.6 tree.
>
> This patch fixes some af_irda memory leaks.
> It also checks for irias_new_obect() return value.
>
> Signed-off-by: Jesper Juhl <[
pplied on top of
[PATCH 1/2] irda: return -ENOMEM upon failure to allocate new ias_obj
The Coverity checker gets credit for pointing its finger towards this.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
af_irda.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
d
but I think
it's a lot nicer to simply return -ENOMEM to the caller here where we know
a memory allocation failed, rather than hitting an assertion later.
note: I don't have any means of actually testing this, so it has been
compile tested only.
Signed-off-by: Jesper Juhl &l
t are the no rules
describing the various parts of the address that could perhaps be used
to infer programatically if the address seems to be reversed or not,
and then use that detection logic for all boards that are known to
potentially have the issue?
A module parameter that overrules the autom
From: Jesper Juhl <[EMAIL PROTECTED]>
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
"sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" i
ly-to-all initially; sorry Randy,
now you'll get this mail twice ;)
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send
On Friday 31 August 2007 00:19:53 Joe Perches wrote:
> On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
> > Ok, I must admit I didn't check with sparse since it seemed pointless
> > - we usually never cast void pointers to other pointer types,
> > specifically bec
On 30/08/2007, Daniel Drake <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > Since kmalloc() returns a void pointer there is no reason to cast
> > its return value.
> > This patch also removes a pointless initialization of a variable.
>
> NAK: adds a sparse wa
The general kernel memory allocation functions return void pointers
and there is no need to cast their return values.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/bsd_comp.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bsd_co
kmalloc() and friends return void*, no need to cast it.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/wireless/libertas/debugfs.c |2 +-
drivers/net/wireless/libertas/ethtool.c |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wi
ing be
slightly better?
Signed-off-by: Keir Fraser <[EMAIL PROTECTED]>
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/xen-netfront.c |4 +++-
1 files changed, 3 insertio
nt that tests for a NULL
'dev', then that NULL deref can never happen.
It never hurts to be safe :-)
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index e22a3f5..671f4da 100644
--- a/drivers/net/tokenr
(this one looks like it should go to netdev as well - added to Cc)
On 10/08/07, Sinisa Segvic <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I've just got a kernel oops.
>
> http://lxr.linux.no/source/Documentation/oops-tracing.txt
> seems to suggest that oops reports are welcome at this address.
>
> Cheers
On 09/08/2007, Chris Snook <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > On 09/08/2007, Chris Snook <[EMAIL PROTECTED]> wrote:
> >> From: Chris Snook <[EMAIL PROTECTED]>
> >>
> >> Some architectures currently do not declare the contents
thought we were trying to move away from volatile since it is
very weakly defined and towards explicit barriers and locks...
Points to --> Documentation/volatile-considered-harmful.txt
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top
ts for a NULL
'dev', then that NULL deref can never happen.
It never hurts to be safe :-)
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index e22a3f5..671f4da 100644
--- a/drivers/net/tokenring/3c359.
On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > Hello,
> >
> > This patch makes sure we don't dereference a NULL pointer in
> > drivers/net/usb/pegasus.c::write_bulk_ca
that pointer until after that check.
Please consider merging.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/usb/pegasus.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index a05fd97..04cb
On 24/07/07, Patrick McHardy <[EMAIL PROTECTED]> wrote:
Jesper Juhl wrote:
> This patch cleans up duplicate includes in
> net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl
Hi,
This patch cleans up duplicate includes in
net/xfrm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c3a4b0a..e67489a 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -23,10 +23,9 @@
#i
Hi,
This patch cleans up duplicate includes in
net/tipc/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/tipc/port.c b/net/tipc/port.c
index 5d2b9ce..7608815 100644
--- a/net/tipc/port.c
+++ b/net/tipc/port.c
@@ -41,7 +41,6 @@
#include "addr.h"
Hi,
This patch cleans up duplicate includes in
net/ipv6/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d67fb1e..db50114 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -56,7 +56,6 @@
#include
#i
Hi,
This patch cleans up duplicate includes in
net/sched/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index bf90e60..6085be5 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -16,7 +16,6 @@
#i
Hi,
This patch cleans up duplicate includes in
net/netfilter/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c
b/net/netfilter/nf_conntrack_proto_tcp.c
index 87ad3cc..eb3fe74 100644
--- a/net/netfilter/nf_conntrack_proto
Hi,
This patch cleans up duplicate includes in
net/atm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 2770fb4..59d5aa3 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -21,7 +21,6 @@
#include
#include
#include
-#i
Hi,
This patch cleans up duplicate includes in
net/bridge/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/bridge/netfilter/ebt_log.c b/net/bridge/netfilter/ebt_log.c
index 031bfa4..89d0d59 100644
--- a/net/bridge/netfilter/ebt_log.c
+++ b/net/bridge/net
Why not mention all the various methods, dmesg -n,
/proc/sys/kernel/printk, SysRq, ignore_loglevel ??
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsu
people to set their console log level to something useful, as
> having that set too low is the most common problem people encounter.
How about this?
From: Satyam Sharma <[EMAIL PROTECTED]>
Add some useful general-purpose tips.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
into
if (!cphy)
return NULL;
callers need to be able to handle that ofcourse, but I haven't checked that yet.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://w
On 27/11/06, David Miller <[EMAIL PROTECTED]> wrote:
From: Jesper Juhl <[EMAIL PROTECTED]>
Date: Mon, 27 Nov 2006 22:44:07 +0100
> In net/key/af_key.c::pfkey_send_policy_notify() there's a check at the
> beginning of the function :
>
> if (xp && xp->
in the else part :
optptr = opt->is_data ? opt->__data : (unsigned char*)&(skb->nh.iph[1]);
So if 'skb' is NULL, the only route I see that doesn't cause a NULL
pointer deref is if (opt != NULL) and at the same time
(opt->is_data != NULL) . Is that gu
gt;PME(D0-,D1+,D2+,D3hot+,D3cold+)
>>Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>>00: ec 10 67 81 17 00 b0 02 10 00 00 02 08 40 00 00
>>10: 01 d8 00 00 00 fc 8f fe 00 00 00 00 00 00 00 00
>>20: 00 00 00 00 00 00 00 00 00 00 00 00 43 10 45 13
>>30: 00 0
Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv()
We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {"
but at that point we may have allocated opt_skb, but we never free it
in that path before the return.
Signed-off-by: Jesper
le to
> test Linus's current git tree?
Sorry, I don't have oodles of disk space free to hold all the git
historical information (iirc, it's huge).
[snip]
You could just grab the latest snapshot (at the time of this writing
that's 2.6.18-git8) from kernel.org - that way y
t.
It was the only way I could find to accomplish that. If you know of a
better way I'd appreciate a hint :)
In any event, propagating this method pointer to the wrong device
structure is a bug.
Ok, then the patch as it stands is dead. I'll try to find another way.
Thank you for y
On 01/09/06, Jesper Juhl <[EMAIL PROTECTED]> wrote:
On 01/09/06, Herbert Xu <[EMAIL PROTECTED]> wrote:
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
> >
> > I've just encountered the problem on a different server with an
> > identical vlan setup. That
On 01/09/06, Herbert Xu <[EMAIL PROTECTED]> wrote:
Jesper Juhl <[EMAIL PROTECTED]> wrote:
>
> I've just encountered the problem on a different server with an
> identical vlan setup. That server is running 2.6.13.4
Do you have a simple recipe to reproduce this? Ide
On 31/08/06, Jesper Juhl <[EMAIL PROTECTED]> wrote:
On 31/08/06, Ben Greear <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > Hi,
> >
> > I've got a small problem with 2.6.18-rc5-git2.
> >
> > I've got a vlan setup on eth0.20, eth0 does n
On 31/08/06, Ben Greear <[EMAIL PROTECTED]> wrote:
Jesper Juhl wrote:
> Hi,
>
> I've got a small problem with 2.6.18-rc5-git2.
>
> I've got a vlan setup on eth0.20, eth0 does not have an IP.
>
> When I attempt to reboot or halt the machine I get the followin
interface
before the 'lo' interface. I tried that and indeed, it works.
Any idea how we can get this fixed?
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.
it up and arrive at a version that's
mergable, I'd greatly appreciate it.
PS. If you reply to this on the netdev list, please keep me on Cc:
since I'm only subscribed to linux-kernel.
Kind regards,
Jesper Juhl <[EMAIL PROTECTED]>
Signed-off-by: Jesper Juhl &l
be to find a replacement URL if one exist, but
failing that removing the wrong ones is a good thing IMHO.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To
On 05/08/06, David Miller <[EMAIL PROTECTED]> wrote:
From: "Jesper Juhl" <[EMAIL PROTECTED]>
Date: Sat, 5 Aug 2006 01:30:49 +0200
> On 31/07/06, David Miller <[EMAIL PROTECTED]> wrote:
> > From: "Jesper Juhl" <[EMAIL PROTECTED]>
> > Dat
On 31/07/06, David Miller <[EMAIL PROTECTED]> wrote:
From: "Jesper Juhl" <[EMAIL PROTECTED]>
Date: Sun, 30 Jul 2006 23:51:20 +0200
> Looks ok to me.
I've applied James's version of the fix, thanks everyone.
Hmm, if you are refering to commit
118075b3cdc9
On 30/07/06, James Morris <[EMAIL PROTECTED]> wrote:
On Sun, 30 Jul 2006, Stephen Hemminger wrote:
> On Sun, 30 Jul 2006 21:38:02 +0200
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
>
> > There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
> &
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
We are not freeing 'tbuf' on error.
Patch below fixes that.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
net/ipv4/tcp_probe.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
---
On 2/26/06, Paul Rolland <[EMAIL PROTECTED]> wrote:
> Hello,
>
> > are you planning a 2.6 patch as well ?
> >
> I'm preparing it, and I'll be carefull with Tab/space ;)
>
Ok, great, I was just wondering since I would have made one if you had
no plans to
On 2/25/06, Paul Rolland <[EMAIL PROTECTED]> wrote:
> Hello,
>
> This patch is based on Linux 2.4.32, and I've verified the same problem
> exists on 2.6.15.4.
are you planning a 2.6 patch as well ?
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://w
roblem and post a patch that
> doesn't "break userspace" if necessary.
>
Maybe if you described "your current problem" someone could suggest a
solution...
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.htm
nd even then it's announced for several months (years
sometimes) in Documentation/feature-removal.txt and elsewhere.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.
al packets to consume memory
> from critical page pool.
>
> I would appreciate any feedback or comments on this approach.
>
To be a little serious, it sounds like something that could be used to
cause trouble and something that will lose its usefulness once enough
people start using it
Get rid of needless casting of kmalloc() return value in net/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
net/bluetooth/hci_conn.c |2 +-
net/sunrpc/svc.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.15-rc5-git1-orig/net/bluetooth/hci_
> Al
>
> Also, how does this involve the kernel? The interface to the kernel
> for hardware configuration is via ioctl(). For logic, sockets.
>
> If the user-level tools suck, then they should be fixed. It
> really doesn't have anything to do with the kernel.
>
> Ch
send the "patch" to? Or can someone simply change that?
>
Firmware should go into /lib/firmware, not /etc/firmware.
Found by Alejandro Bonilla.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/net/wireless/Kconfig |2 +-
1 files changed, 1 insertion(+), 1 del
ly cares about it any more.
You should probably also talk to the netdev people (CC'ed).
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from
nd include an URL in the email
- compress the file(s) and attach the compressed files to the email
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscrib
On 8/30/05, Sridhar Samudrala <[EMAIL PROTECTED]> wrote:
> On Tue, 2005-08-30 at 22:45 +0200, Jesper Juhl wrote:
> > Since the patch to add a NULL short-circuit to crypto_free_tfm() went in,
> > there's no longer any need for callers of that function to check for NULL.
ainline and not -mm,
so this patch is against 2.6.13.
Feedback, ACK, NACK, etc welcome.
Sorry about the large Cc list, but I wanted to include everyone involved
with the code I change.
Please keep me on Cc.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
./drivers/net/wireless/ai
58 matches
Mail list logo
