Re: Possible race in nsc-ircc.ko

2017-08-25 Thread Jean Tourrilhes
On Fri, Aug 25, 2017 at 05:05:25PM +0300, Anton Volkov wrote: > Hello. > > While searching for races in the Linux kernel I've come across > "drivers/net/irda/nsc-ircc.ko" module. Here is a question that I came up > with while analyzing results. Lines are given using the info from Linux > v4.12. >

Re: [PATCH]race between open and disconnect in irda-usb

2007-10-11 Thread Jean Tourrilhes
On Thu, Oct 11, 2007 at 05:45:28PM +0200, Oliver Neukum wrote: > Hi, > Hi, You need to cc Samuel Ortiz and the IrDA mailing list if you want any meaningful response. > it seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kil

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-12 Thread Jean Tourrilhes
On Wed, Jul 11, 2007 at 11:30:17PM -0400, Dan Williams wrote: > On Tue, 2007-07-10 at 14:25 -0500, Larry Finger wrote: > > Jean, > > > > Jean Tourrilhes wrote: > > > Hi, > > > > > > SoftMAC output the channel twice in the scan output. It shou

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-12 Thread Jean Tourrilhes
On Thu, Jul 12, 2007 at 11:40:23AM -0500, Larry Finger wrote: > Jean Tourrilhes wrote: > > > > Well, I actually like forcing driver to use frequency, because > >that's an absolute physical measure and contains more meaning. > > Yes, but it is easier to keep a

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-10 Thread Jean Tourrilhes
On Tue, Jul 10, 2007 at 02:25:12PM -0500, Larry Finger wrote: > Jean, > > Jean Tourrilhes wrote: > > Hi, > > > > SoftMAC output the channel twice in the scan output. It should > >display frequency an

[PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-10 Thread Jean Tourrilhes
al level=-47 dBm Noise level=-65 dBm Extra: Last beacon: 120ms ago The fix is simple, patch attached, tested for 2.6.22 with bcm43xx. If you like it, send it to John. Regards, Jean Signed-off-by:

Re: [PATCH 2.6] SoftMAC : fix ESSID problem

2007-07-09 Thread Jean Tourrilhes
On Mon, Jul 09, 2007 at 06:40:44PM -0500, Larry Finger wrote: > > This patch should also be sent to [EMAIL PROTECTED] Please do so if you like it. > Larry Jean - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

[PATCH 2.6] SoftMAC : fix ESSID problem

2007-07-09 Thread Jean Tourrilhes
pretty trivial. John : would you mind pushing that to 2.6.23 ? Thanks... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09

[PATCH 2.6] WE : Fix get 32 char ESSID

2007-07-09 Thread Jean Tourrilhes
... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/net/wireless/wext.j1.c2007-07-09 13:19:22.0 -0700 +++ linux/net/wireless/wext.c 2007-07-09 13:19:59.0 -0700 @@ -741,39 +741,11 @@ stat

Re: [PATCH 7/9] wext: reduce inline abuse

2007-04-26 Thread Jean Tourrilhes
On Thu, Apr 26, 2007 at 07:03:27PM +0200, Michael Buesch wrote: > > Sure, other people have different opinions on that, but I think > with my approach we get smallest code with good speed. Try with gcc-3.3 if you don't trust me. Your patch will produce bigger and slower code. Thanks.

Re: [PATCH 7/9] wext: reduce inline abuse

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:39PM +0200, Johannes Berg wrote: > This patch removes a bunch of inline abuse from wext. Most functions > that were marked inline are only used once so the compiler will inline > them anyway, others are used multiple times but there's no requirement > for them to be in

Re: [PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: > This patch makes the wext bits in struct net_device depend on > CONFIG_WIRELESS_EXT. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> I personally would not do that. Having conditional fields in "struct net_device" is ve

Re: [PATCH 3/9] wext: remove dead debug code

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:35PM +0200, Johannes Berg wrote: > This patch kills a whole bunch of code that can only ever be used by > defining some things in wext.c. Also, the things that are printed are > mostly useless since the API is fairly well-tested. > > Signed-off-by: Johannes Berg <[EMA

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-18 Thread Jean Tourrilhes
On Wed, Apr 18, 2007 at 01:34:50AM +0200, Michael Buesch wrote: > > I'd say nobody but you does fully understand WEXT. Not true. If tommorow I was run over by an ICE, you could ask Jouni, Dan or Pavel to take over. Have fun... Jean - To unsubscribe from this list: send th

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-17 Thread Jean Tourrilhes
On Tue, Apr 17, 2007 at 02:34:42PM -0400, John W. Linville wrote: > On Tue, Apr 17, 2007 at 10:08:20AM -0700, Jean Tourrilhes wrote: > > > > First, I'm the current active maintainer of the > > wext-over-netlink interface, and nobody bothered to even 'inform

Re: [PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-04-17 Thread Jean Tourrilhes
On Mon, Apr 02, 2007 at 12:06:50PM +0200, Johannes Berg wrote: > > Jean Tourrilhes wrote : > > Johannes Berg discovered that kernel space was leaking to > > userspace on 64 bit platform. He made a first patch to fix that. This > > is an improved version of his patch.

[PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-03-22 Thread Jean Tourrilhes
Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/include/linux/wireless.j1.h linux/include/linux/wireless.h --- linux/include/linux/wireless.j1.h 2007-03-08 10:34:32.0 -0800 +++ linux/include/linux/wire

[PATCH 2.6] Add missing ioctls to 64<->32 conversion

2007-03-22 Thread Jean Tourrilhes
stream ? Thanks... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/fs/compat_ioctl.j1.c linux/fs/compat_ioctl.c --- linux/fs/compat_ioctl.j1.c 2007-03-06 17:49:33.0 -0800

Re: wireless extensions vs. 64-bit architectures

2007-03-13 Thread Jean Tourrilhes
On Tue, Mar 13, 2007 at 08:42:05PM +0100, Johannes Berg wrote: > On Mon, 2007-03-12 at 10:56 -0700, Jean Tourrilhes wrote: > > > I did that in the e-mail to Jouni. The problem is that most > > people are unfamiliar with decoding iwevents, so can't grasp the > > e

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jean Tourrilhes
On Mon, Mar 12, 2007 at 10:21:49AM -0800, Jouni Malinen wrote: > On Mon, Mar 12, 2007 at 10:56:39AM -0700, Jean Tourrilhes wrote: > > > > I would guess that others "use" iwlib like that too. > > > > Which others ? The applications that process scan resul

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jean Tourrilhes
On Sun, Mar 11, 2007 at 06:40:01PM +0100, Johannes Berg wrote: > On Fri, 2007-03-09 at 13:35 -0800, Jean Tourrilhes wrote: > > > It's not as bad as it look like. All userspace programs > > nowadays use either the iwlib or wpa_supplicant. For example, > > NetworkM

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jean Tourrilhes
On Fri, Mar 09, 2007 at 03:19:22PM -0800, Jouni Malinen wrote: > On Fri, Mar 09, 2007 at 01:35:31PM -0800, Jean Tourrilhes wrote: > > > It's not as bad as it look like. All userspace programs > > nowadays use either the iwlib or wpa_supplicant. For example, > >

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 11:35:26PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > > > First possiblity, we could stick with this band-aid > > permanently. > > It sucks for various reasons, one for example being that I don&

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 11:22:06PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > > > This is exactly what I was pointing out earlier. Well, > > actually, there may be ways of fixing it in the kernel, but that would > > be rea

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 02:17:56PM -0800, Randy Dunlap wrote: > On Thu, 8 Mar 2007 14:11:28 -0800 Jean Tourrilhes wrote: > > > > Third possibility : we declare 32 bit userspace on 64 bit > > kernel as not supported and advise users to get a 64 bit > > userspace.

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 08:40:01PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 11:34 -0800, Jouni Malinen wrote: > > > Yes, workaround in just iwlib is not enough. If the only possible > > solution is user space workaround, it better be documented (and > > communicated to maintainers of us

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 08:08:29PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote: > > > A proper fix would involve forcing the alignement in the > > kernel. Unfortunately, that would break 64bit->64bit configs. I think > > I

Re: wireless extensions vs. 64-bit architectures

2007-03-08 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 03:39:07PM +0100, Johannes Berg wrote: > On Tue, 2007-03-06 at 18:03 -0800, Jean Tourrilhes wrote: > > > Ok, please check the patch attached. I don't have a box to > > test that on, and on my 32 bit kernel it is not even compiled, but I > >

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
nt? Ok, please check the patch attached. I don't have a box to test that on, and on my 32 bit kernel it is not even compiled, but I believe I got everything all right. Please push that to the usual channels... > Greetings Michael. Thanks again

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
On Tue, Mar 06, 2007 at 07:43:06PM +0100, Michael Buesch wrote: > > > > Yep, and it's even in fs/compat_ioctl.c. Hint, hint ;-) > > Ok, it is wrapping the following ioctls: > > HANDLE_IOCTL(SIOCGIWRANGE, do_wireless_ioctl) > HANDLE_IOCTL(SIOCSIWSPY, do_wireless_ioctl) > HANDLE_IOCTL(SIOCGIWS

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
On Tue, Mar 06, 2007 at 02:27:26AM +0100, Johannes Berg wrote: > Hi, > > Wtf! After struggling with some strange problems with zd1211rw (see some > other mail) I decided to think again about what could possibly cause all > the other problems I'm having with it. The kernel seems fine, but iw* > use

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-03-01 Thread Jean Tourrilhes
On Thu, Mar 01, 2007 at 08:42:09AM +0100, Jarek Poplawski wrote: > On Wed, Feb 28, 2007 at 10:45:41AM -0800, Jean Tourrilhes wrote: > > > > + > > > > + if ((size <= 0) || (i >= num_envp)) > > > > > > Btw.: > > > 1. if size == 10

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Thu, Mar 01, 2007 at 01:37:46AM +0100, Johannes Berg wrote: > On Wed, 2007-02-28 at 16:26 -0800, Jean Tourrilhes wrote: > > > + /* This function is only used for network interface. > > +* Some hotplug package track interfaces by their name and > > +* therefo

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: > On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: > > diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c > > --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800 > > +

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote: > Hi, > > > Patch for 2.6.20 is attached. > > ... and in the meantime netdevices aren't class_device any more :) IOW, > your patch isn't going to work any more. That's why I always specify the kernel version. I'll look in

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 10:34:37AM +0100, Jarek Poplawski wrote: > On 28-02-2007 02:27, Jean Tourrilhes wrote: > > Hi all, > ... > > Patch for 2.6.20 is attached. The patch was tested on a system > > running the hotplug scripts, and on another system running ude

Re: [PATCH 2.6.20] kobject net ifindex + rename

2007-02-28 Thread Jean Tourrilhes
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: > On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: > > diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c > > --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800 > > +

[PATCH 2.6.20] kobject net ifindex + rename

2007-02-27 Thread Jean Tourrilhes
he hotplug scripts, and on another system running udev. Have fun... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> - diff -u -p linux/include/linux/kobject.j1.h linux/include/linux/kobject.h --- linux/include/li

Re: [airo.c bug] Couldn't allocate RX FID / Max tries exceeded when issueing command

2006-11-02 Thread Jean Tourrilhes
On Thu, Nov 02, 2006 at 04:21:16PM -0500, Ivan Matveich wrote: > On 11/2/06, Dan Williams <[EMAIL PROTECTED]> wrote: > >Do you know which kernel version that patch first appeared in? > > It was committed on 1 Dec 2005, and 2.6.15 was released on 3 Jan 2006. > > >That would be a great idea, let us

Re: Please pull 'we21-fix' branch of wireless-2.6.git

2006-10-19 Thread Jean Tourrilhes
On Thu, Oct 19, 2006 at 05:56:53PM -0400, John W. Linville wrote: > Jeff, > > Here is my ugly patch to fix userland ABI compatibility for WE-21. > It tries to detect WE <= 20 by the request length or the inclusion of > '\0' in the length for the ESSID and NICKN ioctls. If it finds that, > it temp

Re: Request to postpone WE-21

2006-10-10 Thread Jean Tourrilhes
On Tue, Oct 10, 2006 at 03:40:04PM -0400, John W. Linville wrote: > > I think this patch still has two problems. One is that the length > modification does not happen until after the "Check what user space > is giving us" clause. So, max length requests will fail. (Did you > check SIOCGIWESSID

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 06:37:53PM -0400, Pavel Roskin wrote: > Hello! > > On Tue, 2006-10-03 at 09:34 -0700, Jean Tourrilhes wrote: > > I don't really want to overstep my authority there, my goal > > was to minimise the changes. Pavel will have to clean up my mess,

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 03:15:50PM -0700, Jouni Malinen wrote: > On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote: > > + if((cmd == SIOCSIWESSID) || > > + (cmd == SIOCSIWNICKN)) { > > + if(extra[i

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > Based on the feedback, I formally request you to back out all > > of WE-21 from 2.6.19. Rationale : it's probably too early. Yo

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 02:57:51PM -0700, Jouni Malinen wrote: > On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > > > What about a patch like the one below? It tries to detect WE-20 > > ESSID/NICKN accesses and adjust them to WE-21 style. What am > > I missing? > > > diff --g

Re: Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote: > On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote: > > > Based on the feedback, I formally request you to back out all > > of WE-21 from 2.6.19. Rationale : it's probably too early. Yo

Request to postpone WE-21

2006-10-05 Thread Jean Tourrilhes
Hi John, Based on the feedback, I formally request you to back out all of WE-21 from 2.6.19. Rationale : it's probably too early. You can keep it for a later date if you wish. Regards, Jean - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote: > On 3/10, Jean Tourrilhes wrote: > > | > I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that > | > the last byte is cleared as well. Or am I missing something? > | > | No, that would br

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 05:58:31PM +0200, Samuel Tardieu wrote: > >>>>> "Jean" == Jean Tourrilhes <[EMAIL PROTECTED]> writes: > > Jean> @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o > Jean> len = le16_to_cpu(essidbuf.len

[PATCH 2.6] Fix WE-21 Orinoco overflow issue...

2006-10-02 Thread Jean Tourrilhes
Hi John, This patch fixes the Orinoco driver overflow issue with WE-21. This was discussed on the mailing list, the reporter confirmed that it fixes the issue and Andrew has already added this patch in tree. Regards, Jean --

[PATCH 2.6] More WE-21 potential overflows...

2006-10-02 Thread Jean Tourrilhes
Hi, After the Orinoco issue, I did an audit of other drivers for the same issue. Three drivers were NULL terminating the ESSID, which could cause an overflow in WE-21 when the ESSID has maximum size. Sorry for having overlooked that... Jean Signed-off-by: Jean

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-02 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > % grep ioctl /tmp/foo2 | sort -u | more > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > ioctl(13, SIOCGIWRANGE, 0xbfbcdbdc) = 0 > > ioctl(13, SIOCGIWRATE, 0xbfbcdbbc) = 0 > > Y

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > % grep ioctl /tmp/foo2 | sort -u | more > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > ioctl(13, SIOCG

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > Here's the traceback I got: > > > > slab error in verify_redzone_free(): cache `size-32': memory outside object > > was overwritten > > [] dump_trace+0x64/0x1cd > > [] show_trace_log_lvl+0

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Thu, Sep 21, 2006 at 05:42:35PM -0700, Jouni Malinen wrote: > On Thu, Sep 21, 2006 at 03:55:14PM -0700, Jean Tourrilhes wrote: > > > > Jean, are there any other possibilities? > > > > Yes, dropping SIOCSIWAP (set) entirely, and keep only > > SIOCGIWAP (g

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Fri, Sep 22, 2006 at 12:38:44AM +0200, Jiri Benc wrote: > On Thu, 21 Sep 2006 13:39:18 -0700, mabbas wrote: > > I can fix the patch to do just that if we agree on that. > > Well, we need a flag indicating whether we are associated or not. I don't > know about such a flag in WE (hopefully we wil

Re: [PATCH 2.6.18] WE-21 for ipw2200

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote: > > This hunk doesn't apply to the upstream branch of wireless-2.6. > I propose this one instead: > > @@ -8875,8 +8875,6 @@ static int

Re: [PATCH 2.6.18] WE-21 for ipw2200

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote: > On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote: > > @@ -8861,7 +8861,7 @@ static int ipw_wx_set_essid(struct net_d > > int length = 0; > > mutex_lock(&priv->mutex); > >

Re: [RFC] Alternate WE-21 support (core API)

2006-09-12 Thread Jean Tourrilhes
On Tue, Sep 12, 2006 at 10:43:57AM +0200, Johannes Berg wrote: > > > But there are bits left and right, so > > more inspection of drivers would be needed. For example, wavelan and > > netwave are using encryption key sizes which are not compatible with > > 802.11. > > Hmm, interesting. Will need

Re: [PATCH 1/3] [IrDA] af_irda.c cleanups

2006-09-11 Thread Jean Tourrilhes
On Mon, Sep 11, 2006 at 08:46:36AM +0300, Samuel Ortiz wrote: > Hi Dave, > > We lock the socket when both releasing and getting a disconnected > notification. In the latter case, we also ste the socket as orphan. > This fixes a potential kernel bug that can be triggered when we get the > disconnec

Re: [RFC] Alternate WE-21 support (core API)

2006-09-08 Thread Jean Tourrilhes
On Fri, Sep 08, 2006 at 10:29:23AM -0400, John W. Linville wrote: > On Wed, Sep 06, 2006 at 02:30:53PM -0700, Jean Tourrilhes wrote: > > On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote: > > > > + * V20 to V21 > > > + * -- > > >

Re: [RFC] Alternate WE-21 support (core API)

2006-09-06 Thread Jean Tourrilhes
On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote: > On Thu, Aug 31, 2006 at 04:00:05PM +0200, Johannes Berg wrote: > > On Thu, 2006-08-31 at 06:51 -0700, Jouni Malinen wrote: > > > > > I don't know about the others, but long/short retry limits have users > > > (e.g., Host AP driver

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-05 Thread Jean Tourrilhes
On Mon, Sep 04, 2006 at 10:35:09AM +0200, Johannes Berg wrote: > Uh, please don't strip me from the CC list :) > > > WE-netlink is optional. And WE-ioctl could be made optional > > (still on the todo list). You can also disable WE-event and WE-iwspy > > for further footprint reduction. > > Th

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-01 Thread Jean Tourrilhes
On Fri, Sep 01, 2006 at 08:55:48PM +0200, Michael Buesch wrote: > > > Note that one thing that worry me with your approach is > > footprint. I've used various embedded devices over the years, such as > > the Gumstix (4MB Flash), and this is why WE was optimised for > > footprint. > > Can you

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-09-01 Thread Jean Tourrilhes
On Fri, Sep 01, 2006 at 08:54:00AM +0200, Johannes Berg wrote: > On Thu, 2006-08-31 at 10:12 -0700, Jean Tourrilhes wrote: > > > And I strongly disagree with your disagrement ;-) > > You're of course free to do that :) But let me explain. And my explanat

Re: [PATCH 2.6.18] WE-21 support (core API)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote: > On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote: > > o modulation > > o long/short retry > > o relative power saving. > > I strongly disagree to these.

Re: [PATCH] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 09:57:45AM -0400, John W. Linville wrote: > On Thu, Aug 31, 2006 at 08:22:22AM -0500, Larry Finger wrote: > > > John, have you merged, or do you plan to merge, "[PATCH 2.6.18] WE-21 > > support (core API)" into > > wireless-2.6? > > I guess that is still up for discussion

Re: [PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-31 Thread Jean Tourrilhes
On Thu, Aug 31, 2006 at 03:09:04PM +0200, Johannes Berg wrote: > Jean, > > > This is the version of the patch for out-of-tree, I guess you > > will need it. Not tested. > > We don't, neither softmac nor bcm43xx is maintained out-of-tree any > more. > > johannes Cool. I should have c

Re: [PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-30 Thread Jean Tourrilhes
On Wed, Aug 30, 2006 at 02:51:05PM +0200, Michael Buesch wrote: > On Wednesday 30 August 2006 03:12, Jean Tourrilhes wrote: > > Hi, > > > > WE-21 for Broadcom driver and SoftMAC... > > This version is for wireless-2.6 git. > > > >

Re: [PATCH] WE-21 for zd1211rw

2006-08-30 Thread Jean Tourrilhes
On Wed, Aug 30, 2006 at 03:46:27AM +0100, Daniel Drake wrote: > Looks like zd1211rw was forgotten from the WE-21 migration. This patch > should do it... Good catch ! Actually, I did look at it, and verified that it was using softmac for ESSID, so I thought I was ok... With the numb

[PATCH 2.6.18] Prism54 : add bitrates to scan result

2006-08-29 Thread Jean Tourrilhes
... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/prism54/isl_ioctl.r1.c linux/drivers/net/wireless/prism54/isl_ioctl.c --- linux/drivers/net/wireless/prism54/isl_ioctl.r1.c

[PATCH 2.6.18] WE-21 for bcm43xx (wireless-2.6 git)

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Broadcom driver and SoftMAC... This version is for wireless-2.6 git. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/net/ieee80211/softmac/ieee80211softmac

[PATCH 2.6.18] WE-21 for prism54usb

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Prism54 SoftMAC driver... Patch for wireless-2.6 git. And most likely useless ;-) Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/pris

[PATCH 2.6.18] WE-21 for bcm43xx (2.6.18-rc5)

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Broadcom driver and SoftMac... This version is for 2.6.18-rc5. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/net/ieee80211/softmac/ieee80211softmac_w

[PATCH 2.6.18] WE-21 for tiacx

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for TI ACX driver... Patch for wireless-2.6 git. Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/drivers/net/wireless/tiacx/ioctl.20.c 2006-08-29 15:38:59.0

[PATCH 2.6.18] WE-21 for adm8211

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for ADMTek driver... Patch for wireless-2.6 git... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/adm8211/adm8211_ioctl.20.c linux/drive

[PATCH 2.6.18] WE-21 for zd1201

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for ZyDAS driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/zd1201.20.c linux/drivers/net/wireless/zd1201.c --- linux/drivers/net/wi

[PATCH 2.6.18] WE-21 for ray_cs

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Raylink driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ray_cs.20.c linux/drivers/net/wireless/ray_cs.c --- linux/drivers/net/wi

[PATCH 2.6.18] WE-21 for orinoco

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Orinoco driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/orinoco.20.c linux/drivers/net/wireless/orinoco.c --- linux/drivers/net/wi

[PATCH 2.6.18] WE-21 for wl3501

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for wl3501 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/drivers/net/wireless/wl3501_cs.20.c 2006-08-28 17:41:19.0 -0700 +++ linux/drivers/net/wi

[PATCH 2.6.18] WE-21 support (core API)

2006-08-29 Thread Jean Tourrilhes
you mind sending that into Linus's kernel at the next opportunity, for example for 2.6.19-pre. Have fun... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/include/linux/wireless.20.h

[PATCH 2.6.18] WE-21 for Prism54

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Prism54 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/prism54/isl_ioctl.20.c linux/drivers/net/wireless/prism54/isl_ioctl.c ---

[PATCH 2.6.18] WE-21 for ipw2100

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for IPW2100 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ipw2100.20.c linux/drivers/net/wireless/ipw2100.c --- linux/drivers/net/wi

[PATCH 2.6.18] WE-21 for ipw2200

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for IPW2200 driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/ipw2200.20.c linux/drivers/net/wireless/ipw2200.c --- linux/drivers/net/wi

[PATCH 2.6.18] WE-21 for hostap

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for HostAP driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/hostap/hostap_ioctl.20.c linux/drivers/net/wireless/hostap/hostap_i

[PATCH 2.6.18] WE-21 for atmel

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Atmel driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/atmel.19.c linux/drivers/net/wireless/atmel.c --- linux/drivers/net/wireless

[PATCH 2.6.18] WE-21 for airo

2006-08-29 Thread Jean Tourrilhes
Hi, WE-21 for Aironet driver... Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- diff -u -p linux/drivers/net/wireless/airo.20.c linux/drivers/net/wireless/airo.c --- linux/drivers/net/wireless/a

Re: proposal for new wireless configuration API

2006-08-17 Thread Jean Tourrilhes
On Tue, Aug 15, 2006 at 09:13:23PM +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 20:14, Dan Williams wrote: > > On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > > > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > > > o Separate attributes for channel and frequency > >

Re: orinoco driver causes *lots* of lockdep spew

2006-08-03 Thread Jean Tourrilhes
On Thu, Aug 03, 2006 at 02:59:58PM -0400, Dave Jones wrote: > On Thu, Aug 03, 2006 at 11:58:00AM -0700, Jean Tourrilhes wrote: > > On Thu, Aug 03, 2006 at 03:11:53PM +0100, Christoph Hellwig wrote: > > > On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote: > &

Re: orinoco driver causes *lots* of lockdep spew

2006-08-03 Thread Jean Tourrilhes
On Thu, Aug 03, 2006 at 03:11:53PM +0100, Christoph Hellwig wrote: > On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote: > > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > > > this is another one of those nasty buggers; > > > > Good catch. It's really time that we fix this properly

Re: orinoco driver causes *lots* of lockdep spew

2006-08-03 Thread Jean Tourrilhes
her hand, netlink really doesn't like being > invoked in an IRQ context. So we need to postpone the sending of > netlink skb's to a tasklet. Yes, this was needed. I really like the way you implemented it, simple and efficient. Go for it ! > Signed-off-by: Herbert Xu <

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-14 Thread Jean Tourrilhes
On Thu, Jul 13, 2006 at 11:37:45PM -0400, Dan Williams wrote: > On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote: > > Dan Williams wrote: > > > > > > NAK... remember, range->max_qual.level must be _0_ if you're in dBm, > > > > I do not think this is right. From the comments in include/linux/

Re: [PATCH] wavelan: fix section mismatch

2006-05-25 Thread Jean Tourrilhes
On Thu, May 25, 2006 at 11:09:21AM -0700, Randy.Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix section mismatch warning: > WARNING: drivers/net/wireless/wavelan.o - Section mismatch: reference to > .init.text: from .text between 'init_module' (at offset 0x371e) and > 'cleanup_modul

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jean Tourrilhes
On Mon, May 15, 2006 at 02:40:14PM -0700, Jouni Malinen wrote: > On Mon, May 15, 2006 at 01:28:13PM -0700, Jean Tourrilhes wrote: > > > I believe the BSSID has to be unique. HP APs can also offer > > multiple ESSID for the same BSSID, but they do so using different > &g

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-15 Thread Jean Tourrilhes
On Sun, May 14, 2006 at 11:29:38PM -0400, Dan Williams wrote: > On Mon, 2006-05-15 at 00:29 +0100, Daniel Drake wrote: > > Hi Jean, Hi, Nice discussion you got going here ;-) > > I'd just like to check my understanding (and softmacs implementation) > > of SIWESSID and SIWAP beha

Re: [PATCH 1/5] new pcmcia IDs for hostap - ASUS WL-110

2006-05-12 Thread Jean Tourrilhes
Marcin Juszkiewicz wrote : > > This time I checked more carefully my changeset and split it into > smaller parts. Few of my patches was tested by OpenZaurus users, some > are waiting for testing. I'm sorry, but I will have again to veto part of your patch. You are removing IDs fro

Re: dBm cutoff at -1dBm is too low

2006-05-09 Thread Jean Tourrilhes
On Tue, May 09, 2006 at 12:54:55AM -0400, Pavel Roskin wrote: > On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote: > > > But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value > > > is positive or negative? > > > > You can't

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Jean Tourrilhes
On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote: > On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: > > > > There are still quite a few drivers which have not been > > converted to use IW_QUAL_DBM, so I don't want to drop the backward >

Re: dBm cutoff at -1dBm is too low

2006-05-05 Thread Jean Tourrilhes
On Thu, May 04, 2006 at 12:37:45PM -0400, Pavel Roskin wrote: > Hello, Jean! > > I'm converting Orinoco to the dBm reporting, and it turns out that the > best signal iwconfig will report is -1dBm (0.8mW). This would happen if > qual->level has its highest value of 255. Please see this code from

Re: [PATCH] Add some new card IDs to hostap_cs

2006-05-01 Thread Jean Tourrilhes
Marcin Juszkiewicz wrote : > > When I use pcmcia-cs then my Pretec WiFi card is handled by hostap > driver and everything is working fine. Recently I switched to > pcmciautils and after card insert orinoco modules are loaded. I prefer > to use hostap modules because they work the same under 2.4 an

  1   2   >