On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote:
> On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote:
> > @@ -8861,7 +8861,7 @@ static int ipw_wx_set_essid(struct net_d
> >     int length = 0;
> >     mutex_lock(&priv->mutex);
> >     if (wrqu->essid.flags && wrqu->essid.length) {
> > -           length = wrqu->essid.length - 1;
> > +           length = wrqu->essid.length;
> >             essid = extra;
> >     }
> >     if (length == 0) {
> 
> This hunk doesn't apply to the upstream branch of wireless-2.6.

        It did apply to your branch the day I sent the patches. Sorry
about that.

> I propose this one instead:
> 
> @@ -8875,8 +8875,6 @@ static int ipw_wx_set_essid(struct net_d
>          }
>  
>       length = min((int)wrqu->essid.length, IW_ESSID_MAX_SIZE);
> -     if (!extra[length - 1])
> -             length--;
>  
>       priv->config |= CFG_STATIC_ESSID;
>  
> Everything else stays the same...OK?

        It looks good. I will double check the code, and redo the
out-of-tree patch for the IPW people. GIT through our HTTP proxy is
quite slow, so bear with me :-(

> John

        Jean
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to