On Mon, 18 Feb 2008 10:00:51 -0800
"Subbu Seetharaman" <[EMAIL PROTECTED]> wrote:
> I have one question about bit fields. Several of
> headers in the common code are generated by
> srcgen from f/w source files. Some of the structures
> in these headers have bit fields (with separate defin
In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
we propose to move the existing atl1 driver to a new directory
(drivers/net/atlx), then split out functions and definitions that both
atl1 and atl2 can share. The final structure will look like this:
drivers/net/atl1
Make needlessly global functions static. In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Use netif_msg_* for console messages emitted by the driver. Add a
parameter to allow control of messaging at driver startup, and also
add the ability to control it with ethtool.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net
Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 26 ++
1 files changed, 22 insertions(+), 4 deleti
Use skb->csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atl
. Finally, shorten some variable names in the transmit
processing path to reduce line lengths, rename some variables to better
describe their purpose (e.g., nseg versus m), and add a comment or two
to better describe what the code is doing.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by:
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 5
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
tpd.
Also, some of our bit assignments are made to the wrong tpd words. Change
those to the correct words.
Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
On Tue, 22 Jan 2008 18:31:09 -0600
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> On Tue, 22 Jan 2008 04:58:17 -0500
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
[...]
> > for such a huge patch, this description is very tiny. [describe]
> > what is refactored, and why.
On Tue, 22 Jan 2008 04:56:11 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Update initialization parameters to match the current vendor driver
> > version 1.2.40.2.
[...]
> A
On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Refactor tx processing to use a less convoluted tx packet
> > descriptor and to conform generally with th
On Mon, 14 Jan 2008 20:04:28 -0600
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> On Mon, 14 Jan 2008 19:56:41 -0600
> Jay Cliburn <[EMAIL PROTECTED]> wrote:
>
> > The driver sets up the hardware to accept a frame with max length
> > equal to MTU + Ethernet header +
On Mon, 14 Jan 2008 19:56:41 -0600
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> The driver sets up the hardware to accept a frame with max length
> equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to
> add the VLAN tag size to the ingress buffer. When a VLAN-tagged
patch fixes that.
Thanks to David Harris for reporting the bug and testing the fix.
Tested-by: David Harris <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --g
On Tue, 08 Jan 2008 15:08:48 -0800 (PST)
David Miller <[EMAIL PROTECTED]> wrote:
>
> Can people do me a favor and do more constructive things like test
> that my patches really do fix the "device down during packet flood"
> bug
Hi Dave,
Your patches seem to work for the atl1 NAPI implementatio
Thanks for your comments Stephen and Joonwoo. Here's the revised
version of the atl1 NAPI patch.
>From 9c3a8944220287671f983557099bc329f02fda9b Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 11:55:24 -0600
Subject: [PATCH 25/26] atl1: add NAP
On Tue, 1 Jan 2008 17:58:40 +
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> On Mon, Dec 31, 2007 at 08:22:27PM -0600, Jay Cliburn wrote:
> > The first two patches submitted in this patchset accomplish the
> > relocation by movng the atl1 driver -- lock, stock, and
Refactor atl1 initialization and startup to conform with the current
vendor driver version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 507 ---
drivers/net/atlx/atl1.h | 10 +-
drivers/net/atlx/
Make atl1_reset() a static function.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 6432956..7697e80 100644
--- a/drive
Rename atl1_poll_controller() to atl1_netpoll() and update to conform with
the current vendor driver version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/ne
Update atl1_close() to conform with current vendor driver version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
Check for null pointers and such in ring handling functions. Make
needlessly global functions static. Clean up some comments and indentation.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 20 +++-
1 files changed, 11 insertions(+), 9 del
Update wake-on-lan to conform with the current vendor driver version
1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 140 ---
1 files changed, 84 insertions(+), 56 deletions(-)
diff --git a/drivers/net/atl
All major netdevice functionality is now present in the atl1 driver. As
a result, remove the EXPERIMENTAL Kconfig tag in the main driver, but leave
it in the NAPI driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |4 ++--
drivers/net/atlx/atl1.c
Refactor atl1_probe to conform with current vendor driver version 1.2.40.2.
Also reorder functions to minimize the need for forward declarations.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 1397 +++
drivers/ne
Update atl1_change_mtu() to conform with the current vendor driver version
1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 39 ++-
1 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/drivers/net/atlx/
Add some debug dev_printks if we encounter a bad receive return descriptor.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/
Update shutdown and remove functions to conform with the current vendor
driver version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 31 +++
1 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/ne
Add support for NAPI, styled after the e1000 NAPI implementation. That we
follow the e1000 for NAPI shouldn't come as much of a surprise, since the
entire atl1 driver is based heavily upon it.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/Kconfig | 14
Update atl1_check_link() to conform with the current vendor driver version
1.2.40.2. Clean up vertical spacing, indentation, and remove dead code.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 65 +++---
drivers/ne
Update atl1_phy_config() to conform with current vendor driver version
1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index a
Refactor interrupt handling to conform with the current vendor driver
version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 196 ++-
drivers/net/atlx/atl1.h | 25 +-
drivers/net/atlx/atlx.c |2
Add DMA engine configuration tweaks per current vendor atl1 driver version
1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 10 ++
drivers/net/atlx/atlx.h |6 ++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drive
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/d
Update atl1_down() and atl1_up() to conform with the current vendor driver
version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 21 -
drivers/net/atlx/atl1.h |1 -
drivers/net/atlx/atlx.c |2 +-
3 files changed, 9 inse
Use skb->csum_start for tx checksum offload preparation.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index b0c3273..31aad
Update initialization parameters to match the current vendor driver
version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/
When we initially set max rx frame size, we don't explicitly allow room for
the VLAN header; it's done later in a somewhat obscure fashion. Let's make
it clear from the top that we've allowed enough room for the VLAN header.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]
mode 100644 drivers/net/atlx/Makefile
create mode 100644 drivers/net/atlx/atl1.c
create mode 100644 drivers/net/atlx/atl1.h
create mode 100644 drivers/net/atlx/atlx.c
create mode 100644 drivers/net/atlx/atlx.h
Best regards,
Jay Cliburn
--
To unsubscribe from this list: send the line "u
tpd.
Also, some of our bit assignments are made to the wrong tpd words. Change
those to the correct words.
Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 29 +++--
1 files chang
Refactor tx processing to use a less convoluted tx packet descriptor and
to conform generally with the vendor's current version 1.2.40.2.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 265 +--
drivers/net/
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Move some stray defines out to a header file. Improve indentation from
ghastly to horrid.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 29 -
drivers/net/atlx/atl1.h |6 ++
2 files changed, 18 insertions(+), 17 del
Chris Snook wrote:
wrote:
in function
at_alloc_rx_buffers(), pci_unmap_page() and netif_rx() in function
at_clean_rx_irq(),
Okay, I didn't know you were talking about the atl1 driver. Are you
using the
in-tree driver in 2.6.22, or the pre-merge driver on sourceforge, or the
vendor
d
On Sat, 8 Sep 2007 17:36:21 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Sat, 8 Sep 2007 13:08:37 -0700 (PDT)
> [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=8996
> >
> >Summary: atl1 driver cause kernel oops IF ram > 4Gyte
> > and a lot of network
From: Ingo Molnar <[EMAIL PROTECTED]>
use the simpler spin_trylock_irqsave() API to get the adapter lock.
[ this is also a fix for -rt where adapter->lock is a sleeping lock. ]
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
On Wed, 25 Jul 2007 17:31:02 -0400
Chuck Ebbert <[EMAIL PROTECTED]> wrote:
> This is what was committed.
>
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3f516c00d416bd39aab6cfb348b68919e295fe23
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.
Use constants already provided by the kernel for ethernet related lengths.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |5 -
drivers/net/atl1/atl1_main.c | 13 +++--
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drive
The DMA engine setup contains a typo that can result in an incorrect
dmaw_block setting.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/ne
s/dam/dma
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
index 100c09c..f0d7e82 100644
--- a/drivers/net/atl1/atl1_hw.h
+++ b/d
: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index 3b8f633..6aa2dc3 100644
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/ne
Please accept the following patches for the atl1 driver. Thanks.
atl1: use kernel provided ethernet length constants
atl1: fix typo in dma_req_block
atl1: change cmb write threshold
atl1: fix typo in DMA engine setup
atl1: change tpd_avail function name
drivers/net/atl1/atl1_hw.h |9 ++---
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index fd1e156..79d60e1 100644
Fix indentation, remove dead code, improve some comments, change dev_dbg to
dev_printk.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 278 +-
1 files changed, 137 insertions(+), 141 deletions(-)
diff --git a/d
Remove unused structure members, improve comments, break long comment lines,
rename a constant to be consistent with others in the file.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h | 155 ++
drivers/net/atl1/atl1_
Remove unnecessary irq_sem code.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |1 -
drivers/net/atl1/atl1_main.c |6 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/driv
Move excessively indented code to separate functions. Also move ring
pointer initialization to its own function.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 86 -
1 files changed, 50 insertions(+), 36 del
Please accept the following patches for the atl1 driver.
atl1: remove irq_sem
atl1: header file cleanup
atl1: cleanup atl1_main
atl1: fix excessively indented code
atl1: reorder atl1_main functions
drivers/net/atl1/atl1.h | 156 ++--
drivers/net/atl1/atl1_main.c | 2176
update = 1;
> +
> tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
> buffer_info =
> &tpd_ring->buffer_info[sw_tpd_next_to_clean]; if (buffer_info->dma) {
>
Acked-by: Jay Cliburn <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "u
On Mon, 25 Jun 2007 23:18:55 +0200
Luca Tettamanti <[EMAIL PROTECTED]> wrote:
> Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto:
> > Jay L. T. Cornwall wrote:
> > >Jay Cliburn wrote:
> > >
> > >>For reasons not yet clear to me, it
On Mon, 25 Jun 2007 17:57:20 -0400
Chris Snook <[EMAIL PROTECTED]> wrote:
> Jay L. T. Cornwall wrote:
> > Chris Snook wrote:
> >
> >> What boards have we seen this on? It's quite possible this is:
> >
> > I can reproduce on an Asus P5K with a Core 2 Duo E6600.
> >
> > lspci identifies the cont
On Wed, 30 May 2007 02:00:25 +0200
Jose Alberto Reguero <[EMAIL PROTECTED]> wrote:
> I have problems with a M2V motherboard and atl1 driver with msi and
> kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems.
> I must add in drivers/pci/quirks.c (line 1723):
>
> DECLARE_PCI_FIXUP_FINAL(PCI_VE
Thank you very much for looking at this, Len.
On Fri, 11 May 2007 23:28:58 -0400
Len Brown <[EMAIL PROTECTED]> wrote:
> > > [ 94.754852] APIC error on CPU0: 08(40)
> > > [ 94.806045] APIC error on CPU0: 40(08)
>
> /* Here is what the APIC error bits mean:
>0: Send CS err
Use dev_printk macros for PCI related errors, warnings, debug and info
console messages.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 22 +--
drivers/net/atl1/atl1_main.c
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
Please accept the following trivial patches to the atl1 driver.
- use dev_printk macros
- fix whitespace damage
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 44 ++---
drivers/net/atl1/atl1_main.c| 83 +---
Chuck Ebbert wrote:
Where is the text of the oops?
In one of the files on the website I referenced. Here's the text...
[ 173.584000] APIC error on CPU1: 08(08)
[ 173.665000] APIC error on CPU0: 08(08)
[ 173.665000] APIC error on CPU1: 08(08)
[ 173.746000] APIC error on CPU0: 08(08)
[ 17
[Adding linux-kernel to the cc list, hoping for wider exposure.]
On Fri, 23 Mar 2007 20:08:17 -0500
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> We're trying to track down the source of a problem that occurs
> whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc
On Sun, 1 Apr 2007 12:00:00 +0200
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Jay Cliburn <[EMAIL PROTECTED]> :
> > Francois,
> >
> > I get this on 2.6.21-rc5 and earlier kernels going back to at least
> > 2.6.20-git14, both i386 and x86_64, dual-core AM2
Francois,
I get this on 2.6.21-rc5 and earlier kernels going back to at least
2.6.20-git14, both i386 and x86_64, dual-core AM2 and LGA775
motherboards, using two different RTL8169 PCI add-in cards. Has anyone
else reported it?
Unable to handle kernel NULL pointer dereference at
[] :r8169:rtl
On Wed, 28 Mar 2007 01:00:24 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> Subject: atl1 net driver: problem with sockets
> References : http://lkml.org/lkml/2007/3/21/248
> Submitter : Jose Alberto Reguero <[EMAIL PROTECTED]>
> Patch : http://marc.info/?l=linux-netdev&m=117502041808665
From: Jay Cliburn <[EMAIL PROTECTED]>
The original vendor driver contained a private ether_crc_le() function
that produced an inverted crc. When we changed to the kernel version of
ether_crc_le(), we neglected to undo the inversion. Let's do it now.
Discovered by and patch proffe
On Tue, 27 Mar 2007 14:42:20 -0600
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
Thanks for replying, Eric. I've added atl1-devel to the cc list.
> Do you have msi's working in 2.6.21-rc4 in the x86_64 kernel?
I can't personally verify it anymore because I removed x86_64 to
duplicate the MSI pro
We're trying to make the Attansic L1 NIC correctly suspend, resume,
and wake-on-lan. Can someone point me to a PCIe-based NIC driver in
the kernel tree that correctly does these things? I'd like to see how
it's *supposed* to be done.
Thanks,
Jay
-
To unsubscribe from this list: send the line "un
From: Jay Cliburn <[EMAIL PROTECTED]>
Bump the version number.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
i
From: Chris Snook <[EMAIL PROTECTED]>
Add device id for the Attansic L1 chip to pci_ids.h, then use it.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
include/linux/pci_ids.h
From: Chris Snook <[EMAIL PROTECTED]>
Remove unused define from atl1_main.c.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
From: Jay Cliburn <[EMAIL PROTECTED]>
On some Asus motherboards containing the L1 NIC, the MAC address is
written by the BIOS directly to the MAC register during POST, and is
not stored in eeprom. If we don't succeed in fetching the MAC address
from eeprom or spi, try reading it di
From: Al Viro <[EMAIL PROTECTED]>
An ioread32 statement reads the wrong address. Fix it.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.c |
From: Jay Cliburn <[EMAIL PROTECTED]>
The atl1 driver doesn't need NET_PCI. Remove it from Kconfig.
Noticed by Chad Sprouse.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |2 +-
1 files chan
Jeff,
Please accept the following patchset for the atl1 network device driver.
* Drop unnecessary NET_PCI config
* Fix incorrect hash table address
* Read MAC address from register
* Remove unused define
* Add Attansic L1 device id to pci_ids
* Bump version number
This patchset contains changes
From: Jay Cliburn <[EMAIL PROTECTED]>
atl1: move extern to header file; make some global code static
Move an extern declaration to a header file. Make needlessly global
functions static. Noticed by Adrian Bunk.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net
On Tue, 6 Feb 2007 23:12:29 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc6-mm2:
> >...
> > git-netdev-all.patch
> >...
> > git trees
> >...
>
>
> This patch contains the following possible cleanu
From: Jay Cliburn <[EMAIL PROTECTED]>
pci_ids: add Attansic vendor id
Add Attansic to pci_ids and use the ID in the driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |2 +-
include/linux/pci_ids.h |2 ++
2 files changed, 3 inse
From: Jay Cliburn <[EMAIL PROTECTED]>
MAINTAINERS: add atl1 maintainers
Add a maintainers entry for atl1.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
MAINTAINERS | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
i
From: Jay Cliburn <[EMAIL PROTECTED]>
atl1: fix whitespace damage
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |8 +-
drivers/net/atl1/atl1_ethtool.c | 42 ++--
drivers/net/at
This set of patches completes the final bit of tidying up in the Attansic
ethernet driver. Sorry for nickel-and-diming you, Jeff, but this really
should be the end of it for awhile.
Summary:
1. Clean up whitespace damage.
2. Add a maintainers entry.
3. Add a pci_ids entry.
---
MAINTAINERS
From: Jay Cliburn <[EMAIL PROTECTED]>
Fix up some constants relating to max and min ring descriptor counts.
Also add functionality to enable ethtool to set tx and rx ring parameters.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |4 +-
driv
From: Jay Cliburn <[EMAIL PROTECTED]>
pci_module_init is deprecated. Use pci_register_driver instead.
Discovered by and modification suggested by Alan Cox.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |5 +
1 files changed, 1 inse
The subject line on all four of the current crop of atl1 patches is
incorrect; they were generated against *2.6.20-rc6*, not rc5. I apologize
for the error.
Jay
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
From: Jay Cliburn <[EMAIL PROTECTED]>
Incorporate reviewer comments from:
Randy Dunlap, http://lkml.org/lkml/2007/1/21/157
Arjan van de Ven, http://lkml.org/lkml/2007/1/22/21
Francois Romieu, http://lkml.org/lkml/2007/1/22/49
Fixup to follow coding standards, remove MII defines already fo
From: Jay Cliburn <[EMAIL PROTECTED]>
Fix power management by properly using ifdef CONFIG_PM. Discovered by
and modification suggested by Andrew Morton.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |7 +--
1 files changed, 5 inse
From: Jay Cliburn <[EMAIL PROTECTED]>
Include dma-mapphing.h to provide DMA_32BIT_MASK and DMA_64BIT_MASK.
Discovered by and modification suggested by Andrew Morton.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |1 +
1 files changed, 1 inse
From: Luca Tettamanti <[EMAIL PROTECTED]>
Unconditionally enable MSI in atl1 driver. Also remove some useless
#ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
configured in.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[
Jeff Garzik wrote:
As a driver maintainer, you need to patch sets, and submit them in a
timely fashion to me. Note I said patch set, not patch, in following
with Rule #3 from Documentation/SubmittingPatches. Also make sure to
review http://linux.yyz.us/patch-format.html
Understood. Both re
Luca Tettamanti wrote:
[snip]
Anyway...
Unconditionally enable MSI in atl1 driver. Also remove some useless
#ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
configured in.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
Acked-by: Jay Cliburn <[EMAIL PROTE
Jeff Garzik wrote:
OK, I have merged the monolithic patch into jgarzik/netdev-2.6.git#atl1.
Once I'm done merging patches tonight, I will merge this new 'atl1'
branch into the 'ALL' meta-branch, which will auto-propagate this driver
into Andrew Morton's -mm for testing.
For future driver up
1 - 100 of 125 matches
Mail list logo
