On Mon, 18 Feb 2008 10:00:51 -0800 "Subbu Seetharaman" <[EMAIL PROTECTED]> wrote:
> I have one question about bit fields. Several of > headers in the common code are generated by > srcgen from f/w source files. Some of the structures > in these headers have bit fields (with separate definitions > for little endian and big endian hosts). Are these un-acceptable > in Linux driver submissions ? The netdev maintainer, Jeff Garzik (to whom you should submit your driver), frowns upon the use of bitfields, and for good reason. See, for example, http://marc.info/?l=linux-kernel&m=118444531031506&w=2 http://lkml.org/lkml/2005/8/5/361 http://lkml.org/lkml/2006/6/20/470 http://en.wikipedia.org/wiki/Bit_field. You should avoid them if at all possible. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html