Add support for the new rxfh_fields callbacks, instead of de-muxing
the rxnfc calls. This driver does not support flow filtering so
the set_rxnfc callback is completely removed.
Signed-off-by: Jakub Kicinski
---
CC: m...@redhat.com
CC: jasow...@redhat.com
CC: xuanz...@linux.alibaba.com
CC: epere
On Wed, 14 May 2025 13:44:33 +0800 Tang Longjun wrote:
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index e53ba600605a..c9a86f325619 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -4897,7 +4897,7 @@ static int __virtnet_get_hw_stats(struct virt
: d888f04c09bb ("virtio-net: support queue stat")
Signed-off-by: Jakub Kicinski
---
drivers/net/virtio_net.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f9e3e628ec4d..e53ba600605a 100644
--- a/drivers/net/virtio_n
was tempting to always use num_*x_queues as the end, but virtio
seems to clamp its queue count after allocating the netdev. And this
way we can trivaly reuse the helper for [0, real_..).
Signed-off-by: Jakub Kicinski
---
include/net/netdev_queues.h | 6
net/core/netdev-genl.c |
Another small fix discovered after we enabled virtio multi-queue
in netdev CI. The queue stat test fails:
# Exception| Exception: Qstats are lower, fetched later
not ok 3 stats.pkt_byte_sum
The queue stats from disabled queues are supposed to be reported
in the "base" stats.
Jaku
refill when pausing rx")
Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
Signed-off-by: Jakub Kicinski
---
v2:
- wrap schedule under the spin lock
v1: https://lore.kernel.org/20250429143104.2576553-1-k...@kernel.org
CC: m...@redhat.com
CC: jasow...@redhat.com
CC
uff_pool.c:226)
xsk_bind+0x6a5/0x1ae0
__sys_bind+0x15e/0x230
__x64_sys_bind+0x72/0xb0
do_syscall_64+0xc1/0x1d0
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Acked-by: Jason Wang
Fixes: e9f3962441c0 ("virtio_net: xsk: rx: support fill with xsk buffer")
Signed-off-by: Ja
On Wed, 30 Apr 2025 01:29:06 -0400 Michael S. Tsirkin wrote:
> > > @@ -3728,7 +3731,7 @@ static int virtnet_set_queues(struct virtnet_info
> > > *vi, u16 queue_pairs)
> > > succ:
> > > vi->curr_queue_pairs = queue_pairs;
> > > /* virtnet_open() will refill when device is going to
uff_pool.c:226)
xsk_bind+0x6a5/0x1ae0
__sys_bind+0x15e/0x230
__x64_sys_bind+0x72/0xb0
do_syscall_64+0xc1/0x1d0
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Fixes: e9f3962441c0 ("virtio_net: xsk: rx: support fill with xsk buffer")
Signed-off-by: Jakub Kicinski
---
CC: m...@
rtnet_rx_resume() found by code inspection.
Fixes: 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx")
Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
Signed-off-by: Jakub Kicinski
---
CC: m...@redhat.com
CC: jasow...@redhat.com
CC: x
On Tue, 4 Feb 2025 13:17:08 -0800 Paul E. McKenney wrote:
> > > TBH I'm slightly confused by this, and the previous warnings.
> > >
> > > The previous one was from a timer callback.
> > >
> > > This one is with BH disabled.
> > >
> > > I thought BH implies RCU protection. We certainly depend on tha
On Tue, 4 Feb 2025 21:10:59 +0100 Eric Dumazet wrote:
> > Test output:
> > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/
> > Decoded:
> > https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/vm-crash-thr2-0
> >
>
> Oh well. So many bugs.
TBH I'm slightly co
On Fri, 27 Dec 2024 20:11:57 +0100 chia-yu.ch...@nokia-bell-labs.com
wrote:
> Hello
Hello.
Someone may still review, but:
## Form letter - winter-break
Networking development is suspended for winter holidays, until Jan 2nd.
We are currently accepting bug fixes only, see the announcements at:
h
On Thu, 7 Nov 2024 16:54:56 +0800 Xuan Zhuo wrote:
> + * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO).
> + * Returns zero or a negative error (ie. ENOSPC, ENOMEM, EIO).
Looks like we need a rebase, doesn't apply any more.
When you rebase please correct the kdoc, looks like the off
On Wed, 6 Nov 2024 04:16:07 -0500 Michael S. Tsirkin wrote:
> I thought it can but can't remember why now. OK, nm then, thanks!
FWIW (I think there was confusion in earlier discussions) we do merge
net into net-next once a week. So we can always apply stuff to net,
and then depending patches to ne
On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote:
> In the last linux version, we disabled this feature to fix the
> regress[1].
>
> The patch set is try to fix the problem and re-enable it.
>
> More info:
> http://lore.kernel.org/all/20240820071913.68004-1-xuanz...@linux.alibaba.com
Sorry to
On Tue, 10 Sep 2024 08:12:06 -0400 Michael S. Tsirkin wrote:
> Just making sure netdev maintainers see this, this patch is for net.
Got it, thanks! I'll be applying it shortly.
On Tue, 13 Aug 2024 11:43:43 +0800 Jason Wang wrote:
> Hello netdev maintainers.
>
> Could we get this series merged?
Repost it with the Fixes tag correctly included.
On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote:
> Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing
> commands
subject currently reads like this is an optimization, could you
rephrase?
> From the virtio spec:
>
> The driver MUST have negotiated the VIRTIO_NET_F_VQ
On Mon, 22 Jul 2024 15:27:42 +0800 Jason Wang wrote:
> I wonder why this series is tagged as "RFC"?
I guess it's because net-next is closed during merge window.
I understand that the situation is somewhat special
because we got Rx merged but not Tx.
Do you think this is ready for v6.11 with high
On Wed, 19 Jun 2024 10:55:29 +0800 Li RongQing wrote:
> This place is fetching the stats, so u64_stats_fetch_begin
> and u64_stats_fetch_retry should be used
>
> Fixes: 6208799553a8 ("virtio-net: support rx netdim")
> Signed-off-by: Li RongQing
> ---
> drivers/net/virtio_net.c | 14 -
On Wed, 19 Jun 2024 10:02:58 +0800 Heng Qi wrote:
> > > Currently we do not allow RXCUSM to be disabled.
> >
> > You don't have to disable checksuming in the device.
>
> Yes, it is up to the device itself to decide whether to validate checksum.
> What I mean is that we don't allow users to di
On Tue, 18 Jun 2024 11:09:02 +0800 Heng Qi wrote:
> > (Should we manually do checksum if RXCUSM is disabled?)
> >
>
> Currently we do not allow RXCUSM to be disabled.
You don't have to disable checksuming in the device.
Just ignore VIRTIO_NET_HDR_F_DATA_VALID if user cleared NETIF_F_RXCSUM.
I
On Tue, 11 Jun 2024 19:41:43 +0800 Xuan Zhuo wrote:
> @@ -534,10 +534,13 @@ enum virtnet_xmit_type {
> VIRTNET_XMIT_TYPE_SKB,
> VIRTNET_XMIT_TYPE_XDP,
> VIRTNET_XMIT_TYPE_DMA,
> + VIRTNET_XMIT_TYPE_XSK,
Again, would be great to avoid the transient warning (if it can be done
c
On Tue, 11 Jun 2024 19:41:40 +0800 Xuan Zhuo wrote:
> +static int virtnet_sq_set_premapped(struct send_queue *sq, bool premapped)
Could you try to add __maybe_unused or some such and then remove it
in the patch which calls this function? Having warnings during
bisection is not great.
On Tue, 11 Jun 2024 19:41:33 +0800 Xuan Zhuo wrote:
> +/**
> + * virtqueue_dma_map_page_attrs - map DMA for _vq
> + * @_vq: the struct virtqueue we're talking about.
> + * @page: the page to do dma
> + * @offset: the offset inside the page
> + * @size: the size of the page to do dma
> + * @dir: DMA
On Sat, 8 Jun 2024 08:41:44 +0800 Jason Xing wrote:
> > > Sorry to revive this thread. I wonder why not use this patch like mlnx
> > > driver
> > > does instead of adding statistics into the yaml file? Are we gradually
> > > using or
> > > adding more fields into the yaml file to replace the 'eth
On Fri, 31 May 2024 09:40:14 +0800 Xuan Zhuo wrote:
> On Thu, 30 May 2024 19:54:44 +0800, Xuan Zhuo
> wrote:
> > On Thu, 30 May 2024 07:53:17 -0400, "Michael S. Tsirkin"
> > wrote:
> > > It's great that you are working on this but
> > > I'd like to see the actual use of this first.
> >
> >
On Tue, 28 May 2024 15:52:25 +0800 Heng Qi wrote:
> The integer variable 'ret', denoting the return code, is mismatched with
> the boolean return type of virtnet_send_command_reply(); hence, it is
> renamed to 'err'.
>
> The usage of 'ret' is deferred to the next patch.
That seems a bit much. Can
On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote:
> diff --git a/tools/include/uapi/linux/netdev.h
> b/tools/include/uapi/linux/netdev.h
> index cf24f1d9adf8..ccf6976b1693 100644
> --- a/tools/include/uapi/linux/netdev.h
> +++ b/tools/include/uapi/linux/netdev.h
> @@ -164,7 +164,8 @@ enum {
On Wed, 8 May 2024 09:53:08 +0100 Simon Horman wrote:
> On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote:
> > This patch set prepares for supporting af-xdp zerocopy.
> > There is no feature change in this patch set.
> > I just want to reduce the patch num of the final patch set,
> > so I s
On Fri, 26 Apr 2024 11:39:20 +0800 Xuan Zhuo wrote:
> As the spec:
>
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> The virtio net supports to get device stats.
These got marked as "not applicable" in netdev pw over the weekend, but
I think net-nex
e.
>
> As the document
> https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
>
> We should not duplicate the stats which get reported via the netlink API in
> ethtool. If the stats are for queue stat, that will not be reported by
> ethtool -S.
Reviewed-by: Jakub Kicinski
Thank you!
t; name: tx-hw-gso-wire-packets
> name: tx-hw-gso-wire-bytes
> name: tx-hw-drop-ratelimits
>
> Signed-off-by: Xuan Zhuo
Reviewed-by: Jakub Kicinski
On Thu, 25 Apr 2024 20:58:54 +0800 Heng Qi wrote:
> When the dim worker is scheduled, if it no longer needs to issue
> commands, dim may not be able to return to the working state later.
>
> For example, the following single queue scenario:
> 1. The dim worker of rxq0 is scheduled, and the dim s
On Tue, 23 Apr 2024 19:31:41 +0800 Xuan Zhuo wrote:
> +static void virtnet_get_base_stats(struct net_device *dev,
> +struct netdev_queue_stats_rx *rx,
> +struct netdev_queue_stats_tx *tx)
> +{
> + /* The queue stats of the virtio-n
On Thu, 18 Apr 2024 17:48:57 +0200 Paolo Abeni wrote:
> > > Side note: the compiler apparently does not like guard() construct,
> > > leading to
> > > new warning, here and in later patches. I'm unsure if the code
> > > simplification
> > > is worthy.
> >
> > I didn't see any warnings with GCC
On Wed, 17 Apr 2024 10:22:52 +0800 Heng Qi wrote:
> Have you encountered compilation problems in v8?
Yes, please try building allmodconfig:
make allmodconfig
make ..
there's many drivers using this API, you gotta build the full kernel..
On Tue, 16 Apr 2024 20:29:46 +0800 Heng Qi wrote:
> Please review, thank you very much!
Please stop posting code which does not compile.
The mailing list is for reviewing code, not build testing it.
--
pw-bot: cr
On Tue, 16 Apr 2024 03:15:34 + Dan Jurgens wrote:
> Which version? It compiles for me with:
> $ clang -v
> clang version 15.0.7 (Fedora 15.0.7-2.fc37)
clang version 17.0.6 (Fedora 17.0.6-2.fc39)
allmodconfig
The combination of UNIQUE() goto and guard seems to make it unhappy:
../drivers/net
On Sat, 13 Apr 2024 15:23:53 +0200 Jiri Pirko wrote:
> That is a goal. Currently I do it with:
> vng --qemu-opts="-nic
> tap,id=nd0,ifname=xtap0,model=virtio-net-pci,script=no,downscript=no,mac=52:54:00:12:34:57
> -nic
> tap,id=nd1,ifname=xtap1,model=virtio-net-pci,script=no,downscript=no,mac=52
On Thu, 11 Apr 2024 22:12:29 +0800 Heng Qi wrote:
> +name: usec
> +type: u16
> + -
> +name: pkts
> +type: u16
> + -
> +name: comps
> +type: u16
I think I mentioned already - u32 please.
On Thu, 11 Apr 2024 22:12:29 +0800 Heng Qi wrote:
> +#include
> #include
> #include
> #include
> @@ -1649,6 +1650,9 @@ struct net_device_ops {
> * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
> * ndo_hwtstamp_set() for all timestamp requests regardless of source,
> *
On Fri, 12 Apr 2024 14:53:08 -0500 Daniel Jurgens wrote:
> Once the RTNL locking around the control buffer is removed there can be
> contention on the per queue RX interrupt coalescing data. Use a spin
> lock per queue.
Does not compile on Clang.
> + scoped_guard(spinlock, &vi
On Fri, 12 Apr 2024 17:13:08 +0200 Jiri Pirko wrote:
> This patchset aims at introducing very basic initial infrastructure
> for virtio_net testing, namely it focuses on virtio feature testing.
>
> The first patch adds support for debugfs for virtio devices, allowing
> user to filter features to p
On Wed, 10 Apr 2024 11:09:16 +0800 Heng Qi wrote:
> The point is that the driver may check whether the user has set
> parameters that it does not want.
> For example, virtio may not want the modification of comps, and ice/idpf
> may not want the modification
> of comps and pkts.
If it's simply a
On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote:
> +/**
> + * coalesce_put_profile - fill reply with a nla nest with four child nla
> nests.
> + * @skb: socket buffer the message is stored in
> + * @attr_type: nest attr type ETHTOOL_A_COALESCE_*X_*QE_PROFILE
> + * @profile: data passed to userspa
On Tue, 9 Apr 2024 20:03:24 +0800 Heng Qi wrote:
> + /* DIM profile list */
> + struct dim_cq_moder rx_eqe_conf[NET_DIM_PARAMS_NUM_PROFILES];
Can you please wrap this into a structure with other necessary
information and add a pointer in struct net_device instead.
What's the point of eve
On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote:
> + nla_for_each_nested(nest, nests, rem) {
> + if (WARN_ONCE(nla_type(nest) !=
> ETHTOOL_A_MODERATIONS_MODERATION,
> + "unexpected nest attrtype %u\n", nla_type(nest)))
Maybe just use the newly added nla_
On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote:
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -408,6 +408,18 @@ attribute-sets:
>-
> name: combined-count
> type: u32
> + -
> + name: profile
> + attributes
On Thu, 4 Apr 2024 07:42:45 +0200 Jaroslav Pulchart wrote:
> We do not have much progress
Random thought - do you have KFENCE enabled?
It's sufficiently low overhead to run in production and maybe it could
help catch the bug? You also hit some inexplicable bug in the Intel
driver, IIRC, there may
On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote:
> I have a question regarding the workflow for feature discussions. If we
> consistently engage in discussions about a particular feature, this may result
> in the submission of multiple patch sets. In light of this, should we modify
> the
> usag
On Fri, 15 Mar 2024 16:05:40 +0800 Xuan Zhuo wrote:
> > Don't duplicate the stats which get reported via the netlink API in
> > ethtool. Similar story to the rtnl stats:
> >
> > https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
> >
>
> Sorry, this patch set did no
On Thu, 14 Mar 2024 16:54:58 +0800 Xuan Zhuo wrote:
> + -
> +name: rx-hw-drops
> +doc: |
> + Number of packets that arrived at the device but never left it,
> + encompassing packets dropped for reasons such as insufficient
> buffer
s/encompassing/including/
On Thu, 14 Mar 2024 16:54:59 +0800 Xuan Zhuo wrote:
> +static void virtnet_get_base_stats(struct net_device *dev,
> +struct netdev_queue_stats_rx *rx,
> +struct netdev_queue_stats_tx *tx)
> +{
> + /* The queue stats of the virtio-n
On Thu, 14 Mar 2024 16:54:54 +0800 Xuan Zhuo wrote:
> make virtio-net support getting the stats from the device by ethtool -S
> .
>
> Due to the numerous descriptors stats, an organization method is
> required. For this purpose, I have introduced the "virtnet_stats_map".
> Utilizing this array sim
On Mon, 11 Mar 2024 18:48:45 +0800 Xuan Zhuo wrote:
> On Thu, 7 Mar 2024 08:50:21 -0800, Jakub Kicinski wrote:
> > CC: Willem and some driver folks for more input, context: extending
> > https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/
> > to cover vir
CC: Willem and some driver folks for more input, context: extending
https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/
to cover virtio stats.
On Tue, 27 Feb 2024 16:03:00 +0800 Xuan Zhuo wrote:
> +static const struct virtnet_stat_desc virtnet_stats_rx_basic_desc[] = {
> + VI
On Thu, 7 Mar 2024 17:36:35 +0800 Xuan Zhuo wrote:
> > Please wait for this API to get merged:
> > https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/
> > A lot of the stats you're adding here can go into the new API.
> > More drivers can report things like number of LSO / GRO pac
On Tue, 27 Feb 2024 16:07:13 +0100 Jiri Pirko wrote:
> >Please wait for this API to get merged:
> >https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/
> >A lot of the stats you're adding here can go into the new API.
>
> Can. But does that mean that ethtool additions of things
On Tue, 27 Feb 2024 16:03:02 +0800 Xuan Zhuo wrote:
> Now, we just show the stats of every queue.
>
> But for the user, the total values of every stat may are valuable.
Please wait for this API to get merged:
https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/
A lot of the stats
On Tue, 20 Feb 2024 13:05:46 -0500 Michael S. Tsirkin wrote:
> > Michael, are you a NACK on this? Jakub seemed OK with it, Jason
> > also thinks it's useful, and it's low risk.
>
> Not too bad ... Jakub can you confirm though?
Ughhm. Let me implement the generic API myself. I should have a few
On Fri, 2 Feb 2024 16:46:28 + Daniel Jurgens wrote:
> > Daniel, I think this may be a good enough excuse to add per-queue stats to
> > the netdev genl family, if you're up for that. LMK if you want more info,
> > otherwise I guess ethtool -S is fine for now.
>
> For now, I would like to go w
On Fri, 2 Feb 2024 14:52:59 +0800 Jason Xing wrote:
> > Can you say more? I'm curious what's your use case.
>
> I'm not working at Nvidia, so my point of view may differ from theirs.
> From what I can tell is that those two counters help me narrow down
> the range if I have to diagnose/debug som
On Wed, 31 Jan 2024 10:45:53 +0800 Xuan Zhuo wrote:
> As the spec:
>
> https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>
> The virtio net supports to get device stats.
Does not apply to net-next, could you rebase?
On Wed, 31 Jan 2024 10:54:33 +0800 Jason Xing wrote:
> > [danielj@sw-mtx-051 upstream]$ ethtool -S ens2f1np1 | grep 'stop\|wake'
> > tx_queue_stopped: 0
> > tx_queue_wake: 0
> > tx0_stopped: 0
> > tx0_wake: 0
> >
>
> Yes, that's it! What I know is that only mlx driv
On Tue, 16 Jan 2024 13:37:30 +0100 Paolo Abeni wrote:
> For future submission it would be better if you split this series in
> smaller chunks: the maximum size allowed is 15 patches.
Which does not mean you can split it up and post them all at the same
time, FWIW.
On Wed, 27 Dec 2023 22:26:37 +0800 Zhu Yanjun wrote:
> From: Zhu Yanjun
>
> Fix the warnings when building virtio_net driver.
This got marked as Not Applicable in patchwork, not sure why.
Could you repost?
On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote:
> For rq, we have three cases getting buffers from virtio core:
>
> 1. virtqueue_get_buf{,_ctx}
> 2. virtqueue_detach_unused_buf
> 3. callback for virtqueue_resize
>
> But in commit 295525e29a5b("virtio_net: merge dma operations when
> filling m
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to all the sock diag modules in one fell swoop.
Signed-off-by: Jakub Kicinski
---
CC: dsah...@kernel.org
CC: matt...@kernel.org
CC: martin...@kernel.org
CC: marcelo.leit...@gmail.com
CC: lucien@gmail.com
On Tue, 14 Nov 2023 13:55:47 +0800 Heng Qi wrote:
> We do not currently support tx dim, so respond to -EOPNOTSUPP.
Hm, why do you need this? You don't set ADAPTIVE_TX in
.supported_coalesce_params, so core should prevent attempts
to enable ADAPTIVE_TX.
On Tue, 20 Apr 2021 14:33:36 +0300 dlin...@nvidia.com wrote:
> From: Dmytro Linkin
>
> Currently kernel provides a way to change tx rate of single VF in
> switchdev mode via tc-police action. When lots of VFs are configured
> management of theirs rates becomes non-trivial task and some grouping
>
On Tue, 20 Apr 2021 10:34:17 +0200 Eric Dumazet wrote:
> On Tue, Apr 20, 2021 at 9:54 AM AceLan Kao wrote:
> >
> > From: "Chia-Lin Kao (AceLan)"
> >
> > The rtnl_lock() has been called in rtnetlink_rcv_msg(), and then in
> > __dev_open() it calls pm_runtime_resume() to resume devices, and in
> >
On Tue, 20 Apr 2021 07:00:39 + Hayes Wang wrote:
> > > @@ -6878,7 +8942,11 @@ static int rtl8152_probe(struct usb_interface
> > > *intf,
> > > set_ethernet_addr(tp);
> > >
> > > usb_set_intfdata(intf, tp);
> > > - netif_napi_add(netdev, &tp->napi, r8152_poll, RTL8152_NAPI_WEIGHT);
> > >
On Tue, 20 Apr 2021 16:13:21 +0100 Edward Cree wrote:
> On 15/04/2021 23:53, Jakub Kicinski wrote:
> > Report what appears to be the standard block counts:
> > - 30.5.1.1.17 aFECCorrectedBlocks
> > - 30.5.1.1.18 aFECUncorrectableBlocks
> >
> > Don't repor
h": 255,
"val": 1
},
{
"low": 1024,
"high": 0,
"val": 0
}
]
}
}
]
This allows for easy querying, e.g. to add up all packets larger
than 128 (assuming buckets align):
# eth
.
Suggested-by: Ido Schimmel
Signed-off-by: Jakub Kicinski
---
ethtool.8.in | 5 -
ethtool.c| 2 +-
netlink/parser.c | 17 ++-
netlink/parser.h | 4
netlink/stats.c | 55
5 files changed, 80 insertions(+), 3 dele
-by: Jakub Kicinski
---
ethtool.c | 5 -
netlink/extapi.h | 5 +++--
netlink/netlink.c | 9 +++--
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 0933bc02ce5e..b07fd9292d77 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -5608,6 +5608,7
aning "not supported".
Because of those deviations existing link mode parsers
can't be directly reused.
Allocate error code 83 for FEC errors.
JSON support included.
Signed-off-by: Jakub Kicinski
---
Makefile.am| 2 +-
ethtool.c | 2 +
netlink/desc-et
simpler to use.
At the same time (similarly to open_json_object()) do not require
specifying output type. Users can pass an empty string if they
want nothing printed for non-JSON output.
Signed-off-by: Jakub Kicinski
---
json_print.c | 20 ++--
json_print.h | 4 ++--
2 files
tics": {
"corrected_blocks": {
"total": 256,
"lanes": [ 255,1 ]
},
"uncorrectable_blocks": {
"total": 145,
Update to kernel commit 6ecaf81d4ac6.
Signed-off-by: Jakub Kicinski
---
uapi/linux/ethtool.h | 111 +++--
uapi/linux/ethtool_netlink.h | 188 +++
uapi/linux/if_link.h | 9 +-
uapi/linux/netlink.h | 2 +-
uapi/linux
This series adds support for FEC requests via netlink
and new "standard" stats.
Changes compared to RFC:
- improve commit messages
- fix Rx vs Tx histogram in JSON
- make histograms less hardcoded to RMON
- expand man page entry for -S a little
- add --all-groups (last patch)
Jaku
On Mon, 19 Apr 2021 23:54:32 +0200 Pablo Neira Ayuso wrote:
> On Mon, Apr 19, 2021 at 02:43:41PM -0700, Jakub Kicinski wrote:
> > On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote:
> > > No rtnl lock is held from the netfilter side, see:
> > >
> > >
ned-off-by: Jakub Kicinski
---
Documentation/networking/ethtool-netlink.rst | 70 ++--
1 file changed, 36 insertions(+), 34 deletions(-)
diff --git a/Documentation/networking/ethtool-netlink.rst
b/Documentation/networking/ethtool-netlink.rst
index 48cad2fce147..25131df3c2bd 10
On Mon, 19 Apr 2021 23:45:17 +0200 Andrew Lunn wrote:
> > @@ -210,45 +210,47 @@ All constants identifying message types use
> > ``ETHTOOL_CMD_`` prefix and suffix
> >``ETHTOOL_MSG_TUNNEL_INFO_GET`` get tunnel offload info
> >``ETHTOOL_MSG_FEC_GET`` get FEC settings
> >
On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote:
> On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote:
> > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote:
> > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and
&
ETHTOOL_MSG_MODULE_EEPROM_GET is missing from the list of messages.
ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY is sadly a rather long name
so we need to adjust column length.
Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM
data")
Signed-off-by: Jaku
On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote:
> Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and
> stats to different workqueues") splits the workqueue per event type. Add
> a mutex to serialize updates.
>
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: ad
On Sat, 17 Apr 2021 02:42:20 +0300 Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> This patch series contains logic for enabling the lossless mode on the
> RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO
> memory.
>
> During testing it was found that, with the default FIF
Ido suggests we add a comment about the init of stats to -1.
This is unlikely to be clear to first time readers.
Suggested-by: Ido Schimmel
Signed-off-by: Jakub Kicinski
---
net/ethtool/stats.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c
eth0 | grep '\(fcs\|align\|oor\)'
rx_fcs_err_frames: 1
rx_align_err_frames: 0
tx_fcs_err_frames: 0
Suggested-by: Michael Chan
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/d
On Sat, 17 Apr 2021 22:10:39 +0200 Michal Kubecek wrote:
> On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote:
> > Heh, I misunderstood your question. You're asking if the strings can be
> > queried from the command line.
> >
> > No, I don'
On Sun, 18 Apr 2021 11:04:16 +0300 Ido Schimmel wrote:
> On Fri, Apr 16, 2021 at 12:27:42PM -0700, Jakub Kicinski wrote:
> > +/**
> > + * struct ethtool_rmon_hist_range - byte range for histogram statistics
> > + * @low: low bound of the bucket (inclusive)
> > + * @hig
On Sat, 17 Apr 2021 22:22:57 +0300 Ido Schimmel wrote:
> > > So you will have something like:
> > >
> > > ETHTOOL_A_STATS_GRP_HIST_BKT_UNITS_BYTES
> >
> > Histogram has two dimensions, what's the second dimension for bytes?
> > Time? Packet arrival?
>
> Not sure what you mean. Here you are c
On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > >
On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > > Um, yes and now. The only places the user space puts those names
> > > is th
On Sat, 17 Apr 2021 21:14:40 +0300 Ido Schimmel wrote:
> > + if (!is_json_context()) {
> > + fprintf(stdout, "rmon-%s-etherStatsPkts",
> > + mnl_attr_get_type(hist) == ETHTOOL_A_STATS_GRP_HIST_RX ?
> > + "rx" : "tx");
> > +
> > + if (low &&
On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > I tried to understand how you add new groups without user space
> > changes and I think this statement is not entirely accurate.
> >
> > At minimum, user space needs to know the names of these groups, but
>
On Sat, 17 Apr 2021 20:15:11 +0300 Ido Schimmel wrote:
> On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote:
> > Add an interface for reading standard stats, including
> > stats which don't have a corresponding control interface.
> >
> > Start with IEEE
1 - 100 of 8657 matches
Mail list logo
