On Fri, 26 Apr 2024 11:39:28 +0800 Xuan Zhuo wrote:
> To enhance functionality, we now support reporting statistics through
> the netdev-generic netlink (netdev-genl) queue stats interface. However,
> this does not extend to all statistics, so a new field, qstat_offset,
> has been introduced. This field determines which statistics should be
> reported via netdev-genl queue stats.
> 
> Given that queue stats are retrieved individually per queue, it's
> necessary for the virtnet_get_hw_stats() function to be capable of
> fetching statistics for a specific queue.
> 
> As the document 
> https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
> 
> We should not duplicate the stats which get reported via the netlink API in
> ethtool. If the stats are for queue stat, that will not be reported by
> ethtool -S.

Reviewed-by: Jakub Kicinski <k...@kernel.org>

Thank you!

Reply via email to