Now that the driver will always be notified that the role is deleted
before the ring is deleted, then we don't need to duplicate the logic of
cleaning the resources also in the delete function.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot_mrp.c | 16 --
make sure that the driver is notified that the role is
changed to disabled before the MRP instance is deleted to have similar
callbacks with the creating of the instance. In this way it would
simplify the logic in the drivers.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 7 +++
1
The first patch in this series make sures that the driver is notified
that the role is disabled before the MRP instance is deleted. The
second patch uses this so it can simplify the driver.
Horatiu Vultur (2):
bridge: mrp: Disable roles before deleting the MRP instance
net: ocelot: Simplify
NULL port.
The fix consists of using the port on which the function was called.
Fixes: 7c588c3e96e9733a ("net: ocelot: Extend MRP")
Reported-by: Dan Carpenter
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot_mrp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Now when extracting frames from CPU the cpuq is not used anymore so
remove it.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot.c | 3 +--
include/linux/dsa/ocelot.h | 5 -
net/dsa/tag_ocelot.c | 2 --
3 files changed, 1 insertion(+), 9 deletions
This patch extends MRP support for Ocelot. It allows to have multiple
rings and when the node has the MRC role it forwards MRP Test frames in
HW. For MRM there is no change.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot.c | 6 -
drivers/net/ethernet/mscc/ocelot_mrp.c
Add a new PGID that is used not to forward frames anywhere. It is used
by MRP to make sure that MRP Test frames will not reach CPU port.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot.c | 3 +++
include/soc/mscc/ocelot.h | 4 +++-
2 files changed, 6 insertions(+), 1
ame ocelot_mrp_find_port to ocelot_mrp_find_partner_port
- rename PGID_MRP to PGID_BLACKHOLE
- use GFP_KERNEL instead of GFP_ATOMIC
- fix other whitespace issues
Horatiu Vultur (3):
net: ocelot: Add PGID_BLACKHOLE
net: ocelot: Extend MRP
net: ocelot: Remove ocelot_xfh_get_cpuq
drivers/net/ether
The 03/16/2021 13:24, Vladimir Oltean wrote:
>
> From: Vladimir Oltean
>
> Add a short summary of the methods that a driver writer must implement
> for getting an MRP instance to work on top of a DSA switch.
>
> Cc: Horatiu Vultur
> Signed-off-by: Vladimir Oltean
The 03/11/2021 20:02, Vladimir Oltean wrote:
>
> On Thu, Mar 11, 2021 at 08:30:08PM +0100, Horatiu Vultur wrote:
> > > > +static void ocelot_mrp_save_mac(struct ocelot *ocelot,
> > > > + struct ocelot_port *port)
> > > >
The 03/11/2021 02:25, Vladimir Oltean wrote:
Hi Vladimir,
>
> On Wed, Mar 10, 2021 at 09:51:40PM +0100, Horatiu Vultur wrote:
> > This patch extends MRP support for Ocelot. It allows to have multiple
> > rings and when the node has the MRC role it forwards MRP Test frames
This patch extends MRP support for Ocelot. It allows to have multiple
rings and when the node has the MRC role it forwards MRP Test frames in
HW. For MRM there is no change.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot.c | 6 -
drivers/net/ethernet/mscc/ocelot_mrp.c
The 02/23/2021 15:50, Vladimir Oltean wrote:
> On Tue, Feb 23, 2021 at 02:30:28PM +0100, Horatiu Vultur wrote:
> > The 02/22/2021 22:25, Vladimir Oltean wrote:
> > >
> > Hi Vladimir,
> > > Hi Horatiu,
> > >
> > > On Mon, Feb 22, 2021 at 08:46:26P
The 02/22/2021 22:25, Vladimir Oltean wrote:
>
Hi Vladimir,
> Hi Horatiu,
>
> On Mon, Feb 22, 2021 at 08:46:26PM +0100, Horatiu Vultur wrote:
> > > - Why does ocelot support a single MRP ring if all it does is trap the
> > > MRP PDUs to the CPU? What is stoppin
The 02/21/2021 23:33, Vladimir Oltean wrote:
>
> From: Vladimir Oltean
>
> Add a short summary of the methods that a driver writer must implement
> for getting an MRP instance to work on top of a DSA switch.
>
> Cc: Horatiu Vultur
> Signed-off-by: Vladimir Oltean
Hi
The 02/18/2021 13:17, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
Hi Vladimir,
> Hi Horatiu,
>
> On Thu, Feb 18, 2021 at 12:47:26PM +0100, Horatiu Vultur wrote:
> > This patch fixes the oce
ed-by: Vladimir Oltean
Signed-off-by: Horatiu Vultur
---
This was tested using switchdev and only compile tested the DSA driver.
---
drivers/net/dsa/ocelot/felix.c | 20 ---
drivers/net/ethernet/mscc/ocelot_mrp.c | 49 --
drivers/net/ethernet/mscc/ocelot_n
The 02/17/2021 11:14, Vladimir Oltean wrote:
>
> On Tue, Feb 16, 2021 at 10:42:03PM +0100, Horatiu Vultur wrote:
> > Add basic support for MRP. The HW will just trap all MRP frames on the
> > ring ports to CPU and allow the SW to process them. In this way it is
> > poss
The 02/17/2021 10:59, Vladimir Oltean wrote:
>
> On Tue, Feb 16, 2021 at 10:42:02PM +0100, Horatiu Vultur wrote:
> > diff --git a/net/bridge/br_mrp.c b/net/bridge/br_mrp.c
> > index 01c67ed727a9..12487f6fe9b4 100644
> > --- a/net/bridge/br_mrp.c
> > +++ b/net/bridge
The 02/17/2021 10:56, Vladimir Oltean wrote:
>
> On Tue, Feb 16, 2021 at 10:42:01PM +0100, Horatiu Vultur wrote:
> > This patch extends the br_mrp_switchdev functions to be able to have a
> > better understanding what cause the issue and if the SW needs to be used
> > as
The 02/17/2021 10:34, Vladimir Oltean wrote:
Hi Vladimir,
>
> On Tue, Feb 16, 2021 at 10:41:59PM +0100, Horatiu Vultur wrote:
> > Add the member sw_backup to the structures switchdev_obj_ring_role_mrp
> > and switchdev_obj_in_role_mrp. In this way the SW can call the driver i
Implement functions 'port_mrp_add', 'port_mrp_del',
'port_mrp_add_ring_role' and 'port_mrp_del_ring_role' to call the mrp
functions from ocelot.
Also all MRP frames that arrive to CPU on queue number OCELOT_MRP_CPUQ
will be forward by the SW.
Signed-off-
_ROLE
which calls to .port_mrp_add/del and .port_mrp_add/del_ring_role in the
DSA driver for the switch.
Signed-off-by: Horatiu Vultur
---
include/net/dsa.h | 12 ++
net/dsa/dsa_priv.h | 26 +++
net/dsa/port.c | 48 +
net/dsa/slave.c| 22 ++
net/
the frames to CPU. In case the driver
returns 0 then the SW will continue to configure the node accordingly.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_switchdev.c | 171 +-
net/bridge/br_private_mrp.h | 24 +++--
2 files changed, 118 insertions(+), 77
Remove #IS_ENABLED(CONFIG_BRIDGE_MRP) from switchdev.h. This will
simplify the code implements MRP callbacks and will be similar with the
vlan filtering.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/include/net
ring.
- the HW should be able to do forwarding of MRP Test frames so the SW
will not need to do this. So it would be able to have the role MRC
without SW support.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/Makefile | 1 +
drivers/net/ethernet/mscc/ocelot.c
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implementation,
- BR_MRP_HW, continue without SW implementation,
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43
ment MRP support for Felix.
v3:
- implement the switchdev calls needed by Ocelot driver.
v2:
- fix typos in comments and in commit messages
- remove some of the comments
- move repeated code in helper function
- fix issue when deleting a node when sw_backup was true
Horatiu Vultur
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect the cases where HW can't implement
the functionality or when SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file change
false and return 0 when
sw_backup is true.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 465362d9d063..b7fc7d0f54e2 100644
--- a/include/net/switchdev.h
+++ b/include/net/switch
> vsc7514 driver too for features that get added through DSA :)
That is totally fair. I will do it in the next version :)
>
> On Tue, Feb 09, 2021 at 09:21:12PM +0100, Horatiu Vultur wrote:
> > Add basic support for MRP. The HW will just trap all MRP frames on the
> > ring po
The 02/10/2021 10:08, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Hi Horatiu,
>
> On Tue, Feb 09, 2021 at 09:21:07PM +0100, Horatiu Vultur wrote:
> > This patch series extends MRP switchdev t
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect the cases where HW can't implement
the functionality or when SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file change
the frames to CPU. In case the driver
returns 0 then the SW will continue to configure the node accordingly.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_switchdev.c | 171 +-
net/bridge/br_private_mrp.h | 24 +++--
2 files changed, 118 insertions(+), 77
ring.
- the HW should be able to do forwarding of MRP Test frames so the SW
will not need to do this. So it would be able to have the role MRC
without SW support.
Signed-off-by: Horatiu Vultur
---
drivers/net/ethernet/mscc/ocelot_net.c | 154 +
drivers/net/ethernet
move some of the comments
- move repeated code in helper function
- fix issue when deleting a node when sw_backup was true
Horatiu Vultur (5):
switchdev: mrp: Extend ring_role_mrp and in_role_mrp
bridge: mrp: Add 'enum br_mrp_hw_support'
bridge: mrp: Extend br_mrp_switchdev to det
false and return 0 when
sw_backup is true.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 6dcfc4c51a6e..067f259279e1 100644
--- a/include/net/switchdev.h
+++ b/include/net/switch
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implementation,
- BR_MRP_HW, continue without SW implementation,
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43
r
switchdev")
Fixes: 2f1a11ae11d222 ("bridge: mrp: Add MRP interface.")
Reported-by: Rasmus Villemoes
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 9 ++---
net/bridge/br_mrp_switchdev.c | 7 +++
net/bridge/br_private_mrp.h | 3 +--
3 files changed, 10 insert
Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to
notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere
else, therefore we can remove it.
Fixes: c284b545900830 ("switchdev: mrp: Extend switchdev API to offload MRP")
Signed-off-by: Horatiu Vultur
---
i
.
[1] https://www.spinics.net/lists/netdev/msg714816.html
Horatiu Vultur (2):
bridge: mrp: Fix the usage of br_mrp_port_switchdev_set_state
switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT
include/net/switchdev.h | 2 --
net/bridge/br_mrp.c | 9 ++---
net/bridge
The 02/02/2021 11:50, Jakub Kicinski wrote:
>
> On Tue, 2 Feb 2021 08:40:02 +0100 Rasmus Villemoes wrote:
> > On 30/01/2021 04.01, Jakub Kicinski wrote:
> > > On Wed, 27 Jan 2021 21:52:37 +0100 Horatiu Vultur wrote:
> > >> This patch series extends MRP switchdev
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implementation,
- BR_MRP_HW, continue without SW implementation,
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43
the frames to CPU. In case the driver
returns 0 then the SW will continue to configure the node accordingly.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_switchdev.c | 171 +-
net/bridge/br_private_mrp.h | 24 +++--
2 files changed, 118 insertions(+), 77
false and return 0 when
sw_backup is true.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 88fcac140966..3f236eaa4f3e 100644
--- a/include/net/switchdev.h
+++ b/include/net/switch
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect the cases where HW can't implement
the functionality or when SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file change
mments and in commit messages
- remove some of the comments
- move repeated code in helper function
- fix issue when deleting a node when sw_backup was true
Horatiu Vultur (4):
switchdev: mrp: Extend ring_role_mrp and in_role_mrp
bridge: mrp: Add 'enum br_mrp_hw_support'
bridge: m
The 01/25/2021 19:06, Willem de Bruijn wrote:
> On Sat, Jan 23, 2021 at 11:23 AM Horatiu Vultur
> wrote:
Hi Willem,
> >
> > This patch extends the br_mrp_switchdev functions to be able to have a
> > better understanding what cause the issue and if the SW needs to
.
- when HW can implement completely the functionality.
So, initially the SW tries to offload the entire functionality in HW, if
that fails it tries offload parts of the functionality in HW and use the
SW as helper and if also this fails then MRP can't run on this HW.
Horatiu Vultur (4):
sw
false and return 0 when
sw_backup is true.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 88fcac140966..3f236eaa4f3e 100644
--- a/include/net/switchdev.h
+++ b/include/net/switch
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implemtation
- BR_MRP_HW, continue without SW implemtation.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43
ntinue to configure the
node accordingly.
In this way is more clear when the SW needs to stop configuring the
node, or when the SW is used as a backup or the HW can implement the
functionality.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_switchdev.c | 189 +
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect better the cases where the HW can't
implement this or when the SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file change
The 01/22/2021 00:43, Rasmus Villemoes wrote:
>
> It's not true that switchdev_port_obj_notify() only inspects the
> ->handled field of "struct switchdev_notifier_port_obj_info" if
> call_switchdev_blocking_notifiers() returns 0 - there's a WARN_ON()
> triggering for a non-zero return combined wit
The 01/21/2021 21:40, Rasmus Villemoes wrote:
It seems that is missing a Fixes tag, other than that it looks fine.
Reviewed-by: Horatiu Vultur
>
> Wireshark says that the MRP test packets cannot be decoded - and the
> reason for that is that there's a two-byte hole fille
The 01/18/2021 23:07, Rasmus Villemoes wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 18/01/2021 22.19, Vladimir Oltean wrote:
> > On Sat, Jan 16, 2021 at 02:42:12AM +0100, Tobias Waldekranz wrote:
> >>> What I'm _really_ trying to do
The 01/19/2021 16:52, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Tue, Jan 19, 2021 at 09:32:40AM +0100, Horatiu Vultur wrote:
> > The 01/18/2021 21:27, Vladimir Oltean wrote:
> > > EXTERNAL E
The 01/18/2021 21:27, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, Jan 18, 2021 at 09:20:36PM +0100, Horatiu Vultur wrote:
> > The 01/18/2021 19:46, Vladimir Oltean wrote:
> > >
>
The 01/18/2021 19:46, Vladimir Oltean wrote:
>
> On Mon, Jan 18, 2021 at 07:56:18PM +0100, Horatiu Vultur wrote:
> > The reason was to stay away from STP, because you can't run these two
> > protocols at the same time. Even though in SW, we reuse port's state.
&g
The 01/18/2021 19:13, Rasmus Villemoes wrote:
>
Hi Rasmus,
> When using MRP with hardware that does understand the concept of
> blocked or forwarding ports, but not the full MRP offload, we
> currently fail to tell the hardware what state it should put the port
> in when the ring is closed - res
The 01/13/2021 14:15, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 12/01/2021 15:59, Horatiu Vultur wrote:
> > Based on the comments of the previous version, we started to work on a
> >
?
Signed-off-by: Horatiu Vultur
---
include/uapi/linux/if_link.h | 1 +
net/bridge/br_device.c | 2 +-
net/bridge/br_input.c| 2 +-
net/bridge/br_multicast.c| 505 ++-
net/bridge/br_netlink.c | 9 +-
net/bridge/br_private.h | 90
The 12/28/2020 14:24, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Wed, 23 Dec 2020 15:45:32 +0100 Rasmus Villemoes wrote:
> > Wireshark says that the MRP test packets cannot be decoded - and the
> > reason for that is
Hi Andrew,
The 12/23/2020 19:41, Andrew Lunn wrote:
>
> > > @@ -96,7 +96,7 @@ struct br_mrp_ring_test_hdr {
> > > __be16 state;
> > > __be16 transitions;
> > > __be32 timestamp;
> > > -};
> > > +} __attribute__((__packed__));
> >
> > Yes, I agree that this should be packed
The 12/23/2020 15:45, Rasmus Villemoes wrote:
>
> Hi Horatiu and net folks
Hi Rasmus,
>
> I'm having quite some trouble getting MRP working in a simple setup
> involving three mv88e6250 switches in a ring, with one node set as
> manager and the other two as clients.
>
> I'm reasonably confiden
The 12/23/2020 15:45, Rasmus Villemoes wrote:
Hi Rasmus,
>
> Wireshark says that the MRP test packets cannot be decoded - and the
> reason for that is that there's a two-byte hole filled with garbage
> between the "transitions" and "timestamp" members.
>
> So Wireshark decodes the two garbage by
The 12/11/2020 11:46, Nikolay Aleksandrov wrote:
>
> On 11/12/2020 11:26, Horatiu Vultur wrote:
> > This patch tries to add vlan support to IGMP queries.
> > It extends the function 'br_ip4_multicast_alloc_query' to add
> > also a vlan tag if vlan is enabl
functional. But I am curious if this is the way to go forward or is
there a different way of implementing this?
Signed-off-by: Horatiu Vultur
---
net/bridge/br_multicast.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/net/bridge/br_multica
rules on
how to forward this frame.
Acked-by: Nikolay Aleksandrov
Signed-off-by: Horatiu Vultur
---
v1 -> v2:
- remove struct 'br_mrp_in_link_status_hdr' as is unused
---
include/uapi/linux/mrp_bridge.h | 1 +
net/bridge/br_mrp.c | 18 +++---
2 file
The 11/23/2020 14:05, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote:
> > >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr {
> > >>> __be16 interval;
> >
The 11/23/2020 14:13, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 23/11/2020 13:14, Horatiu Vultur wrote:
> > Extend MRP to support LC mode(link check) for the interconnect port.
> >
and
extends existing rules on how to forward this frame.
Signed-off-by: Horatiu Vultur
---
include/uapi/linux/mrp_bridge.h | 7 +++
net/bridge/br_mrp.c | 18 +++---
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/mrp_bridge.h b
Replace list_head with hlist_head for MRP list under the bridge.
There is no need for a circular list when a linear list will work.
This will also decrease the size of 'struct net_bridge'.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_device.c | 2 +-
net/bridge/br_mrp.c
The 09/26/2020 15:37, Vladimir Oltean wrote:
>
> Hi Horatiu,
Hi Vladimir,
>
> On Sat, Sep 26, 2020 at 01:20:02PM +0200, Horatiu Vultur wrote:
> > To be honest, I don't remember precisely. I will need to setup a board
> > and see exactly. But from what I remember:
The 09/25/2020 15:18, Vladimir Oltean wrote:
Hi Vladimir,
>
> At this stage, the tc-flower offload of mscc_ocelot can only delegate
> rules to the VCAP IS2 security enforcement block. These rules have, in
> hardware, separate bits for policing and for overriding the destination
> port mask and/o
The 09/25/2020 02:39, Vladimir Oltean wrote:
>
Hi Vladimir,
> Hi Horatiu,
>
> On Thu, Apr 23, 2020 at 10:29:48AM +0200, Horatiu Vultur wrote:
> > > > +static const struct vcap_props vcap_is2 = {
> > > > + .name = "IS2",
> > >
The 09/23/2020 20:45, Vladimir Oltean wrote:
>
> On Wed, Sep 23, 2020 at 10:35:30PM +0200, Horatiu Vultur wrote:
> > The 09/23/2020 20:22, Vladimir Oltean wrote:
> > > On Wed, Sep 23, 2020 at 10:08:00PM +0200, Horatiu Vultur wrote:
> > > > The 09/23/
The 09/23/2020 20:22, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Wed, Sep 23, 2020 at 10:08:00PM +0200, Horatiu Vultur wrote:
> > The 09/23/2020 14:24, Vladimir Oltean wrote:
> > > +
The 09/23/2020 14:24, Vladimir Oltean wrote:
>
Hi Vladimir,
I have just one question, please see bellow.
> Currently, ocelot switchdev passes the skb directly to the function that
> enqueues it to the list of skb's awaiting a TX timestamp. Whereas the
> felix DSA driver first clones the skb, th
evices since they are in the
> common library portion.
I have looked over ocelot changes and they look fine to me.
Reviewed-by: Horatiu Vultur
>
> Vladimir Oltean (7):
> net: mscc: ocelot: fix race condition with TX timestamping
> net: mscc: ocelot: add locking for the port
el using netlink. The kernel will try to offload
> > the requests to the HW via switchdev API (not implemented yet).
> >
> > Any notification emitted by CFM from the kernel can be monitored in user
> > space by starting 'cfm_server' program.
> >
> > Currentl
old behavior that accepted the "phase" via the "start"
> argument.
Reviewed-by: Horatiu Vultur
>
> Signed-off-by: Vladimir Oltean
> ---
> Changes in v2:
> Made sure it applies to net-next.
>
> drivers/net/ethernet/mscc/ocelot_ptp.c | 74 +
The 07/14/2020 18:33, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 14/07/2020 18:07, Horatiu Vultur wrote:
> > The 07/14/2020 16:29, Nikolay Aleksandrov wrote:
> >> EXTERNAL EMAIL:
The 07/14/2020 16:29, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 14/07/2020 10:34, Horatiu Vultur wrote:
> > This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which
> &
This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which
allows to notify the userspace when the node lost the contiuity of
MRP_InTest frames.
Signed-off-by: Horatiu Vultur
---
include/uapi/linux/if_link.h | 1 +
net/bridge/br_netlink.c| 3 +++
tools/include/uapi
frames can be missed before declaring
the interconnect ring open and the period which represents for how long
to send MRP_InTest frames.
Signed-off-by: Horatiu Vultur
---
include/uapi/linux/if_bridge.h | 53 +
include/uapi/linux/mrp_bridge.h | 38
Extend the existing MRP_INFO to return status of MRP interconnect. In
case there is no MRP interconnect on the node then the role will be
disabled so the other attributes can be ignored.
Signed-off-by: Horatiu Vultur
---
include/uapi/linux/if_bridge.h | 5 +
1 file changed, 5 insertions
This patch extends the existing MRP netlink interface with the following
attributes: IFLA_BRIDGE_MRP_IN_ROLE, IFLA_BRIDGE_MRP_IN_STATE and
IFLA_BRIDGE_MRP_START_IN_TEST. These attributes are similar with their
ring attributes but they apply to the interconnect port.
Signed-off-by: Horatiu Vultur
This patch renames the function br_mrp_port_open to
br_mrp_ring_port_open. In this way is more clear that a ring port lost
the continuity because there will be also a br_mrp_in_port_open.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 6 +++---
net/bridge/br_mrp_netlink.c | 2
but this field
is also part of the MRP_InTest frames.
- the interconnect role, which can be MIM or MIC.
- the interconnect state, which can be open or closed.
- the interconnect delayed_work for sending MRP_InTest frames and check
for lost of continuity.
Signed-off-by: Horatiu Vultur
---
ne
This patch extends the function br_mrp_fill_info to return also the
status for the interconnect ring.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_netlink.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c
Implement the MRP API for interconnect switchdev. Similar with the other
br_mrp_switchdev function, these function will just eventually call the
switchdev functions: switchdev_port_obj_add/del.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_switchdev.c | 62
es is happening in the kernel
and is done by MRP instances.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 570 ++--
net/bridge/br_private_mrp.h | 4 +
2 files changed, 543 insertions(+), 31 deletions(-)
diff --git a/net/bridge/br_mrp.c b/net/bridge/br_
This patch adds a new flag(BR_MRP_LOST_IN_CONT) to the net bridge
ports. This bit will be set when the port lost the continuity of
MRP_InTest frames.
Signed-off-by: Horatiu Vultur
---
include/linux/if_bridge.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/if_bridge.h b
This function notifies the userspace when the node lost the continuity
of MRP_InTest frames.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp_netlink.c | 22 ++
net/bridge/br_private_mrp.h | 1 +
2 files changed, 23 insertions(+)
diff --git a/net/bridge/br_mrp_netlink.c
ring
changes it states to open or closed.
SWITCHDEV_OBJ_ID_IN_TEST_MRP: This is used to start/stop sending
MRP_InTest frames on all MRP ports. This is called only on nodes that
have the interconnect role MIM.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 38
.
v2:
- rearrange structures not to contain holes
- stop sending MRP_InTest frames when the MRP instance is deleted
Horatiu Vultur (12):
switchdev: mrp: Extend switchdev API for MRP Interconnect
bridge: uapi: mrp: Extend MRP attributes for MRP interconnect
bridge: mrp: Extend bridge int
The 07/13/2020 21:54, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 12/07/2020 17:05, Horatiu Vultur wrote:
> > Thie patch adds support for MRP Interconnect. Similar with the MRP ring,
> >
es is happening in the kernel
and is done by MRP instances.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 570 ++--
net/bridge/br_private_mrp.h | 4 +
2 files changed, 543 insertions(+), 31 deletions(-)
diff --git a/net/bridge/br_mrp.c b/net/bridge/br_
This patch extends the existing MRP netlink interface with the following
attributes: IFLA_BRIDGE_MRP_IN_ROLE, IFLA_BRIDGE_MRP_IN_STATE and
IFLA_BRIDGE_MRP_START_IN_TEST. These attributes are similar with their
ring attributes but they apply to the interconnect port.
Signed-off-by: Horatiu Vultur
1 - 100 of 201 matches
Mail list logo
