4 bytes of the FCS; not just 2")
> Link: https://lore.kernel.org/lkml/20210408172353.21143-1-thesve...@gmail.com/
> Signed-off-by: Sven Van Asbroeck
I'm glad everyone was able to work together to get this fixed properly
without any figure pointing or mud slinging! Kudos everyone.
On Thu, Apr 8, 2021 at 1:35 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 2:26 PM Sven Van Asbroeck wrote:
> >
> > George, I will send a patch for you to try shortly. Except if you're
> > already ahead :)
>
> Would this work for you? It does for me.
Works for me too.
>
>
On Thu, Apr 8, 2021 at 12:46 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 1:36 PM George McCollister
> wrote:
> >
> > Can you explain the difference in behavior with what I was observing
> > on the LAN7431?
>
> I'm not usin
Sven Van Asbroeck
> ---
>
> To: Bryan Whitehead
> To: "David S. Miller"
> To: Jakub Kicinski
> To: George McCollister
> Cc: unglinuxdri...@microchip.com
> Cc: netdev@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
>
> drivers/net/ethernet/microchip/la
On Thu, Apr 1, 2021 at 5:33 PM Russell King - ARM Linux admin
wrote:
>
> Hi,
>
> I hadn't responded earlier because I wanted to think about it more,
> but then forgot about this email.
>
> On Thu, Mar 25, 2021 at 11:36:26AM -0500, George McCollister wrote:
> > When
t. If any of you have interest in getting these
patches upstream it would be great to work with someone on it.
You can find what I have here:
https://github.com/gmccollister/linux/tree/net-i210-mv88e6390
Regards,
George McCollister
for MLO_AN_INBAND or also for
ML_AN_FIXED? Do we want phylink_validate called in phylink_create even
though it gets called anyway for MLO_AN_INBAND and ML_AN_FIXED later?
Regards,
George McCollister
On Mon, Mar 22, 2021 at 3:46 PM Vladimir Oltean wrote:
>
> On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote:
> > Use a temporary variable to hold the return value from
> > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving
> > an
keep a copy of the tagging protocol in the DSA
switch tree")
Signed-off-by: George McCollister
---
net/dsa/dsa2.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index eb709d988c54..8f9e35e1aa89 100644
--- a/net/dsa/dsa2.c
+++
idn't work depending on the order the ports were added to the
hsr device.
Fixes: bd62e6f5e6a9 ("net: dsa: xrs700x: add HSR offloading support")
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Trim all 4 bytes of the received FCS; not just 2 of them. Leaving 2
bytes of the FCS on the frame breaks DSA tailing tag drivers.
Fixes: a8db76d40e4d ("lan743x: boost performance on cpu archs w/o dma cache
snooping")
Signed-off-by: George McCollister
---
drivers/net/ethernet
On Wed, Feb 24, 2021 at 7:42 PM Andrew Lunn wrote:
>
> > +IEC 62439-3 (HSR/PRP)
> > +-
> > +
> > +The Parallel Redundancy Protocol (PRP) is a network redundancy protocol
> > which
> > +works by duplicating and sequence numbering packets through two
> > independent L2
> > +net
On Mon, Feb 22, 2021 at 7:38 AM Wenzel, Marco wrote:
>
> On Fri, Feb 19, 2021 at 2:14 PM : George McCollister
> wrote:
> >
> > On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco > eberle.de> wrote:
> > >
> > > On Thu, Feb 18, 2021 at 6:06 PM : George M
On Sun, Feb 21, 2021 at 3:34 PM Vladimir Oltean wrote:
>
> From: Vladimir Oltean
>
> Add a short summary of the methods that a driver writer must implement
> for offloading a HSR/PRP network interface.
>
> Cc: George McCollister
> Signed-off-by: Vladimir Oltean
still fail to
> link because it calls hsr_get_version() and for that one there is no
> easy solution.
Thanks for looking into this. It's not something I've run into before.
It didn't occur to me what would happen if HSR was a module. I'll look
out for this in the future.
Sorry for the inconvenience.
Reviewed-by: George McCollister
-George
> --
> Florian
On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco wrote:
>
> On Thu, Feb 18, 2021 at 6:06 PM : George McCollister
> wrote:
> >
> > On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel > eberle.de> wrote:
> > >
> > > In IEC 62439-3 EntryForgetTime is defined w
mmunication problem?
> --
> 2.30.0
>
scripts/checkpatch.pl gives errors about DOS line endings but once
that is resolved this looks good. I tested it on an HSR network with
the software implementation and the xrs700x which uses offloading and
everything still works. I don't have a way to force anything on the
HSR network to reuse sequence numbers after 400ms.
Reviewed-by: George McCollister
On Wed, Feb 17, 2021 at 7:14 AM Wenzel, Marco wrote:
>
> On Mon, Feb 15, 2021 at 5:49 PM George McCollister
> wrote:
> >
> > On Mon, Feb 15, 2021 at 6:30 AM Wenzel, Marco > eberle.de> wrote:
[snip]
>
> I was not so familiar with kernel patching until now and h
n.h b/net/hsr/hsr_main.h
> index 7dc92ce5a134..f79ca55d6986 100644
> --- a/net/hsr/hsr_main.h
> +++ b/net/hsr/hsr_main.h
> @@ -21,6 +21,7 @@
> #define HSR_LIFE_CHECK_INTERVAL 2000 /* ms */
> #define HSR_NODE_FORGET_TIME 6 /* ms */
> #def
On Sun, Feb 14, 2021 at 9:54 AM Vladimir Oltean wrote:
[snip]
> diff --git a/net/dsa/tag_xrs700x.c b/net/dsa/tag_xrs700x.c
> index 858cdf9d2913..215ecceea89e 100644
> --- a/net/dsa/tag_xrs700x.c
> +++ b/net/dsa/tag_xrs700x.c
> @@ -45,8 +45,7 @@ static struct sk_buff *xrs700x_rcv(struct sk_buff *sk
Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
forwarding and duplication supported by the xrs7000 series switches.
Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
v0 is not).
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c
driver should then set netdev feature flags for the
HSR/PRP operation that it offloads.
NETIF_F_HW_HSR_TAG_INS
NETIF_F_HW_HSR_TAG_RM
NETIF_F_HW_HSR_FWD
NETIF_F_HW_HSR_DUP
Signed-off-by: George McCollister
---
include/net/dsa.h | 13 +
net/dsa/dsa_priv.h | 11
ports.
Export is_hsr_master so DSA can tell them apart from other devices in
dsa_slave_changeupper.
Signed-off-by: George McCollister
---
Documentation/networking/netdev-features.rst | 21 +
include/linux/if_hsr.h | 27 +++
include
allow offloading.
Signed-off-by: George McCollister
---
net/hsr/hsr_device.c | 39 +++
net/hsr/hsr_forward.c | 8 +++-
2 files changed, 14 insertions(+), 33 deletions(-)
diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index ab953a1a0d6c..ec6a68b403d5 1
void.
* Remove hsr_init_skb() proto argument. (Vladimir Oltean)
George McCollister (4):
net: hsr: generate supervision frame without HSR/PRP tag
net: hsr: add offloading support
net: dsa: add support for offloading HSR
net: dsa: xrs700x: add HSR offloading support
Documentation/networking/n
On Tue, Feb 9, 2021 at 12:51 PM Vladimir Oltean wrote:
>
> On Tue, Feb 09, 2021 at 12:37:38PM -0600, George McCollister wrote:
> > On Tue, Feb 9, 2021 at 11:20 AM Vladimir Oltean wrote:
> > >
> > > On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote
Use of_match_ptr() on xrs700x_mdio_dt_ids so that NULL is substituted
when CONFIG_OF isn't defined. This will prevent unnecessary use of
xrs700x_mdio_dt_ids when CONFIG_OF isn't defined.
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x_mdio.c | 3 ++-
1 file
Reported-by: kernel test robot
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x_i2c.c | 2 +-
drivers/net/dsa/xrs700x/xrs700x_mdio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/xrs700x/xrs700x_i2c.c
b/drivers/net/dsa/xrs700
On Tue, Feb 9, 2021 at 11:20 AM Vladimir Oltean wrote:
>
> On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote:
> > > If you return zero, the software fallback is never going to kick in.
> >
> > For join and leave? How is this not a problem for the b
On Tue, Feb 9, 2021 at 8:38 AM Tobias Waldekranz wrote:
>
> On Mon, Feb 08, 2021 at 15:09, George McCollister
> wrote:
> > On Mon, Feb 8, 2021 at 2:16 PM Tobias Waldekranz
> > wrote:
> >>
> >> On Thu, Feb 04, 2021 at 15:59, George McCollister
> &g
On Mon, Feb 8, 2021 at 2:16 PM Tobias Waldekranz wrote:
>
> On Thu, Feb 04, 2021 at 15:59, George McCollister
> wrote:
> > Add support for offloading HSR/PRP (IEC 62439-3) tag insertion, tag
> > removal, forwarding and duplication on DSA switches.
> > This series add
On Sat, Feb 6, 2021 at 7:26 PM Vladimir Oltean wrote:
>
> On Thu, Feb 04, 2021 at 03:59:23PM -0600, George McCollister wrote:
> > @@ -289,23 +286,12 @@ static void send_hsr_supervision_frame(struct
> > hsr_port *master,
> > hsr->announce_count++;
> &g
On Sat, Feb 6, 2021 at 5:29 PM Vladimir Oltean wrote:
>
> On Thu, Feb 04, 2021 at 03:59:25PM -0600, George McCollister wrote:
> > @@ -1935,6 +1936,19 @@ static int dsa_slave_changeupper(struct net_device
> > *dev,
> > dsa_port_lag_l
On Sat, Feb 6, 2021 at 5:43 PM Vladimir Oltean wrote:
>
> On Tue, Feb 02, 2021 at 08:49:25AM -0600, George McCollister wrote:
> > > > > Why is it such a big deal if supervision frames have HSR/PRP tag or
> > > > > not?
> > > >
> > > > B
On Sat, Feb 6, 2021 at 5:53 PM Vladimir Oltean wrote:
>
> On Thu, Feb 04, 2021 at 03:59:26PM -0600, George McCollister wrote:
> > +static int xrs700x_hsr_join(struct dsa_switch *ds, int port,
> > + struct net_device *hsr)
> > +{
&g
allow offloading.
Signed-off-by: George McCollister
---
net/hsr/hsr_device.c | 32
net/hsr/hsr_forward.c | 6 +-
2 files changed, 9 insertions(+), 29 deletions(-)
diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index ab953a1a0d6c..161b8da6a21d 100644
---
. (Vladimir Oltean)
* eliminate IFF_HSR and use is_hsr_master instead. (Vladimir Oltean)
* Make hsr_handle_sup_frame handle skb_std as well (required when offloading)
* Don't add hsr tag for HSR v0 supervisory frames.
* Fixed tag insertion offloading for PRP.
George McCollister (4):
net
driver should then set netdev feature flags for the
HSR/PRP operation that it offloads.
NETIF_F_HW_HSR_TAG_INS
NETIF_F_HW_HSR_TAG_RM
NETIF_F_HW_HSR_FWD
NETIF_F_HW_HSR_DUP
Signed-off-by: George McCollister
---
include/net/dsa.h | 13 +
net/dsa/dsa_priv.h | 11
ports.
Export is_hsr_master so DSA can tell them apart from other devices in
dsa_slave_changeupper.
Signed-off-by: George McCollister
---
Documentation/networking/netdev-features.rst | 21 +
include/linux/if_hsr.h | 27 +++
include
Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
forwarding and duplication supported by the xrs7000 series switches.
Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
v0 is not).
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c
I don't see the second patch.
Regards,
George McCollister
On Mon, Feb 1, 2021 at 9:23 AM Vladimir Oltean wrote:
[snip]
> > @@ -357,6 +367,7 @@ static void hsr_forward_do(struct hsr_frame_info *frame)
> > {
> > struct hsr_port *port;
> > struct sk_buff *skb;
> > + bool sent = false;
> >
> > hsr_for_each_port(frame->port_rcv->hsr, po
[2] = reg >> 7 & 0xff;
> - buf[3] = (reg & 0x7f) << 1 | 1;
> - buf[4] = val >> 8 & 0xff;
> - buf[5] = val & 0xff;
> + cmd.reg = cpu_to_be32(reg);
> + cmd.val = cpu_to_be16(val);
>
> - ret = i2c_master_send(i2c, buf, sizeof(buf));
> + ret = i2c_master_send(i2c, (char *)&cmd, sizeof(cmd));
> if (ret < 0) {
> dev_err(dev, "xrs i2c_master_send returned %d\n", ret);
> return ret;
> --
> 2.17.1
>
Reviewed-by: George McCollister
On Mon, Feb 1, 2021 at 6:37 PM Vladimir Oltean wrote:
>
> On Mon, Feb 01, 2021 at 01:43:43PM -0600, George McCollister wrote:
> > > > diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
> > > > index ab953a1a0d6c..161b8da6a21d 100644
> > > > --- a/
On Mon, Feb 1, 2021 at 9:29 AM Vladimir Oltean wrote:
>
> On Mon, Feb 01, 2021 at 08:05:03AM -0600, George McCollister wrote:
> > Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
> > forwarding and duplication supported by the xrs7000 series switches.
>
On Mon, Feb 1, 2021 at 9:23 AM Vladimir Oltean wrote:
>
> On Mon, Feb 01, 2021 at 08:05:01AM -0600, George McCollister wrote:
> > Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion
> > tag removal, duplicate generation and forwarding.
> >
> > Use a n
On Mon, Feb 1, 2021 at 8:59 AM Vladimir Oltean wrote:
>
> On Mon, Feb 01, 2021 at 08:05:00AM -0600, George McCollister wrote:
> > Generate supervision frame without HSR/PRP tag and rely on existing
> > code which inserts it later.
> > This will allow HSR/PRP tag insertion
lease repost"
Changes since RFC:
* Split hsr and dsa patches. (Florian Fainelli)
George McCollister (4):
net: hsr: generate supervision frame without HSR tag
net: hsr: add offloading support
net: dsa: add support for offloading HSR
net: dsa: xrs700x: add HSR offloading support
Doc
Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
forwarding and duplication supported by the xrs7000 series switches.
Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
v0 is not).
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c
driver should then set netdev feature flags for the
HSR/PRP operation that it offloads.
NETIF_F_HW_HSR_TAG_INS
NETIF_F_HW_HSR_TAG_RM
NETIF_F_HW_HSR_FWD
NETIF_F_HW_HSR_DUP
Signed-off-by: George McCollister
---
include/net/dsa.h | 13 +
net/dsa/dsa_priv.h | 11
Generate supervision frame without HSR/PRP tag and rely on existing
code which inserts it later.
This will allow HSR/PRP tag insertions to be offloaded in the future.
Signed-off-by: George McCollister
---
net/hsr/hsr_device.c | 32
net/hsr/hsr_forward.c | 10
redundant ports. This is required because the
inserted HSR/PRP header/trailer must contain the same sequence number
on the frames sent out both redundant ports.
Signed-off-by: George McCollister
---
Documentation/networking/netdev-features.rst | 20
include/linux/if_hsr.h
ot;Time after which an entry is removed from the
duplicate table" with a value of 400ms and states devices should
usually be configured to keep entries in the table for a much shorter
time. hsr_framereg.c needs to be reworked to handle this according to
the specification.
>
> Thanks
> Marco Wenzel
Regards,
George McCollister
On Sun, Jan 24, 2021 at 2:43 AM Vladimir Oltean wrote:
>
[snip]
>
> I would like to give HSR a spin to get a better idea of what you're doing, but
> it's kinda hard when this happens out of the box, with none of your changes
> already:
>
> [ 1385.000453] hsr0: hw csum failure
> [ 1385.004105] skb
On Sun, Jan 24, 2021 at 11:29 AM Vladimir Oltean wrote:
>
> On Fri, Jan 22, 2021 at 09:59:47AM -0600, George McCollister wrote:
> > diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> > index f2fb433f3828..fc7e3ff11c5c 100644
> > --- a/net/dsa/slave.c
> > +++ b/
On Fri, Jan 22, 2021 at 11:56 AM Florian Fainelli wrote:
>
>
>
> On 1/22/2021 7:59 AM, George McCollister wrote:
> > Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion
> > tag removal, duplicate generation and forwarding on DSA switches.
> >
> >
automatically sending a single frame
from the CPU port to both redundant ports. This is required because the
inserted HSR/PRP header/trailer must contain the same sequence number
on the frames sent out both redundant ports.
Signed-off-by: George McCollister
---
Documentation/networking/netdev
series. Since
many may not be familiar with HSR/PRP let me know if I omitted anything
in the commit messages which might have seemed obvious to me.
George McCollister (3):
net: hsr: generate supervision frame without HSR tag
net: hsr: add DSA offloading support
net: dsa: xrs700x: add HSR
Add offloading for HSR/PRP (IEC 62439-3) tag insertion, tag removal
forwarding and duplication supported by the xrs7000 series switches.
Only HSR v1 and PRP v1 are supported by the xrs7000 series switches (HSR
v0 is not).
Signed-off-by: George McCollister
---
drivers/net/dsa/xrs700x/xrs700x.c
Generate supervision frame without HSR/PRP tag and rely on existing
code which inserts it later.
This will allow HSR/PRP tag insertions to be offloaded in the future.
Signed-off-by: George McCollister
---
net/hsr/hsr_device.c | 32
net/hsr/hsr_forward.c | 10
Add myself as maintainer of the Arrow SpeedChips XRS7000 series Ethernet
switch driver.
Suggested-by: Jakub Kicinski
Signed-off-by: George McCollister
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 096b584e7fed..992530a481a0 100644
On Thu, Jan 14, 2021 at 4:48 PM Vladimir Oltean wrote:
>
> On Thu, Jan 14, 2021 at 01:57:33PM -0600, George McCollister wrote:
[snip]
>
> Reviewed-by: Vladimir Oltean
>
> This driver is good to go, just one small nitpick below, you can fix it
> up afterwards if you wan
Add documentation and an example for Arrow SpeedChips XRS7000 Series
single chip Ethernet switches.
Signed-off-by: George McCollister
Reviewed-by: Florian Fainelli
---
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 73 ++
1 file changed, 73 insertions(+)
create mode
.
Support for advanced features such as PTP and
HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and
may be added at a later date.
Signed-off-by: George McCollister
---
drivers/net/dsa/Kconfig| 2 +
drivers/net/dsa/Makefile | 1 +
drivers/net
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.
Signed-off-by: George McCollister
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6 +
net
i2c/mdio data before registering. (Florian Fainelli)
George McCollister (3):
dsa: add support for Arrow XRS700x tag trailer
net: dsa: add Arrow SpeedChips XRS700x driver
dt-bindings: net: dsa: add bindings for xrs700x switches
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 73 +++
d
On Thu, Jan 14, 2021 at 12:32 PM Vladimir Oltean wrote:
> > > May boil down to preference too, but I don't believe "dev" is a happy
> > > name to give to a driver private data structure.
> >
> > There are other drivers in the subsystem that do this. If there was a
> > consistent pattern followed i
On Thu, Jan 14, 2021 at 11:28 AM Florian Fainelli wrote:
>
> On 1/13/21 6:59 AM, George McCollister wrote:
> > Add a driver with initial support for the Arrow SpeedChips XRS7000
> > series of gigabit Ethernet switch chips which are typically used in
> > critical
On Wed, Jan 13, 2021 at 7:57 PM Vladimir Oltean wrote:
>
> What PHY interface types does the switch support as of this patch?
> No RGMII delay configuration needed?
>
Port 0: RMII
Port 1-3: RGMII
For RGMII the documentation states:
"PCB is required to add 1.5 ns to 2.0 ns more delay to the clock
On Wed, Jan 13, 2021 at 7:05 PM Vladimir Oltean wrote:
> > +++ b/net/dsa/tag_xrs700x.c
> > @@ -0,0 +1,67 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * XRS700x tag format handling
> > + * Copyright (c) 2008-2009 Marvell Semiconductor
>
> Why does Marvell get copyright?
What Andrew s
.
Support for advanced features such as PTP and
HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and
may be added at a later date.
Signed-off-by: George McCollister
---
drivers/net/dsa/Kconfig| 2 +
drivers/net/dsa/Makefile | 1 +
drivers/net
in devicetree examples. (Rob Herring)
* Use ethernet-port(s) in devicetree examples. (Rob Herring)
* Use strscpy() instead of strlcpy().
George McCollister (3):
dsa: add support for Arrow XRS700x tag trailer
net: dsa: add Arrow SpeedChips XRS700x driver
dt-bindings: net: dsa: add bindings for xr
Add documentation and an example for Arrow SpeedChips XRS7000 Series
single chip Ethernet switches.
Signed-off-by: George McCollister
Reviewed-by: Florian Fainelli
---
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 73 ++
1 file changed, 73 insertions(+)
create mode
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.
Signed-off-by: George McCollister
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6 +
net
On Mon, Dec 7, 2020 at 6:40 PM kernel test robot wrote:
>drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct
> dsa_switch_ops' has no member named 'get_stats64'
This patch depends on "net: dsa: add optional stats64 support" being
merged first:
https://lore.kernel.org/netdev/2020120
.
Support for advanced features such as PTP and
HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and
may be added at a later date.
Signed-off-by: George McCollister
---
This patch depends on "net: dsa: add optional stats64 support" being
merged first.
https://lore.ker
Add documentation and an example for Arrow SpeedChips XRS7000 Series
single chip Ethernet switches.
Signed-off-by: George McCollister
Reviewed-by: Florian Fainelli
---
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 74 ++
1 file changed, 74 insertions(+)
create mode
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.
Signed-off-by: George McCollister
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6 +
net
tats via .get_stats64. (Jakub Kicinski, Vladimir Oltean)
* Use a 3 second polling rate for counters.
George McCollister (3):
dsa: add support for Arrow XRS700x tag trailer
net: dsa: add Arrow SpeedChips XRS700x driver
dt-bindings: net: dsa: add bindings for xrs700x switches
.../devi
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Allow DSA drivers to export stats64
>
> Signed-off-by: Oleksij Rempel
> Reviewed-by: Vladimir Oltean
Reviewed-by: George McCollister
I've already updated my xrs700x dsa driver for v3 to use this. I'm
blocked on
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Add stats support for the ar9331 switch.
>
> Signed-off-by: Oleksij Rempel
> ---
> drivers/net/dsa/qca/ar9331.c | 247 ++-
> 1 file changed, 246 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote:
>
> Add stats support for the ar9331 switch.
>
> Signed-off-by: Oleksij Rempel
> ---
> drivers/net/dsa/qca/ar9331.c | 247 ++-
> 1 file changed, 246 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/
On Mon, Nov 30, 2020 at 5:50 PM Vladimir Oltean wrote:
>
> On Mon, Nov 30, 2020 at 10:52:35AM -0600, George McCollister wrote:
> > Another possible option could be replacing for_each_netdev_rcu with
> > for_each_netdev_srcu and using list_for_each_entry_srcu (though it&#x
On Fri, Nov 27, 2020 at 8:15 PM Jakub Kicinski wrote:
>
> On Sat, 28 Nov 2020 03:41:06 +0200 Vladimir Oltean wrote:
> > Jakub, I would like to hear more from you. I would still like to try
> > this patch out. You clearly have a lot more background with the code.
>
> Well, I've seen people run into
On Fri, Nov 27, 2020 at 1:50 PM Vladimir Oltean wrote:
>
> On Fri, Nov 27, 2020 at 12:47:41PM -0600, George McCollister wrote:
> > On Fri, Nov 27, 2020, 12:35 PM Jakub Kicinski wrote:
> >
> > > On Fri, 27 Nov 2020 00:05:00 +0200 Vladimir Oltean wrote:
> > >
On Thu, Nov 26, 2020 at 11:56 AM Vladimir Oltean wrote:
>
> On Thu, Nov 26, 2020 at 03:24:18PM +0200, Vladimir Oltean wrote:
> > On Wed, Nov 25, 2020 at 08:25:11PM -0600, George McCollister wrote:
> > > > > + {XRS_RX_UNDERSIZE_L, "rx_undersize"}
On Wed, Nov 25, 2020 at 7:42 PM Jakub Kicinski wrote:
>
> On Wed, 25 Nov 2020 13:37:39 -0600 George McCollister wrote:
> > Add a driver with initial support for the Arrow SpeedChips XRS7000
> > series of gigabit Ethernet switch chips which are typically used in
>
drew Lunn)
* Add inbound policy to allow BPDUs. (Andrew Lunn)
* Move files into their own subdir. (Vladimir Oltean)
* Automate regmap field allocation. (Vladimir Oltean)
* Move setting link speed to .mac_link_up. (Vladimir Oltean)
* Use different compatible strings for e/f variants.
George Mc
Add documentation and an example for Arrow SpeedChips XRS7000 Series
single chip Ethernet switches.
Signed-off-by: George McCollister
---
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 74 ++
1 file changed, 74 insertions(+)
create mode 100644 Documentation/devicetree
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.
Signed-off-by: George McCollister
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6 +
net/dsa/Makefile | 1 +
net/dsa/tag_xrs700x.c | 67
.
Support for advanced features such as PTP and
HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and
may be added at a later date.
Signed-off-by: George McCollister
---
drivers/net/dsa/Kconfig| 2 +
drivers/net/dsa/Makefile | 1 +
drivers/net
On Mon, Nov 23, 2020 at 4:18 PM Florian Fainelli wrote:
>
>
>
> On 11/20/2020 10:16 AM, George McCollister wrote:
> > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
> > is modeled on tag_trailer.c which works in a similar way.
> >
> &g
On Mon, Nov 23, 2020 at 4:09 PM Andrew Lunn wrote:
>
> > > > https://www.flexibilis.com/downloads/xrs/SpeedChip_XRS7000_3000_User_Manual.pdf
>
> Section 6.1.4
>
> The forwarding decision is presented in Figure 19. Note that also
> frames coming into a disabled port are received to the buffer memor
On Sun, Nov 22, 2020 at 5:39 PM Vladimir Oltean wrote:
>
> Hi George,
>
> On Fri, Nov 20, 2020 at 12:16:26PM -0600, George McCollister wrote:
> > Add a driver with initial support for the Arrow SpeedChips XRS7000
> > series of gigabit Ethernet switch chips which are typica
On Fri, Nov 20, 2020 at 5:24 PM Andrew Lunn wrote:
>
> Hi George
>
> > > > +static void xrs700x_port_stp_state_set(struct dsa_switch *ds, int port,
> > > > +u8 state)
> > > > +{
> > > > + struct xrs700x *priv = ds->priv;
> > > > + unsigned int val;
> > >
On Fri, Nov 20, 2020 at 1:33 PM Andrew Lunn wrote:
>
> > +static const struct xrs700x_mib xrs700x_mibs[] = {
> > + {XRS_RX_GOOD_OCTETS_L(0), "rx_good_octets"},
> > + {XRS_RX_BAD_OCTETS_L(0), "rx_bad_octets"},
> > + {XRS_RX_UNICAST_L(0), "rx_unicast"},
> > + {XRS_RX_BROADCAST_L(0),
On Fri, Nov 20, 2020 at 12:58 PM Andrew Lunn wrote:
>
> On Fri, Nov 20, 2020 at 12:16:25PM -0600, George McCollister wrote:
> > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
> > is modeled on tag_trailer.c which works in a similar way.
> >
&
439-3 Clause 5 & 4) offloading with integration into net/hsr.
George McCollister (3):
dsa: add support for Arrow XRS700x tag trailer
net: dsa: add Arrow SpeedChips XRS700x driver
dt-bindings: net: dsa: add bindings for xrs700x switches
.../devicetree/bindings/net/dsa/arrow,xrs700x.y
Add documentation and an example for Arrow SpeedChips XRS7000 Series
single chip Ethernet switches.
Signed-off-by: George McCollister
---
.../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 72 ++
1 file changed, 72 insertions(+)
create mode 100644 Documentation/devicetree
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.
Signed-off-by: George McCollister
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6
net/dsa/Makefile | 1 +
net/dsa/tag_xrs700x.c | 91
1 - 100 of 106 matches
Mail list logo
