Re: Latest net-next kernel 4.19.0+

2018-10-29 Thread Dimitris Michailidis
On Mon, Oct 29, 2018 at 8:52 PM, Eric Dumazet wrote: > > > On 10/29/2018 07:53 PM, Eric Dumazet wrote: >> >> >> On 10/29/2018 07:27 PM, Cong Wang wrote: >>> Hi, >>> >>> On Mon, Oct 29, 2018 at 5:19 PM Paweł Staszewski >>> wrote: Sorry not complete - followed by hw csum: [ 34

[PATCH net] net: fix pskb_trim_rcsum_slow() with odd trim offset

2018-10-19 Thread Dimitris Michailidis
sum_sub(). We need to use csum_block_sub() here that takes into account the parity of the start address and handles the swapping. Matches existing code in __skb_postpull_rcsum() and esp_remove_trailer(). Fixes: 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends&qu

Re: [PATCH RFC net-next 06/11] udp: add gso support to virtual devices

2018-04-17 Thread Dimitris Michailidis
On Tue, Apr 17, 2018 at 1:00 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Virtual devices such as tunnels and bonding can handle large packets. > Only segment packets when reaching a physical or loopback device. > > Signed-off-by: Willem de Bruijn > --- > include/linux/netdev_featur

[PATCH net-next] macvlan: add offload features for encapsulation

2017-08-16 Thread Dimitris Michailidis
Currently macvlan devices do not set their hw_enc_features making encapsulated Tx packets resort to SW fallbacks. Add encapsulation GSO offloads to ->features as is done for the other GSOs and set ->hw_enc_features. Signed-off-by: Dimitris Michailidis --- drivers/net/macvlan.c | 3 ++-

[PATCH] net: fix ndo_features_check/ndo_fix_features comment ordering

2017-01-31 Thread Dimitris Michailidis
quot;) Signed-off-by: Dimitris Michailidis --- include/linux/netdevice.h | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9bde9558b596..70ad0291d517 100644 --- a/include/linux/netdevice.h

Re: [PATCH] ipv6: fix flow labels when the traffic class is non-0

2017-01-30 Thread Dimitris Michailidis
On Mon, Jan 30, 2017 at 3:45 PM, Eric Dumazet wrote: > On Mon, Jan 30, 2017 at 3:40 PM, Tom Herbert wrote: > >> Thanks for pointing out the issue, but I don't think this fix is quite >> right. This would be discarding traffic class from being in the return >> value. I can try to fix that. > > Fix

Re: [PATCH] ipv6: fix flow labels when the traffic class is non-0

2017-01-30 Thread Dimitris Michailidis
On Mon, Jan 30, 2017 at 2:23 PM, Eric Dumazet wrote: > On Mon, Jan 30, 2017 at 2:09 PM, Dimitris Michailidis > wrote: >> ip6_make_flowlabel() determines the flow label for IPv6 packets. It's >> supposed to be passed a flow label, which it returns as is if non-0 and

[PATCH] ipv6: fix flow labels when the traffic class is non-0

2017-01-30 Thread Dimitris Michailidis
) 1010 1010 0101 1110 = Flow Label: 0xafa5e Payload Length: 688 Next Header: TCP (6) Signed-off-by: Dimitris Michailidis --- include/net/ipv6.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 7afe991e900e..db

Re: [PATCH] net: don't lose features in netdev_add_tso_features()

2016-05-17 Thread Dimitris Michailidis
On Tue, May 17, 2016 at 11:10 AM, David Miller wrote: > From: Dimitris Michailidis > Date: Mon, 16 May 2016 15:33:35 -0700 > >> The goal of netdev_add_tso_features() is to enable all TSO features but >> it unintentionally loses NETIF_F_ALL_FOR_ALL features. T

[PATCH] net: don't lose features in netdev_add_tso_features()

2016-05-16 Thread Dimitris Michailidis
luded in NETIF_F_ALL_TSO. The behavior can be seen by enabling tx-nocache-copy on the slaves and noticing the feature remains off at the master. Fix this by including NETIF_F_ALL_FOR_ALL in the incremental features. Signed-off-by: Dave Platt Signed-off-by: Dimitris Michailidis --- include/

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-15 Thread Dimitris Michailidis
On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote: > From: Dimitris Michailidis <[EMAIL PROTECTED]> > Date: Fri, 12 Aug 2005 10:00:12 -0700 > > > On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote: > > > This would mean that every time we wi

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Dimitris Michailidis
On 8/12/05, Mitchell Blank Jr <[EMAIL PROTECTED]> wrote: > I'm fairly pessimistic about full TOE also, I just want to see the patch > cleaned up a bit so we can see the exact impact it would have. The RX > optimization work presented in the Neterion and Intel papers at OLS sounds a > lot more int

Re: [PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Dimitris Michailidis
On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote: > > > - static was removed from functions '__tcp_inherit_port' & '__tcp_v4_hash' > > because these are called outside of tcp_ipv4.c from the TOM driver. > > There is no way you're going to be allowed to call such deep TCP > internals from you

Re: FW: [ANNOUNCE] Chelsio 10Gb TOE (TCP Offload Engine)

2005-08-09 Thread Dimitris Michailidis
On 8/9/05, David S. Miller wrote: > > @@ -735,6 +737,9 @@ > > ssize_t res; > > struct sock *sk = sock->sk; > > > > + if (sk->sk_prot->sendpage) > > + return sk->sk_prot->sendpage(sk, page, offset, size, flags); > > + > > This doesn't make any sense, invoking sk->sk_pro