On Mon, Jan 30, 2017 at 3:45 PM, Eric Dumazet <eduma...@google.com> wrote: > On Mon, Jan 30, 2017 at 3:40 PM, Tom Herbert <t...@herbertland.com> wrote: > >> Thanks for pointing out the issue, but I don't think this fix is quite >> right. This would be discarding traffic class from being in the return >> value. I can try to fix that. > > Fix looks fine to me. > > ip6_make_flowlabel() is usually used in an enclosing ip6_flow_hdr(), > which gives the tclass. > > ip6_flow_hdr(hdr, tclass, ip6_make_flowlabel(net, skb, fl6->flowlabel, > > np->autoflowlabel, fl6));
Yes, all the callers of ip6_make_flowlabel() I've seen feed the result to ip6_flow_hdr().