ith the call of the new function
> where appropriate.
Acked-by: David Vrabel
Please queue for the next release.
David
uests are placed on the ring, permanently stalling
the VIF.
This is a regression introduced by eb1723a29b9a7 (xen-netback:
refactor guest rx).
Fix this by reinstating the setting of queue->last_rx_time when
placing a packet onto the guest Rx ring.
Signed-off-by: David Vrabel
---
drivers
On 04/10/16 13:47, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 04, 2016 at 10:29:16AM +0100, Paul Durrant wrote:
>> From: David Vrabel
>>
>> Instead of only placing one skb on the guest rx ring at a time, process
>> a batch of up-to 64. This improves performance by ~
On 04/10/16 10:29, Paul Durrant wrote:
> From: Ross Lagerwall
>
> This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45
> fragments) to be handled by netback for to-guest rx.
Reviewed-by: David Vrabel
David
stead being fragmented in the backend.
Reviewed-by: David Vrabel
David
e().
Suggested-by: Trond Myklebust
Signed-off-by: David Vrabel
---
net/sunrpc/xprtsock.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index bf16883..e72581d 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
On 19/09/16 11:22, Vitaly Kuznetsov wrote:
> David Miller writes:
>
>> From: Vitaly Kuznetsov
>> Date: Fri, 16 Sep 2016 12:59:14 +0200
>>
>>> @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb,
>>> struct net_device *dev)
>>> offset = offset_in_page(skb->data);
>>> le
On 16/09/16 18:06, Trond Myklebust wrote:
>
>> On Sep 16, 2016, at 12:41, David Vrabel wrote:
>>
>> On 16/09/16 17:01, Trond Myklebust wrote:
>>>
>>>> On Sep 16, 2016, at 08:28, David Vrabel wrote:
>>>>
>>>> Write space
On 16/09/16 17:01, Trond Myklebust wrote:
>
>> On Sep 16, 2016, at 08:28, David Vrabel wrote:
>>
>> Write space becoming available may race with putting the task to sleep
>> in xprt_wait_for_buffer_space(). The existing mechanism to avoid the
>> race does not
) (which
is supposed to handle the above race) does not call
xprt_write_space() as the SOCKWQ_ASYNC_NOSPACE bit is clear and
thus the task is not woken.
Fix the race by have xprt_wait_for_buffer_space() check for write
space after putting the task to sleep.
Signed-off-by: David Vrabel
---
at's what
> this patch is trying to achieve with skb_copy().
>
> Signed-off-by: Vitaly Kuznetsov
We should probably fix the backend to handle this (by grant copying a
minimum amount in the linear area, but since netfront needs to work with
older netback.
Acked-by: David Vrabel
David
On 22/08/16 16:42, Vitaly Kuznetsov wrote:
>
> I see two ways to fix the issue:
> - Change the 'wire' protocol between netfront and netback to start keeping
> the original SKB structure. We'll have to add a flag indicating the fact
> that the particular request is a part of the original linear
On 07/07/16 09:00, Jan Beulich wrote:
> ... as being the simpler variant.
It's really annoying that all these related cleanups where not in the
same thread. Don't do this again, please.
The better clean-up is to remove xenbus_write() in favour of
xenbus_printf() everywhere (especially since one o
On 07/07/16 11:35, Wei Liu wrote:
> On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote:
>> On 07/07/16 08:57, Jan Beulich wrote:
>>> Only a positive return value indicates success.
>>
>> This is not correct.
>>
>
> Do you mean the commit
On 07/07/16 08:57, Jan Beulich wrote:
> Only a positive return value indicates success.
This is not correct.
David
On 07/07/16 08:59, Jan Beulich wrote:
> Only a positive return value indicates success.
This checks were already correct.
David
On 07/07/16 08:57, Jan Beulich wrote:
> ... for single items being collected: It is more typesafe (as the
> compiler can check format string and to-be-written-to variable match)
> and requires one less parameter to be passed.
Do not split commit messages between the subject and the body in this
wa
On 20/02/16 01:27, Gonglei wrote:
> It's possible for a race condition to exist between xennet_open() and
> talk_to_netback(). After invoking netfront_probe() then other
> threads or processes invoke xennet_open (such as NetworkManager)
> immediately may trigger BUG_ON(). Besides, we also should re
On 20/02/16 06:00, Gonglei (Arei) wrote:
> Hi,
>
> Thanks for rapid feedback :)
>
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Saturday, February 20, 2016 12:37 PM
>>
>> From: Gonglei
>> Date: Sat, 20 Feb 2016 09:27:26 +0800
>>
>>> It's possible for a race condition to exist betwe
Crossley
Signed-off-by: David Vrabel
---
v2:
- Use bool.
---
drivers/net/xen-netfront.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index d6abf19..96ccd4e 100644
--- a/drivers/net/xen-netfront.c
+++ b
On 22/01/16 14:15, Ian Campbell wrote:
> On Fri, 2016-01-22 at 13:49 +, Wei Liu wrote:
>> On Fri, Jan 22, 2016 at 01:14:24PM +0000, David Vrabel wrote:
>>> On 22/01/16 12:34, Wei Liu wrote:
>>>> The comment at the beginning of the file is the canonical source of
On 22/01/16 12:34, Wei Liu wrote:
> The comment at the beginning of the file is the canonical source of
> licenses for this module. Currently it contains GPL and MIT license. Fix
> the code to reflect the reality.
"The MIT license" isn't really a thing. The closest is the X11
license[1], but this
On 21/10/15 19:57, Marek Marczykowski-Górecki wrote:
>
> Any ideas?
No, sorry. Netfront looks correct to me.
We take an additional ref for the ref released by
gnttab_release_grant_reference(). The get_page() here is safe since we
haven't freed the page yet (this is done in the subsequent call
On 24/10/15 12:55, David Miller wrote:
> From: Paul Durrant
> Date: Wed, 21 Oct 2015 11:36:17 +0100
>
>> This series adds xen-netback support for hash negotiation with a frontend
>> driver, and an implementation of toeplitz hashing as the initial negotiable
>> algorithm.
>
> Ping, I want to see
On 16/10/15 10:05, Wei Liu wrote:
> On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote:
>> I changed patch with valid format.
>>
>> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote:
>>
>>> Since vzalloc can be failed in memory pressure,
>>> writes -ENOMEM to xenstore to indicate error.
>>>
>>
On 14/09/15 22:28, Charles (Chas) Williams wrote:
> The xen store preserves this information across module invocations.
> If you insmod netfront with two queues and later insmod again with one
> queue, the backend will still believe you asked for two queues.
Can you rewrite the commit message to b
On 09/09/15 20:34, David Miller wrote:
> From: David Vrabel
> Date: Tue, 8 Sep 2015 14:25:14 +0100
>
>> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix
>> unlimited guest Rx internal queue and carrier flapping) introduced a
>> regression.
>>
On 10/09/15 11:18, Wei Liu wrote:
> Originally that parameter was always reset to num_online_cpus during
> module initialisation, which renders it useless.
>
> The fix is to only set max_queues to num_online_cpus when user has not
> provided a value.
Reviewed-by: David Vrabel
T
On 09/09/15 20:34, Konrad Rzeszutek Wilk wrote:
> On Tue, Sep 08, 2015 at 02:25:14PM +0100, David Vrabel wrote:
>> Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix
>> unlimited guest Rx internal queue and carrier flapping) introduced a
>> regression.
>>
On 09/09/15 11:23, Wei Liu wrote:
> Originally that parameter was always reset to num_online_cpus during
> module initialisation, which renders it useless.
>
> The fix is to only set max_queues to num_online_cpus when user has not
> provided a value.
Reviewed-by: David Vrabel
nsigned int xenvif_max_queues = 0;
You don't need this.
Otherwise,
Reviewed-by: David Vrabel
Is an equivalent fix needed in netfront?
David
> module_param_named(max_queues, xenvif_max_queues, uint, 0644);
> MODULE_PARM_DESC(max_queues,
>"Maximum numbe
uests.
Signed-off-by: David Vrabel
---
drivers/net/xen-netback/common.h | 10 --
drivers/net/xen-netback/netback.c | 23 ---
2 files changed, 16 insertions(+), 17 deletions(-)
Note that this can only be backported as-is on top of
1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b
ata in small
> chunk of 4KB. The rest of the code is relying on the grant table code.
>
> Note that we allocate a Linux page for each rx skb but only the first
> 4KB is used. We may improve the memory usage by extending the size of
> the rx skb.
Reviewed-by: David Vrabel
David
--
On 07/08/15 17:34, Julien Grall wrote:
> Hi all,
>
> This patch series aims to use the memory terminologies described in
> include/xen/mm.h [1] for Linux xen code.
Applied to for-linus-4.3, thanks.
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a messag
On 10/08/15 14:40, Jason A. Donenfeld wrote:
> It turns out that domU also requires the Xen APIC driver. Otherwise we
> get stuck in busy loops that never exit, such as in this stack trace:
Applied to for-linus-4.2 and tagged for stable, thanks.
David
--
To unsubscribe from this list: send the li
On 10/08/15 14:40, Jason A. Donenfeld wrote:
> It turns out that domU also requires the Xen APIC driver. Otherwise we
> get stuck in busy loops that never exit, such as in this stack trace:
What's the difference between v3 and v2?
David
--
To unsubscribe from this list: send the line "unsubscrib
On 06/08/15 16:58, Jason A. Donenfeld wrote:
> On Thu, Aug 6, 2015 at 12:02 PM, David Vrabel wrote:
>> Linux PV guests must use the "Xen PV" APIC driver. You need to
>> investigate why your PV guest is not using this (although I'm surprised
>> it works at al
On 05/08/15 00:01, Jason A. Donenfeld wrote:
> Hey David,
>
> Sorry for the premature response on my phone earlier. Real reply follows.
>>> rcu_read_lock, when using Xen PV. Relevant excerpts of the
>> ^^ PV guest?
>
> Yes. The lockup occurs on a PV guest. Nothing
On 04/08/15 17:41, Jason A. Donenfeld wrote:
> Hi folks,
>
> Paul McKenney and I had an offline discussion about some rcu questions
> that eventually lead into me investigating a strange full lock-up I'm
> experiencing as a consequence of a printk in softirq inside of an
> rcu_read_lock, when usin
On 29/07/15 12:35, Julien Grall wrote:
> Hi Wei,
>
> On 29/07/15 11:13, Wei Liu wrote:
>> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote:
>> [...]
>>> diff --git a/drivers/net/xen-netback/netback.c
>>> b/drivers/net/xen-netback/netback.c
>>> index 7d50711..3b7b7c3 100644
>>> --- a/d
page_to_gfn. More complex clean up
> will come in follow-up patches.
>
> I think it may be possible to do further clean up in the x86 code to
> ensure that helpers returning machine address (such as virt_address) is
> not used by no auto-translated guests. I will let x86 xen expert d
On 27/06/15 00:17, Liang Li wrote:
> The function netif_set_real_num_tx_queues() will return -EINVAL if
> the second parameter < 1, so call this function with the second
> parameter set to 0 is meaningless.
Reviewed-by: David Vrabel
David
--
To unsubscribe from this list: s
On 17/06/15 15:28, Julien Grall wrote:
> Hi,
>
> Thoses patches was originally part of the Xen 64KB series [1]. Although,
> I think they can go without waiting the rest of the 64KB series.
>
> Patch #1-#4 should go through the Xen tree, even though patch #1 touches
> multiple part.
>
> Patch #5-
On 04/06/15 13:45, Julien Grall wrote:
> On 03/06/15 18:06, Joe Perches wrote:
>> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
>>> rx->status is an int16_t, print it using %d rather than %u in order to
>>> have a meaningful value when the field is negative.
>> []
>>> diff --git a/drivers/
On 29/05/15 17:24, Ian Campbell wrote:
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev)
> kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
> xen_unregister_watchers(b
.
Signed-off-by: David Vrabel
---
drivers/net/xen-netfront.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 3f45afd..e031c94 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
es to delete the
napi instances that have already been freed.
Fix this by fully destroy the queues (which includes deleting the napi
instances) before freeing the netdevice.
Reported-by: Marek Marczykowski
Signed-off-by: David Vrabel
---
drivers/net/xen-netfront.c | 15 ++-
1 fi
On 22/05/15 17:42, Marek Marczykowski-Górecki wrote:
> On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote:
>> On 22/05/15 12:49, Marek Marczykowski-Górecki wrote:
>>> Hi all,
>>>
>>> I'm experiencing xen-netfront crash when doing xl network-detach
On 22/05/15 12:49, Marek Marczykowski-Górecki wrote:
> Hi all,
>
> I'm experiencing xen-netfront crash when doing xl network-detach while
> some network activity is going on at the same time. It happens only when
> domU has more than one vcpu. Not sure if this matters, but the backend
> is in anot
Vrabel
ipg: initialize Rx buffers correctly
A previous patch resulted in the initialization of the Rx buffers
being skipped.
Signed-off-by: David Vrabel <[EMAIL PROTECTED]>
--- linux-source-2.6.16.orig/drivers/net/ipg.c 2006-05-20 21:38:44.604788258
+0100
+++ linux-source-2.6.16/drivers/net
Francois Romieu wrote:
ipg: remove forward declarations
It makes no sense in a new driver.
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
Ack.
ipg: replace #define with enum
Added some underscores to improve readability.
Signed-off-by: Francois
wn. I see Craig
> Rich's email (only email found in the original mail) is out of date so if
> anyone knows how to reach him, please let me know. Thanks!
I think/guess that IC Plus bought out Sundance so you'd need to contact
someone at IC Plus.
David Vrabel
-
To unsubscribe fr
Lennert Buytenhek wrote:
On Mon, May 01, 2006 at 10:38:47PM +0200, Francois Romieu wrote:
-/* Minimum number of miliseconds used to toggle MDC clock during
+/* Minimum number of nanoseconds used to toggle MDC clock during
* MII/GMII register access.
*/
-#define IPG_PC_PHYCTRLWAIT
David Vrabel wrote:
- something (PHY reset/auto negotiation?) takes 2-3 seconds and
appears to be done with interrupts disabled.
It was clocking the MII management interface (MDC) at 500 Hz so each PHY
register access took some 130 ms, and many registers accesses were being
done on
c32_le() instead.
- No more nonsense with root_dev -- ipg_remove() now works.
- Move PHY and MAC address initialization into the ipg_probe(). It was
previously filling in the MAC address on open which breaks some user
space.
- Folded ipg_nic_init into ipg_probe since it was broke otherwise.
Sign
Pekka Enberg wrote:
I ended up doing most of them myself [1]. Sorry :-) Are the datasheets
public by the way?
http://www.icplus.com.tw/Data/Datasheet/IP1000A-DS-R08-07052005.pdf
1. http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch
-
To unsubscribe from this list: send the line
rewriting from scratch based on
the datasheet depending on how horrific the code looks on closer inspection.
Not got a whole lot of time to do this so no timescale for completion...
David Vrabel
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
l before userspace.
In the specific case of the IXP4xx, you presumably have some userspace
available because you've just loaded the NPE firmware from it, yes?
David Vrabel
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ce at getting into the kernel. The above
mentioned bits for eCos/RedBoot would probably be a good starting point.
David Vrabel
ps. It's bad form to CC a subscription-only list. I've trimmed
linux-arm-kernel from the CCs.
--
David Vrabel, Design Engineer
Arcom, Clifton Road T
59 matches
Mail list logo
