Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

2018-10-25 Thread Chas Williams
On 10/25/2018 05:59 PM, Jay Vosburgh wrote: Chas Williams <3ch...@gmail.com> wrote: netif_is_lag_port should be used to identify link aggregation ports. For this to work, we need to reorganize the bonding and team drivers so that the necessary flags are set before dev_open is

Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

2018-10-25 Thread Chas Williams
dev_open is called. commit 31e77c93e432 ("sched/fair: Update blocked load when newly idle") made this decision originally based on the IFF_SLAVE flag which isn't used by the team driver. Note, we do need to retain the IFF_SLAVE check for the eql driver. Signed-off-by: Chas Williams &l

[PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

2018-10-25 Thread Chas Williams
s decision originally based on the IFF_SLAVE flag which isn't used by the team driver. Note, we do need to retain the IFF_SLAVE check for the eql driver. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/bonding/bond_main.c | 4 ++-- drivers/net/team/team.c | 7 +--

Re: [PATCH] team: set IFF_SLAVE on team ports

2018-09-27 Thread Chas Williams
On 07/10/15 02:41, Jiri Pirko wrote: Thu, Jul 09, 2015 at 05:36:55PM CEST, jblu...@infradead.org wrote: On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko wrote: Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAV

[PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-02 Thread Chas Williams
rn of deleting and re-adding an interface to change the vlan id. Signed-off-by: Chas Williams <3ch...@gmail.com> --- include/linux/netdevice.h | 1 + net/8021q/vlan.c | 4 ++-- net/8021q/vlan.h | 2 ++ net/8021q/vlan_netlink.c | 49 +

[PATCH v3,net-next] vlan: implement vlan id and protocol changes

2018-06-25 Thread Chas Williams
vlan_changelink silently ignores attempts to change the vlan id or protocol id of an existing vlan interface. Implement by adding the new vlan id and protocol to the interface's vlan group and then removing the old vlan id and protocol from the vlan group. Signed-off-by: Chas Williams

[PATCH v2 net-next] vlan: implement vlan id and protocol changes

2018-06-11 Thread Chas Williams
vlan_changelink silently ignores attempts to change the vlan id or protocol id of an existing vlan interface. Implement by adding the new vlan id and protocol to the interface's vlan group and then removing the old vlan id and protocol from the vlan group. Signed-off-by: Chas Williams

[PATCH net-next] vlan: implement vlan id and protocol changes

2018-06-10 Thread Chas Williams
From: "Charles (Chas) Williams" vlan_changelink silently ignores attempts to change the vlan id or protocol id of an existing vlan interface. Implement by adding the new vlan id and protocol to the interface's vlan group and then removing the old vlan id and protocol from

[PATCH net-next] Allow ethtool to change tun link settings

2018-06-02 Thread Chas Williams
Let user space set whatever it would like to advertise for the tun interface. Preserve the existing defaults. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/tun.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-03 Thread Chas Williams
On Tue, Apr 3, 2018 at 2:13 AM, Roopa Prabhu wrote: > On Mon, Apr 2, 2018 at 8:26 AM, Chas Williams <3ch...@gmail.com> wrote: >> On Mon, Apr 2, 2018 at 11:08 AM, Roopa Prabhu >> wrote: >>> > > [snip] > >>> they are popular...in-fact they are the

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-02 Thread Chas Williams
On Mon, Apr 2, 2018 at 11:08 AM, Roopa Prabhu wrote: > On Fri, Mar 30, 2018 at 12:54 PM, Chas Williams <3ch...@gmail.com> wrote: >> On Thu, Mar 29, 2018 at 9:02 PM, Toshiaki Makita >> wrote: >>> On 2018/03/30 1:49, Roopa Prabhu wrote: >>>> On

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-03-30 Thread Chas Williams
On Thu, Mar 29, 2018 at 9:02 PM, Toshiaki Makita wrote: > On 2018/03/30 1:49, Roopa Prabhu wrote: >> On Thu, Mar 22, 2018 at 9:53 PM, Roopa Prabhu >> wrote: >>> On Thu, Mar 22, 2018 at 8:34 AM, Chas Williams <3ch...@gmail.com> wrote: >>>> If the bridge

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-03-23 Thread Chas Williams
On Fri, Mar 23, 2018 at 12:20 PM, Nikolay Aleksandrov wrote: > On 23/03/18 18:17, David Miller wrote: >> From: Chas Williams <3ch...@gmail.com> >> Date: Thu, 22 Mar 2018 11:34:06 -0400 >> >>> If the bridge is allowing multiple VLANs, some VLANs may have >

[PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-03-22 Thread Chas Williams
VLANS. Signed-off-by: Chas Williams <3ch...@gmail.com> --- net/bridge/br.c | 2 +- net/bridge/br_device.c | 2 +- net/bridge/br_if.c | 26 ++ net/bridge/br_private.h | 2 +- 4 files changed, 25 insertions(+), 7 deletions(-) diff --git a/net/bridge/

Re: net/atm: warning in alloc_tx/__might_sleep

2017-03-14 Thread Chas Williams
On Mon, 2017-03-13 at 18:43 +0100, Andrey Konovalov wrote: > On Thu, Jan 12, 2017 at 11:40 AM, Chas Williams <3ch...@gmail.com> wrote: > > On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: > >> On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > >> > On

[Patch net-next] atm: remove an unnecessary loop

2017-03-11 Thread Chas Williams
ported-by: Andrey Konovalov Reviewed-and-Tested-by: Chas Williams <3ch...@gmail.com> Signed-off-by: Chas Williams <3ch...@gmail.com> --- net/atm/common.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/net/atm/common.c b/net/atm/common.c inde

Re: [Patch net] atm: remove an unnecessary loop

2017-01-14 Thread Chas Williams
On Fri, 2017-01-13 at 16:30 -0800, Cong Wang wrote: > On Fri, Jan 13, 2017 at 3:54 PM, Chas Williams <3ch...@gmail.com> wrote: > > On Fri, 2017-01-13 at 10:20 -0800, Cong Wang wrote: > >> On Fri, Jan 13, 2017 at 9:10 AM, David Miller wrote: > >> > From: Franc

Re: [Patch net] atm: remove an unnecessary loop

2017-01-13 Thread Chas Williams
On Fri, 2017-01-13 at 10:20 -0800, Cong Wang wrote: > On Fri, Jan 13, 2017 at 9:10 AM, David Miller wrote: > > From: Francois Romieu > > Date: Fri, 13 Jan 2017 01:07:00 +0100 > > > >> Were alloc_skb moved one level up in the call stack, there would be > >> no need to use the new wait api in the s

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-12 Thread Chas Williams
On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: > On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > > On Wed 11-01-17 20:45:25, Michal Hocko wrote: > >> On Wed 11-01-17 09:37:06, Chas Williams wrote: > >> > On Mon, 2017-01-09 at 18:20 +0100, Andre

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Chas Williams
On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). > > A reproducer is attached. > > [ cut here ] > WARNING: CPU:

4.4 Backport request 4d06dd537f95 cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-07-19 Thread Chas Williams
Can 4d06dd537f95 cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind be added to 4.4 stable?  This fixes CVE-2016-3951 [The second half necessary for a complete fix, 666984c8625 ("usbnet: cleanup after bind() in probe()"), is already present in 4.4.] Thanks!

[PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address

2016-01-05 Thread Chas Williams
When running certain routing protocols like VRRP, VF guests need the ability to set the unicast address of the interface. Extend the new ndo trust feature to let the hypervisor trust a guest to set/update its own unicast address. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drive

[PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address

2016-01-01 Thread Chas Williams
When running certain routing protocols like VRRP, VF guests need the ability to set the unicast address of the interface. Extend the new ndo trust feature to let the hypervisor trust a guest to set/update its own unicast address. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drive

[PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address

2015-12-31 Thread Chas Williams
When running certain routing protocols like VRRP, VF guests need the ability to set the unicast address of the interface. Extend the new ndo trust feature to let the hypervisor trust a guest to set/update its own unicast address. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drive

Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-03 Thread Charles (Chas) Williams
On Thu, 2015-12-03 at 13:58 +0100, LABBE Corentin wrote: > On Thu, Dec 03, 2015 at 06:26:31AM -0500, Charles (Chas) Williams wrote: > > On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote: > > > @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, >

Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

2015-12-03 Thread Charles (Chas) Williams
On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote: > @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, int > port, struct sk_buff *skb > if (!str) > return -EIO; > > - ver = simple_strtol(str, NULL, 10); > - if (ver < 1) { > + err = ks

Re: [PATCH -stable] multiple backports requested

2015-11-15 Thread Charles (Chas) Williams
On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: > From: "Charles (Chas) Williams" <3ch...@gmail.com> > Date: Fri, 13 Nov 2015 15:13:11 -0500 > > > Dave, could you please add the following backports? > > > > For the 3.14.y stable queue:

Re: [PATCH -stable] multiple backports requested

2015-11-14 Thread Charles (Chas) Williams
On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: > From: "Charles (Chas) Williams" <3ch...@gmail.com> > Date: Fri, 13 Nov 2015 15:13:11 -0500 > > > Dave, could you please add the following backports? > > > > For the 3.14.y stable queue:

[PATCH -stable] multiple backports requested

2015-11-13 Thread Charles (Chas) Williams
Dave, could you please add the following backports? For the 3.14.y stable queue: commit 77751427a1ff25b27d47a4c36b12c3c8667855ac ipv6: addrconf: validate new MTU before applying it This addresses CVE-2015-0272 commit 74e98eb085889b0d2d4908f59f6e00026063014f

[PATCH -stable] virtio-net: drop NETIF_F_FRAGLIST

2015-11-10 Thread Charles (Chas) Williams
Dave, could you please add commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39 virtio-net: drop NETIF_F_FRAGLIST to your stable queues for 3.14.y and 4.1.y? This fixes CVE-2015-5156, https://security-tracker.debian.org/tracker/CVE-2015-5156 -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-12 Thread Charles (Chas) Williams
On Sat, 2015-10-10 at 21:47 +0200, Tillmann Heidsieck wrote: > this series fixes two of them. The if(); warning would require > restructuring the code to a larger extend. Beyond this there remains a > whooping number of > 2k checkpatch.pl warnings and errors each. Those > can be grouped into ... >

Request for stable-4.1.y stable inclusion

2015-10-05 Thread Charles (Chas) Williams
Hello Dave, Could you please backport the following to stable-4.1.y: commit 74e98eb085889b0d2d4908f59f6e00026063014f -- RDS: verify the underlying transport exists before creating a connection This fixes CVE-2015-6937. commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5

Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist'

2015-09-30 Thread Charles (Chas) Williams
On Wed, 2015-09-30 at 13:26 +0200, Arnd Bergmann wrote: > The zatm_t_hist structure is not used anywhere in the kernel, but is > exported to user space. As we are trying to eliminate uses of time_t > in the kernel for y2038 compatibility, the current definition triggers > checking tools because it

[linux 3.14-stable] ipv6: addrconf: validate new MTU before applying it

2015-09-29 Thread Charles (Chas) Williams
S. Miller Signed-off-by: Chas Williams <3ch...@gmail.com> --- net/ipv6/addrconf.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 3f0ec06..7b74fca 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrc

[linux 3.14-stable] virtio-net: drop NETIF_F_FRAGLIST

2015-09-29 Thread Charles (Chas) Williams
sgvec overflow the sg array, leading to memory corruption. Drop NETIF_F_FRAGLIST so we only get what we can handle. Fixes CVE-2015-5156. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Acked-by: Michael S. Tsirkin Signed-off-by: David S. Miller Signed-off-by: Chas Williams <3ch...@g

[linux 3.14-stable] RDS: verify the underlying transport exists before creating a connection

2015-09-29 Thread Charles (Chas) Williams
imkar Signed-off-by: Sasha Levin Signed-off-by: David S. Miller Signed-off-by: Chas Williams <3ch...@gmail.com> --- net/rds/connection.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/rds/connection.c b/net/rds/connection.c index 378c3a6..f5fb7d6 100644 --- a/net/rds/connect

[PATCH net-next v2] xen-netfront: always set num queues if possible

2015-09-16 Thread Charles (Chas) Williams
: Chas Williams <3ch...@gmail.com> --- drivers/net/xen-netfront.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index f821a97..9bf63c2 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netf

[PATCH net-next] xen-netfront: always set num queues if possible

2015-09-15 Thread Charles (Chas) Williams
: Chas Williams <3ch...@gmail.com> --- drivers/net/xen-netfront.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index f821a97..7f8b7bd 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netf

Re: [Xen-devel] [PATCH net-next] xen-netfront: always set num queues if possible

2015-09-15 Thread Charles (Chas) Williams
On Tue, 2015-09-15 at 11:59 +0100, David Vrabel wrote: > On 14/09/15 22:28, Charles (Chas) Williams wrote: > > The xen store preserves this information across module invocations. > > If you insmod netfront with two queues and later insmod again with one > > queue, the backe

[PATCH net-next] xen-netfront: always set num queues if possible

2015-09-14 Thread Charles (Chas) Williams
The xen store preserves this information across module invocations. If you insmod netfront with two queues and later insmod again with one queue, the backend will still believe you asked for two queues. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/xen-netfront.

[PATCH net-next] net/xen-netfront: only napi_synchronize() if running

2015-08-27 Thread Charles (Chas) Williams
From: Chas Williams <3ch...@gmail.com> If an interface isn't running napi_synchronize() will hang forever. [ 392.248403] rmmod R running task0 359343 0x [ 392.257671] 88003760fc88 880037193b40 880037193160 88003760fc88 [

xen-netfront: bug with napi_synchronize()

2015-08-20 Thread Charles (Chas) Williams
I have seen some hangs in recent versions of the xen-netfront driver. If I unload or unbind the driver immediately befor bringing up the interface, I get a hang as show in the traceback here. ... [ 194.037351] [] ? msleep+0x27/0x30 [ 194.037358] [] ? xennet_disconnect_backend+0xfa/0x390 [xen

[PATCH net-next] net/xen-netfront: only clean up queues if present

2015-08-19 Thread Charles (Chas) Williams
From: Chas Williams <3ch...@gmail.com> If you simply load and unload the module without starting the interfaces, the queues are never created and you get a bad pointer dereference. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/xen-netfront.c | 5 +++-- 1 fil

Re: converting fore200e driver to use request_firmware()

2008-02-07 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >> however, i ran into a little problem with the sbus interface. what should >> i pass for 'struct device *' for an sbus device? > >"&sdev->ofdev.dev" should work thanks! that is what i needed. so what i have works on pci and is quite a bit cl

converting fore200e driver to use request_firmware()

2008-02-06 Thread chas williams - CONTRACTOR
however, i ran into a little problem with the sbus interface. what should i pass for 'struct device *' for an sbus device? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2008-01-30 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,"Chung- Chi Lo" writes: >> + } else { /* vc-mux */ >> + if (brdev->payload == p_routed) { > >add line > > skb->protocol = __constant_htons(ETH_P_IP); > >here just like LLC did? > >> + skb_reset_network_he

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2008-01-26 Thread chas williams - CONTRACTOR
his routed mode patch doesn't include encaps=VCMUX and >RFC2684 routed >protocol decapsulation? yep. eric believes the following should fix both problems: commit 43e4b025ffe130cd6a292fa9ff909e39a88f849c Author: Chas Williams - CONTRACTOR <[EMAIL PROTECTED]> Date: Sat Jan 26 07:1

[PATCH net-2.6.24][ATM]: [nicstar] delay irq setup until card is configured

2008-01-04 Thread chas williams - CONTRACTOR
if an interrupt occurs too soon, the driver oops while trying to handle a shortage of buffers condition (caused by no buffers having been allocated yet). commit a3322d3d34854edf27f7950efaa93e68f5f71ace Author: Chas Williams - CONTRACTOR <[EMAIL PROTECTED]> Date: Fri Jan 4 16:27:07 2008

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2007-12-31 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,Christoph Hellwig writes: >> +#define LLC 0xaa, 0xaa, 0x03 >> +#define SNAP_BRIDGED0x00, 0x80, 0xc2 >> +#define SNAP_ROUTED 0x00, 0x00, 0x00 >> +#define PID_ETHERNET0x00, 0x07 >> +#define ETHERTYPE_IPV4 0x08, 0x00 >> +#define ETHERTYPE_IPV

[PATCH net-2.6.25 7/7][ATM]: [he] fixing compilation when you define USE_RBPS_POOL/USE_RBPL_POOL

2007-12-29 Thread chas williams - CONTRACTOR
commit 62024377f1da8a3f5b49cfd60d892c778f5a5741 Author: Jorge Boncompte <[EMAIL PROTECTED]> Date: Thu Dec 13 16:14:40 2007 -0500 [ATM]: [he] fixing compilation when you define USE_RBPS_POOL/USE_RBPL_POOL Signed-off-by: Jorge Boncompte <[EMAIL PROTECTED]> Signed-

[PATCH net-2.6.25 5/7][ATM]: [br2864] whitespace cleanup

2007-12-29 Thread chas williams - CONTRACTOR
commit 6b11f93a718dc916198feb1099ae0cef39ce3936 Author: Chas Williams <[EMAIL PROTECTED]> Date: Sat Oct 27 08:33:40 2007 -0400 [ATM]: [br2864] whitespace cleanup Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --git a/include/linux/atmbr2684.h b/include/linux

[PATCH net-2.6.25 6/7][ATM]: [ambassador] kmalloc + memset conversion to kzalloc

2007-12-29 Thread chas williams - CONTRACTOR
commit 87c1811be8f1c6587ed3b57d23f93c7e91afdde7 Author: Joonwoo Park <[EMAIL PROTECTED]> Date: Tue Nov 27 09:43:04 2007 -0500 [ATM]: [ambassador] kmalloc + memset conversion to kzalloc Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Signed-off-by: Chas Will

[PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2007-12-29 Thread chas williams - CONTRACTOR
commit fea6b121bcc150fc91186e5012466c91944ce64d Author: Eric Kinzie <[EMAIL PROTECTED]> Date: Fri Oct 26 08:05:08 2007 -0400 [ATM]: [br2864] routed support From: Eric Kinzie <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --g

[PATCH net-2.6.25 3/7][ATM]: [he] This patch removes the ancient version string.

2007-12-29 Thread chas williams - CONTRACTOR
commit 41d6b7e20dd6d57bec4f14697f654c8211ff5d57 Author: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri Oct 26 07:29:47 2007 -0400 [ATM]: [he] This patch removes the ancient version string. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[

[PATCH net-2.6.25 2/7][ATM]: Convert struct class_device to struct device

2007-12-29 Thread chas williams - CONTRACTOR
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 9ef07ed..1b88311 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -9,13 +9,15 @@ #define to_atm

[PATCH net-2.6.25 1/7][ATM]: atm is no longer experimental

2007-12-29 Thread chas williams - CONTRACTOR
commit f57512af6142cf14bd15012c4c627f9ebef0582a Author: Robert P. J. Day <[EMAIL PROTECTED]> Date: Fri Oct 26 07:27:07 2007 -0400 [ATM]: atm is no longer experimental From: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]>

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-27 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,"Rober t P. J. Day" writes: >> > in any event, i just thought i'd point it out. if you're absolutely >> > sure there will never be another call to setup_dev() from somewhere >> > else, then, yes, it's safe. >> >> I understood your opinions. and partially agree with y

[PATCH 1/1][ATM]: [he] initialize lock and tasklet earlier

2007-11-26 Thread chas williams - CONTRACTOR
if you are lucky (unlucky?) enough to have shared interrupts, the interrupt handler can be called before the tasklet and lock are ready for use. commit 44b3e82778b0edf73147529c8b1c115d241a6a4d Author: chas williams - CONTRACTOR <[EMAIL PROTECTED]> Date: Mon Nov 26 11:30:33 2007 -0500

[PATCH 4/5][ATM]: [br2864] routed support

2007-10-27 Thread chas williams - CONTRACTOR
commit fea6b121bcc150fc91186e5012466c91944ce64d Author: Eric Kinzie <[EMAIL PROTECTED]> Date: Fri Oct 26 08:05:08 2007 -0400 [ATM]: [br2864] routed support From: Eric Kinzie <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --g

[PATCH 1/5][ATM]: atm is no longer experimental

2007-10-27 Thread chas williams - CONTRACTOR
commit f57512af6142cf14bd15012c4c627f9ebef0582a Author: Robert P. J. Day <[EMAIL PROTECTED]> Date: Fri Oct 26 07:27:07 2007 -0400 [ATM]: atm is no longer experimental From: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]>

[PATCH 2/5][ATM]: Convert struct class_device to struct device

2007-10-27 Thread chas williams - CONTRACTOR
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 9ef07ed..1b88311 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -9,13 +9,15 @@ #define to_atm

[PATCH 3/5][ATM]: [he] This patch removes the ancient version string.

2007-10-27 Thread chas williams - CONTRACTOR
commit 41d6b7e20dd6d57bec4f14697f654c8211ff5d57 Author: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri Oct 26 07:29:47 2007 -0400 [ATM]: [he] This patch removes the ancient version string. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[

[PATCH 5/5][ATM]: [br2864] whitespace cleanup

2007-10-27 Thread chas williams - CONTRACTOR
commit 6b11f93a718dc916198feb1099ae0cef39ce3936 Author: Chas Williams <[EMAIL PROTECTED]> Date: Sat Oct 27 08:33:40 2007 -0400 [ATM]: [br2864] whitespace cleanup Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --git a/include/linux/atmbr2684.h b/include/linux

Re: [PATCH 4/7][ATM]: [lanai] change VENDOR to DEVICE

2007-07-16 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >Because of this and the sch_atm.c rejects, I guess you're >not generating these patches against Linus's current tree. i was working against your net-2.6 tree. i will checkout the linus tree and check before submitting patches. - To unsubscribe

[PATCH 6/7][ATM]: [drivers] ioremap balanced with iounmap

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: [drivers] ioremap balanced with iounmap Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit 15fa4d7e8fda822d42bc202fe390b52309ee9d86 tree bb741ef4aba074d449f6199522f746a64c3ab244 parent 9b3515b17a74eff9aad7409dd64888cf0cd

[PATCH 7/7][ATM]: [idt77252] Rename CONFIG_ATM_IDT77252_SEND_IDLE to not resemble a Kconfig variable

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: [idt77252] Rename CONFIG_ATM_IDT77252_SEND_IDLE to not resemble a Kconfig variable Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit c6023af8babdaefc46d8ac7e3293f4bb87537422 tree f9aaecd241f8263b58caa6929f8b8400222

[PATCH 4/7][ATM]: [lanai] change VENDOR to DEVICE

2007-07-16 Thread chas williams - CONTRACTOR
MAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit b7560ad591d64544359766df2f2c687e9e65 tree fc9f8bdd2bf0f16de90cf9576220cff586ce4d8b parent e9e4b3e9524fd445fcc06f56678a6b7f3d1d5f3a author Jiri Slaby <[EMAIL PROTECTED]> Wed, 11 Jul 2007 12:26:48

[PATCH 2/7][ATM]: Eliminate dead config variable CONFIG_BR2684_FAST_TRANS.

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: Eliminate dead config variable CONFIG_BR2684_FAST_TRANS. From: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit 6bab08f73e2c24665a523f15a4ebe4002be38a91 tree 2c6d28e064934b097f37b3b766900b7bb77

[PATCH 1/7][ATM]: Replacing kmalloc/memset combination with kzalloc.

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: Replacing kmalloc/memset combination with kzalloc. Signed-off-by: vignesh babu <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit ffc2850a65ef863fe52650e5e1bc7ac3e098bbb8 tree 1e66e6f29dbda236b826cfdd6ce1b053d15

[PATCH 5/7][ATM]: [lanai] sram_test_word() must be __devinit

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: [lanai] sram_test_word() must be __devinit Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit 9b3515b17a74eff9aad7409dd64888cf0cd03d4d tree 6b10b2df62cd24cfc86558c70ecc761e5bcaf724 parent b7560ad591d64544359766df

[PATCH 3/7][ATM]: [nicstar] Replace C code with call to ARRAY_SIZE() macro.

2007-07-16 Thread chas williams - CONTRACTOR
[ATM]: [nicstar] Replace C code with call to ARRAY_SIZE() macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: chas williams <[EMAIL PROTECTED]> --- commit e9e4b3e9524fd445fcc06f56678a6b7f3d1d5f3a tree 7edafbabdafaad229fb728c1c74e6bca60a

Re: [PATCH] Introduce BROKEN_ON_64BIT facility

2006-10-02 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,Jeff Garzik writes: >Several driver have been marked as dependent on CONFIG_32BIT in the >past, when they should really be dependent on this new >CONFIG_BROKEN_ON_64BIT option, because the 32BIT marker was due to bugs >rather than fundamentals. some of the drivers in

Re: ATM firestream bug

2006-10-01 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,Jeff Garzik writes: >1) not safe on 64-bit firestream is not the only driver that's likely 32-bit safe only. zatm, nicstar, horizon and ambassdor all use virt_to_bus(). >2) variable 'tmc0' is indeed potentially used uninit'd, in particular if >make_rate() returns a

Re: ATM bug found

2006-10-01 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,Mitchell Blank Jr writes: >The fix is for alloc_shaper() should really do "*pcr = ATM_MAX_PCR" in >the "if (ubr)" stanza. Chas, want to submit that in the next batch >of patches? i dont think you can do that. pcr gets assigned to .min_pcr and .min_pcr = ATM_MAX_PCR

[PATCH 3/3][ATM]: [zatm] always *pcr in alloc_shaper()

2006-10-01 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [zatm] always *pcr in alloc_shaper() Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit ae0e261f74750f57c963349f5c09c8057d5eee32 tree 5e9358ef3fd7d00e3be7a1862afa62a6852c8cb6 parent d7b1207f84d681df2e46c6f22ca153eb7f0944cb autho

[PATCH 2/3][ATM]: [ambassador] Change the return type to reflect reality

2006-10-01 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [ambassador] Change the return type to reflect reality Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit d7b1207f84d681df2e46c6f22ca153eb7f0944cb tree 9204a7e7f6812bd683a0079a9a91

[PATCH 1/3][ATM]: kmalloc to kzalloc patches for drivers/atm

2006-10-01 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: kmalloc to kzalloc patches for drivers/atm Signed-off-by: Om Narasimhan <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 339d365266211690a446773e3eb9d864637a71bb tree d48530e7ba716797687d2831f0f5148cda4

Re: ATM bug found

2006-10-01 Thread chas williams - CONTRACTOR
max_pcr = 0 means "best effort". still generates a warning from gcc though. [ATM]: [zatm] always *pcr in alloc_shaper() Signed-off-by: Chas Williams <[EMAIL PROTECTED]> diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index c491ec4..083c5d3 100644 --- a/drivers/atm/zatm.c

[PATCH 8/8][ATM]: [lec] use refcnt to protect lec_arp_entries outside lock

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] use refcnt to protect lec_arp_entries outside lock Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 74391472d01cdd483714b807c9417a0279ed75d5 tree a191d09973b569f0562d9d433c324bbe80a08560

[PATCH 7/8][ATM]: [lec] add reference counting to lec_arp entries

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] add reference counting to lec_arp entries Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 397725689277192a899da4009cd078bab8f6ee2d tree 3bba44e1549229947ed332bb6263c704cabd55c7 parent 0152dcfb9d42e203ff26d1619158c9664cfbf2d9

[PATCH 6/8][ATM]: [lec] use work queue instead of timer for lec arp expiry

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] use work queue instead of timer for lec arp expiry Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 0152dcfb9d42e203ff26d1619158c9664cfbf2d9 tree 24d0a36e52e7d4e86dd7bf1422ae9948011a194d

[PATCH 5/8][ATM]: [lec] old_close is no longer used

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] old_close is no longer used Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 693b186c2a764f62e017db4b7ed39298831d99e8 tree d054ccd10917693803070634a21481b09361b126 parent cf14c654bcb812dae6ed85075777a19e1e02bee1 author chas wi

[PATCH 4/8][ATM]: [lec] convert lec_arp_table to hlist

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] convert lec_arp_table to hlist Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit cf14c654bcb812dae6ed85075777a19e1e02bee1 tree d01bc707baf050862e676e5609081ba1cc22aca1 parent ad9e9d30230b99dd41921b61a506c41e168e1a84 autho

[PATCH 3/8][ATM]: [lec] header indent, comment and whitespace cleanup

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] header indent, comment and whitespace cleanup Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit ad9e9d30230b99dd41921b61a506c41e168e1a84 tree cc1e31605aaf3d473c4f3c8e26d9a1f9b98e72b7 parent 55300d040155e883eb8d3dd39d381c9508

Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-25 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >Chas, as a subsystem maintainer, if you change a submitter's patch in >a significant and non-trivial way, you should at least mention a brief >reason why you did that. In this case, why did you delete all of >Roland's __init/__devinit transforma

[RFC] indenting/whitespace/comment clean for lane client

2006-09-19 Thread chas williams - CONTRACTOR
its rather big (4000+ lines) so i am posting a url here instead. this reduces net/atm/lec.c by about 17k. ftp://ftp.cmf.nrl.navy.mil/pub/chas/netdev/lec-cleanup-diff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[PATCH 3/3][ATM]: potential NULL pointer dereference in clip_mkip()

2006-09-16 Thread chas williams - CONTRACTOR
TED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 87409562aeed5fb2b85dc2f9bddca0a1bbde8c37 tree 0885b8bd2b8881201de422877abd8979861c44de parent fc6b6284e9383bd8d9fd95210fbc5e3c54ccc65d author chas williams - CONTRACTOR <[EMAIL PROTECTED]> Sat, 16 Sep 2006 15:55:01 -0

[PATCH 2/3][ATM]: [he] don't hold the device lock when upcalling

2006-09-16 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [he] don't hold the device lock when upcalling This can create a deadlock/lock ordering problem with other layers that want to use the transmit (or other) path of the card at that time. Signed-off-by: Chas Williams <[EMAIL PROTECTED]>

[PATCH 1/3][ATM]: [he] he_init_one() is declared __devinit, but calls __init functions

2006-09-16 Thread chas williams - CONTRACTOR
leads to WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (at offset 0x2130) and 'he_service_tbrq' Fix this by changing the __init functions to __devinit. Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> Signed-off

[PATCH 2/2][ATM]: proper prototypes in net/atm/mpc.h (and reduce ifdef clutter)

2006-09-07 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: proper prototypes in net/atm/mpc.h (and reduce ifdef clutter) Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 0d60b74cf4354672e4586ca2bedde6695

[PATCH 1/2][ATM]: Move linux/device.h include in linux/atmdev.h to #ifdef __KERNEL__ section

2006-09-07 Thread chas williams - CONTRACTOR
when building iproute2. Signed-off-by: Ismail Donmez <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 0293994f3f7a3a4bc4db6e286473e9b422b8f582 tree b8b24f8e3025e23dbeb61dc101ca1f35f8efaf8e parent 837a0955d484497fc6b0b1991d9cf77fb74f15e8 author chas williams

[PATCH 1/1][ATM]: [he] when transmit fails, unmap the dma regions

2006-09-07 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [he] when transmit fails, unmap the dma regions Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit e2c84ae30cb2dca23afb5e811c108e235f941c3d tree a4acb86e2e10baa5ac651e566a550e0af0c55507 parent 0d60b74cf4354672e4586ca2bedde6695db43165

Re: [PATCH] clear skb cb on IP input

2006-07-16 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >From: Herbert Xu <[EMAIL PROTECTED]> >> At least this lets us get rid of a few other memsets :) >> >Applied, good spotting :-) I remember when we added those >things. > >But I'm beginning to think that the onus of this may in fact fall upon >th

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-14 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >From: Christoph Hellwig <[EMAIL PROTECTED]> >Date: Thu, 13 Jul 2006 22:36:16 +0200 >> - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c: >> These use private skb queues and do odd things. I can't see >> any point for usi

[PATCH 1/2][ATM]: Typo in drivers/atm/Kconfig...

2006-07-07 Thread chas williams - CONTRACTOR
99740 parent d0cddc7d78816bf6ceae9730eb51d78a73a62c15 author chas williams <[EMAIL PROTECTED]> Thu, 06 Jul 2006 12:38:03 -0400 committer chas williams <[EMAIL PROTECTED]> Thu, 06 Jul 2006 12:38:03 -0400 drivers/atm/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/a

[PATCH 2/2][ATM]: fix possible recursive locking in skb_migrate()

2006-07-07 Thread chas williams - CONTRACTOR
address of the skb.. it's not pretty but it's the best this can do in a minimally invasive way. Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit c895a2f42057801ca096f5155e85bc2b2f381250 tree ee64100fdd0302fe5c12ce6c1

[PATCH 1/4][ATM]: [idt77105] should be __devinit not __init

2006-06-28 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [idt77105] should be __devinit not __init Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 51403ade3cedfc85f1f41d81cb3a227f9ce2366f tree f9cf0143466de92eda0080e27240d4b53c130c18 parent 982703b5b38b314081d79ebc657fc06b1b6fe6b6 autho

[PATCH 4/4][ATM]: basic sysfs support for ATM devices

2006-06-28 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: basic sysfs support for ATM devices From: Roman Kagan <[EMAIL PROTECTED]> Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 034e4008acda89bc2422541e077f2dbfd530b717 tree e528e0e6f2d69c729f2daf6618df22133b3

[PATCH 3/4][ATM]: [suni] change suni_init to __devinit

2006-06-28 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [suni] change suni_init to __devinit Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 4768199f3a5582378164820cc74251e485a01292 tree fd27293baebffd029ae53a6efe18913cfb68cada parent 3d63ef0340a7f49a72f5eaa33f08b38fa78d48e1 autho

[PATCH 2/4][ATM]: [iphase] should be __devinit not __init

2006-06-28 Thread chas williams - CONTRACTOR
please consider for 2.6.18 -- thanks! [ATM]: [iphase] should be __devinit not __init Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit a6d3f9a19cc29d6ece38f057eb896c16a4372129 tree 109e40a1fb873f0105bb75ecf21456f25b1756ef parent 51403ade3cedfc85f1f41d81cb3a227f9ce2366f autho

  1   2   >