[PATCH net v2] vxlan: don't allow overwrite of config src addr

2017-02-24 Thread Brian Russell
ookup.") Signed-off-by: Brian Russell Acked-by: Jiri Benc --- drivers/net/vxlan.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 556953f..2e05129 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2035

[PATCH net] vxlan: don't allow overwrite of config src addr

2017-02-20 Thread Brian Russell
desired, the source address must be passed as any. The overwrite breaks this for subsequent lookups. Avoid this by copying the configured address to an existing stack variable and pass a pointer to that instead. Signed-off-by: Brian Russell --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2

[PATCH net] Don't allow overwrite of config src addr

2017-02-20 Thread Brian Russell
desired, the source address must be passed as any. The overwrite breaks this for subsequent lookups. Avoid this by copying the configured address to an existing stack variable and pass a pointer to that instead. Signed-off-by: Brian Russell --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2

Re: [PATCH net-next v3 2/3] nsh: logging module

2016-03-04 Thread Brian Russell
On 01/03/16 18:25, Joe Perches wrote: > On Tue, 2016-03-01 at 11:11 +0000, Brian Russell wrote: >> Module can register for Type 1 or specified classes of Type 2 metadata >> and will then log incoming matching packets. > > This logging mechanism seems like a way to fill/DoS

Re: [PATCH net-next v3 0/3] NSH and VxLAN-GPE

2016-03-04 Thread Brian Russell
On 01/03/16 18:12, Alexei Starovoitov wrote: > On Tue, Mar 01, 2016 at 11:11:46AM +0000, Brian Russell wrote: >> These patches add a new module to support encap/decap of Network >> Service Header (NSH) as defined in: >> >> https://urldefense.pr

[PATCH net-next v3 1/3] nsh: encapsulation module

2016-03-01 Thread Brian Russell
Support encap/decap of Network Service Header (NSH) as defined in https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 Includes support for Type 1 and Type 2 metadata and a simple registration for listeners to see decapsulated packets based on the Type/Class. Signed-off-by: Brian Russell

[PATCH net-next v3 3/3] nsh: netfilter target

2016-03-01 Thread Brian Russell
Add an NSH netfilter target, to add NSH encap'd metadata to outgoing packets. Signed-off-by: Brian Russell --- include/uapi/linux/netfilter/xt_NSH.h | 25 + net/netfilter/Kconfig | 9 net/netfilter/Makefile| 1 + net/netfilter/xt_

[PATCH net-next v3 0/3] NSH and VxLAN-GPE

2016-03-01 Thread Brian Russell
e added the NSH logging module to illustrate the use of the simple mechanism to register for incoming decap'd NSH metadata. I've added the NSH netfilter target to illustrate metadata being NSH encap'd. Brian Russell (3): nsh: encapsulation module nsh: logging module nsh: netfil

[PATCH net-next v3 2/3] nsh: logging module

2016-03-01 Thread Brian Russell
Module can register for Type 1 or specified classes of Type 2 metadata and will then log incoming matching packets. Signed-off-by: Brian Russell --- net/ipv4/Kconfig | 8 net/ipv4/Makefile | 1 + net/ipv4/nsh_log.c | 135 + 3 files

Re: [PATCH net-next v2 1/2] nsh: encapsulation module

2016-03-01 Thread Brian Russell
On 15/02/16 17:01, Jiri Benc wrote: > On Thu, 11 Feb 2016 19:57:05 +0000, Brian Russell wrote: >> --- /dev/null >> +++ b/net/ipv4/nsh.c >> @@ -0,0 +1,365 @@ >> +/* >> + * Network Service Header (NSH) inserted onto encapsulated packets >> + * or frames to rea

Re: [PATCH net-next v2 1/2] nsh: encapsulation module

2016-03-01 Thread Brian Russell
On 17/02/16 03:31, Alexei Starovoitov wrote: > On Thu, Feb 11, 2016 at 07:57:05PM +0000, Brian Russell wrote: >> Support encap/decap of Network Service Header (NSH) as defined in >> https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dsfc-2Dnsh-

Re: [PATCH net-next v2 2/2] vxlan: support GPE/NSH

2016-03-01 Thread Brian Russell
On 15/02/16 16:49, Jiri Benc wrote: > On Thu, 11 Feb 2016 19:57:06 +0000, Brian Russell wrote: >> +skip_l2: >> skb_reset_network_header(skb); >> + >> /* In flow-based mode, GBP is carried in dst_metadata */ >> -if (!(vs->flags & VXLAN_F_CO

[PATCH net-next v2 0/2] NSH and VxLAN-GPE

2016-02-11 Thread Brian Russell
type vxlan" command. v2 - fix copyright notices and tidy up use of types Brian Russell (2): nsh: encapsulation module vxlan: support GPE/NSH drivers/net/vxlan.c | 139 ++-- include/net/nsh.h | 161 +++ include/net/vxlan.h | 40

[PATCH net-next v2 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
Support encap/decap of Network Service Header (NSH) as defined in https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 Includes support for Type 1 and Type 2 metadata and a simple registration for listeners to see decapsulated packets based on the Type/Class. Signed-off-by: Brian Russell

[PATCH net-next v2 2/2] vxlan: support GPE/NSH

2016-02-11 Thread Brian Russell
-off-by: Brian Russell --- drivers/net/vxlan.c | 139 +++ include/net/vxlan.h | 40 - include/uapi/linux/if_link.h | 1 + 3 files changed, 166 insertions(+), 14 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
On 11/02/16 16:39, David Miller wrote: > From: Brian Russell > Date: Thu, 11 Feb 2016 10:35:13 + > >> +++ b/include/net/nsh.h >> +struct nsh_metadata { >> +u_short class; >> +u_char crit; >> +u_char type; >> +u_int len; /* 4

Re: [PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
On 11/02/16 16:17, Robert Shearman wrote: > On 11/02/16 11:35, Brian Russell wrote: > ... >> diff --git a/include/net/nsh.h b/include/net/nsh.h >> new file mode 100644 >> index 000..7a5fb95 >> --- /dev/null >> +++ b/include/net/nsh.h >> @@ -0,0 +1,1

[PATCH iproute2 net-next] iplink: vxlan: gpe support

2016-02-11 Thread Brian Russell
Add VXLAN GPE support to ip link Signed-off-by: Brian Russell --- include/linux/if_link.h | 1 + ip/iplink_vxlan.c | 21 ++--- man/man8/ip-link.8.in | 12 +++- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/include/linux/if_link.h b/include

[PATCH net-next 2/2] vxlan: support GPE/NSH

2016-02-11 Thread Brian Russell
-off-by: Brian Russell --- drivers/net/vxlan.c | 139 +++ include/net/vxlan.h | 40 - include/uapi/linux/if_link.h | 1 + 3 files changed, 166 insertions(+), 14 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net

[PATCH net-next 1/2] nsh: encapsulation module

2016-02-11 Thread Brian Russell
Support encap/decap of Network Service Header (NSH) as defined in https://tools.ietf.org/html/draft-ietf-sfc-nsh-01 Includes support for Type 1 and Type 2 metadata and a simple registration for listeners to see decapsulated packets based on the Type/Class. Signed-off-by: Brian Russell

[PATCH net-next 0/2] NSH and VxLAN-GPE

2016-02-11 Thread Brian Russell
type vxlan" command. Brian Russell (2): nsh: encapsulation module vxlan: support GPE/NSH drivers/net/vxlan.c | 139 ++-- include/net/nsh.h | 158 ++ include/net/vxlan.h | 40 - include/uapi/linux/if_ether.h | 1 + inc