On 11/02/16 16:39, David Miller wrote:
> From: Brian Russell <bruss...@brocade.com>
> Date: Thu, 11 Feb 2016 10:35:13 +0000
>
>> +++ b/include/net/nsh.h
>> +struct nsh_metadata {
>> + u_short class;
>> + u_char crit;
>> + u_char type;
>> + u_int len; /* 4 byte words */
>> + void *data;
>
> Do not use these shorthands, spell out "unsigned short" etc. explicitly.
>
> But in these cases you should be using fixed sized types like "u16".
>
> Also, in a header file such as this one which is private to the kernel
> you should be using the variants of these types without the leading
> underscores.
>
Ok, will fix those up.
Thanks,
Brian
