[PATCH net] MAINTAINERS: net: update Solarflare maintainers

2019-04-01 Thread Bert Kenward
Cc: Martin Habets Signed-off-by: Bert Kenward --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1fdc8970e816..ade9e18488d2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13982,7 +13982,7 @@ F: drivers/media/rc/serial_ir.c

Re: [PATCH AUTOSEL 3.18 12/16] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-19 Thread Bert Kenward
On 15/02/2019 02:15, Sasha Levin wrote: > From: Edward Cree > > [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] > > Use a bitmap to keep track of which partition types we've already seen; > for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and > thus skip adding t

[PATCH net-next] sfc: ensure recovery after allocation failures

2019-02-14 Thread Bert Kenward
. There is little downside to *always* requesting a slow fill if we failed to allocate a buffer, so the condition has been removed completely. The timer that triggers the request for a refill has also been shortened. Signed-off-by: Robert Stonehouse Signed-off-by: Bert Kenward --- drivers/net/ethernet

Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any

2019-02-14 Thread Bert Kenward
ommit message fixups look good, but apart from that: Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index c3ad564..ed551f0 100644

[PATCH net] sfc: initialise found bitmap in efx_ef10_mtd_probe

2019-02-12 Thread Bert Kenward
The bitmap of found partitions in efx_ef10_mtd_probe was not initialised, causing partitions to be suppressed based off whatever value was in the bitmap at the start. Fixes: 3366463513f5 ("sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe") Signed-off-by: Be

[PATCH net-next] sfc: add bundle partition definitions to mtd

2019-02-08 Thread Bert Kenward
From: Paul Fox Signed-off-by: Paul Fox Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 2 ++ drivers/net/ethernet/sfc/mcdi_pcol.h | 8 2 files changed, 10 insertions(+) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index

[PATCH net-next] sfc: extend MTD support for newer hardware

2019-01-16 Thread Bert Kenward
The X2 family of NICs (based on the SFC9250) have additional MTD partitions for firmware and configuration. This includes partitions that are read-only. The NICs also have extended versions of the NVRAM interface, allowing more detailed status information to be returned. Signed-off-by: Bert

Re: [PATCH] net: sfc: checks status of efx_mcdi_rpc

2019-01-02 Thread Bert Kenward
Hello, On 26/12/18 05:05, Kangjie Lu wrote: > efx_mcdi_rpc() could fail. The fix checks its status and issues an error > message if it fails. > > Signed-off-by: Kangjie Lu > --- > drivers/net/ethernet/sfc/mcdi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/s

Re: [PATCH net 10/11] sfc-falcon: remove ndo_poll_controller

2018-09-28 Thread Bert Kenward
ux maintainers > Cc: Edward Cree > Cc: Bert Kenward Acked-By: Bert Kenward > --- > drivers/net/ethernet/sfc/falcon/efx.c | 26 -- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/fal

Re: [PATCH net 09/11] sfc: remove ndo_poll_controller

2018-09-28 Thread Bert Kenward
amount of time, since one > cpu is generally not able to drain all the queues under load. > > sfc uses NAPI for TX completions, so we better let core > networking stack call the napi->poll() to avoid the capture. > > Signed-off-by: Eric Dumazet > Cc: Edward Cree >

[PATCH net 2/2] sfc: hold filter_sem consistently during reset

2018-07-11 Thread Bert Kenward
wsem in the filter table instead of filter_lock") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 570ec72266f3..ce3a17708

[PATCH net 1/2] sfc: avoid hang from nested use of the filter_sem

2018-07-11 Thread Bert Kenward
ef10 its own rwsem in the filter table instead of filter_lock") Tested-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/d

[PATCH net 0/2] sfc: filter locking fixes

2018-07-11 Thread Bert Kenward
Two fixes for sfc ef10 filter table locking. Initially spotted by lockdep, but one issue has also been seen in normal use. Bert Kenward (2): sfc: avoid hang from nested use of the filter_sem sfc: hold filter_sem consistently during reset drivers/net/ethernet/sfc/ef10.c | 30

[PATCH net] sfc: correctly initialise filter rwsem for farch

2018-06-29 Thread Bert Kenward
Fixes: fc7a6c287ff3 ("sfc: use a semaphore to lock farch filters too") Suggested-by: Joseph Korty Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/farch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sfc/farch.c b/drivers/net/ethernet/sfc/far

[PATCH net-next] sfc: set and clear interrupt affinity hints

2018-04-19 Thread Bert Kenward
Use cpumask_local_spread to provide interrupt affinity hints for each queue. This will spread interrupts across NUMA local CPUs first, extending to remote nodes if needed. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 36 1 file changed

[PATCH net] sfc: check RSS is active for filter insert

2018-04-17 Thread Bert Kenward
For some firmware variants - specifically 'capture packed stream' - RSS filters are not valid. We must check if RSS is actually active rather than merely enabled. Fixes: 42356d9a137b ("sfc: support RSS spreading of ethtool ntuple filters") Signed-off-by: Bert Kenward ---

[PATCH net] sfc: remove ctpio_dmabuf_start from stats

2018-04-04 Thread Bert Kenward
The ctpio_dmabuf_start entry is not actually a stat and shouldn't be exposed to ethtool. Fixes: 2c0b6ee837db ("sfc: expose CTPIO stats on NICs that support them") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 2 -- drivers/net/ethernet/sfc/nic.h | 1 - 2 f

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-13 Thread Bert Kenward
gt; erase_info->state assignments. While at it, get rid of the > erase_info->state field, all MTD_ERASE_XXX definitions and the > mtd_erase_callback() function. > > Signed-off-by: Boris Brezillon For sfc parts: Acked-by: Bert Kenward Thanks, Bert.

[PATCH net-next] sfc: add suffix to large constant in ptp

2018-01-26 Thread Bert Kenward
Fixes: 1280c0f8aafc ("sfc: support second + quarter ns time format for receive datapath") Reported-by: kbuild test robot Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ptp.c

[PATCH v2 net-next 2/4] sfc: support variable number of MAC stats

2017-12-21 Thread Bert Kenward
MC_CMD_MAC_GENERATION_END). So read num_mac_stats from the GET_CAPABILITIES response, if present; otherwise assume MC_CMD_MAC_NSTATS; and always use num_mac_stats - 1 rather than MC_CMD_MAC_GENERATION_END. Signed-off-by: Edward Cree Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 23

[PATCH v2 net-next 4/4] sfc: expose CTPIO stats on NICs that support them

2017-12-21 Thread Bert Kenward
While the Linux driver doesn't use CTPIO ('cut-through programmed I/O'), other drivers on the same port might, so if we're responsible for reporting per-port stats we need to include the CTPIO stats. Signed-off-by: Bert Kenward Signed-off-by: Edward Cree --- drivers/net

[PATCH v2 net-next 3/4] sfc: expose FEC stats on Medford2

2017-12-21 Thread Bert Kenward
From: Edward Cree There's no explicit capability bit, so we just condition them on having efx->num_mac_stats >= MC_CMD_MAC_NSTATS_V2. Signed-off-by: Edward Cree Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 24 +++- drivers/net/etherne

[PATCH v2 net-next 0/4] sfc: support extra stats on Medford2

2017-12-21 Thread Bert Kenward
X2000-series NICs add port stats for two new features: FEC (Forward Error Correction, used on 25G links) and CTPIO (cut-through programmed I/O). This patch series adds support for reporting both of these sets of stats v2: add additional Signed-off-by Bert Kenward (1): sfc: expose CTPIO stats

Re: [PATCH net-next 4/4] sfc: expose CTPIO stats on NICs that support them

2017-12-20 Thread Bert Kenward
On 19/12/17 17:06, Edward Cree wrote: > From: Bert Kenward > > While the Linux driver doesn't use CTPIO ('cut-through programmed I/O'), > other drivers on the same port might, so if we're responsible for > reporting per-port stats we need to include the C

[PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

2017-12-07 Thread Bert Kenward
dereference in efx_dequeue_buffer, with efx_enqueue_skb in the call stack. Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2") Reported-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/tx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [PATCH] net: sfc: remove redundant variable start

2017-11-09 Thread Bert Kenward
d > > Signed-off-by: Colin Ian King Acked-by: Bert Kenward Thanks Colin. > --- > drivers/net/ethernet/sfc/ptp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c > index 56c2db398def..caa89bf7603

[PATCH net-next] sfc: don't warn on successful change of MAC

2017-11-07 Thread Bert Kenward
From: Robert Stonehouse Fixes: 535a61777f44e ("sfc: suppress handled MCDI failures when changing the MAC address") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/d

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

2017-10-24 Thread Bert Kenward
Edward Cree > Cc: Bert Kenward > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jiri Pirko > Cc: Jamal Hadi Salim > Cc: Ingo Molnar > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/efx

Re: Fwd: [PATCH] net: ethernet: sfc: There is a typo, modify curent to current.

2017-10-02 Thread Bert Kenward
On 29/09/17 12:53, Hao Zhang wrote: > There is a typo, fix it by modify curent to current. > > Signed-off-by: Hao Zhang Acked-by: Bert Kenward

[PATCH net] sfc: don't try and read ef10 data on non-ef10 NIC

2017-08-15 Thread Bert Kenward
with: BUG: KASAN: slab-out-of-bounds in efx_mcdi_mac_stats Fixes: 0a2ab4d988d7 ("sfc: set the port-id when calling MC_CMD_MAC_STATS") Reported-by: Stefano Brivio Tested-by: Stefano Brivio Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi_port.c | 8 ++-- 1 file change

[PATCH net] sfc: don't read beyond unicast address list

2017-07-12 Thread Bert Kenward
more than 288 unicast addresses we will then read past the multicast address table, which is likely to be more exciting. Fixes: 12fb0da45c9a ("sfc: clean fallbacks between promisc/normal in efx_ef10_filter_sync_rx_mode") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/

[PATCH v4.9 -stable] sfc: provide dummy definitions of vswitch functions

2017-06-16 Thread Bert Kenward
eed to be defined. Fixed in mainline by: commit 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver") Fixes: 6d8aaaf6f798 ("sfc: create VEB vswitch and vport above default firmware setup") Signed-off-by: Bert Kenward --- dr

[PATCH net] sfc: tx ring can only have 2048 entries for all EF10 NICs

2017-04-25 Thread Bert Kenward
Fixes: dd248f1bc65b ("sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC") Reported-by: Patrick Talbert Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.h | 5 - drivers/net/ethernet/sfc/workarounds.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-)

[PATCH net] sfc: limit the number of receive queues

2017-04-12 Thread Bert Kenward
The number of rx queues is determined by the rss_cpus parameter or the cpu topology. If that is higher than EFX_MAX_RX_QUEUES the driver can corrupt state. Fixes: 8ceee660aacb ("New driver "sfc" for Solarstorm SFC4000 controller.") Signed-off-by: Bert Kenward --- drivers/ne

Re: [patch v2 net-next] sfc: fix an off by one bug

2017-02-07 Thread Bert Kenward
t; Signed-off-by: Dan Carpenter Thanks Dan. Acked-by: Bert Kenward

[PATCH net-next] sfc: don't rearm interrupts if busy polling

2017-02-06 Thread Bert Kenward
Since commit 364b6055738b ("net: busy-poll: return busypolling status to drivers"), napi_complete_done() returns a boolean that can be used by drivers to conditionally rearm interrupts. Testing with a 7142 shows a small latency improvement of ~100 ns. Signed-off-by: Bert Kenward

Re: [PATCH net-next] sfc-falcon: get rid of custom busy polling code

2017-02-03 Thread Bert Kenward
e lock operation in fast path. > > Signed-off-by: Eric Dumazet > Cc: Edward Cree > Cc: Bert Kenward Acked-by: Bert Kenward

Re: [PATCH net-next] sfc: get rid of custom busy polling code

2017-02-03 Thread Bert Kenward
e lock operation in fast path. > > Signed-off-by: Eric Dumazet > Cc: Edward Cree > Cc: Bert Kenward We were talking about doing this just yesterday. Thanks Eric. Acked-by: Bert Kenward

[PATCH net-next] sfc: reduce severity of PIO buffer alloc failures

2017-01-25 Thread Bert Kenward
From: Tomáš Pilař PIO buffer allocation can fail for two valid reasons: - we've run out of them (results in -ENOSPC) - the NIC configuration doesn't support them (results in -EPERM) Since both these failures are expected netif_err is excessive. Signed-off-by: Bert Kenward --- d

Re: [PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-21 Thread Bert Kenward
On 20/12/16 22:24, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/sfc/falcon/efx.c |2 +- > drivers/net/ethernet/sfc/falcon/ethtool.

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
On 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Tested-by: Bert Kenward Acked-by: Bert Kenward

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Bert Kenward
n 14/12/16 23:12, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Thanks Philippe. We'll get some testing done on this. Bert.

Re: [patch net-next] sfc: remove unneeded variable

2016-11-24 Thread Bert Kenward
On 24/11/16 11:16, Dan Carpenter wrote: > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > TSO") so let's remove the last traces. > > Signed-off-by: Dan Carpenter Acked-by: Bert Kenward

Re: [PATCH net-next] sfc: remove napi_hash_del() call

2016-11-16 Thread Bert Kenward
On 16/11/16 14:01, Eric Dumazet wrote: > From: Eric Dumazet > > Calling napi_hash_del() after netif_napi_del() is pointless. > > Signed-off-by: Eric Dumazet > Cc: Edward Cree > Cc: Bert Kenward > --- > drivers/net/ethernet/sfc/efx.c |5 ++--- > 1 fi

Re: [PATCH net-next] sfc: clear napi_hash state when copying channels

2016-11-11 Thread Bert Kenward
Apologies, this was meant for net, not net-next. Shall I resubmit? Bert.

[PATCH net-next] sfc: clear napi_hash state when copying channels

2016-11-11 Thread Bert Kenward
ithin napi_by_id() or napi_hash_add(). efx_copy_channel() is only used when tx or rx ring sizes are changed (ethtool -G). Fixes: 36763266bbe8 ("sfc: Add support for busy polling") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 3 +++ 1 file changed, 3 insertions(+

[PATCH net-next] ethernet/sfc: use core min/max MTU checking

2016-10-18 Thread Bert Kenward
Fixes: 61e84623 ("net: centralize net_device min/max MTU checking") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c ind

[PATCH net-next] sfc: check async completer is !NULL before calling

2016-09-22 Thread Bert Kenward
Add a NULL check before calling asynchronous MCDI completion functions during device removal. Fixes: 7014d7f6 ("sfc: allow asynchronous MCDI without completion function") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH 11/15] sfc: use IS_ENABLED() instead of checking for built-in or module

2016-09-12 Thread Bert Kenward
of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas Acked-by: Bert Kenward Thanks, Bert.

[PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread Bert Kenward
Reported-by: Ma Yuying Suggested-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c| 12 +++- drivers/net/ethernet/sfc/net_driver.h | 3 +++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net

[PATCH net-next 2/6] sfc: allow asynchronous MCDI without completion function

2016-08-11 Thread Bert Kenward
Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c index d28e7dd..9fbc12a 100644 --- a/drivers/net/ethernet/sfc/mcdi.c +++ b/drivers/net/ethernet

[PATCH net-next 0/6] sfc: SFN8000 support improvements

2016-08-11 Thread Bert Kenward
objective rather than enabling individual flags. Bert Kenward (6): sfc: update MCDI protocol headers sfc: allow asynchronous MCDI without completion function sfc: retrieve second word of datapath capabilities sfc: use new performance based event queue init sfc: set interrupt moderation via

[PATCH net-next 6/6] sfc: get timer configuration from adapter

2016-08-11 Thread Bert Kenward
On SFN8000 series adapters the MC provides a method to get the timer quantum and the maximum timer setting. We revert to the old values if the new call is unavailable. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 142 +++--- drivers/net

[PATCH net-next 5/6] sfc: set interrupt moderation via MCDI

2016-08-11 Thread Bert Kenward
what the ethtool interface is interested in. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c| 38 +++ drivers/net/ethernet/sfc/efx.c | 89 ++ drivers/net/ethernet/sfc/efx.h | 2 + drivers/net/ethernet/sfc

[PATCH net-next 4/6] sfc: use new performance based event queue init

2016-08-11 Thread Bert Kenward
Rather than explicitly specifying flags we can now specify a desired performance target to the firmware, ie higher throughput or lower latency. For now we use the default "auto" configuration. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/e

[PATCH net-next 1/6] sfc: update MCDI protocol headers

2016-08-11 Thread Bert Kenward
Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi_pcol.h | 530 ++- 1 file changed, 515 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/sfc/mcdi_pcol.h b/drivers/net/ethernet/sfc/mcdi_pcol.h index c9a5b00..ccceafc 100644 --- a

[PATCH net-next 3/6] sfc: retrieve second word of datapath capabilities

2016-08-11 Thread Bert Kenward
Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 10 -- drivers/net/ethernet/sfc/nic.h | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index f658fee..fd5d086 100644 --- a/drivers

Re: [PATCH stable] sfc: report supported link speeds on SFP connections

2016-07-06 Thread Bert Kenward
On 06/07/16 05:28, David Miller wrote: > From: Bert Kenward > Date: Tue, 28 Jun 2016 11:11:11 +0100 > >> commit 1974282ab547df7437276c8d4ec47f3d2300f339 >> Author: Bert Kenward >> Date: Mon Jun 6 17:29:30 2016 +0100 >> >> sfc: report supported lin

[PATCH stable] sfc: report supported link speeds on SFP connections

2016-06-28 Thread Bert Kenward
1974282ab547df7437276c8d4ec47f3d2300f339 Author: Bert Kenward Date: Mon Jun 6 17:29:30 2016 +0100 sfc: report supported link speeds on SFP connections Fixes: dd248f1bc65b49cba622a7e925d90d790e572996 Thanks, Bert.

Re: [PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-16 Thread Bert Kenward
ype-limits] > ethernet/sfc/farch.c:124:731: error: comparison of unsigned expression < 0 is > always false [-Werror=type-limits] > > The macro and the caller are both correct, but we can avoid the > warning by changing the index variable to a signed type. > > Signed-off-by: A

[PATCH net v2] sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
7000-series SFC NICs connected with an SFP+ module currently fail to report any supported link speeds. Reported-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi_port.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP connections

2016-06-06 Thread Bert Kenward
Apologies for delay in replying. On 03/06/16 02:33, Jarod Wilson wrote: > My solarflare cards connected to a 10GbE switch with an SFP+ module/cable > don't currently report any supported link speeds: > > ... > > diff --git a/drivers/net/ethernet/sfc/mcdi_port.c > b/drivers/net/ethernet/sfc/mcdi_

[PATCH net] MAINTAINERS: net: update sfc maintainers

2016-04-25 Thread Bert Kenward
Add myself and Edward Cree as maintainers. Remove Shradha Shah, who is on extended leave. Cc: David S. Miller Cc: Edward Cree Cc: Shradha Shah Signed-off-by: Bert Kenward --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH net] sfc: disable RSS when unsupported

2016-04-25 Thread Bert Kenward
press allocating a default RSS context. The absence of an RSS context is picked up in filter insertion and RSS flags are discarded. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/eth

[PATCH net-next v2 4/5] sfc: Downgrade EPERM messages from MCDI to debug

2015-12-23 Thread Bert Kenward
From: Tomáš Pilař When running in an unprivileged function we expect some MC commands to fail with permission errors. To avoid log spew downgrade these to debug only. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH net-next v2 5/5] sfc: Downgrade or remove some error messages

2015-12-23 Thread Bert Kenward
Depending on configuration the NIC may return errors for unprivileged functions and/or VFs. Where these are expected and handled, reduce the level of any output. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 20 ++-- drivers/net/ethernet/sfc/efx.c | 7

[PATCH net-next v2 3/5] sfc: Make failed filter removal less noisy

2015-12-23 Thread Bert Kenward
There are situations - mostly reset related - where our view of the filter table differs from the hardware. In this case we may try and remove filters that aren't actually installed. This isn't that interesting in most situations, so downgrade the logging. Signed-off-by: Be

[PATCH net-next v2 2/5] sfc: Handle MCDI proxy authorisation

2015-12-23 Thread Bert Kenward
retry. Note that this provides only the functionality for the unprivileged functions, not the handling of the administrative side. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 154 +--- drivers/net/ethernet/sfc/mcdi.h | 9 +++ 2 files

[PATCH net-next v2 1/5] sfc: Retry MCDI after NO_EVB_PORT error on a VF

2015-12-23 Thread Bert Kenward
After reboot the vswitch configuration from the PF may not be complete before the VF attempts to restore filters. In that case we see NO_EVB_PORT errors from the MC. Retry up to a time limit or until a different result is seen. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c

[PATCH net-next v2 0/5] sfc: additional virtual function support​

2015-12-23 Thread Bert Kenward
#ifdef DEBUG around new WARN_ON in mcdi.c. Bert Kenward (4): sfc: Retry MCDI after NO_EVB_PORT error on a VF sfc: Handle MCDI proxy authorisation sfc: Make failed filter removal less noisy sfc: Downgrade or remove some error messages Tomáš Pilař (1): sfc: Downgrade EPERM messages from

[PATCH net-next 5/5] sfc: Downgrade or remove some error messages

2015-12-18 Thread Bert Kenward
Depending on configuration the NIC may return errors for unprivileged functions and/or VFs. Where these are expected and handled, reduce the level of any output. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 20 ++-- drivers/net/ethernet/sfc/efx.c | 7

[PATCH net-next 4/5] sfc: Downgrade EPERM messages from MCDI to debug

2015-12-18 Thread Bert Kenward
From: Tomáš Pilař When running in an unprivileged function we expect some MC commands to fail with permission errors. To avoid log spew downgrade these to debug only. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH net-next 3/5] sfc: Make failed filter removal less noisy

2015-12-18 Thread Bert Kenward
There are situations - mostly reset related - where our view of the filter table differs from the hardware. In this case we may try and remove filters that aren't actually installed. This isn't that interesting in most situations, so downgrade the logging. Signed-off-by: Be

[PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation

2015-12-18 Thread Bert Kenward
retry. Note that this provides only the functionality for the unprivileged functions, not the handling of the administrative side. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 156 +--- drivers/net/ethernet/sfc/mcdi.h | 9 +++ 2 files

[PATCH net-next 1/5] sfc: Retry MCDI after NO_EVB_PORT error on a VF

2015-12-18 Thread Bert Kenward
After reboot the vswitch configuration from the PF may not be complete before the VF attempts to restore filters. In that case we see NO_EVB_PORT errors from the MC. Retry up to a time limit or until a different result is seen. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c

[PATCH net-next 0/5] sfc: additional virtual function support​

2015-12-18 Thread Bert Kenward
This introduces the client side of a mechanism to defer authorisation of operations, for example multicast subscription. Although primarily aimed at SRIOV VFs this can also apply to unprivileged PFs. Also handle reboot ordering corner cases better and reduce the level of some logging. Bert

[PATCH net v2] sfc: only use RSS filters if we're using RSS

2015-12-11 Thread Bert Kenward
Without this, filter insertion on a VF would fail if only one channel was in use. This would include the unicast station filter and therefore no traffic would be received. Signed-off-by: Bert Kenward --- v2 - fix indenting as requested drivers/net/ethernet/sfc/ef10.c | 24

[PATCH net] sfc: only use RSS filters if we're using RSS

2015-12-10 Thread Bert Kenward
Without this filter insertion on a VF would fail if only one channel was in use. This would include the unicast station filter and therefore no traffic would be received. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 23 +++ drivers/net/ethernet/sfc

[PATCH net-next] sfc: check warm_boot_count after other functions have been reset

2015-12-04 Thread Bert Kenward
at is unnecessary since the PFs that have been reset will each receive an MC reboot notification. In that case, the driver re-reads the unchanged value. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --

Re: [PATCH net-next] sfc: use ALIGN macro for aligning frame sizes

2015-12-01 Thread Bert Kenward
On 30/11/15 22:12, Jarod Wilson wrote: > Don't open-code it. > > CC: Solarflare linux maintainers > CC: Shradha Shah > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson Acked-by: Bert Kenward > --- > drivers/net/ethernet/sfc/net_driver.h | 3 ++- > 1

[PATCH v2 net-next 1/2] sfc: make TSO version a per-queue parameter

2015-11-30 Thread Bert Kenward
The Solarflare 8000 series NIC will use a new TSO scheme. The current driver refuses to load if the current TSO scheme is not found. Remove that check and instead make the TSO version a per-queue parameter. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 13

[PATCH v2 net-next 0/2] Basic support for Solarflare 8000 series NICs

2015-11-30 Thread Bert Kenward
The upcoming Solarflare 8000 series 10G/40G network card supports a similar interface to the current 7000 series cards. This patch series provides basic support for these cards, making no use of any new functionality. v2: fix indenting in ef10.c in patch 1/2. Bert Kenward (2): sfc: make TSO

[PATCH v2 net-next 2/2] sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC

2015-11-30 Thread Bert Kenward
Also add support for 7000 series 40G NIC VF. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 4e82bcf..b405349 100644 --- a/drivers/net/ethernet/sfc

[PATCH 0/2] Basic support for Solarflare 8000 series NICs

2015-11-25 Thread Bert Kenward
The upcoming Solarflare 8000 series 10G/40G network card supports a similar interface to the current 7000 series cards. This patch series provides basic support for these cards, making no use of any new functionality. Bert Kenward (2): sfc: make TSO version a per-queue parameter sfc: Add

[PATCH 1/2] sfc: make TSO version a per-queue parameter

2015-11-25 Thread Bert Kenward
The Solarflare 8000 series NIC will use a new TSO scheme. The current driver refuses to load if the current TSO scheme is not found. Remove that check and instead make the TSO version a per-queue parameter. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 13

[PATCH 2/2] sfc: Add PCI ID for Solarflare 8000 series 10/40G NIC.

2015-11-25 Thread Bert Kenward
Also add support for 7000 series 40G NIC VF. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 4e82bcf..b405349 100644 --- a/drivers/net/ethernet/sfc

Re: [PATCH 11/15] sfc: don't call dma_supported

2015-10-05 Thread Bert Kenward
On 03/10/15 16:19, Christoph Hellwig wrote: dma_set_mask already checks for a supported DMA mask before updating it, the call to dma_supported is redundant. Signed-off-by: Christoph Hellwig Acked-by: Bert Kenward -- To unsubscribe from this list: send the line "unsubscribe netdev&qu